- Aug 12, 2013
-
-
Felix Kopp authored
Brings logo text "TYPO3" in line with module menu text. Change-Id: Ief21e7ded4f8085e2f661304b55861211f202955 Resolves: #51015 Releases: 6.2 Reviewed-on: https://review.typo3.org/23047 Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters
-
Felix Kopp authored
Text links are not spotted easily. Give TYPO3 an easy visual feedback for text links on hover. Hover on table rows also pumps up text links. Change-Id: Ie255df54a5c556160f0e0826c87ff6425907bcb0 Resolves: #50997 Releases: 6.2 Reviewed-on: https://review.typo3.org/23019 Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters
-
Felix Kopp authored
Removes excessive spaces from within links / a-tags. Change-Id: Ica8b6d365282dc3a0e6588a5099404c6b4bc7c73 Resolves: #51016 Releases: 6.2 Reviewed-on: https://review.typo3.org/23048 Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters
-
Stefan Neufeind authored
Good security-practice is to choose a username different than "admin". Change-Id: Ib4a70b491f1f9a9112b8cd37db43664186d7192d Resolves: #50949 Releases: 6.2 Reviewed-on: https://review.typo3.org/22982 Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters
-
Felix Kopp authored
Use transparent PNG version of backend module icon for EXT: extensionmanager in module menu instead of GIF. Change-Id: I424a082c6a294be5f49d4c2a9dd976cb014d5096 Resolves: #51014 Releases: 6.2 Reviewed-on: https://review.typo3.org/23046 Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters
-
Felix Kopp authored
Backend user's username and real name are tightly coupled. These texts should stand right next to each other. Merged username and real name columns. When real name is unknown, not a problem. Also adds link to the primary action / edit view to user listing. Change-Id: I16d06771ad302fe64232e068e12663d87c07d79d Resolves: #50999 Resolves: #50994 Related: #50998 Releases: 6.2 Reviewed-on: https://review.typo3.org/23020 Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
- Aug 11, 2013
-
-
Helmut Hummel authored
Whether a storage is browsable or not should not affect the possibility to read a file with a given identifier. Releases: 6.0, 6.1, 6.2 Resolves: #51010 Change-Id: Ic754143ed39a277f14c488c5b0d4c050dde027df Reviewed-on: https://review.typo3.org/23034 Reviewed-by: Steffen Ritter Tested-by: Steffen Ritter Reviewed-by: Stefan Neufeind Tested-by: Stefan Neufeind
-
Helmut Hummel authored
When handling the old file permission settings from user or user group records, all current FAL user permissions should be set accordingly, to not allow file actions with FAL which were not allowed before. In particular no write / change actions should be allowed if no permissions are granted in the records. Releases: 6.0, 6.1, 6.2 Resolves: #51005 Related: #51007 Change-Id: I873f23ed02428842621c8256df5792e54abbfe2c Reviewed-on: https://review.typo3.org/23035 Reviewed-by: Steffen Ritter Tested-by: Steffen Ritter Reviewed-by: Helmut Hummel Tested-by: Helmut Hummel
-
Helmut Hummel authored
We miss a central place to adapt or change configuration for a resource storage. Add a signal in the resource factory to be able to post process a storage object after creation. Releases: 6.0, 6.1, 6.2 Resolves: #51011 Change-Id: Iace95bc50ab149b4e62dd85c01417b3a3e6bf1cf Reviewed-on: https://review.typo3.org/23033 Reviewed-by: Steffen Ritter Tested-by: Steffen Ritter Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters
-
Stanislas Rolland authored
Problem: Editing acronym records fails with Static Info Tables 6.0+ as tx_staticinfotables_div->selectItemsTCA does not exist anymore. Solution: Use suggest wizard Resolves: #50502 Releases: 6.0, 6.1, 6.2 Change-Id: I69e564662df19f0625ec3e71b05e91c7ed5edfc8 Reviewed-on: https://review.typo3.org/22664 Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters Reviewed-by: Stanislas Rolland Tested-by: Stanislas Rolland
-
- Aug 10, 2013
-
-
Tomita Militaru authored
The array with allowed color space names contains an invalid value (grey), which is replaced by the correct one (gray). Resolves: #50287 Releases: 6.2, 6.1 Change-Id: I96a2a1c4b55fc32e95a68f0f8ff0304d8de7bc51 Reviewed-on: https://review.typo3.org/23023 Reviewed-by: Markus Klein Tested-by: Markus Klein Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters
-
- Aug 09, 2013
-
-
Tim Spiekerkoetter authored
The ViewHelpers f:form.textfield and f:form.textarea were lacking the HTML5 "autofocus" attribute. It is available for button, input and textarea. Now Fluid reflects this correctly by adding this attribute to the initializeArguments methods for TextareaViewHelper and TextfieldViewHelper. Resolves: #48689 Releases: 6.2 Change-Id: I00480dc4e76b2854dc0be36d150d32c7b432d93d Reviewed-on: https://review.typo3.org/21994 Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
Anja Leichsenring authored
The patch for #21892 breaks functionality due to a mixed up parameters list in BackendUtility. Resolves: #50976 Releases: 6.2 Change-Id: I46585d995ec345561f605a19202d91614ad5e8d8 Reviewed-on: https://review.typo3.org/23012 Reviewed-by: Philipp Gampe Tested-by: Philipp Gampe Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters
-
- Aug 08, 2013
-
-
Wouter Wolters authored
When you select a report from an extension, the reports module will remember this when you re-open it. But if you have uninstalled the extension in the meantime, the reports module will throw an exception. This is fixed by checking the $reportClass. If this is NULL then redirect to indexAction. Change-Id: Ifad4e6ee8dc651a3d6b1360486fd5a7cb2abf111 Resolves: #48523 Releases: 6.2, 6.1, 6.0 Reviewed-on: https://review.typo3.org/22726 Reviewed-by: Stefan Neufeind Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn Reviewed-by: Anja Leichsenring Tested-by: Anja Leichsenring
-
Wouter Wolters authored
In stdWrap function numberFormat $content is a string. Make sure this is a float value when it is passed into PHP function number_format. Change-Id: If4a98ae8238264f94f771c997fbe6cac98311912 Resolves: #50868 Releases: 6.2, 6.1, 6.0, 4.7, 4.5 Reviewed-on: https://review.typo3.org/22936 Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn Reviewed-by: Anja Leichsenring Tested-by: Anja Leichsenring
-
Wouter Wolters authored
When you skip the update wizard for workspaces and version you always get the wizard back. The update wizard is not marked as done when you don't want to install the extensions. To fix this we need to copy some functions from AbstractUpdate because the update wizard for workspaces and version extend the SystemExtension update wizard. Change-Id: I4f7f3e8606cdf41db5737b5f4dd22d8faf4a4acb Resolves: #47734 Releases: 6.2 Reviewed-on: https://review.typo3.org/22680 Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn Reviewed-by: Anja Leichsenring Tested-by: Anja Leichsenring
-
Susanne Moog authored
Adds buttons to uninstall incompatible extensions to the install tool extension compatibility tester. You may install extensions one-by-one or all at once. Change-Id: I717e127128f0f26e5b6711e0c1db04cf8d8cbfce Resolves: #50940 Releases: 6.2 Reviewed-on: https://review.typo3.org/22972 Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
Christian Kuhn authored
* Implements a basic postprocessor to perform a redirect. * Adds it to the form-wizard. * Enables prepared ExtJS-code for removing a postprocessor. Resolves: #44482 Resolves: #38094 Releases: 6.2 Change-Id: I7e09bc9aa9821ac20e890343eb95c34c010dfba3 Reviewed-on: https://review.typo3.org/18307 Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
- Aug 07, 2013
-
-
Alexander Stehlik authored
This patch makes the FileExtensionFilter case insensitive. If the filter is configured to allow files with the ".EXT" extension it will now also allow files with an ".ext" extension. Additionally the order of a data provider method in the FileExtensionFilterTest has been corrected. Resolves: #50568 Releases: 6.2, 6.1, 6.0 Change-Id: I5761ab7f06116ef847caeb2ae786e580730c0e6b Reviewed-on: https://review.typo3.org/22724 Reviewed-by: Stefan Neufeind Tested-by: Stefan Neufeind Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters
-
Nicole Cordes authored
In the function TYPO3\CMS\Backend\Utility\BackendUtility::exec_foreign_table_where_query a lot of default markers (like CURRENT_PID, etc.) are replaced. It would be useful to have this substitution available as single function, so that it can be called without executing some query. Resolves: #21892 Releases: 6.2 Change-Id: I4da8279d1b95566690bb0934ac00299e4f4fee3e Reviewed-on: https://review.typo3.org/22661 Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn Reviewed-by: Nicole Cordes Tested-by: Nicole Cordes Reviewed-by: Anja Leichsenring Tested-by: Anja Leichsenring
-
Helmut Hummel authored
With FAL a new way to define file permissions (for storages) has been introduced. You can set these in User TsConfig instead of doing it in the user record. There is a backwards compatibility layer, which should set the permissions according to the database entry in case no permissions have been set in TsConfig. This however does not work, because of a wrong check for existence of UserTsConfig properties. Instead of checking for an array (which is always the case), we have to check if the array is not empty. Releases: 6.0, 6.1, 6.2 Resolves: #50872 Change-Id: I0ec30a1ae96c4b6916a3e46c7222f832c44f603e Reviewed-on: https://review.typo3.org/22921 Reviewed-by: Nicole Cordes Tested-by: Nicole Cordes Reviewed-by: Oliver Hader Reviewed-by: Frans Saris Tested-by: Frans Saris Reviewed-by: Anja Leichsenring Tested-by: Anja Leichsenring Reviewed-by: Helmut Hummel Tested-by: Helmut Hummel
-
Steffen Ritter authored
There are many tasks which apply to all drivers working on an Hierarchical FileSystem (NFS, WebDav, LocalDriver, ....). When it comes to security we dont want custom drivers to implement that all on their own, but provide it by the System. Introducing AbstractHierarchicalFilesystemDriver enables us to do so, without breaking compatibility (Base class, interface and Classname stay the same). Releases: 6.2, 6.1, 6.0 Resolves: #50867 Change-Id: Ib1b45c6ad384f82f7a5138372ed91269b8db38c2 Reviewed-on: https://review.typo3.org/22916 Reviewed-by: Nicole Cordes Tested-by: Nicole Cordes Reviewed-by: Helmut Hummel Tested-by: Helmut Hummel
-
Nicole Cordes authored
Two tests in class TYPO3\CMS\Core\Tests\Unit\Resource\FactoryTest fail with warnings. This is because of two single issues. First of all the test depends on a folder which (might) belong to an own storage other than storage 0 (fileadmin). This patch changes fileadmin to the typo3 folder as this one should be not included in any storage. On the other hand on Windows systems a full path contains always a colon which breaks any storage check. To solve this we have to fix any absolute path beforehand as it is done in the sub functions as well. Resolves: #50843 Releases: 6.2, 6.1, 6.0 Change-Id: I950a3c81222155da403ca1eb7b920e8682033450 Reviewed-on: https://review.typo3.org/22894 Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn Reviewed-by: Steffen Ritter Tested-by: Steffen Ritter
-
Wouter Wolters authored
After the namespace change a wrong replace was done in indexed_search. Replace it with the correct class. Change-Id: I35295f4fecde241ec3004a8ee6b7dd71d5e34e93 Resolves: #47106 Releases: 6.2, 6.1, 6.0 Reviewed-on: https://review.typo3.org/22595 Reviewed-by: Stefan Neufeind Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
Marius Büscher authored
The property $callBack pointed to a Controller that was not existing. Now it points back to the Hook. Resolves: #50562 Releases: 6.2, 6.1, 6.0 Change-Id: I79e0ce73a23d98c5922ead43480202b3445282b2 Reviewed-on: https://review.typo3.org/22897 Reviewed-by: Stefan Neufeind Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
Nicole Cordes authored
The test createdFilesAreEmpty depends on another test which returns a mocked object. In the mock two returnValues for getIdentifier() and getName() were set. But due to PHPUnit architecture mocked functions belong to the test there were defined and cannot be shared. This is why the mock has to be initialized within the test itself. The test only works because on unix system you can open a folder which returns an empty string. Furthermore if you use any php function to get a folder path we have to fix the containing backslashes. Finally due to some errors we have to rewind any iterator of class RecursiveIteratorIterator as otherwise a wrong index is returned. Resolves: #50844 Releases: 6.2, 6.1, 6.0 Change-Id: I13f9efbd1618056fcd66220e3de5e12af79e4dc6 Reviewed-on: https://review.typo3.org/22895 Reviewed-by: Jigal van Hemert Tested-by: Jigal van Hemert Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
Nicole Cordes authored
If the singleton management is changed in unit tests, a local copy of the previous stage is done to re-construct this state in tearDown(). This has to be done before any other instantiation in setUp() is initiated which might register additional singletons. Resolves: #50812 Releases: 6.2, 6.1, 6.0 Change-Id: I7788a5788aca6777040b777aeceb0558f96022b2 Reviewed-on: https://review.typo3.org/22838 Reviewed-by: Nicole Cordes Tested-by: Nicole Cordes Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn Reviewed-by: Stefan Neufeind Tested-by: Stefan Neufeind
-
Wouter Wolters authored
PHP warning will be thrown if typo3conf/Documentation does not exists. Add a check to prevent the warning. Change-Id: Ia9def8bb5b36da888eba3817ded9b348f48c37a3 Resolves: #50841 Releases: 6.2 Reviewed-on: https://review.typo3.org/22893 Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn Reviewed-by: Stefan Neufeind Tested-by: Stefan Neufeind
-
Nicole Cordes authored
When running the tests in the PHPUnit backend, the path of the current working directory is typo3/ (where mod.php is included). Therefore the test canWriteConfigurationReturnsTrueIfDirectoryAndFilesAreWritable fails as it deals with paths relative to the root directory. We have to use absolute paths to ensure files in typo3temp folder exist. Resolves: #50845 Releases: 6.2, 6.1 Change-Id: I7859978c31cf523c8803316fdac8c067d00042cc Reviewed-on: https://review.typo3.org/22896 Reviewed-by: Jigal van Hemert Tested-by: Jigal van Hemert Reviewed-by: Stefan Neufeind Tested-by: Stefan Neufeind
-
- Aug 06, 2013
-
-
Lars Peipmann authored
Adds FILE_NUM_CURRENT and FILES_COUNT to the register for each file. Use case: 10 = FILES 10 { references { table = tt_news uid.field = uid fieldName = media } renderObj = COA renderObj { 10 = TEXT 10.value = Render first file two times 10.if.isFalse.data = register:FILE_NUM_CURRENT 20 = TEXT 20.value = file {register:FILE_NUM_CURRENT} of {register:FILES_COUNT} 20.insertData = 1 } } Resolves: #49480 Releases: 6.2 Change-Id: I3eca404210ee21f73cea0860fa0be7cc39b4632f Reviewed-on: https://review.typo3.org/21747 Reviewed-by: Lars Peipmann Tested-by: Lars Peipmann Tested-by: Wouter Wolters Reviewed-by: Wouter Wolters Reviewed-by: Stefan Neufeind Tested-by: Stefan Neufeind
-
Xavier Perseguers authored
The documentation extension should be loaded by default for new websites and should be suggested in Install Tool when upgrading. Resolves: #50536 Releases: 6.2 Change-Id: I97755b96cf0ccce849e986650d5deca37cde294a Reviewed-on: https://review.typo3.org/22668 Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters
-
Sascha Egerer authored
EmConfUtility::fixEmConf generates a string instead of an array for "$emConf['constraints']['conflicts']" Resolves: #50628 Releases: 6.2, 6.1, 6.0 Change-Id: I37e026569e761b8550a9b0e6a1cb10835f6c899b Reviewed-on: https://review.typo3.org/22746 Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn Reviewed-by: Sascha Egerer Tested-by: Sascha Egerer Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters
-
Georg Ringer authored
The page module uses a custom implementation of a wordwrap as this was not supported by the browser in those earlier days. The big drawback is that there is no UTF8 support for this which leads to empty preview boxes when e.g. using Japanese. Change-Id: I7caab8e14a9a0b7ccbd38c692b0cf98635967567 Resolves: #15797 Releases: 6.2, 6.1 Reviewed-on: https://review.typo3.org/22840 Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
Philipp Gampe authored
The condition in ResourceStorage::deleteFolder is wrong. Negate the isFolderEmpty() clause. Resolves: #50125 Releases: 6.2, 6.1, 6.0 Change-Id: Ia60f3e97ff8d1e0cc2671cec1b31cfc995c235b1 Reviewed-on: https://review.typo3.org/22674 Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters
-
Stefan Neufeind authored
Some classes contain static getInstance()-methods that return an instance of themselves. Instead of using the correct namespace and classname everywhere, just use __CLASS__. Change-Id: I22770505acded0c54b07dd0e239976ad01fdf893 Resolves: #50615 Releases: 6.2, 6.1, 6.0 Reviewed-on: https://review.typo3.org/22741 Reviewed-by: Dmitry Dulepov Tested-by: Dmitry Dulepov Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters
-
Stefan Neufeind authored
For a persistent connection the hostname needs to be prefixed with "p:". This was already prepared in the code, however that variable was not yet used. Change-Id: I01e20fd69239d0772ca9b371af0058316541f2a9 Resolves: #50781 Releases: 6.2, 6.1 Reviewed-on: https://review.typo3.org/22813 Reviewed-by: Philipp Gampe Tested-by: Stefan Neufeind Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
Anja Leichsenring authored
With #50803 the usage of the constant TYPO3_MODE was introduced. This leads to the failing test, after the constant can not be redefined for test purposes. To work around this, a method that can be mocked is introduced, and specifically set to "FE" for this test to work again. Resolves: #50809 Relates: #50803 Releases: 6.2, 6.1, 6.0 Change-Id: I7319d8ccef530feff69a7f9885df24dba0beed4d Reviewed-on: https://review.typo3.org/22836 Reviewed-by: Ernesto Baschny Tested-by: Ernesto Baschny Reviewed-by: Anja Leichsenring Tested-by: Anja Leichsenring Reviewed-by: Nicole Cordes Tested-by: Nicole Cordes
-
- Aug 05, 2013
-
-
Anja Leichsenring authored
In case the link target is not available (maybe hidden), the behaviour known from the Core is to render the link text, but no a tag. The pageVH renders the link, but the href parameter will be empty. Resolves: #50751 Releases: 6.2, 6.1, 6.0 Change-Id: I526aa0e3d42f8aba867b3f996bac2366dc1f6d19 Reviewed-on: https://review.typo3.org/22789 Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters
-
Ernesto Baschny authored
Don't rely on $TSFE object to detect if we are in a frontend context. Rely on TYPO3_MODE constant instead. Releases: 6.2, 6.1, 6.0 Resolves: #50803 Change-Id: I06ea2692dab7683c7284e5f3ff45036d72c64999 Reviewed-on: https://review.typo3.org/22830 Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters Reviewed-by: Stefan Neufeind Tested-by: Stefan Neufeind
-
Wouter Wolters authored
Cleanup the update wizard classes and move all classes to one folder instead of the two that are used now. Change-Id: Id6a000fe75892d1596984954b2b2f8a78eaf0483 Resolves: #50670 Releases: 6.2 Reviewed-on: https://review.typo3.org/22754 Reviewed-by: Susanne Moog Tested-by: Susanne Moog Reviewed-by: Stefan Neufeind Tested-by: Stefan Neufeind
-