Change-Id: Id3d424c06859b9842172daa905ce0dab2c36cd41
Reviewed-on: https://review.typo3.org/19536
Reviewed-by: TYPO3 Release Team
Tested-by: TYPO3 Release Team

Intialize configuration as array to prevent PHP warnings for
Illegal string offset.

Change-Id: Ic7398ba2c041c3278a1bd5562968ac5183643d3d
Fixes: #43291
Releases: 6.1, 6.0, 4.7, 4.5
Reviewed-on: https://review.typo3.org/16731
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer

* Reduce number of IDE warnings by fixing method annotations
* Minor nitpicks
* Remove "define visibility" TODOs for API methods

Change-Id: Ica0bf776d3f22678b6fb67cdd85da188011509b0
Reviewed-on: https://review.typo3.org/19522
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

The dummy, government and introduction packages deliver with a
default typo3conf/LocalConfiguration.php file to set defaults. If
the installation was not yet completed, those files do not contain
database settings. The bootstrap loads LocalConfiguration and
redirects to the install tool in 123 mode, if those db credentials
are missing. This is ugly and leads to several headaches.

The patch introduces a new file called "FactoryConfiguration.php"
within ext:core Configuration directory to set those defaults now.
The packages can overload these settings with an own file in
typo3conf called "AdditionalFactoryConfiguration", eg. to load the
specific extensions needed during the install process.

This way, the packages do not deliver a "LocalConfiguration" file
anymore. The boostrap now just checks for the existence of the file
and redirects to the install tool if it doesn't exist. The install
tool then creates the "LocalConfiguration" from the factory files
at an early point in the process.

The patch has to deal with different side effect of this:
* ConfigurationManager is no singleton anymore, there was no reason
  for that in the first place anyway.
* ConfigurationManager has a new method to deal with the factory
  files.
* ConfigurationManager got some refactoring to get rid of constants
* Bootstrap is adapted to the new file existance handling.
* GeneralUtility::fixPermissions now can give default permission
  values for files if the settings do not exist yet.
* GeneralUtility::writeFile now accepts a new argument to force
  setting permissions. This is used in ConfigurationManager to
  end up with a LocalConfigurationFile with correct permissions
  as soon as installation is completed.
* As usual, the patch has a good test coverage to show everything
  works as expected.

Change-Id: Icb644534e6d1f426bc9512a941a69d3ee3727223
Resolves: #46854
Releases: 6.1
Reviewed-on: https://review.typo3.org/19506
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Change-Id: I39f576aebdfa181c11896cf0942b66823435cb20
Reviewed-on: https://review.typo3.org/19521
Reviewed-by: TYPO3 Release Team
Tested-by: TYPO3 Release Team

The names of some special folders (user upload,
temporary files, recycler) were historically
converted to a human readable string. This is partly
broken in the current version, especially the sorting
gets mixed up. This commit changes the concept to
make the mapping more flexible (i.e., the driver can
decide what folder has which special role) and also
fixes the name mapping and sorting.

Change-Id: Iaf7dee74f4d9031ed91b446937361ecdede9a0b5
Resolves: #46542
Releases: 6.1
Reviewed-on: https://review.typo3.org/19177
Tested-by: Philipp Gampe
Tested-by: Andreas Wolf
Reviewed-by: Philipp Gampe
Reviewed-by: Andreas Wolf

To use in example content/record security,
a hook is implemented before and after the SELECT call.

The interface introduces a new function that needs to be
implemented to avoid breaking functionality!

The SELECT call is the only database call without such hook

Resolves: #45699
Releases: 6.1
Change-Id: I915bd2422e3d6743a408ea53af7e6491cfe2657a
Reviewed-on: https://review.typo3.org/18411
Reviewed-by: Dmitry Dulepov
Reviewed-by: Mattias Nilsson
Tested-by: Dmitry Dulepov
Reviewed-by: Wouter Wolters
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer

The TypoScriptParser is executed in strict mode by default.

Change-Id: I95a206e184cbafaebe28f1db592bd0f6a6dda4db
Related: #46839
Releases: 6.0, 6.1
Reviewed-on: https://review.typo3.org/19504
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader

A ProcessedFile is used to generate a preview or crop-scaled
version of a File. Actually a Task implementing the
TaskInterface defines the basics and an accordant Helper
object takes care of the modifications to that file.
There are pre-process and post-process signals that seem to
be useless in modifying the scope of a particular task, however.

Imagine a file shall be pre-processed (e.g. color profile
transformation) and that result shall be used for resizing.
The current task implementation is using the original file
directly, however the task actually shall define which is the
source (the original file) the modifications shall be based on.

This change modifies the TaskInterface with a getSourceFile()
method to overcome this limitation.

Change-Id: I280ea9a0bf056f9eee0a06995ab809fdafb8a11a
Fixes: #46795
Releases: 6.0, 6.1
Reviewed-on: https://review.typo3.org/19438
Reviewed-by: Stefan Neufeind
Tested-by: Steffen Ritter
Reviewed-by: Steffen Ritter
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader

By using the PCRE_DOTALL (/s) pattern modifier in the cropHTML
regular expression for preserving HTML entities the dot in the
pattern will include line breaks.

Resolves: #28741
Releases: 6.1, 6.0, 4.7, 4.6, 4.5
Change-Id: Ifda9e397406dd481b634ded22fd13cac90192118
Reviewed-on: https://review.typo3.org/18219
Reviewed-by: Dmitry Dulepov
Tested-by: Dmitry Dulepov
Reviewed-by: Stefan Neufeind
Reviewed-by: Susanne Moog
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack

After the persistence patch in extbase was reverted, em needs an
adaption to make the Repository tab work again.

Change-Id: If88f9c2e52fdeed344955a62568835b3968db5e2
Fixes: #46844
Related: #46837
Releases: 6.1
Reviewed-on: https://review.typo3.org/19497
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

This reverts commit 524951cf.

Commit 524951cf has to be
reverted as it relies on patch http://forge.typo3.org/issues/42506
which has been reverted due to an introduced regression.

Resolves: #46838
Releases: 6.1
Change-Id: I3d1037e508a0defbe127a6f4b8f15efdcf678ef3
Reviewed-on: https://review.typo3.org/19490
Reviewed-by: Marc Bastian Heinrichs
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Change-Id: I54aff9f762761eba162d3d62fac19264fdbbee8e
Reviewed-on: https://review.typo3.org/19496
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Resolves: #46839
Releases: 6.0, 6.1
Change-Id: I3dd007908bbd127386b86dd0f31e927c1034bb97
Reviewed-on: https://review.typo3.org/19491
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader

The tests for a parameter array check for equality of
the parameter array and the according value.
Instead we only wanna know if two keys are present and
set correctly and we do not care about other array values.

This refactors the Test to be more polite and is a follow-up
for #46596.

Change-Id: Ia7b4a0521b1d11b9494de2ff766f11b3c8bd1f60
Releases: 6.0, 6.1
Related: #46596
Reviewed-on: https://review.typo3.org/19487
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader

PHP filesystem functions like pathinfo, dirname and
basename are dependent on the locale set in PHP.
If one enables UTF8filesystem in the install tool, he may
use non-ascii characters in filenames and directory names.
For this to work properly you need to configure
SystemLocale, too.

The file abstraction layer classes need to take care of
the SystemLocale; to avoid code duplication new static
wrapper functions have been introduced.

Change-Id: I635e18d7ed08d928c6c4e427c0348dd46d9c5900
Releases: 6.0, 6.1
Resolves: #45982
Reviewed-on: https://review.typo3.org/19444
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader

When a backenduser uploads a file an index record is
created. The sys_file table ships with the column cruser_id
 which is never been filled because all sys_file records
are created by the IndexerService which does not take care
of that field.

Add this knowledge to the indexer service.

Releases: 6.0, 6.1
Fixes: #46596
Change-Id: I2a82ea5375b892604fc1a27376487bc4efe3a16e
Reviewed-on: https://review.typo3.org/19217
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Stefan Neufeind
Reviewed-by: Andreas Wolf
Tested-by: Andreas Wolf

Allow quotes and upper-case notation when checking if
$TYPO3_CONF_VARS['SYS']['setDBinit'] is configured properly.

Resolves: #24582
Releases: 6.1, 6.0
Change-Id: I51a5f6cf363077c738656c207648f21d726de72b
Reviewed-on: https://review.typo3.org/19034
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert

TypoScriptParserTest uses superfluous mock object just to
call protected methods but without using mock behaviour.

Change-Id: Iaf8ed0150e63b5da4185dccbcf3dbd5eaa0cf94f
Fixes: #46833
Releases: 6.1
Reviewed-on: https://review.typo3.org/19481
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader

If using GMENU_LAYERS/TMENU_LAYERS and (for example) indexed_search on
the same page, the JavaScript header tags are missing if the page is
loaded from the cache.

Resolves: #36719
Releases: 4.5, 4.6, 4.7, 6.0, 6.1
Change-Id: Icd52f68d2b9462360f0b9efd912d93d4b0c1048c
Reviewed-on: https://review.typo3.org/19266
Reviewed-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

MySQL previously returned FALSE if there were no more rows.
MySQLi returns NULL. So we'll need to turn that into FALSE
again not to break things.

Fixes: #46824
Releases: 6.1
Change-Id: Ia3f6e32ac71b9cec216459b66b42c7d9526671dd
Reviewed-on: https://review.typo3.org/19473
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Adds an extra BEHAVIOUR section to form tab with a
checkbox to control whether the confirmation page
should be shown.

Change-Id: Id58ad0f8fa7fbbd5470e9a87e5fe31098b777a13
Resolves: #28628
Releases: 6.1
Reviewed-on: https://review.typo3.org/9136
Reviewed-by: Wouter Wolters
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Change-Id: Ie0f9a9e5d31d787b81dcff7a1877dedf2a4c0ef6
Reviewed-on: https://review.typo3.org/19472
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

In the early stages of the processing functionality, the class
"ImageProcessingService" was added as a proof-of-concept which
failed, as it just moved the cImage functionality and can
only be used in FE (cObj dependency). The new Task interface
for ProcessedFiles serves this purpose since the introduction
of FAL in 6.0.

The file can be removed without any deprecation, as it is
unusable (no API, not used at all).

Releases: 6.1
Resolves: #46625
Change-Id: I8637ca812ed7fd45439cbe85ce3a32ceba946441
Reviewed-on: https://review.typo3.org/19245
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack

The close button did not work because hide() was called on
a HTMLElement instead of an Ext.Element.

Fixes: #46373
Related: #31368
Releases: 6.1, 6.0, 4.7
Change-Id: I70c65a82683ece39de4ed043a916b0521aabafa1
Reviewed-on: https://review.typo3.org/19252
Tested-by: Wouter Wolters
Reviewed-by: Laurent Cherpit
Tested-by: Laurent Cherpit
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

APCu is just the user-data part of APC,
providing the same API.

If installed it currently identifies itself
as both "apcu" and "apc" (for compatibility).
Thus if "apcu" shows up, we actually have an APC
without opcache-support.

Resolves: #46821
Releases: 4.5, 4.7, 6.0, 6.1
Change-Id: Ie046fa21102c5c7eb6b5b8a9cf54b20252c30cd9
Reviewed-on: https://review.typo3.org/19462
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Specifying multiple recipients (To or CC) for emails
leads to an error upon form-submit without further explanation.
This patch implements validation for multiple email addresses of
which only the valid ones are then returned.
The sending-API can already handle multiple recipients.

Change-Id: I59b65adc4e09d298167738778c17d310b8ecce47
Fixes: #44485
Releases: 4.7, 6.0, 6.1
Reviewed-on: https://review.typo3.org/17505
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Tested-by: Stefan Neufeind
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert

Change-Id: Id467f5f9a7b99075ede94532cd3e9a49131a1287
Resolves: #46612
Releases: 6.1
Reviewed-on: https://review.typo3.org/19460
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

The displayCond option is expanded with support for multiple
conditions and even the logical operators OR and AND.

Change-Id: I6cb38ef83093ed7399b47701e234ac13bdfa47dd
Fixes: #18211
Releases: 6.1
Reviewed-on: https://review.typo3.org/13508
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

xcache is another PHP opcode cache like APC.
Similar to APC, it has a key-value for user data.
This storage is now available in the TYPO3 caching framework
by providing an according cache backend.

Note: XCache does not work in CLI mode!

Resolves: #46142
Releases: 6.1
Change-Id: I4e9e856a8397978eb6f6d480b79996ff49ff8a7b
Reviewed-on: https://review.typo3.org/18823
Reviewed-by: Stefan Neufeind
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Add missing, basic list-functionality for TypoScript.
Also splits out the TS-operator-functions into a
separate function and adds unit-tests.

Resolves: #45091
Releases: 6.1
Change-Id: I2ff425845681494053dc56b785ebd0064f100ed6
Reviewed-on: https://review.typo3.org/17939
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

In order to streamline \TYPO3\CMS\Backend\Form\FormEngine
(formerly t3lib_TCEforms) the functionality for 'displayCond' is extracted
into a new class: \TYPO3\CMS\Backend\Form\ElementConditionMatcher

* Refactor the code a bit without changing it's behaviour
* Deprecate FormEngine->isDisplayCondition() and remove its core usages
* Add a bit of documentation in the new class
* Add Unit tests

Releases: 6.1
Resolves: #46461
Change-Id: Ie199fe0600a70231f1e7b710a09164364cef8578
Reviewed-on: https://review.typo3.org/19080
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Change-Id: Id6d1ecee341547145a067dba661651704dcaae54
Reviewed-on: https://review.typo3.org/19457
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Method sql_field_type was rewritten with the mysqli switch for
compatibility with the old behavior. The introduced call to
fetch_field_redirect returns an object, but the result is
handled as an array, leading to warnings.

Change-Id: I73c434e8ce8086f4e60e119f4c2e2d1e2c9c7d20
Fixes: #46806
Related: #36419
Reviewed-on: https://review.typo3.org/19448
Reviewed-by: Philipp Gampe
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Tested-by: Philipp Gampe
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Change-Id: Idb67b153daea1a233e54ec164b4abdb9cbeb331c
Related: #36419
Reviewed-on: https://review.typo3.org/19443
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

The integerity test checks if TYPO3_DB is a resource. After switch to
mysqli, this is now an object and thus reflected with the patch now.
At the same time, the $link property - while it changed its type - is
now made protected, and a getter / setter is added.

Change-Id: I5ecdcc27f628352a26a51fc28d5a9d7be5e16315
Resolves: #46805
Related: #36419
Releases: 6.1
Reviewed-on: https://review.typo3.org/19447
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Long lines for database queries are not too long anymore.

Change-Id: I2bfbeb9e5e375c43483af9b3d33264a23a4c6adc
Resolves: #46804
Releases: 6.1
Reviewed-on: https://review.typo3.org/19446
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Typo3DatabaseBackend get function does not return FALSE when
there is no result.

Change-Id: I738ffc2879a9c125af4e7f0727c2cb5c88ed2da0
Fixes: #46802
Releases: 6.1
Reviewed-on: https://review.typo3.org/19445
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert

Adds the JS loader "RequireJS" to the TYPO3 core, accessible
for the TYPO3 Frontend and Backend in the PageRenderer
class.

Additionally, defined AMD modules can be loaded
by RequireJS on page load. This way, the whole JS code
in the core can be moved to standard AMD modules
with dependencies.

The shipped jQuery version already puts itself in a AMD
module named "jquery", so it can be used in all AMD
modules.

All created AMD modules should be named
"TYPO3/CMS/[PackageName]/[ModuleName]" so the
file name is resolved automatically as
"EXT:PackageName/Resources/Public/JavaScript/ModuleName.js"

Releases: 6.1
Resolves: #39622
Change-Id: I6e3177019e9b98b409aa90f771122b48cee235e1
Reviewed-on: https://review.typo3.org/18924
Reviewed-by: Wouter Wolters
Tested-by: Stefan Neufeind
Tested-by: Wouter Wolters
Reviewed-by: Daniel Sattler
Tested-by: Daniel Sattler
Reviewed-by: Stefan Neufeind
Reviewed-by: Marcus Schwemer
Tested-by: Marcus Schwemer
Reviewed-by: Mattias Nilsson
Tested-by: Mattias Nilsson
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack

This feature comes after feature freeze for 4.7 but accidently it was
already mentioned in the release notes while not being implemented yet.

Release notes mention that the new stdWrap.cache feature (#34299)
stores cache tags that can be flushed by tag from TCEmain.clearCacheCmd
with feature #34352.

As stdWrap.cache stores tags into cache_hash and not into cache_pages
the feature mentioned in the release notes does not work that way.

But nevertheless that would be a handy feature and so I suggest to
add stdWrap.addPageCacheTags = pagetag1,pagetag2,pagetag3

To distinguish these tags being written to cache_pages instead of
cache_hash I'd suggest to not have this feature inside "cache." but
as a separate configuration option "addPageCacheTags".

See http://forge.typo3.org/issues/34403 for some more details.

Including the other cache (tag) related features this completes a set
of handy tools to handly cache tags in a very flexible way.

Change-Id: Ida42937356644f8ea1c27cecdf1e8252182b06ee
Resolves: #34403
Releases: 6.1
Reviewed-on: https://review.typo3.org/9294
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn