- Sep 21, 2017
-
-
Stephan Jorek authored
In the constructors of the two new http-response classes ... * TYPO3\CMS\Core\Http\HtmlResponse * TYPO3\CMS\Core\Http\JsonResponse ... change the spelling of the value of the lowercased header-names for the default/fallback 'Content-Type' header from 'Content-type' to 'Content-Type'. Mind the capital 'T' in '...-Type'. Resolves: #82537 Releases: master Change-Id: Ib7b3d0f6c6de0a1490345e9e537d3545b80b4d82 Reviewed-on: https://review.typo3.org/54200 Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
-
Markus Klein authored
Enforcing the admPanel for users via user TSconfig is working again without crashing the FE. We make sure that when the admPanel configuration is fetched, we do not fall back to the toplevel value if the requested sub-value does not exist. Resolves: #82460 Releases: master, 8.7, 7.6 Change-Id: Ibd288805aa6c91d74eee8a9c80ebcce62d1f860f Reviewed-on: https://review.typo3.org/54123 Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Joerg Boesche <typo3@joergboesche.de> Reviewed-by:
Stefan Neufeind <typo3.neufeind@speedpartner.de> Reviewed-by:
Susanne Moog <susanne.moog@typo3.org> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
Raphael Graf authored
and remove the whole paragraph about specific rights of the user. Releases: master, 8.7 Resolves: #82527 Change-Id: Icd65ba13c7464fdd0290cec48f08de9d0934e796 Reviewed-on: https://review.typo3.org/54188 Reviewed-by:
-
- Sep 20, 2017
-
-
Georg Ringer authored
Allow 255 chars for a domain to be in sync with RFC 1035. Resolves: #82515 Releases: master, 8.7, 7.6 Change-Id: I63916cb115b00e50c62c1926cf890e29bf89de77 Reviewed-on: https://review.typo3.org/54186 Reviewed-by:
Patrik Karisch <p.karisch@pixelart.at> Tested-by:
Alexander Schnitzler <review.typo3.org@alexanderschnitzler.de> Tested-by:
-
Ralf Zimmermann authored
Make it possible to use the same form multiple times on one page by adding the content element uid to the form identifier. Resolves: #81775 Releases: master Change-Id: I001a654f8ffc47c91c984133d8475605f1b15b7a Reviewed-on: https://review.typo3.org/54125 Tested-by:
-
Alexander Schnitzler authored
The Typo3DbBackend fetches PageTS via BackendUtility::getPagesTSconfig and then stores a copy of it (for each page separately) in a static property. This is a bug and leads to performance decreases because the PageTS is already cached via BackendUtility::getPagesTSconfig and it's done even better than in Typo3DbBackend because the backend utility store a single cache entry for different pages with the same PageTS. The Typo3DbBackend does create a copy of the PageTS for each page. Resolves: #82496 Releases: master, 8.7 Change-Id: I61bd6fa8eb3ba29baea355ae01a8d71f7ae7e963 Reviewed-on: https://review.typo3.org/54151 Reviewed-by:
-
Mathias Brodala authored
The icon parameter is passed through to TCA "select" items, thus aside from an icon file path an icon identifier can be used here. Resolves: #82351 Releases: master, 8.7 Change-Id: Ia84aa9c739c10372f1ad76c5b4dde9f0b1a62c99 Reviewed-on: https://review.typo3.org/53987 Tested-by:
-
Christian Kuhn authored
The initial view of the installer enables the 'proceed' buttons on first step via JS. The ac test has to wait until the buttons are rendered before proceeding. Change-Id: I1426f1434d80124ac5036c1270668867c86fc2d6 Resolves: #82516 Related: #82504 Releases: master Reviewed-on: https://review.typo3.org/54180 Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
-
Mats Svensson authored
Add condition and only render target attribute if set on page. Resolves: #82464 Releases: master, 8.7 Change-Id: I14c561188f1e8a7389b145adf85c64918e61d461 Reviewed-on: https://review.typo3.org/54160 Reviewed-by:
Benjamin Kott <benjamin.kott@outlook.com> Tested-by:
Sascha Wilking <sascha.wilking@hmmh.de> Tested-by:
-
Georg Ringer authored
To improve the performance of sys_note rendering, the injection can be skipped as the current user id can be used directly. Resolves: #82506 Releases: master Change-Id: I40b04ac725628f4dcfb3f1e5a280edf9c8e545f9 Reviewed-on: https://review.typo3.org/54166 Reviewed-by:
-
David Gurk authored
This allows to translate a form element validation messages without a specific form definition identifier. Resolves: #82366 Releases: master, 8.7 Change-Id: I1db756c7f3c84d599f5c3c2265d8a7ca07fc2205 Reviewed-on: https://review.typo3.org/53988 Reviewed-by:
Mathias Brodala <mbrodala@pagemachine.de> Tested-by:
Daniel Lorenz <daniel.lorenz@extco.de> Reviewed-by:
Ralf Zimmermann <ralf.zimmermann@tritum.de> Reviewed-by:
Sonja Großewinkelmann <s.grossewinkelmann@neusta.de> Tested-by:
Bjoern Jacob <bjoern.jacob@tritum.de> Tested-by:
Sascha Rademacher <sascha.rademacher+typo3@gmail.com> Reviewed-by:
-
Ralf Zimmermann authored
Cleanup some leftovers from issue #82336 (review:53946) within the EXT:form documentation. Basically, long file paths are shortened. Resolves: #82472 Related: #82336 Releases: master Change-Id: I6ecac403a91d195d0c35d99281ecbe665ca8ec54 Reviewed-on: https://review.typo3.org/54132 Reviewed-by:
-
Łukasz Uznański authored
L=0 is added to Indexed Search results links if current page language is > 0. Resolves: #81164 Related: #81994 Related: #81986 Releases: master, 8.7 Change-Id: Ia9738b4d64bdcf1f3b2d6fa91d446f2f22c8130b Reviewed-on: https://review.typo3.org/53978 Tested-by:
Mona Muzaffar <mona.muzaffar@gmx.de> Tested-by:
-
- Sep 19, 2017
-
-
Christian Kuhn authored
The install tool suffered from three main issues since 6.2 rewrite: * The "step" installer was re-used for recovery and installation * The routing logic was server based and threw lots of redirects which lead to redirect loops * The Controller/Action class structure was weird and hard to understand The patch solves this with a rather huge rewrite: * There are two request handlers: One for the Installer, one for the install tool. * A simple list of controllers. One InstallerController for the step installer, the others for the main module points of the install tool and a Login and a Layout controller. * Single action code is moved into controllers. * Both tool and installer first load only a <head> section that contain JS references. All other calls are ajax based and the routing is done JS side. * Installer and install tool no longer share controller code or templates, the installer can potentially be fully extracted from ext:install in another step. * Installer.js is the "walk through installation" module of the installer. * Router.js is the routing module for the install tool, all tool ajax requests get specific urls from this module and hand over errors to the Router. * Error handling is handled on JS side: If for instance the login session expires and user clicks elsewhere, a 403 response is returned which is handled by JS to route to login. This is also the place where a recovery can hook in later. * The silent configuration updater is executed again which was removed during one of the previous master patches. * The template structure is much easier. * Various card content which has been calculated when loading the card layout is moved to the ajax code for single card content. That increases the performance of the main module points and makes them pretty snappy. Change-Id: Ib40f40acba17bb47142c0da1bcfb389ab9b4b3a1 Resolves: #82504 Releases: master Reviewed-on: https://review.typo3.org/54128 Tested-by:
-
- Sep 18, 2017
-
-
Markus Klein authored
Do not reference the logger inside a constructor as its injection happens after the constructor has been executed. Therefore create a dedicated instance for logging. Resolves: #82430 Releases: master Change-Id: Ic943ad53e4ae2abed3fabb55e24b17362de92e1c Reviewed-on: https://review.typo3.org/54161 Reviewed-by:
Daniel Goerz <ervaude@gmail.com> Tested-by:
Helmut Hummel <typo3@helhum.io> Tested-by:
-
Alexander Schnitzler authored
This introduces an iterable command registry that aggregates commands from Configuration/Commands.php files. To speed things up for subsequent usage, a first level cache is used. Resolves: #82455 Releases: master Change-Id: Ibd123ef947d06939bc84f5ea609996fec85de6e8 Reviewed-on: https://review.typo3.org/54120 Reviewed-by:
-
Alexander Schnitzler authored
This changes the output of "typo3/sysext/core/bin/typo3 extbase" to show the standard Symfony error message instead of a misleading one. Calling a Symfony base command outputs an error message with a list of possible commands. We change the command name of the core command to get the same behavior for the Extbase base command. Resolves: #81917 Releases: master, 8.7 Change-Id: I9ba05600a461aceb4180d3e2dd124a5ec3006e08 Reviewed-on: https://review.typo3.org/53926 Tested-by:
-
Markus Klein authored
The function GeneralUtility::sysLog() is deprecated and all calls are replaced with direct calls to according Logging API methods. The usual configuration options of the Logging API allows to define all sorts of destinations for log entries, including the syslog facility as well as file targets. Resolves: #82430 Releases: master Change-Id: Ief3f3f14fd10a3ae90b9df4a5e4e7456c2f7619c Reviewed-on: https://review.typo3.org/54090 Tested-by:
-
- Sep 17, 2017
-
-
Helmut Hummel authored
* Widget template override also works with legacy config option * Runtime cache is removed * TemplatePathsTests from https://github.com/helhum/fluid_test are integrated Resolves: #82344 Resolves: #82181 Resolves: #73207 Related: #82407 Releases: master, 8.7 Change-Id: Icd0a8aa3f1646315c094ad8768e2ff0bb34033d9 Reviewed-on: https://review.typo3.org/53958 Tested-by:
Claus Due <claus@phpmind.net> Tested-by:
Nicole Cordes <typo3@cordes.co> Tested-by:
-
Oliver Hader authored
Allowed classes in the options of unserialize invocation need to be injected using the 'allowed_classes' array index - the current implementation is casted to true which allows all classes. Related: #82408 Releases: master, 8.7 Change-Id: I68fbd873a5a7057630a48586878c77547b532348 Reviewed-on: https://review.typo3.org/54154 Tested-by:
-
- Sep 14, 2017
-
-
Benni Mack authored
This reverts commit 31310553 due to side-effects introduced with this commit. Change-Id: I67680820b0e139fea49cfcc0818cd97af3f6b9b9 Resolves: #82487 Reverts: #82232 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/54147 Tested-by:
-
Benni Mack authored
This reverts commit 30c46719 due to several side effects. Change-Id: I43586802a9838faa2723fdcaa2e9e15492003830 Resolves: #82487 Reverts: #82196 Reverts: #82181 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/54144 Tested-by:
-
Claus Due authored
TYPO3 no longer requires the Soap extension and should not check for it in system environment checks. This patch removes the check. Change-Id: I3dc5715889af598054e2451c957a05c13f39b9fa Resolves: #82452 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/54117 Reviewed-by:
Stephan Großberndt <stephan@grossberndt.de> Tested-by:
-
- Sep 11, 2017
-
-
Sascha Egerer authored
The `type` field is configured via TCA and that configuration must be used instead of hardcoding the fieldname. Also change arrangement of the DataProvider load order to load InitializeProcessedTca directly after ReturnUrl. This avoids the need of accessing $GLOBALS['TCA']. Resolves: #79954 Releases: master, 8.7 Change-Id: I67cbab00f6f0157c48c749cd8fbcd6cbc0ce1644 Reviewed-on: https://review.typo3.org/53749 Reviewed-by:
-
Christian Kuhn authored
With recent routing changes the install tool "backend context" has been switched to a "normal" backend module loaded directly from within the backend application. The standalone is an own application with its own bootstrap. This leads to various issues in the install tool since the backend and standalone requests lead to different bootstrap states, for instance TCA is initialized in BE context, but isn't in standalone. Within backend, this won't change until the backend application can bootstrap to different states depending on a controller. To solve install tool related issues for now, the BackendModuleController of the install tool called from within backend now starts a casual install tool session and marks this session as "initiated from a valid system maintainer". It then redirects to the standalone application which omits login and enable install tool file check if the session is marked as backend user session. Change-Id: I352e6d04e7a91c56ccf2383f784ae94464c9aacd Resolves: #82448 Related: #82306 Releases: master Reviewed-on: https://review.typo3.org/54111 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
Georg Ringer authored
To simplify the class \TYPO3\CMS\Backend\Template\DocumentTemplate, the AJAX based flash message handling is moved to an own class. Adding a RST file will be added with other removals within DocumentTemplate. Resolves: #81564 Releases: master Change-Id: Icff696f2dc8a2a895711218b86ea529128506161 Reviewed-on: https://review.typo3.org/53200 Reviewed-by:
Jan Stockfisch <jan.stockfisch@googlemail.com> Reviewed-by:
-
Helmut Hummel authored
Currently TCA is cached as serialized string using the core cache. Simplify the cache retrieval by taking advantage of the code cache by using requireOnce and previously storing the cache as PHP file that returns an array. This significantly improves performance with opcode cache enabled. The cache identifier is changed to avoid conflicts with previously stored data. Resolves: #82408 Releases: master, 8.7 Change-Id: I59210fa800d10c14d21aceb7416ea418988d6ca5 Reviewed-on: https://review.typo3.org/54062 Tested-by:
-
Markus Klein authored
Instantiating new objects with makeInstance or the ObjectManager will automatically inject a logger into the new objects, if those implement the LoggerAwareInterface. Resolves: #82441 Releases: master Change-Id: I38e1a4619857f3fc2d88b0b95a9721b289c679d3 Reviewed-on: https://review.typo3.org/54101 Reviewed-by:
-
Łukasz Uznański authored
Releases: master Resolves: #82252 Change-Id: I5cddefe1fd3fbf97e2cdc1aea1f373ef2076da72 Reviewed-on: https://review.typo3.org/54071 Reviewed-by:
Joerg Kummer <typo3@enobe.de> Tested-by:
-
- Sep 10, 2017
-
-
Benni Mack authored
The patch introduces three shorthand Response classes for output: HtmlResponse, JsonResponse and RedirectResponse which are used throughout all the actions inside the Install Tool. Resolves: #82415 Releases: master Change-Id: I9edc15c341084fcb59a3b1dc45b42a6f65d87e7f Reviewed-on: https://review.typo3.org/54059 Tested-by:
Markus Hölzle <typo3@markus-hoelzle.de> Tested-by:
-
Benni Mack authored
The check on BE_USER->uc() in frontend context is cleaned up and more strict, checking whether the object exists currently. Additionally, the specific request type is used here. Resolves: #82397 Releases: master, 8.7 Change-Id: Ibe0b533c23e1ba9c35ed2b6b9b0301e1a449c2e3 Reviewed-on: https://review.typo3.org/53832 Tested-by:
-
Benni Mack authored
The entrypoint located under "typo3/sysext/install/Start/Install.php" has been removed, as the entrypoint "typo3/install.php" is the new way to access the install tool. The legacy entrypoint "typo3/install/index.php" will still be kept, as it is easy for existing users to get a simple redirect (still marked as deprecated). Resolves: #82433 Releases: master Change-Id: I36a165649c7ca5a988379b70328e570fc45285b0 Reviewed-on: https://review.typo3.org/54093 Tested-by:
-
Benjamin Kott authored
Releases: master, 8.7 Resolves: #81769 Change-Id: I92df0fc254b4a729298f32d1482ad2a0f39502bf Reviewed-on: https://review.typo3.org/53379 Tested-by:
-
Simon Praetorius authored
Resolves: #82435 Relates: #82399 Releases: master Change-Id: Ic2bb90883c0a6cec5e6bec051cb308c723392d75 Reviewed-on: https://review.typo3.org/54095 Reviewed-by:
-
Jacob Dreesen authored
Add a property 'crossorigin="some-value"' to JavaScript files via TypoScript page.includeJSlibs.<array>.crossorigin = some-value The crossorigin property is automatically set to the value "anonymous" for external JavaScript files with an integrity property if not explicitly set. This patch affects the TypoScript PAGE properties * includeJSlibs * includeJSFooterlibs * includeJS * includeJSFooter Resolves: #76459 Releases: master Change-Id: Ie8d1d86ca5a8863c2a637395f1f87a463729691c Reviewed-on: https://review.typo3.org/48455 Reviewed-by:
-
Andreas Fernandez authored
Resolves: #82434 Related: #82406 Releases: master Change-Id: I67182a131c2499713410807099f5d658a3858d63 Reviewed-on: https://review.typo3.org/54097 Reviewed-by:
-
Andreas Fernandez authored
The route dispatcher can't rely on id being an integer, as file list for example uses string identifier. It is now checked whether the id is an int instead. Resolves: #82440 Related: #82406 Releases: master Change-Id: Idddc8484e0a597fec9d61c509d06f36736990c67 Reviewed-on: https://review.typo3.org/54098 Reviewed-by:
Matthias Vogel <typo3@kanti.de> Tested-by:
-
Christian Kuhn authored
The raise brings an additional UnitTestsDeprecated.xml setup file dedicated to test deprecated core functionality. Change-Id: Ic61ce2d76ed7f4e83bc6c2a12dd1337392d6c4aa Resolves: #82437 Related: #82438 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/54096 Reviewed-by:
-
Markus Hoelzle authored
Remove support for the special constant comment `###MOD_TS:EDITABLE_CONSTANTS###`. This constant was used to show all constants before this comment as default constants in constants editor and is dropped as ancient and widely unknown and rarely used feature. Releases: master Resolves: #82425 Change-Id: I5345871818e1d627cacb8be6db2ab8629770237e Reviewed-on: https://review.typo3.org/54086 Reviewed-by:
-
Sascha Egerer authored
There was one leftover place, where an attributes string was concatenated instead using the helper function. Resolves: #77824 Releases: master Change-Id: I0d01a5bde47b333dc11d25f6dd28bde9e7810696 Reviewed-on: https://review.typo3.org/49819 Tested-by:
-
