- Aug 17, 2021
-
-
Nikita Hovratov authored
Resolves: #94909 Releases: master, 10.4, 9.5 Change-Id: I68b5f28f761e5eb096d8580e7c7291b479f144b5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70641 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
-
Oliver Bartsch authored
A new component "MultiRecordSelection" is added. It's used first for the filelist module as well as the file selector. It simply adds a consistent way of selecting multiple elements (records) and to perform actions on this selection. Therefore, the checkboxes are always displayed at the beginning of each record row. The checkbox actions, such as "check all" are available in the header row of the same column via a dropdown menu. The actions to perform on the selection, e.g. "delete" or "import", appear once a record is selected. For the filelist module, this means those actions are decoupled from the clipboard, making it easier for editors to work with multiple records. This also introduces the "Edit marked" action to the filelist module, which allows to edit the metadata of all selected files at once. Resolves: #94906 Releases: master Change-Id: Id9e2915203049235fc4b503d33a4f1a77646c133 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70515 Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
Nikita Hovratov authored
In a case, where the search term is empty (by removing the search term manually for example) and a node is currently selected, the loader placeholder is now removed. This is the only case, where the method "resetFilter" is not called. Resolves: #94464 Releases: master Change-Id: Iad0deca5c9793cd0823d62c3864bc63e0fb40288 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70182 Tested-by:
-
- Aug 16, 2021
-
-
Oliver Hader authored
composer req typo3/html-sanitizer:^2.0.9 composer req typo3/html-sanitizer:^2.0.9 \ -d typo3/sysext/core --no-update Resolves: #94883 Releases: master, 11.3, 10.4, 9.5 Change-Id: I997ddc423ffcb216927e3ba807e303e604174ee8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70614 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
Oliver Hader authored
As a result of TYPO3-CORE-SA-2021-013, new `htmlSanitize` behavior - when invoking `ContentObjectRenderer::parseFunc` - is enabled per default, in case it was not declared otherwise. That also happened when no processing configuration was given (or could be resolved). Without having any configuration, it was obviously not possible to disable `htmlSanitize`. Fluid's `HtmlViewHelper` can be used with an empty `parseFuncTSPath` (e.g. `<f:format.html parseFuncTSPath="">`) - due to missing (empty) configuration, sanitization was enabled per default in `parseFunc`. With this change, property `htmlSanitize` either needs to be enabled or disabled explicitly - otherwise deprecation logs will be generated, if not given, the fall-back behavior is inferred from new feature flag `security.frontend.htmlSanitizeParseFuncDefault`. Invoking `ContentObjectRenderer::parseFunc` without any configuration behaves like before TYPO3-CORE-SA-2021-013 was applied - it just does not process anything. Resolves: #94786 Releases: master, 11.3, 10.4, 9.5 Change-Id: I4aee54d712ce4758f6c9c2e64a43f80b6c076406 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70404 Tested-by:
Helmut Hummel <typo3@helhum.io> Tested-by:
-
Oliver Hader authored
`ContentObjectRenderer` and `AbstractMenuContentObject` are still relying HTML event attribute `onclick` to open new client window instances, which were (correctly) removed by HTML sanitizer. In order to keep the functionality, exceptional declarations have been added, and `vHWin=window.open(...)` substituted by `openPic(...)`. Resolves: #94866 Releases: master, 11.3, 10.4, 9.5 Change-Id: I961746b3776d12f302933ebb775ab215bdcd85ab Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70551 Tested-by:
-
Krzysztof Gutkowski authored
The label_alt field in TCA is a comma separated list of database columns, so it needs to be exploded before being passed into a database query. Resolves: #83268 Releases: master, 10.4 Change-Id: I5daf07acd3ee2d409d970ac896408bec2e0abe33 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70057 Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Guido Schmechel <guido.schmechel@brandung.de> Reviewed-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Tested-by:
-
- Aug 14, 2021
-
-
Andrzej Kołbuc authored
* "Make query" vanished from the interface since #94121 due to a broken type comparison on $this->queryConfig. * Date fields now properly load date pickers. Resolves: #94862 Resolves: #94884 Related: #94121 Releases: master Change-Id: I69602722bb7ee83bd616b3e6d175725bd9a70907 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70539 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
-
Tymoteusz Motylewski authored
Resolves: #94888 Related: #94577 Releases: master Change-Id: I6f1405b0de857b050799ff521b88e617f0307858 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70589 Tested-by:
Rudy Gnodde <rudy@famouswolf.com> Tested-by:
-
Benni Mack authored
The error handler now uses LogLevel constants in various places, except for sys_log where the severity is manually resolved. Resolves: #94783 Releases: master Change-Id: I6e7fd00510e59c0bc3c661bb21dd42453a5c835e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70285 Reviewed-by:
crell <larry@garfieldtech.com> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
-
Torben Hansen authored
Since the introduction of `ForwardResponse` in Extbase in #92815 password rules and hash validation in the PasswordRecoveryController did not always lead to the expected forward of the request, since initialize*Actions in Extbase do not handle a potential response. This patch moves the existing validation logic to the corresponding controller actions, so `ForwardResponse` objects can be handled properly. Also, all Extbase actions now return PSR-7 responses where suitable. Resolves: #93869 Releases: master Change-Id: Ide7877d40205f86a5a4f7bfe058857d821224438 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69677 Tested-by:
-
Andreas Fernandez authored
The method `FormEngineUtility::getIconHtml()` is used in various places, e.g. when rendering icons of a SelectIcons field wizard. If many icons are loaded, the rendering process may take some time, depending on the user's internet connection. To improve the initial rendering speed, the icons are now lazy loaded. Resolves: #94877 Releases: master, 10.4 Change-Id: I1ffb395124a7d9793188c7acdb039c3da698d41c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70573 Tested-by:
Benjamin Kott <benjamin.kott@outlook.com> Tested-by:
Frank Nägler <frank.naegler@typo3.com> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
-
Georg Ringer authored
A new feature flag enables indexed_search to remove the documents from the index if the page or content is changed in the backend. Resolves: #94577 Releases: master Change-Id: I871978d15366c8d7ac560c82a29702678701db2c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69914 Tested-by:
kharaf <k.haraf@macopedia.com> Tested-by:
-
Roman Büchler authored
This part handles: - EXT:belog - EXT:beuser Resolves: #94878 Releases: master Change-Id: I6f54188d340c6992fa798dfb67f56d8ea3315704 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70576 Tested-by:
-
- Aug 13, 2021
-
-
Wouter Wolters authored
Method is marked deprecated since v10 and can be removed in v11. Resolves: #94781 Releases: master Change-Id: Ibd1211289365ddde5b29de0006f2e1116112d7e7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70400 Tested-by:
-
Wouter Wolters authored
diff-format option has been removed. udiff is the default now since v3. composer u friendsofphp/php-cs-fixer composer/xdebug-handler php-cs-fixer/diff composer req --dev friendsofphp/php-cs-fixer:^3.0 Resolves: #94856 Releases: master Change-Id: I33470fc49b4355130e73326c85323a1848fe3562 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70516 Tested-by:
-
Wouter Wolters authored
The following core extensions are handled: * EXT:scheduler * EXT:seo * EXT:setup * EXT:t3editor * EXT:workspaces Resolves: #94850 Releases: master Change-Id: Ia3e7138a2c4babbcf4428a9a3e5d64de81262687 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70503 Tested-by:
Marcin Sągol <marcin@soee.pl> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
Wouter Wolters authored
Several unused variables are found that can be removed without problems. Resolves: #94793 Releases: master Change-Id: Ibf87fc95fbfe6da1b0dc7ba9e5939d7e738fa867 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70410 Tested-by:
Stefan Busemann <stefan.busemann@in2code.de> Tested-by:
-
Wouter Wolters authored
Test methods are not allowed to have a prefix "test". Use the annotation "@test" in phpDoc instead. Integration into pre-merge and nightly gitlab-ci suites. Note we now have multiple tests based on nikic/php-parser. Those should be rewritten to use one parser instance with multiple visitors to scan php code only once. The exception code checker should be rewritten to use the parser, too. This will be done with a dedicated patch. Resolves: #94859 Releases: master Change-Id: I43ba692eaf2a342a2e0ed3d8978386ea5719183f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70524 Tested-by:
waldhacker <hello@waldhacker.dev> Tested-by:
-
Jochen Roth authored
The "create new element" button in the form editor was cut off. This is fixed by calculating the height minus the doc-header height. Resolves: #94773 Releases: master Change-Id: I7dfc891138473592c76562c6802430a4311739a2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70394 Tested-by:
Björn Jacob <bjoern.jacob@tritum.de> Tested-by:
-
Jochen Roth authored
On each keystroke the animation for validators was triggered. This is now fixed by removing the animation on an active form element. Resolves: #94775 Releases: master Change-Id: I78d454df081c035c5858f32bb0bd3a8b01679a7e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70395 Tested-by:
-
Oliver Hader authored
New `<f:sanitize.html build="default">` view-helper is introduced which directly invokes processing of `typo3/html-sanitize` package. An optional view-helper argument `build` allows using a defined preset, or a fully qualified class name of a builder instance as alternative, which has to implement `\TYPO3\HtmlSanitizer\Builder\BuilderInterface`. In contrast to `<f:format.html>`, this does NOT invoke `lib.parseFunc`, and does NOT rely on TypoScript configuration being loaded and parsed. Resolves: #94825 Releases: master, 11.3, 10.4, 9.5 Change-Id: Id0720120fea7d5d517a8c61d10bdbb6b03658adf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70457 Tested-by:
-
Andreas Fernandez authored
To be more consistent: * Rename "-s install" to "-s acceptanceInstall" * Rename "-s cglAll" to "-s cgl" * Rename "-s lint" to "-s lintPhp" Apart from that, the cgl checker also lints the files before checking cgl. The explicit pre-merge lint jobs are thus obsolete in pre-merge. We keep "lint everything" for nightlies to be sure. Resolves: #94769 Releases: master Change-Id: Ie7b409f3b2485a8792199e4ad2eaec8565daf253 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70340 Tested-by:
-
Björn Jacob authored
Resolves: #94882 Releases: master Change-Id: I3f398731cb2bd313efae0f8f7f75032fb4220ca7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70583 Reviewed-by:
-
11nd11 authored
Streamline and optimize styling and markup of the form manager of form module. * Clean up markup and classes of form list * Optimize UX of the form list and use the new alternative action menu for better icon description * Use new common styles and elements for better overview and modern look Resolves: #94806 Releases: master Change-Id: I5e24be3e022480c1798745131be7d41f4a5eaf2f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70450 Tested-by:
Paul H <paul+typo3@ecopixel.com> Tested-by:
-
Benni Mack authored
* Clickmenu needs to wait for full initialization before clicking on 'more'. * Always wait for page elements when loading new page. Resolves: #94875 Related: #94772 Releases: master Change-Id: I883a0370c34309ca555076b4088f173d77579f61 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70549 Tested-by:
Alexander Nitsche <typo3@alexandernitsche.com> Tested-by:
-
Oliver Bartsch authored
The columns selector actions buttons did previously not respond when clicking on their icon. This is fixed by adding the event listener to the corresponding buttons instead of the outer container and by accessing the required data attribute from `event.currentTarget`. Resolves: #94881 Releases: master Change-Id: I7992a307bd5a397eff11b395c5a4b22bd9e05a40 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70581 Tested-by:
-
Mathias Brodala authored
Resolves: #94871 Releases: master Change-Id: If8f4c823d1e21639a173f8ba2580e15c4daf9e20 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70544 Tested-by:
-
Björn Jacob authored
The documentation describes how to exclude specific options from being overridden via the form plugin. Resolves: #80407 Releases: master, 10.4 Change-Id: Id90808b921afadc3d090078e6d2cc5eb157fcf43 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70538 Tested-by:
Mathias Brodala <mbrodala@pagemachine.de> Tested-by:
-
Christian Kuhn authored
This one is disabled with sqlite already, mssql suffers from the same issue. Needs a dedicated fix somewhere in the tree classes, the issue is on our todo list with current ext:impexp works. Resolves: #94874 Related: #94772 Releases: master Change-Id: Ic4770ba5c6cb72c790816edafd732ca263ab8c1b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70545 Tested-by:
-
Ralf Zimmermann authored
Cleanup the last "duplicate form" wizard code and make the buttons in the last "duplicate form" wizard step clickable. Resolves: #94860 Releases: master Change-Id: Ib6dac66cc3a3860fb380ee7028890acb08890f36 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70527 Tested-by:
Andreas Steiger <typo3@andreassteiger.de> Tested-by:
-
Wouter Wolters authored
The FileSpoolTest is creating a directory "spool" on root level. Unit tests should never create directories on the root level of TYPO3 project. Instead use `Environment::getVarPath()` as path. Resolves: #94858 Releases: master,10.4 Change-Id: I04d1aa246d496b175361f22aa49ed2ac8fec3853 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70520 Reviewed-by:
Simon Gilli <typo3@gilbertsoft.org> Reviewed-by:
-
Jochen Roth authored
Fixed by adding a fallback to the affected array keys. Resolves: #94863 Releases: master Change-Id: I373910d106971c101493b0a427d09cf9904ab249 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70541 Tested-by:
-
Stefan Bürk authored
Remove resolved scriptName with leading slash from url in PageRouter matchRequest method. This prevent to change the url to a invalid url if PageTypeSuffix Decorator with .php is used and a page slugs ends in index. Resolves: #94537 Releases: master, 10.4, 9.5 Change-Id: I5057bb6888c228a4ca5b53d363ecf1bc7a6af1c6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69854 Tested-by:
-
Andreas Häfner authored
In patch #94429 inclusion of LL file has been removed accidentally. To prevent multiple inclusion of LL-file in loop, incusion is done in DataStructureIdentifierHook::__construct now. Adds new constant for LLFile. Resolves: #90784 Related: #94429 Releases: master Change-Id: I4446ed6e05b8e506279e77fae4703a817831129d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70465 Tested-by:
-
Ralf Zimmermann authored
Form mixins were deprecated with #89742. The patch removes the code. Resolves: #94861 Releases: master Change-Id: Ic82729ae52d3f8c6ca7cd0ad8f6c97aceebc96d0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70528 Tested-by:
-
Benni Mack authored
When having a content element on the clipboard (normal mode) the page module dynamically shows paste icons everywhere. This change centralizes the generation of the Paste icons into JavaScript, so the inline javascript usage of "top.*" functionality to park code somewhere has been removed, and the actual items are generated in JavaScript. In addition, as this code is only affecting the page module when a tt_content element is on the clipboard, the Paste.js JS module is only loaded when appropriate, thus reducing the actual loading time for "regular" visits on the Page Module. The icon in the paste button is now loaded via a native web component, and only necessary logic is used in the Paste JS module. The outer rendering for the Page Module has been simplified, moving this functionality all into PageLayoutController, reducing cross-dependencies between the PageLayout* classes. Resolves: #94840 Releases: master Change-Id: I380df9a56bfff74684616732166f25c68bbc6dec Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70488 Tested-by:
-
Guido Schmechel authored
Resolves: #94357 Releases: master, 10.4 Change-Id: I8c074372c3c42b8c5a74afff7b9fb386c2f136a2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69953 Tested-by:
Torben Hansen <derhansen@gmail.com> Tested-by:
-
Roman Büchler authored
Resolves: #94851 Releases: master Change-Id: Ied2b2e1eb3ca05da12893a1ad23784e85bda74d5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70506 Tested-by:
-
Georg Ringer authored
Skip a real check of the file system for SVG files in advance in the SvgFilesSanitization wizard to avoid timeouts in e.g. the reports module. Resolves: #94801 Releases: master, 11.3, 10.4, 9.5 Change-Id: I4ed52d357effec4a8e698d5b117f024150a01beb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70448 Tested-by:
-
