When searching for an extension in the remote repository with the "filter" text field, the currently selected repository is not taken into account and results from the main typo3 repository are returned.

Reason: the repository was still hardcoded to main repository

Change-Id: Ife22540867b58beab0bd7fd882b8a2ea9c02a624
Resolves: #25390
Reviewed-on: http://review.typo3.org/1315
Reviewed-by: Steffen Kamper
Tested-by: Steffen Kamper

$GLOBALS['BE']['pageTree']['preloadLimit'] should be
$GLOBALS['TYPO3_CONF_VARS']['BE']['pageTree']['preloadLimit']

Change-Id: Iecefc92580a001267056a3748fb4423cb48767c7
Resolves: #25431
Reviewed-on: http://review.typo3.org/1310
Reviewed-by: Steffen Kamper
Tested-by: Steffen Kamper

Change-Id: I02345d49af5e496796ec98a0cfe05b59ef0aedc0
Reviewed-on: http://review.typo3.org/1308
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader

Change-Id: Ia926b145e9eb184d4244ec4f6552487e72392483
Related: #M17844
Fixes: #M17846
Reviewed-on: http://review.typo3.org/1005
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog

The preview info should not contain workspace related code.
The proposed patch removes all output from tslib_fe::previewInfo
and adds the possibility to hook in it and render a specific
message. The followup implements this for the regular preview.

Change-Id: Ie3c05a1837bb2e11cdb66c72114218ae6e12c973
Related: #13571
Fixes: #M17844
Reviewed-on: http://review.typo3.org/1003
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog

To clear output buffers, the utility function t3lib_div::cleanOutputBuffers()
has to be used. Otherwise things break with compressionLevel enabled.

This change replaces the ob_end_clean() call in the Extension download process,
which did not work, as crap is sent to the user agent.

Change-Id: I078bab66c24d0667b3cd8c2397f26569ed2dbf8d
Resolves: #M18029
Also-Applies: TYPO3_4-5
Reviewed-on: http://review.typo3.org/1264
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog

With the missing link icon it's not clear that there is more info on click.
This cahnge brings back the icon to the tooltip.

Change-Id: I6a09c830772e3b128d31a400c5a8e59959f371a9
Resolves: #M18036
Reviewed-on: http://review.typo3.org/1288
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
Reviewed-by: Francois Suter
Tested-by: Francois Suter

Because of a PHP bug on some systems the request to ajax.php fails because it
includes '../t3lib/class.t3lib_div.php' with relative path while init.php uses
PATH_t3lib . 'class.t3lib_div.php'.
On some systems PHP is not able to detect the already included file when a
different path is used.

Change-Id: I66e39690747c4f78b4571cf63777d98cb88b6b75
Resolves: #M17250
Reviewed-on: http://review.typo3.org/1286
Reviewed-by: Joh. Feustel
Tested-by: Joh. Feustel
Reviewed-by: Steffen Kamper
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers

If only one value is allowed in a group field (maxitems==1), the
present value will be removed when the user selects a new value via
element browser or file upload field.

If the list is disabled (by disable_controls setting) the user doesn't
have the possibility to remove items. To prevent a "write once" field
the first item in the list will be removed if the maxitems limit has
been reached.

Change-Id: Iac48371f672b78e7c2ea3450af581759986015bc
Resolves: #M14430
Reviewed-on: http://review.typo3.org/1142
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
Reviewed-by: Steffen Kamper
Tested-by: Steffen Kamper

Exchange the CSS style definition for the non-existant element "submit"
with "button", which is supposed to be meant.

Change-Id: Ib865addda8e3729970a4b72c1eb233e257ae9074
Resolves: #M18043
Reviewed-on: http://review.typo3.org/1279
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert

The upgrade wizard of the install tool quits with a php fatal error if
php is configured to use registered globals.

When using registered globals, $GLOBALS['LANG'] may already be
initialized (with some string). The buggy line does not properly
initialize the language object if there is content in $GLOBALS['LANG'].
The solution changes this, so that $GLOBALS['LANG'] has to be an object
to prevent object creation. this line is also found in other places in
the typo3 source.

Change-Id: I1e553d233d6dac636d8a10a4ea5e60946e89d220
Resolves: #M17807
Reviewed-on: http://review.typo3.org/1254
Reviewed-by: Peter Niederlag
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Xavier Perseguers
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert

This change makes compressCssFile() also use this helper, as it was forgotten in the
first place.

Change-Id: Id394f9a67e6222f7663e719ddce602d5ada2d10c
Resolves: #M18035
Reviewed-on: http://review.typo3.org/1176
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert

Remove SVN $Id$ auto-properties from TYPO3 source code

Change-Id: I26054ac32d77b212450b740178c8ce18be12e086
Resolves: #M18016
Reviewed-on: http://review.typo3.org/1272


Reviewed-by: Xavier Perseguers <typo3@perseguers.ch>
Tested-by: Xavier Perseguers <typo3@perseguers.ch>

Change-Id: I9de4384637a2c35499d2f54e67b0924183b1bb9b
Reviewed-on: http://review.typo3.org/1266


Reviewed-by: Xavier Perseguers <typo3@perseguers.ch>
Tested-by: Xavier Perseguers <typo3@perseguers.ch>

This change adds a specialized Date Picker, which is used for datetime fields.
Previously, always 0:00 has been returned as time of the day.

Change-Id: I2be56f5ecb56edd9c5619ae3bbf6d8cb8a091768
Resolves: #M17596
Reviewed-on: http://review.typo3.org/1184


Reviewed-by: Steffen Kamper <info@sk-typo3.de>
Tested-by: Steffen Kamper <info@sk-typo3.de>

Remove code, which is not needed anymore and duplicates code.

Change-Id: I59491c8d194574e1ef80a461194fa054f32717ab
Resolves: #M17911
Reviewed-on: http://review.typo3.org/1112


Reviewed-by: Steffen Kamper <info@sk-typo3.de>
Tested-by: Steffen Kamper <info@sk-typo3.de>

Initialize variables, which are used, but not initialized in every case before.

Change-Id: Iccc6f2c31a4ade6485072f56afd7f1b227d1f516
Resolves: #M17934
Reviewed-on: http://review.typo3.org/1144


Reviewed-by: Steffen Gebert <steffen.gebert@typo3.org>
Tested-by: Steffen Gebert <steffen.gebert@typo3.org>
Reviewed-by: Sebastian Fischer <typo3@evoweb.de>
Reviewed-by: Steffen Kamper <info@sk-typo3.de>
Tested-by: Steffen Kamper <info@sk-typo3.de>

You see only the message:
To get and update the list, go to the section "Import extensions" and use the button "Retrieve/Update".
even if table is filled.
 The reason is that it looks for typo3temp/extensions.xml.hz instead checking if the table has records.

 Solution:
 Check table count instead.

 Resolves: #M17907

Change-Id: I6c2905a0afce08f70c4743d66a1b521de30044fb
Reviewed-on: http://review.typo3.org/1108


Reviewed-by: Peter Beernink <p.beernink@drecomm.nl>
Tested-by: Peter Beernink <p.beernink@drecomm.nl>
Reviewed-by: Tolleiv Nietsch <info@tolleiv.de>
Reviewed-by: Steffen Kamper <info@sk-typo3.de>
Tested-by: Steffen Kamper <info@sk-typo3.de>

When checking one of the filter provided by the filter button menu, it gets printed bold.
However this seems not clear enough for many users, so display the "Clear filters" button would make it more clear.

Change-Id: I7345ab182fd5879ca18b2bf131c8c860f71def1f
Resolves: #M17892
Reviewed-on: http://review.typo3.org/1093


Reviewed-by: Peter Beernink <p.beernink@drecomm.nl>
Tested-by: Peter Beernink <p.beernink@drecomm.nl>
Reviewed-by: Markus Klein <klein.t3@mfc-linz.at>
Tested-by: Markus Klein <klein.t3@mfc-linz.at>
Reviewed-by: Steffen Kamper <info@sk-typo3.de>
Tested-by: Steffen Kamper <info@sk-typo3.de>

In small views the text is not readable as it gets cut.
Solution:
Add the same text to a tooltip.

Resolves: #M17788
Change-Id: I8b963be0867e099383c15f367a9627b7eed0c5f0
Reviewed-on: http://review.typo3.org/960


Reviewed-by: Steffen Kamper <info@sk-typo3.de>
Tested-by: Steffen Kamper <info@sk-typo3.de>

The expand/collapse context menu actions are missing icons.

Change-Id: I3ae86ff0a4de225854d173a485a0a8991adccd22
Resolves: #M17924
Reviewed-on: http://review.typo3.org/1130


Reviewed-by: Stefan Galinski <stefan.galinski@gmail.com>
Tested-by: Stefan Galinski <stefan.galinski@gmail.com>

The first tab has different wrappers, so the CSS does not work on other tabs than the first one.

Change-Id: I980005f7dd981d7f3b27f7b1e1383129c369ae50
Resolves: #M17789
Reviewed-on: http://review.typo3.org/1117


Reviewed-by: Xavier Perseguers <typo3@perseguers.ch>
Tested-by: Xavier Perseguers <typo3@perseguers.ch>
Reviewed-by: Steffen Kamper <info@sk-typo3.de>
Tested-by: Steffen Kamper <info@sk-typo3.de>

When grouping with author you may see many groups with same author. This happens
 if author of extensions is there with different email adresses.
 Further author with email is clickable which is not useful in group header.

 Solution:
 use simple groupRenderer that returns author only.

 Resolves: #M17887

Change-Id: Ia23082498fca61db975ff02eaf335578180315ea
Reviewed-on: http://review.typo3.org/1081


Reviewed-by: Björn Pedersen <bjoern.pedersen@frm2.tum.de>
Reviewed-by: Steffen Kamper <info@sk-typo3.de>
Tested-by: Steffen Kamper <info@sk-typo3.de>

Use Ext.urlEncode() to encode links in TBE_EDITOR. This ensures
correct generation of strings in conjunction with UTF-8 and fixes
wrongly encoded special chars (e.g. umlauts) in the browse-links
dialog's field link-title.

Change-Id: I003f7e64f8a10b0a49d6cbe0e2e82d67d614d21a
Resolves: #M17979
Reviewed-on: http://review.typo3.org/1227


Reviewed-by: Steffen Kamper <info@sk-typo3.de>
Tested-by: Steffen Kamper <info@sk-typo3.de>

t3lib_sqlengine is deprecated, remove it

Change-Id: I38563832cd0a549a84a0076cc855037cded58496
Reviewed-on: http://review.typo3.org/1013


Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Xavier Perseguers <typo3@perseguers.ch>
Reviewed-by: Björn Pedersen <bjoern.pedersen@frm2.tum.de>
Reviewed-by: Steffen Kamper <info@sk-typo3.de>
Tested-by: Steffen Kamper <info@sk-typo3.de>

Reason: ExtJs fails if ExtCore is loaded.
ExtCore is a "small" compilation of ExtJS just for some little widgets and effects.
Resolves: #M17994

Change-Id: I5f676af89c981e0d6aea08ffa4c0db10324f0a0e
Reviewed-on: http://review.typo3.org/1212


Reviewed-by: Steffen Kamper <info@sk-typo3.de>
Tested-by: Steffen Kamper <info@sk-typo3.de>
Reviewed-by: Helmut Hummel <typo3@helmut-hummel.de>

Description
Problem:
I want to use the new TCA tree, but when I configure 1 as maxitems I
can't select a tree node.

This happens, because this.countSelectedNodes in
t3lib\js\extjs\tree\tree.js is 1 even when I create a new record.
And this.countSelectedNodes is 1 because $valueArray in
t3lib\tceforms\class.t3lib_tceforms_tree.php in the function
renderField always has at least one entry.

$valueArray is created by exploding $PA['itemFormElValue']. In fresh
records $PA['itemFormElValue'] is 0 and not NULL (or not set) and
has no other effects. But $valueArray has an entry and that's why
count($valueArray) is 1 and then this.countSelectedNodes is also 1.

To reproduce this issue you can use this TCA (Thanks to Steffen:
http://lists.typo3.org/pipermail/typo3-team-core/2010-November/044931.html):
$GLOBALS['TCA']['pages']['columns']['fe_group']['config']
['renderMode'] = 'tree';
$GLOBALS['TCA']['pages']['columns']['fe_group']['config']['maxitems'] = 1;
$GLOBALS['TCA']['pages']['columns']['fe_group']['config']['treeConfig']
= array(
     'parentField' => 'subgroup',
     'appearance' => array(
         'expandAll' => TRUE,
         'showHeader' => TRUE,
     )
);

Solution:
To fix this issue $PA['itemFormElValue'] should be only exploded if it's
not 0. Like I wrote before, this is done in
t3lib\tceforms\class.t3lib_tceforms_tree.php and fixed in the appended
patch.

Fixing this issue causes a little follow up in t3lib\js\extjs\tree\tree.js.
This is also fixed in the patch.

Change-Id: I5d23ea1d63b1107925e265392f4d13f4db3d1063
Resolves: #M17976
Reviewed-on: http://review.typo3.org/1188


Reviewed-by: Moritz <moemos@gmail.com>
Tested-by: Moritz <moemos@gmail.com>
Reviewed-by: Steffen Ritter <info@rs-websystems.de>
Tested-by: Steffen Ritter <info@rs-websystems.de>

If you try to dump Tables via Extension Manager, you will get a file which looks like this:
...
INSERT INTO static_languages VALUES (NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL);
INSERT INTO static_languages VALUES (NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL);
...

Reason:
tx_em_database::dumpTableContent uses associative Array $fieldStructure to access the database fields. Although $fieldStructure contains a mapping $field => $structure, the fields are read in a foreach-loop which uses the values of the array.

Change-Id: I6617cb5999d0ce4c184e6f15cbaf0d151bb4516d
Resolves: #M17938
Reviewed-on: http://review.typo3.org/1169


Reviewed-by: Björn Pedersen <bjoern.pedersen@frm2.tum.de>
Reviewed-by: Steffen Kamper <info@sk-typo3.de>
Tested-by: Steffen Kamper <info@sk-typo3.de>

By default, TYPO3 uses *_pconnect() to connect to the database. This
is however only required in case connecting to the DB server is slow. In
other cases there is no advantage in turning this on, but there may be
disadvantages if the configuration of database and web server are not
aligned.
See also http://www.php.net/manual/en/features.persistent-connections.php

This commit was made based on a discussion on typo3-dev, see message
<mailman.12316.1298886389.648.typo3-dev@lists.typo3.org> and following.

Change-Id: Ibdc5f5c6045206039cbb23be47e1d2e648a94da5
Reviewed-on: http://review.typo3.org/1137


Tested-by: Mr. Jenkins <blueduck@gmx.net>
Reviewed-by: Xavier Perseguers <typo3@perseguers.ch>
Tested-by: Xavier Perseguers <typo3@perseguers.ch>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Andreas Wolf <andreas.wolf@ikt-werk.de>

Change-Id: I7c11ed05d84e7706f479e21c3954288e99e5d982
Resolves: #M17468
Reviewed-on: http://review.typo3.org/974


Reviewed-by: Steffen Kamper <info@sk-typo3.de>
Reviewed-by: Philipp Gampe <forge.typo3.org@philippgampe.info>
Reviewed-by: Jigal van Hemert <jigal@xs4all.nl>
Tested-by: Jigal van Hemert <jigal@xs4all.nl>

Create common CSS classes to be used for toolbar items so that it looks
the same, and extensions doesn't have to create the same css again and
again.

* Common "drop down" class
* Common ul/li definition
* Common layout, all looks the same

Change-Id: Iedad718ab4f26d87177e3d49ca93f58bf543d9f6
Resolves: #M17888
Reviewed-on: http://review.typo3.org/1088


Reviewed-by: Steffen Gebert <steffen.gebert@typo3.org>
Tested-by: Steffen Gebert <steffen.gebert@typo3.org>
Reviewed-by: Andreas Wolf <andreas.wolf@ikt-werk.de>
Tested-by: Andreas Wolf <andreas.wolf@ikt-werk.de>

Changes type of $TYPO3_CONF_VARS['MAIL']['transport_smtp_encrypt']
from checkbox to input field. So the user can enter a transport protocol
for connecting the SMTP server.

Change-Id: I1195d640320616234ba0be7cc0328151e44a8999
Resolves: #M17465
Reviewed-on: http://review.typo3.org/1127


Reviewed-by: Steffen Gebert <steffen.gebert@typo3.org>
Tested-by: Steffen Gebert <steffen.gebert@typo3.org>
Reviewed-by: Jigal van Hemert <jigal@xs4all.nl>
Tested-by: Jigal van Hemert <jigal@xs4all.nl>

Changing the TCA (especially the columns-part of a table) via
Tools->Configuration breaks eg. the list module.
Tools->Configuration writes strings like
$GLOBALS['TCA']['tt_news']['columns']['image']['config']['allowed'] = 'jpg';
to typo3conf/extTables.php.

However, a call to loadTCA($table) call is not added before, so
the TCA array is incomplete. Furthermore if you set the columns part
in extTables.php any proceeding call to loadTCA will not work, since
'columns' is already defined.

Change-Id: Ifc4103cdd04b6b063e3d099b5c5ccb47dfb7d442
Resolves: #M17754
Reviewed-on: http://review.typo3.org/1043


Reviewed-by: Steffen Gebert <steffen.gebert@typo3.org>
Tested-by: Steffen Gebert <steffen.gebert@typo3.org>
Reviewed-by: Stefan Galinski <stefan.galinski@gmail.com>
Reviewed-by: Susanne Moog <typo3@susannemoog.de>

If TYPO3 is installed in a subfolder, you won't need a absRefPrefix set because normally links are relative.
If a Protocol change will (SSL -> PLAIN or vice versa) happen, the URL has to be generated absolute.
This will fail in the described behaviour.

Notes:
This one has been reported by Michael Maier.
Attached patch is my "easier to read" version doing the same as _v2 of Jigal and the result of talking through all cases which may arise.

Change-Id: Ie5821361b578b6f1fa3612ac9bfa44dd476c9c76
Resolves: #M17118
Reviewed-on: http://review.typo3.org/953


Reviewed-by: Tobias Liebig <mail_typo3.org@etobi.de>
Reviewed-by: Andreas Wolf <andreas.wolf@ikt-werk.de>
Tested-by: Andreas Wolf <andreas.wolf@ikt-werk.de>
Reviewed-by: Sebastian Fischer <typo3@evoweb.de>
Reviewed-by: Helmut Hummel <typo3@helmut-hummel.de>
Tested-by: Helmut Hummel <typo3@helmut-hummel.de>
Reviewed-by: Jigal van Hemert <jigal@xs4all.nl>

When moving a content element in the List module by clicking on
the "Re-position content element" icon, an user is presented with
the old 4 columns instead of columns that would represent the newly
introduced backend layout as it is appearing in the Page module.

Change-Id: Ie8120784b0ccb9036d012437cae966de3484f1e6
Fixes: #M17529
Reviewed-on: http://review.typo3.org/1040


Reviewed-by: Andreas Wolf <andreas.wolf@ikt-werk.de>
Tested-by: Andreas Wolf <andreas.wolf@ikt-werk.de>

Formsonopage-mode raises error: Call to undefined method stdClass::getDynNestedStack.
Thus call initDefaultBEMode() during initialization.

Change-Id: If3ffc4b4fb3aff0dac72f3cbca405cb74d082783
Resolves: #M15553
Reviewed-on: http://review.typo3.org/1078


Reviewed-by: Björn Pedersen <bjoern.pedersen@frm2.tum.de>
Tested-by: Andreas Wolf <andreas.wolf@ikt-werk.de>
Reviewed-by: Andreas Wolf <andreas.wolf@ikt-werk.de>

porting what was in svn:ignore before
needs to be aplied to all branches separatly, once we agree

Change-Id: If03b9e4796604056acadf3bf662f7990c84ca8b5
Fixes: #13627
Reviewed-on: http://review.typo3.org/1096


Tested-by: Andreas Wolf <andreas.wolf@ikt-werk.de>
Reviewed-by: Steffen Ritter <info@rs-websystems.de>
Tested-by: Steffen Ritter <info@rs-websystems.de>
Reviewed-by: Andreas Wolf <andreas.wolf@ikt-werk.de>

The check is wrong. Instead of checking if the entry is equal to default entry, it should check if any parts of the default value are removed.

As it's a security warning, this should be stated in the warning, so change the wording.

Change-Id: If20d362bef39a4d8533a54e8124b4913b9dcb55e
Resolves: #M17817
Reviewed-on: http://review.typo3.org/1031


Tested-by: Andreas Wolf <andreas.wolf@ikt-werk.de>
Reviewed-by: Steffen Ritter <info@rs-websystems.de>
Tested-by: Steffen Ritter <info@rs-websystems.de>
Reviewed-by: Andreas Wolf <andreas.wolf@ikt-werk.de>

Improve the way, TYPO3 is throwing Exceptions:

* Add a unique error code to all Exception($msg, $code) calls
* Replace die() statements with Exceptions, if possible
* Replace some general Exceptions with RuntimeException or ArgumentException.

Change-Id: Ic148f14b9a71136c917e9dc8b95513341b3c6ca0
Resolves: #M16953
Reviewed-on: http://review.typo3.org/1079


Reviewed-by: Andreas Wolf <andreas.wolf@ikt-werk.de>
Tested-by: Andreas Wolf <andreas.wolf@ikt-werk.de>
Reviewed-by: Steffen Ritter <info@rs-websystems.de>

The "deleted" overlay type is missing from the list of overlay
priorities as defined in
$TBE_STYLES['spriteIconApi']['spriteIconRecordOverlayPriorities'].
This patch fixes this by adding it as the first item in the list,
since one can assume "deleted" to be the most important status.

NOTE: it's hard to view the result of this patch as deleted records
are not normally shown in the TYPO3 BE. You may have deleted
records when working in a workspace, but they will still not be
visible after this patch due to a further bug in t3lib_iconworks.
See http://bugs.typo3.org/view.php?id=17117 for a discussion of that
further bug.

To view the effect of this patch, apply the patch from #M17117,
go to a workspace, delete an unversioned record and see the icon
change.

Change-Id: Ie2c1f6ef672c5eb73fbc37066fd7596380c64932
Resolves: #M17815
Reviewed-on: http://review.typo3.org/1089


Reviewed-by: Steffen Ritter <info@rs-websystems.de>
Tested-by: Steffen Ritter <info@rs-websystems.de>