- Jul 18, 2023
-
-
Stefan Bürk authored
RegEx redirects have been processed in the order how they have been inserted into the database ignoring the flag `respect_query_parameters` completely. Due to this fact, a non-query argument based regex redirect would match before a concrete query-argument aware regexp redirect have been matched - additionally favored by the changes introduced with #96480 to provide a fallback. To combine all use-cases and additionally fix the detected issues, this change now splits the cached regex redirects into two flavors: * `regexp_respect_query_parameters` * `regexp_flat` That follows the pre-selection for the non-regex redirects. Redirects respecting query paramaters have higher precedence above the non-respecting once. Therefore, the matching flow in the `RedirectService` has been aligned correspondingly to respect this separated workflow. The #96480 is now only applied for regex redirects which do not respect query-arguments at all. It should be considered if we should remove that safety fallback and enforce correct regex redirects in a dedicated future change. Furthermore, a deterministic sorting criteria chain has been added to the `RedirectCacheService` to ensure a deterministic loading and caching order of redirects. The changes play together, which is the reason why they are included in one change and to avoid a inbetween incorrect test chain. Regression tests have been added to cover the cases. Resolves: #101191 Related: #96480 Releases: main, 12.4, 11.5 Change-Id: I9638835c33809e92ba883efb65d86bb1e9f5031b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80079 Tested-by:
Stefan B�rk <stefan@buerk.tech> Reviewed-by:
core-ci <typo3@b13.com>
-
Andreas Fernandez authored
The identifier for the icon cache used in the client's localStorage is now version-aware to get a chance of updated icons after a release. It now uses the same identifier as the backend cache. Previously, only the registry state itself was taken into account which may not change if icons assets get updated. Resolves: #101348 Releases: main, 12.4, 11.5 Change-Id: I15dfc9d4bf1288f9787f88f579beccf3b13a3fc6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80073 Tested-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
-
- Jul 17, 2023
-
-
Georg Ringer authored
Add the pid to the list of fields which should always be retrieved when selecting a record. This especially avoid a PHP warning in FormEngine when workspace records are overlaid. Resolves: #98181 Releases: main, 12.4, 11.5 Change-Id: Iaf5479e329693486c992495228fca1b711ba6161 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80043 Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
-
- Jul 15, 2023
-
-
Georg Ringer authored
The method str_contains requires the 1st argument to be a string. So we need to ensure that it is a string. (It can be `null` if the command ran into an error.) Resolves: #101349 Related: #70869 Releases: main, 12.4, 11.5 Change-Id: Ic4267f1fd8290d340b5fc43acd47797b592d466e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80032 Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
- Jul 14, 2023
-
-
Georg Ringer authored
Avoid exceptions due to wrong type in the link validator module. Resolves: #101352 Releases: main, 12.4, 11.5 Change-Id: Ic54b38e2fad6c203526fe27fa1b2ea6815f0578f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80028 Reviewed-by:
-
- Jul 13, 2023
-
-
Andreas Fernandez authored
In very rare cases it may happen that a backend session is not valid anymore when an icon is loaded within the TYPO3 backend. If the icon is not in the user's localStorage, the TYPO3 backend login is stored in localStorage instead. To catch this issue in the future, additional checks were implemented: * the response shall not come from a redirected request, which could be an indicator for unwanted markup * the received markup must start with "<span" Resolves: #101339 Releases: main, 12.4, 11.5 Change-Id: Ic30672b770b7d12aa078e423cb595966247d5506 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80016 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
-
Oliver Klee authored
Fix some failures that occur if the internal classes in EXT:backend use strict typing. Resolves: #101325 Releases: main, 12.4, 11.5 Change-Id: I964b802762991b6409e599d7a746bdbe22740dfb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80015 Tested-by:
-
- Jul 12, 2023
-
-
Benjamin Franzke authored
egrep is deprecated since 2.5.3 (2007) and is marked as obsolete in grep 3.8, see https://lists.gnu.org/archive/html/info-gnu/2022-09/msg00001.html Also remove a stray \ before the # symbol, which doesn't need escaping in grep. Prevents the following warnings during the commit-msg hook: egrep: warning: egrep is obsolescent; using grep -E egrep: warning: egrep is obsolescent; using grep -E egrep: warning: egrep is obsolescent; using grep -E grep: warning: stray \ before # egrep: warning: egrep is obsolescent; using grep -E Resolves: #101329 Releases: main, 12.4, 11.5 Change-Id: I2777d8ffd640598d7c92bed166b793b285e5fa06 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79979 Tested-by:
-
- Jul 11, 2023
-
-
Benni Mack authored
Change-Id: I1608d379e6becff4a45b9afb972b02cc91645947 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79966 Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
-
Benni Mack authored
Change-Id: I0c4b5c42c6254d4d63f2f125b58862bcc119613c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79965 Reviewed-by:
-
Oliver Klee authored
`GeneralUtility::sanitizeLocalUrl` expects a string. So the fallback value when calling this method also needs to be a string, not null. This patch adjusts two of such calls. Resolves: #101310 Related: #101305 Releases: main, 12.4, 11.5 Change-Id: I737eea4910e95f653982cbe5b268c782cdf8a502 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79977 Tested-by:
-
Andreas Fernandez authored
With the upgrade to Bootstrap 5, modals unintentionally don't support the `data-content` attribute anymore as this was automatically migrated to the namespaced variant `data-bs-content`. While this is technically correct for Bootstrap 5, Core still needs to support the old variant as documented. Resolves: #98067 Releases: main, 12.4, 11.5 Change-Id: I544cbd779c808727c472575654adca3dc4c91197 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79961 Tested-by:
-
Oliver Klee authored
There already was a data provider for the negative case of this method, but no tests using this data provider. Resolves: #101308 Releases: main, 12.4, 11.5 Change-Id: If32b5f2943240f224031e20d9849f849275358a5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79973 Tested-by:
-
Benjamin Franzke authored
Stage-change notification mails have only been delivered to the last recipient off the list of possible recipients, because Utility.convertFormToObject failed to detect checkbox elements from (other) frames. In this case the to-be-converted form elements are created on the top frame (modal contents are placed outside list frame on the top frame). Due to JavaScript being prototype based, instanceof checks do only operate per-frame. Prototypes are bound to the current window. `foo instanceof HTMLInputElement` is basically a shortcut and equivalent to `foo instanceof window.HTMLInputElement` while `window != top.window`. Instead of `instanceof` checks, we switch to a `tagName` comparision which is usable for cross-frame HTMLElement type detection. Resolves: #99784 Releases: main, 12.4, 11.5 Change-Id: If9bfd7be1e46d8c04619be3563d3bdba9d9de549 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79924 Reviewed-by:
-
- Jul 10, 2023
-
-
Benjamin Franzke authored
Map backend URLs like /typo3/install.php?install%5Bcontroller%5D=settings to /typo3/module/tools/settings for display in the browsers URL bar. Resolves: #101287 Releases: main, 12.4, 11.5 Change-Id: I5177146e28b01011f946c578804a8141fe9a371f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79925 Tested-by:
-
Nicole Cordes authored
The GlobalEventHandler changes the location of the current (target) window. The location is set to a given destination without any ability to interrupt. The existing ConsumerScope API isn't used even if the current window is the ContentContainer. This patch extends the handling of a navigation action by checking its target window and using proper ContentContainer API to set the location. Therefore registered listener can deny a location change and trigger own functions. Resolves: #95474 Resolves: #100114 Releases: main, 12.4, 11.5 Change-Id: If6a3b1cc546e1f2ff0b8e9fed3f83055f3f55e49 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77720 Tested-by:
-
Tomasz Woldański authored
When using GA4, Google's scripts add "_gl" param to track cross domain links. See https://support.google.com/analytics/answer/10071811?hl=en Resolves: #101302 Related: #101180 Releases: main, 12.4, 11.5 Change-Id: I6c32db355a7a1306710cff9768187f687ce4b5a9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79935 Tested-by:
-
Philipp Kuhlmay authored
Replace link to the documentation of the "crawler" community extension. Releases: main, 12.4, 11.5 Resolves: #101300 Change-Id: Ie284fcb1850f655fb3541653326f7c6c0ed79c9d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79933 Reviewed-by:
Lina Wolf <112@linawolf.de> Tested-by:
Bj�rn Jacob <bjoern.jacob@tritum.de> Tested-by:
-
- Jul 08, 2023
-
-
Gerrit Mohrmann authored
Resolves: #98178 Releases: main, 12.4, 11.5 Change-Id: I6ebcbb67b9cc51d7d56b1da945fdd8b05d5081dc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79869 Tested-by:
-
Torben Hansen authored
With #99920 the HTTP referrer evaluation has been extended to not overwrite the evaluated HTTP referrer on failed logins. The fix however broke the HTTP referrer evaluation, when the login plugin is placed on a page which is configured as 403 error page. In this case, the page is called via sub-request and a possible available HTTP referrer from the initiating request is used as redirect url. This patch extends the HTTP referrer evaluation, so the URL of the initiating request is used as HTTP referrer variable, if the plugin is called via sub-request. This ensures, that the user is redirected to the URL which the 403 error handler intercepted. In order to do so, the `PageContentErrorHandler` is extended to pass the original request as request attribute `originalRequest` to the sub-request. Additionally, the evaluation of the referrer URL has been moved to `RedirectHandler` and all scenarios have been covered with tests. It has to be noted, that in TYPO3 11.5 the fix will only work, if the "Subrequest page errors" feature toggle is enabled. Resolves: #100715 Releases: main, 12.4, 11.5 Signed-off-by:
Torben Hansen <derhansen@gmail.com> Change-Id: Ibcfdf5093eac72f1796d15f40ef9426d0597d7f3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79704 Reviewed-by:
Thomas Hohn <tho@gyldendal.dk> Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
-
- Jul 07, 2023
-
-
Stephan Großberndt authored
Backend no longer crashes with an TableNotFoundException if a table has been removed and an according item is in the list of recent documents. The patch catches the exception. Releases: main, 12.4, 11.5 Resolves: #101139 Change-Id: I489d8cf1ee2bb10800fe2966ae4fc1cb0bcd57c5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79842 Tested-by:
-
- Jul 06, 2023
-
-
Oliver Hader authored
The filename of uploaded files might not be encoded as normalized unicode. For instance, this happens when using umlauts in filenames on HFS+ filesystem (macOS). For instance the client sends an `ö`, which is sent in NFD as `0x6fcc88`, but should be normalized as `0xc3b6`. https://en.wikipedia.org/wiki/Unicode_equivalence#Normalization Executed commands: composer req symfony/polyfill-intl-normalizer:^1.27 composer req symfony/polyfill-intl-normalizer:^1.27 \ -d typo3/sysext/core --no-update Resolves: #101253 Releases: main, 12.4, 11.5 Change-Id: I8605481ffdc3b5d96f529850bf09a1fd75d09cd2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79838 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
Sybille Peters authored
The redirects documentation contains a link to the issues on the page "Known problems", using a category filter. This used to be "Link Handling, Site Handling & Routing", but redirects now have their own category "Redirects Handling", so we use this. Resolves: #101260 Releases: main, 12.4, 11.5 Change-Id: Ife6c4bbd7b2db1476054d5ce2558f84f32ab4800 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79830 Tested-by:
-
Stefan Froemken authored
In case of activated STRICT_TRANS_TABLES, better known as strict_mode, the index_words record incl. metaphone can not be stored as a string is provided, but an int is expected. As various metaphone related methods in TYPO3 return a string we change the DB type of column metaphone to varchar. We set the length to 60 as it is the same we use in analyzeHeaderinfo(). Resolves: #99547 Releases: main, 12.4, 11.5 Change-Id: Ice4223f2169595b781ed8c3a7dd5dda3f50e8a1e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79818 Tested-by:
-
Susanne Moog authored
The "show dialog" option is an option below the notification settings of each workspace and therefor only impacts the notification settings. A dialog will still appear, allowing the user to add a comment. The documentation now reflects this. Releases: main, 12.4, 11.5 Resolves: #101255 Resolves: #84629 Change-Id: I16b4d80cb454f77afe9fb0e8783920b41e3991ce Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79784 Reviewed-by:
-
Philipp Kitzberger authored
I've just found out how to hide the fields from the table and table cell dialog without hacking the source code. Releases: 11.5 Resolves: #97285 Change-Id: I46d2f528bbac22a6e29f3d37e6ba5c4c742e026e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74159 Tested-by:
Susanne Moog <look@susi.dev> Tested-by:
-
jakotadesigngroup authored
Nullable time fields with value null (not set) are reset to 0 on update. This changes the value from not set to midnight. It is not so problematic for date fields as there reset value, for the time being, is null also. But this behavior is wrong anyway. Resolves: #99847 Releases: main, 12.4, 11.5 Change-Id: I080b6bb1ad00a025967d9626632ff71b8fb2193a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78168 Reviewed-by:
-
Henrik Elsner authored
Resolves: #97710 Resolves: #97639 Releases: main, 12.4, 11.5 Change-Id: I5ff95d2d8c4d31105a95da3a18467adb0f7d3852 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79779 Tested-by:
-
Benni Mack authored
This change allows user-lang code when using TYPO3's PSR-7 implementation to also use integers and floats for header values. This change popped up in PHP 8.0 environments. Resolves: #101001 Releases: main, 12.4, 11.5 Change-Id: Ia4d3309ef5c6c4f4357eed75bb0ddad40503d132 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79781 Tested-by:
-
Andreas Fernandez authored
TYPO3 ships some default handling for encrypted email links and popup windows. Unfortunately, only links that were available on initial document load were handled, links that were added after couldn't get handled. To solve the issue, the events are not directly bound to such links anymore, but handled by an event delegation approach. Resolves: #101228 Releases: main, 12.4, 11.5 Change-Id: I8ec5d5736d9f9cfe8496cf69cf1128f1af4c0eb8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79762 Tested-by:
-
- Jul 05, 2023
-
-
Mario Lubenka authored
Until TYPO3 CMS 10.4 the ValidatorTask could be used without sending the validation report via email. The task could be used to re-crawl all links and update the reports in the module only. This behaviour is restored by sending emails only if an email address is set. Resolves: #97431 Releases: main, 12.4, 11.5 Change-Id: I63197605c272f56449f933abd08d0c05bd7a7661 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79773 Reviewed-by:
-
Benni Mack authored
Kudos to Georg Ringer for the hint. Resolves: #98600 Releases: main, 12.4, 11.5 Change-Id: I1c200b4a8835bdccc4e9dc2cf2cee423459a13c4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79747 Tested-by:
-
Oliver Bartsch authored
Resolves: #101248 Releases: main, 12.4, 11.5 Change-Id: If7954c44729897bf807bb06dd864fdfbf7f3f7eb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79745 Reviewed-by:
-
Florian Schöppe authored
The indexed_search extension uses a truncated md5 hash for building a word index. The truncation greatly increases the probability for collisions. These collisions are the root cause for the problems that are described in the related issues. The best solution would be to either use full-length hashes or no hashes at all. As this is not possible without changing the database schema and rebuilding the whole word index, this patch prevents the exceptions caused by the hash collisions. This is done by removing all words with colliding hashes before the word index is updated. Note that this patch just makes it possible to index page contents that contain hash collisions (words with colliding hashes) again. The affected words are obviously not added to the word index and though won't yield results when searched for. Resolves: #101249 Related: #84541 Related: #90977 Related: #87138 Releases: main, 12.4, 11.5 Change-Id: I5bf7d562ee42f63a5eeb99381b252018439bfaab Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79754 Tested-by:
-
Benni Mack authored
This change adds an additional guard clause check to avoid SQL errors when an invalid row is entered. Resolves: #98189 Releases: main, 12.4, 11.5 Change-Id: Iecb12b9c6ef97fb603c8b720d5e2be7433543637 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79739 Tested-by:
-
Florian Schöppe authored
Added tests for: - indexing contents and words - a basic search - metaphone search Resolves: #97732 Releases: main, 12.4 Change-Id: Id56e09f129de4bd13092f584e97eedc9fd326b5c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79737 Tested-by:
-
Thomas Hohn authored
The following classes were marked as @internal in TYPO3 11 since the feature was experimental. This should have been removed with TYPO3 12. The @internal has now been removed for: \TYPO3\CMS\Core\Authentication\Mfa\MfaProviderInterface \TYPO3\CMS\Core\Authentication\Mfa\MfaProviderPropertyManager \TYPO3\CMS\Core\Authentication\Mfa\MfaViewType Resolves: #101237 Related: #100224 Related: #93526 Releases: main, 12.4, 11.5 Change-Id: Iad9b3337a595c2ee1b9162f4cd1463d3c45881f1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79716 Tested-by:
-
Andreas Nedbal authored
Prepared nodes were not properly handled in the category element, causing the indetermination state recalculation to never trigger properly. Using the nodes from the nodes-prepared event fixes this issue. Resolves: #98689 Releases: main, 12.4, 11.5 Change-Id: I63f9618c596cdad343d4af8393120eabae3fdbd4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79689 Tested-by:
Andreas Nedbal <andy@pixelde.su> Reviewed-by:
-
- Jul 04, 2023
-
-
Stefan Bürk authored
With #89091 pages with slugs containing trailing slash have been enabled to be resolved when requested with trailing slash in the request uri and have been a logical follow-up of #86055. In between an issue with language fallback chain have been found, which allowed that a valid translated page could be resolved with the default language slug even and reported as #88715 and #96010. These issues have been solved with https://review.typo3.org/c/Packages/TYPO3.CMS/+/75101 which partly broke the original implemented behaviour for pages with trailing slash slugs requested without a trailing slash. This change now ensures pages are resolved containing a trailing slash in their "slug" like "/my-page/subpage/" if requested without the trailing slash like "https://domain.tld/my-page/subpage". Additionally, tests are added to cover this case along with other possible cases. This should detect future regressions. The docblock return annotation for `PageRouter::matchRequest()` is changed to the correct returned value, removing ignore pattern for the phpstan baseline instead of increasing the counter. Note: This change ensures that a page can be resolved in any constellation with trailing slash in record slug/not in record slug and requested with trailing slash/not requested slug. In both cases, already working and the now fixed variant are serving both potential duplicate content - if no correct cannonical url is provided. Tackling the duplicate issue should be done in a dedicated change for both cases. Used command(s): > Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #100990 Related: #96010 Related: #88715 Related: #89091 Related: #86055 Releases: main, 12.4, 11.5 Change-Id: I9f26c4500e2f812e8727b4b565570fcc579bf3e6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79705 Reviewed-by:
-
Alexander Schnitzler authored
ObjectAccess::getGettablePropertyNames() has quite the history by now. It used to be quite simple, an is_callable() check for getters/hassers and issers of objects. That didn't account for methods with mandatory method arguments which was fixed by using reflection. Because runtime reflection is slow, the usage of cached reflection (ClassSchema) had been introduced. But, during that change, symfony/property-access had also been introduces, which contradicts the idea of performance gain because: - symfony/property-access also uses uncached reflection - symfony/property-access actually calls the accessors under test As both is undesirable, the usage of symfony/property-access has been removed again. Releases: main, 12.4, 11.5 Resolves: #101176 Change-Id: I2bc796ebeaf2f1357fd3154b711910c6f553f4e4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79676 Tested-by:
-
