- Jul 26, 2022
-
-
Nikita Hovratov authored
In a scenario, where a backend user has two entry points, in which the second one intersects the first one (is a direct sub-page), pages were shown multiple times. The reason behind this was, that inside PageTreeRepository->groupAndSortPages() every page was added regardless if it was already added in a previous run. This is the case, when the same pages are found in different depth levels. E.g. 1 - Home (DB mount 1) 2 - Page 1 2 - Page 2 (DB mount 2) 3 - Subpage 1 // will be added for level 2 and 3 3 - Subpage 2 To prevent this, a guard clause was added, which checks whether the page was already added by comparing the uid value. Resolves: #96512 Resolves: #97774 Related: #96367 Releases: main, 11.5, 10.4 Change-Id: I65439011b894f05faef9cb507d905b3d7d3b709f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75223 Tested-by:core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
-
- Jul 25, 2022
-
-
Larry Garfield authored
PHPStan says all of these are unnecessary. On visual inspection, it appears to be correct. Used command: > ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #98001 Releases: main, 11.5 Change-Id: Ic18ce25997357c786b17bc5be02cfdb3617c6eef Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75286 Tested-by:
-
Christian Kuhn authored
Not setting $GLOBALS['TCA']['myTable']['ctrl']['crdate'] or $GLOBALS['TCA']['myTable']['ctrl']['cruser_id'] or $GLOBALS['TCA']['myTable']['ctrl']['tstamp'] leads to rather obvious PHP 8 "Undefined array key" warnings in DataHandler. Sanitize them. Resolves: #98018 Releases: main, 11.5 Change-Id: Ia3e94ac65feede4668fd1247cd29562f3215f328 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75284 Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
-
Christian Kuhn authored
Some of the more advanced fields of sys_template records are rather hard to understand without additional description. The patch uses the TCA "description" feature to add some explanations and hints if and when integrators should bother with them in typical scenarios. Resolves: #98017 Related: #97816 Releases: main, 11.5 Change-Id: Ifb4166dd225ec1c74339726f97ec7d7391e6996e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75282 Tested-by:
-
- Jul 24, 2022
-
-
Christian Kuhn authored
The issue has been resolved in sysbox, we don't need the patch level pin anymore. Resolves: #98015 Related: #97570 Releases: main, 11.5, 10.4 Change-Id: I1a2080ec3e8609350c9975bad8f65e69513d5f48 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75221 Tested-by:
-
Christian Kuhn authored
phpstan almost always triggers a full recalculation ignoring cache in CI. We switch phpstan CI cache config to /tmp which is not cached by CI to save some memory. Resolves: #98014 Releases: main, 11.5 Change-Id: I0bf2c72f529e9f179eb4becaac4d164cad8c318a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75276 Tested-by:
-
- Jul 23, 2022
-
-
Christian Kuhn authored
Scenario: * Create a live page that has a 'media' resource * Create a localization of that page * Go to workspace * Edit the localized page * Save * Save again -> crash "Array to string conversion" in DataHandler isSubmittedValueEqualToStoredValue() Investigating this, the issue is not in isSubmittedValueEqualToStoredValue() itself, but within DataMapProcessor, which fails to apply a workspace overlay due to #92209: The default WorkspaceRestriction is not sufficient in this case. The patch changes DataMapProcessor to apply workspace overlays in a different way for this special case. Resolves: #97989 Related: #92209 Releases: main, 11.5 Change-Id: I176aa2d2e209224b48517b872ea39b1e01f06af7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75272 Tested-by:
-
- Jul 22, 2022
-
-
Markus Friedrich authored
Adapts several content objects to use the local TypoScriptFrontendController instance of ContentObjectRenderer, to reduce usage of global objects and to avoid conflicts when different frontend environments are used, e.g. while indexing with EXT:solr. This adaption should be safe as the ContentObjectRenderer falls back to the global TypoScriptFrontendController, which was used in the content objects until now. If TypoScriptFrontendController is not available, a ContentRenderingException is thrown. Resolves: #97638 Releases: main, 11.5 Change-Id: I224829359f150739931da8b972ac3afded67a0fd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75073 Tested-by:
Markus Friedrich <markus.friedrich@dkd.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
Georg Ringer authored
Avoid notices in PageLinkBuilder Resolves: #97968 Releases: main, 11.5 Change-Id: Icc55f4b9fdd6e53333d5337d65b9971a74e956b5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75220 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
-
Larry Garfield authored
The > operator binds higher than ??, meaning these are always comparing null to 0. That is clearly not the intent. Used command: > ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #97978 Releases: main, 11.5 Change-Id: I3410e087fe7fa214c4cb43312a551d8ca3047e70 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75219 Tested-by:
-
- Jul 21, 2022
-
-
Christian Kuhn authored
Relations in 'custom value' mode may not have translation parents. This raises a PHP 8 array access issue in workspace module when for instance a page translation defines own relations for 'media': The workspace module main ajax call crashes. Sanitize this. Resolves: #97988 Releases: main, 11.5 Change-Id: Ie28d3db43a0e425a909d78355e4ecd64e1aedf8b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75218 Tested-by:
-
Christian Kuhn authored
When the TCA colon feature for ['ctrl']['type'] is used in inline parent child relations, the target record may not yet be persisted and getRecord() returns null. This triggers a PHP 8 array warning. Sanitize this access. Resolves: #97985 Releases: main, 11.5 Change-Id: If26e7aecdfc9504fbf1727813bc825de6522b9f9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75217 Tested-by:
-
Larry Garfield authored
This check likely predates types being specified, which makes it unnecessary. Used command: > ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #97979 Releases: main, 11.5 Change-Id: I78af547b9b3c1412c50cc36373973b160f3a82d4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75252 Tested-by:
-
- Jul 19, 2022
-
-
Anja Leichsenring authored
With PHP 8.2, dynamically declared properties raise a deprecation warning, leading to test fails. Resolve these. Resolves: #97969 Releases: main, 11.5 Change-Id: Idb1ad46415fcfa2c2c562863004c9f2b88cff58c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75216 Tested-by:
-
Torben Hansen authored
The initialization of the variable `$conditionMatcher` with a `null` value can safely be removed, since the following condition always overwrites the initial variable value. Resolves: #97970 Releases: main, 11.5 Change-Id: Ia7a555c9ac480f2af1e13089edffd6105f37cdc8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75215 Tested-by:
-
Anja Leichsenring authored
These raises fix the bulk of PHP 8.2 unit test fails. We need to make webmozart/assert:^1.11.0 explicit to pin it as minimum version for PHP 8.2 composer update --prefer-lowest in nightlies. We don't strictly need the phpunit raise, but pick it as casual dev update along the way. $ composer require --dev phpunit/phpunit:^9.5.21 $ composer require --dev webmozart/assert:^1.11.0 Resolves: #97967 Releases: master, 11.5 Change-Id: I5c79a8577c5eb836566cb5c00bb6b63aa1b7ea1f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75242 Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
ToGetATockenOnly authored
Releases: main, 11.5 Resolves: #97965 Change-Id: I6e03354925b4ecb9c3f72554862a01057851f48b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75237 Tested-by:
-
Sascha Egerer authored
If a page of type external link does not have a "target" defined the fallback should be used. This behavior has been changed in #96470 so the fallback is not used anymore as an empty string is also respected as a valid value but should not. Resolves: #97964 Related: #96470 Releases: main, 11.5 Change-Id: I8270aec774a342151eee47000386546e3d5ac70c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75214 Tested-by:
-
- Jul 16, 2022
-
-
Stefan Bürk authored
With #80398 support to set `tableoptions` to proper charset and collate has been added. This setting has been passed through the `doctrine/dbal` connection params and manually set to the schema config for database compare, if it has been set. The choosen key `tableoptions` however is not a valid key for `doctrine/dbal` connection params. `doctrine/dbal` ships proper PHPStan/Psalm type definitions for the param array now, and mumbles about this key. This patch transform the `tableoptions` to the proper `doctrine/dbal` `defaultTableOptions` in the `ConnectionPool`, only transporting the valid params with the connection. Places which handled the invalid `tableoptions` are changed to use `defaultTableOptions` instead. This prepares the ability to raise `doctrine/dbal` dependencies and phpstan with #97956. Full migration with configuration cleanup may be done in a dedicated patch with proper documentation of that change in v12 only. Resolves: #97961 Related: #80398 Related: #97956 Releases: main, 11.5 Change-Id: I33ddc1ae1bebb77e5d64d17e5fbc19eb0e2dc495 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75213 Tested-by:
-
Oliver Klee authored
PHPStan 1.8.1 removes some warnings. Used commands: > composer req --dev phpstan/phpstan:^1.8.1 > ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #97959 Releases: main, 11.5 Change-Id: Ifaaf37add767f98d16b3e847447a2882c3c77ee8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75209 Tested-by:
-
Christian Kuhn authored
Patch level raise of a monorepo --dev dependency as yet another raise to unblock psr/container:^2. $ composer req --dev bnf/phpstan-psr-container:^1.0.1 Change-Id: I73da5737bfbad6dfb739f5f56732d5d283e3e372 Resolves: #97958 Releases: main, 11.5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75207 Tested-by:
-
Oliver Bartsch authored
Replace wrong null fallback for "width" and "height" with empty string and also cast the values before passing to GraphicalFunctions->getImageScale() which expects them to be string. Resolves: #97952 Releases: main, 11.5 Change-Id: I80174038e54ce41dfbde5e5e35339b0a7429be4e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75212 Tested-by:
-
Benni Mack authored
When AbstractContentObject is fetching ->getPageRepository() but TSFE hasn't been fully initialized yet, the Context from TSFE should be used, and not the global one. Resolves: #97951 Releases: main, 11.5 Change-Id: I99880839f5458469e7181467de6a8fb667ef9828 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75147 Tested-by:
-
Nikita Hovratov authored
Resolves: #97953 Releases: main, 11.5 Change-Id: Ie152dfdb8c08f20a835ac9a1c8cf56f1206c4fa1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75151 Tested-by:
-
Oliver Bartsch authored
Resolves: #97767 Releases: main, 11.5 Change-Id: I1c874770ad1201e22a95d0af67e7caf4b09a8aa3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75150 Tested-by:
Nikita Hovratov <nikita.h@live.de> Reviewed-by:
-
- Jul 15, 2022
-
-
Georg Ringer authored
The provided width and height must be cast to a string to avoid notices. Resolves: #97911 Releases: main, 11.5 Change-Id: Ifa7428571026fbd0b0905729ea8ad699ab080bcb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75148 Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
-
Stephan Großberndt authored
This change makes sure hyphens are kept as part of a word instead of removing them. Removing them led to "casesensitive" instead of "case-sensitive" being lexed and added to the index, which in turn led to that occurrence not being found when searching for "case-sensitive". Releases: main, 11.5 Resolves: #93401 Resolves: #77644 Change-Id: I72f8d297384cea002e1ca6cb8e3b1973774199f2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75146 Tested-by:
-
Andreas Fernandez authored
FontAwesome will be phased out in a short while. As a precursor patch, login providers are prepared to accept a new option `iconIdentifier` which takes any icon from the Icon Registry. To ease the migration for 3rd party extension authors, this patch is aimed to be backported to v11. To make the login view itself a bit more logical, the link to reset a user's password is now moved above the available login providers. Resolves: #97950 Releases: main, 11.5 Change-Id: I96f6026c6726cf9dbc2635484bc7ad527f70b4d7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75193 Tested-by:
-
Christian Kuhn authored
Creating a version overlay of a record that has flexform sections and moving or deleting some of these sections at the same time fails in DataHandler due to a wrong uid lookup for the section command array. The patch fixes this scenario in the DataHandler flexform processing code and leaves an according explanation comment. Note this v11 backport contains the fix only and skips the functional tests that have been added with main. Resolves: #73761 Releases: main, 11.5, 10.4 Change-Id: Ib1c910c59a2ebfe9b7545cabb258f44bac2cd273 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75192 Tested-by:
-
Jochen Roth authored
Resolves: #97931 Releases: main, 11.5 Change-Id: I745bffa0c6873f6b8ff5fb15f32da4cd6538959a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75145 Tested-by:
-
- Jul 14, 2022
-
-
Oliver Klee authored
This helps static code analysis in extensions. Resolves: #97893 Releases: main, 11.5 Change-Id: Ie2eee8244438cc8d4624608ce261f5418540c672 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75144 Tested-by:
-
linawolf authored
The reference "Inside TYPO3" is not available anymore since TYPO3 8.7. The sentences are quite useless anyway. Releases: main, 11.5, 10.4 Resolves: #97913 Change-Id: I2d496726db8b22de667d230a99f7d17341fd309d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75143 Tested-by:
-
Oliver Bartsch authored
In case GU::createVersionNumberedFilename() receives a file with an absolute path, no back path should be resolved since the resolved path will always be invalid, which led to no version number got added to the filename anymore. This is now fixed by checking for the path being absolute. Resolves: #97939 Releases: main, 11.5, 10.4 Change-Id: I5bb0150fa27b8c9c1af2aa99bd8baacd55889245 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75141 Tested-by:
-
Nikita Hovratov authored
Resolves: #97938 Releases: main, 11.5 Change-Id: I711a541a9d38f7cd9ea2b1828a5353a8d1f7e0e3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75140 Tested-by:
-
Nicole Cordes authored
If a record with associated inline records gets copied, the DataHandler always handles the record creation as new versions. This raises some warning when the corresponding table doesn't support workspaces. This patch prevents warnings when a corresponding irre-table cannot create any new version of a record. Resolves: #97712 Releases: main, 11.5 Change-Id: Iadcdf693f82d021eca5af1350855803ba433c37b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75139 Tested-by:
-
- Jul 13, 2022
-
-
Stefan Bürk authored
Docblock annotations with more then one space between a wildcard character `*` and the annotation start character `@` was not found. Additionally, annotation identifiers did not regonize hyphens as valid identifier character, thus cutting of e.g. PHPStan annotations. This patch now properly finds annotions with multi-space separations and annotation identifiers containing hyphens. Additionally, two phpstan specific annotations are allowed. > https://phpstan.org/writing-php-code/phpdoc-types#local-type-aliases Summarized contained tasks: > find multi-space separated annotations e.g. `* @<AnnotationIdentifier>` > properly extract full annotation identifier containing hyphens e.g. `* @annoation-identifier-with-hyphen` > add `@phpstan-type` and `@phpstan-import-type` as allowed annotation, but only on class level, and not on class-property or class-method level Resolves: #97917 Resolves: #97918 Resolves: #97919 Releases: main, 11.5, 10.4 Change-Id: Iab69ffd87d407088f1237168e19b67a8dc846c8f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75137 Tested-by:
-
Andreas Fernandez authored
The NoopPasswordHash fixture is currently used in MFA provider tests only. To declutter the Tests/ directory, the fixture directory is now moved to core/Tests/Unit/Authentication/Mfa/Provider/. Resolves: #97920 Releases: main, 11.5 Change-Id: I86544bf897a26a2565278e2432831adde7154be8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75136 Tested-by:
-
- Jul 12, 2022
-
-
Andreas Fernandez authored
With the removal of datatables in #86343 the search terms used to filter tables were not stored anymore, leading to unfiltered tables after requesting pages with such again. This is found to be annoying in the extension manager when many extensions with the same prefix need to get managed. The search terms are now stored in the browser session and the local extension list is filtered again when visiting the extension manager. Resolves: #93628 Related: #86343 Releases: main, 11.5 Change-Id: Ib99e1fbf0ad420826164f8fed019c5235f8c43d5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75155 Tested-by:
-
Shehfinaz Kadavil authored
The existing condition checks if opcache_invalidate and opcache_reset are disabled, the new condition also checks if the function opcache_invalidate exists. Resolves: #97826 Releases: main, 11.5 Change-Id: Ibb201946b358a592f3c5b264646d100867e5e385 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75135 Tested-by:
-
Daniel authored
Like the surrounding $conf['max'], this array index access should also be secured. Releases: main, 11.5 Resolves: #97908 Change-Id: I36ad5cf3d9eac5655e8721c8913bed43ab26377f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75134 Tested-by:
-
