- Apr 05, 2018
-
-
Georg Ringer authored
Allow also tables with the setting 'adminOnly' to be removed with the scheduler task of EXT:recycler. Resolves: #84604 Releases: master, 8.7 Change-Id: I41010359bbc3aa55f88e4bb184e9effe35884a76 Reviewed-on: https://review.typo3.org/56564 Reviewed-by:
Guido Schmechel <littlegee@web.de> Tested-by:
Mathias Brodala <mbrodala@pagemachine.de> Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Stefan Neufeind <typo3.neufeind@speedpartner.de> Tested-by:
-
- Mar 21, 2018
-
-
Georg Ringer authored
In order to show all tables in the recycler record selection even though the label is the same, the table name must be used as part of the identifier. Resolves: #84505 Releases: master, 8.7 Change-Id: I952a94182fde1e052071bb45d065910f4cd73086 Reviewed-on: https://review.typo3.org/56403 Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
-
- Mar 20, 2018
-
-
Georg Ringer authored
Simplify the recycler module by reducing the overhead of extbase. Resolves: #84477 Releases: master Change-Id: I79a74686a54aa0f5fcee06c39e046f9e35fee9d1 Reviewed-on: https://review.typo3.org/56363 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
- Mar 06, 2018
-
-
Łukasz Uznański authored
Add and handle button to select all records from all pages in recycler. Right now, there is pagination, which means that you can select 50 records max. Resolves: #81310 Releases: master Change-Id: Icfc0c93e5cff5cd9573a6a39b615ce0c6e1d273c Reviewed-on: https://review.typo3.org/54849 Tested-by:
Tobi Kretschmann <tobi@tobishome.de> Tested-by:
Joerg Boesche <typo3@joergboesche.de> Tested-by:
Steffen Frese <steffenf14@gmail.com> Reviewed-by:
Jigal van Hemert <jigal.van.hemert@typo3.org> Tested-by:
-
- Mar 01, 2018
-
-
Benjamin Franzke authored
Methods that do not use $this but mainly act as utility may be used statically. The previous non-static chainable behaviour is preserved by returning static::$instance. (Invoking a static method non statically does not trigger E_NOTICE or alike.) The motivation for this change is to deprecate the Bootstrap instanciated usage at some (later) point in order to reduce global state. The following methods are affected: * initializeLanguageObject * initializeBackendAuthentication * initializeBackendUser * initializeBackendRouter * loadExtTables * loadBaseTca * loadTypo3LoadedExtAndExtLocalconf * unsetReservedGlobalVariables * startOutputBuffering * disableCoreCache Releases: master Resolves: #83952 Change-Id: I59d3027c5d10326d7bab2ae02e6ff0eb836f23e4 Reviewed-on: https://review.typo3.org/55775 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Frank Naegler <frank.naegler@typo3.org> Tested-by:
-
- Feb 28, 2018
-
-
Benni Mack authored
The unused BE_USER method setWorkspacePreview() updates a DB field called "workspace_preview_id" which just does not exist at all. It would lead to an SQL error if called. However, since this method is never called, nor evaluated since TYPO3 6.2, all functionality should be removed. Previewing a workspace is handled via `be_users.workspace_id` anyway. Resolves: #84021 Releases: master Change-Id: I706e893aef1faaccf6e43f0e66ac28bff79190d8 Reviewed-on: https://review.typo3.org/55871 Reviewed-by:
-
- Feb 20, 2018
-
-
Andreas Fernandez authored
This patch refactors how the recycler queries records in deep page structures. Instead of resolving each level of the page tree on demand and executing the complex logic of creating query builders and paging all over again, a list of page ids is generated once and stored in the Caching Framework for the current request. This list is then used in an multiple `IN()` statements (depending on the DBMS engine used). Also, some wrong type hints and a wrong language file reference are fixed. Resolves: #83702 Releases: master, 8.7 Change-Id: Ie3314b5a9209fb5585f95a70c16b35639951c197 Reviewed-on: https://review.typo3.org/55472 Reviewed-by:
Mathias Schreiber <mathias.schreiber@typo3.com> Tested-by:
-
- Feb 16, 2018
-
-
Christian Kuhn authored
To further support the PSR-7 / PSR-15 and removal of GeneralUtility::_GP() and friends efforts, all controllers no longer use the second 'ResponseInterface $response' argument given by dispatchers: Dispatchers should not assume which type of response a controller returns, there is no point in preparing this object. Instead, controllers now always create one of HtmlResponse, JsonResponse or RedirectResponse on their own and return these objects. Changes overview: * Always use "new" to instantiate a response, PSR-15 middlewares allow fiddling with the object if needed, xclassing these classes is never needed, we instead can rely on proper API usage. * All controller actions drop the second $response argument and add ResponseInterface return type hint. * Some controllers action also drop first $request argument, but only if the action does not need access to ServerParams at all. Those controllers that access _GP or _POST or similar currently, keep $request for now - they have to be refactored later anyway and then need $request. Change-Id: Icce283b3c19be14ef1adeec761cfd63c90ab24c5 Resolves: #83939 Releases: master Reviewed-on: https://review.typo3.org/55754 Tested-by:
Benjamin Kott <benjamin.kott@outlook.com> Tested-by:
-
- Feb 10, 2018
-
-
Andreas Fernandez authored
Resolves: #83839 Releases: master Change-Id: I1e72f959a7ec91c3834fc04ddf175c5c8cb441f2 Reviewed-on: https://review.typo3.org/55656 Tested-by:
-
Andreas Fernandez authored
The UC of a backend user is now updated only once per request, if there are actual changes. Resolves: #83839 Releases: master, 8.7 Change-Id: I859f8b2cc94b6254251ecf639222201cbf57f1ad Reviewed-on: https://review.typo3.org/55641 Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
-
- Feb 05, 2018
-
-
Frank Naegler authored
This is the first step for introduce CGL for JavaScript files. The settings of the .editorconfig file is now applied to all JavaScript files. This will prevent merge conflicts for the next patches. Resolves: #83752 Releases: master, 8.7 Change-Id: Ie84691e7f7f3a3974f3c62133895a62377b22f67 Reviewed-on: https://review.typo3.org/55521 Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
-
- Jan 30, 2018
-
-
Oliver Hader authored
Change-Id: I221d472b3bd9ac035221cb804601740cf77847b0 Reviewed-on: https://review.typo3.org/55505 Tested-by:
-
Oliver Hader authored
Change-Id: I8ebeca67eb5524682846a2fb7d55ee8bbde1a318 Reviewed-on: https://review.typo3.org/55504 Reviewed-by:
-
- Jan 18, 2018
-
-
Oliver Hader authored
Composer license definition GPL-2.0+ has been deprecated and has to be replaced with GPL-2.0-or-later. Resolves: #83607 Releases: master, 8.7, 7.6, 6.2 Change-Id: I6113bc3a90cb6a56830b930522dde2eaacd5025e Reviewed-on: https://review.typo3.org/55404 Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Riccardo De Contardi <erredeco@gmail.com> Reviewed-by:
-
- Jan 03, 2018
-
-
Andreas Fernandez authored
Resolves: #83453 Releases: master, 8.7, 7.6 Change-Id: I40654f5c230e0e91b3b479dd1c07eb087e639051 Reviewed-on: https://review.typo3.org/55247 Reviewed-by:
-
- Dec 27, 2017
-
-
Benni Mack authored
Some PHP classes still contain unused use statements. They have been removed. Thanks to @cd on his initial patch https://review.typo3.org/52014/ Resolves: 83432 Releases: master Change-Id: I9020f505a826c40fcf11f75f87245293e7c6154f Reviewed-on: https://review.typo3.org/55217 Reviewed-by:
-
- Dec 19, 2017
-
-
Benni Mack authored
Instead of integers, the permission constants should be used throughout the TYPO3 Core. Resolves: #83383 Releases: master Change-Id: I00c10f97fc800d9533866c98284bbd22cd1bb575 Reviewed-on: https://review.typo3.org/55156 Tested-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
- Dec 13, 2017
-
-
Helmut Hummel authored
To be able to install subtree split packages in dev-master the package dependencies between them need to allow exactly that. Releases: master Resolves: #83309 Change-Id: If2b8ea86958a425a6a047207bc064a41698215a4 Reviewed-on: https://review.typo3.org/55062 Reviewed-by:
Nicole Cordes <typo3@cordes.co> Tested-by:
Helmut Hummel <typo3@helhum.io> Tested-by:
-
- Dec 12, 2017
-
-
Benni Mack authored
Releases: master Change-Id: Ia7f55a6f40ec6b80939a78b13aa3fafc6c11132a Reviewed-on: https://review.typo3.org/55055 Tested-by:
-
Benni Mack authored
Change-Id: Iafe266ef8904526c9822576bfbab135d27b6ce27 Reviewed-on: https://review.typo3.org/55054 Reviewed-by:
-
Patrik Karisch authored
It's better to fix the current minor release in the branch version too, so depending projects can use the dev version of this specific minor release and will not have any headaches when 9.0 gets released. Resolves: #77984 Releases: master Change-Id: I36def811213dd99a3bf938af0459026d6233f645 Reviewed-on: https://review.typo3.org/49966 Tested-by:
Susanne Moog <susanne.moog@typo3.org> Tested-by:
-
Susanne Moog authored
Change-Id: I36167b0a8b61532adbafea93c88c93097ea52d73 Resolves: #83297 Releases: master, 8.7, 7.6 Reviewed-on: https://review.typo3.org/55042 Tested-by:
-
Benjamin Kluge authored
The recycler checkbox "Recover content and subpages recursively" has no functionality. Resolves: #81214 Releases: master Change-Id: I45129dd0ff91fc339f520e8e5d9a65ece4a701a8 Reviewed-on: https://review.typo3.org/55027 Tested-by:
-
- Dec 11, 2017
-
-
Benni Mack authored
All system extensions should have a dependency on "typo3/cms-core" with a fixed version set to "9.0.0". Additionally, EXT:core ("typo3/cms-core") needs to have all dependencies of the root composer.json in order to work as standalone composer package. Releases: master Resolves: #83270 Change-Id: Iaf0e925b46548914dcd0ffff49aedf5fc89107b6 Reviewed-on: https://review.typo3.org/55000 Tested-by:
-
- Dec 09, 2017
-
-
Claus Due authored
Instead of annotating and type-hinting specific cache frontend implementations, TYPO3 should program to the FrontendInterface instead. This patch corrects that. Change-Id: Ibc8d31cf78459e700ab9fe3448a53cbe83bccc61 Resolves: #81461 References: #81432 Releases: master Reviewed-on: https://review.typo3.org/53116 Tested-by:
-
Benni Mack authored
The new JsonResponse object should be used throughout the TYPO3 Backend in order to properly call json_encode() with the right flags automatically, making the code inside the controllers simpler. Resolves: #83267 Releases: master Change-Id: Ie03fb1414a965a61632897f0e25645a67f3225a5 Reviewed-on: https://review.typo3.org/54995 Tested-by:
-
- Nov 27, 2017
-
-
Alexander Schnitzler authored
This patch applies the phpdoc_types rule of the php-cs-fixer. See http://cs.sensiolabs.org/ -> phpdoc_types Releases: master, 8.7 Resolves: #83106 Change-Id: I958b75d85a08169a987afe9eed0baa4d86139770 Reviewed-on: https://review.typo3.org/54770 Reviewed-by:
-
- Oct 17, 2017
-
-
Benni Mack authored
TYPO3 Core does not use isAdmin() API of BackendUsers consistently, as there are some places where a direct access to $BE_USER->[admin]. Resolves: #82783 Releases: master Change-Id: I5ae42a79826a3512be8755aabb32b910f4f6c826 Reviewed-on: https://review.typo3.org/54414 Reviewed-by:
-
- Oct 16, 2017
-
-
Benni Mack authored
The goal is to minimize TYPO3_MODE usage in ext_localconf and ext_tables and provide a clear process for extension developers where to put what. This extension streamlines the whole usage within all system extensions, and documents the expected behaviour of all third-party extensions, which will also be included in docs.typo3.org. Resolves: #82692 Releases: master Change-Id: Id83ff0dfc6198564443f2f42e273bcd4f6f25e3e Reviewed-on: https://review.typo3.org/52533 Reviewed-by:
-
Georg Ringer authored
Add the user who deleted a record to the recycler information and also show the avatar of the user. Resolves: #69340 Releases: master Change-Id: Id7d86d737b2759c6746baefa4b60659b6e9527eb Reviewed-on: https://review.typo3.org/54379 Tested-by:
-
- Sep 09, 2017
-
-
Matthias Vogel authored
This patch removes the separate request handler for backend modules, which was accessed via "&M=moduleName" GET parameter. This is now migrated into the RouteDispatcher which can dispatch modules as well. Now, modules are called via the "&route" parameter like all other routes. Additionally, the requested URLs for modules were requested with the additional "moduleToken" which is now called "token". This way, special treatment for modules when dispatching is removed, however the security checks are still in place so this is kept as is. All places where URLs are generated can now still be accessed via `BackendUtility::getModuleUrl()` which can deal with routes, module names and routePaths (from the URL) to keep backwards-compatibility. Next Steps: - Migration wizard for bookmarks + Streamline bookmarks code (see todos) - Check what needs to be added in ExtensionManagementUtility - Introduce slugs in routes for BE, e.g. /file-edit/{fileId}/ and /module/page/view/{id} - Document reserved GET parameters "id", "route" and "token" - Cleanup usage of determineScriptId and getModuleUrl to use new API Resolves: #82406 Releases: master Change-Id: If11c3d5289e14bc9ea766468b8e94cce95c23c71 Reviewed-on: https://review.typo3.org/53881 Reviewed-by:Matthias Vogel <typo3@kanti.de> Tested-by:
-
- Aug 23, 2017
-
-
Wouter Wolters authored
Add 2 new rules * no_superfluous_elseif * no_useless_else Both rules only apply if the if-statement contains a return. If this is the case the obsolete else/elseif part is dropped. Resolves: #82183 Releases: master,8.7 Change-Id: I94dfa6b5b96cbc3e350bd778f1796dda1a4d955a Reviewed-on: https://review.typo3.org/53791 Tested-by:
-
- Jul 30, 2017
-
-
Helmut Hummel authored
Description, dependencies between core packages and core package versions are now in sync in ext_emconf.php and composer.json Now also added extension key information explicitly in composer.json What still should be done later is adding further dependencies to these files if required. This change was mostly automated using helhum/ext-tools with the command: typo3cms composerjson:sync 'typo3/sysext/*' Resolves: #82003 Releases: master, 8.7 Change-Id: Ife913038142e8ecc137d21d4d43e2cdf467fb0f9 Reviewed-on: https://review.typo3.org/53621 Tested-by:
Philipp Gampe <philipp.gampe@typo3.org> Reviewed-by:
-
- Jul 28, 2017
-
-
Helmut Hummel authored
Core extensions installed individually (from subtree split) must never be installed together with the typo3/cms package We can avoid this, by adding a conflict section in each composer.json Resolves: #81982 Releases: master, 8.7 Change-Id: Ia6a346227852237f58875a3e3216d3cad298f8bf Reviewed-on: https://review.typo3.org/53603 Tested-by:
Sascha Egerer <sascha@sascha-egerer.de> Reviewed-by:
-
- Jul 26, 2017
-
-
Helmut Hummel authored
To ease installation of master versions of system extensions from subtree splitted repos, we add a branch alias to all of them. Resolves: #81979 Releases: master Change-Id: Ic7f4aa4762286e4e881447d6ecdbead411e6635f Reviewed-on: https://review.typo3.org/53600 Tested-by:
-
- Jul 11, 2017
-
-
Martin Bless authored
Releases: master Resolves: #81830 Change-Id: Idc5c0713927e6e3c5ee9b7977c39ab4f8354b21f Reviewed-on: https://review.typo3.org/53429 Tested-by:
Martin Bless <martin.bless@mbless.de> Tested-by:
-
- Jul 08, 2017
-
-
Stephan Großberndt authored
Respect the number of records to fetch configured in TSconfig using mod.recycler.recordsPageLimit again. Releases: master, 8.7 Resolves: #81803 Related: #1835 Change-Id: Ic156e290d39ad38e02541bfe7fe80a16296b2f37 Reviewed-on: https://review.typo3.org/53412 Tested-by:
Andreas Fernandez <typo3@scripting-base.de> Tested-by:
-
- Jul 06, 2017
-
-
Georg Ringer authored
Unify the authors in ext_emconf files. Resolves: #81791 Releases: master Change-Id: Ia409787be0ac84c0d3738aa43dade946a6ef9044 Reviewed-on: https://review.typo3.org/53404 Tested-by:
Josef Glatz <josef.glatz@typo3.org> Tested-by:
-
- Jun 28, 2017
-
-
Christian Kuhn authored
Preparing the git split for better composer integration we end up with single repos for all extensions and single packagist packages. All extensions thus need a specific LICENSE.txt now. Change-Id: Ia77ae3e413e479ec7fa9438cbfc2abf808738111 Resolves: #81730 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/53345 Tested-by:
-
- Jun 12, 2017
-
-
DanielRuf authored
Typecasting with (int) is about 2-3 times faster than using intval(). Change-Id: Ifddcaaf9bf5c1fa77c632df10cba62c82d4614d1 Resolves: #81544 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/53183 Reviewed-by:
-
