- Jan 08, 2022
-
-
Nikita Hovratov authored
The type can already be inferred from the source code. The cleanup was run automatically with a PHPStorm plugin. Resolves: #96482 Releases: main Change-Id: I669145adc66dc898f3016de1958cf0105c988243 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72907 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benjamin Franzke <bfr@qbus.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
-
- Jan 07, 2022
-
-
Anja Leichsenring authored
The scenario provided by tables tx_irretutorial_mnasym_* gets its own test extension and gets loaded where needed. Resolves: #96458 Releases: main, 11.5 Change-Id: I905bc6b7e33c54e343828f9569624fdd60042c2d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72899 Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
-
Guido Schmechel authored
In order to be able to influence the query of the LiveSearch, a new PSR-14 event ModifyQueryForLiveSearchEvent is added. This event can be used to e.g. adjust the query limit or to change the result order. Resolves: #93494 Releases: main Change-Id: I5990855d14e9de72adcba1449fb3f5336c004750 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68528 Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
-
Benjamin Franzke authored
User supplied strings must not be concatenated into the format parameter of sprintf() as sequences like %s, or (more likely) %20S (which is ' S' url escaped) may be contained and cause warnings because sprintf() expects additional arguments in that case. Streamline to always use the static '%s: "%s"' format instead. Releases: main, 11.5, 10.4 Resolves: #96478 Change-Id: Ic3b09c6e1e7c617e78ea405289680bd78d0aab64 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72900 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
-
Oliver Bartsch authored
Resolves: #96479 Releases: main, 11.5 Change-Id: I8f054a9dd38e8b25ac606c002f95cb673e4e280c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72902 Tested-by:
-
Jörn Wagner authored
This patch adds a check to detect self referencing redirects, thus avoiding them and instead log an error in the corresponding frontend redirect middleware. Furthermore, add a bunch of tests along the way to cover this change and the different constellations, for example not avoiding redirect with the same path but external host. Resolves: #96427 Releases: main, 11.5, 10.4 Change-Id: I554ba51b53065dd754068e379f69c2a5dffc3054 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72856 Tested-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
-
Stefan Froemken authored
Sorting query results by text columns may require a filesort on harddisk which is slow. To boost up the search results of LiveSearch we have added an ORDER BY uid DESC to always show the newest created records first. Column "uid" exists in all TCA tables and as it is PRIMARY INDEX sorting will happen in memory. Resolves: #96365 Releases: main, 11.5 Change-Id: Icbf6e8c7717a495aaee995ff09cf2cd882173e65 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72669 Tested-by:
-
Benni Mack authored
In #87992 an early return was added to have <a> tags with just an "id" or "name" attribute. This is all nice, but when used further typolink settings (such as userFunc or custom "title"), these options were never run. This change now uses typolink() natively again and removes the introduced "resolveAnchorLinK" workaround. Added tests show that additional attributes are executed and links without href are actually created (was previously untested). Resolves: #96464 Related: #87992 Releases: main, 11.5 Change-Id: I67d4090228684fc89f72bc3d6367109437040ccf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72894 Tested-by:
-
- Jan 06, 2022
-
-
Benni Mack authored
This change mainly adds tests for showing that the global TypoScript option config.ATagParams = tabindex="20" can be used and any given attributes are actually overridden if using typolink.ATagParams = tabindex="13". Resolves: #71703 Releases: main, 11.5 Change-Id: I984d66ecf7c303381e64e447a0cac731f055a567 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72896 Tested-by:
-
Benni Mack authored
When having a page of type "External URL", set to an email address, and config.spamProtectEmailAddresses = ascii set in TypoScript, the encoding now works properly. Resolves: #87787 Releases: main, 11.5 Change-Id: I15563f08a8a0007dc292f5d7e1a311e38a55db26 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72893 Tested-by:
-
Sybille Peters authored
Broken links are marked in RTE by using the attribute data-rte-error in the <a> tag, which results in a special style and lets the link be visible as broken. Previously this was not done for links to hidden pages and links to content elements. These links were however detected as broken by linkvalidator and displayed in the list of broken links. Marking them in RTE as well makes the behaviour consistent. This patch ensures the consistency between the list and the visual highlighting in RTE elements for links to hidden pages and hidden content elements. Highlighting links to hidden pages/content elements on hidden pages may be visually relaxed to a notice instead of an error in a dedicated patch as feature. One PHP8.0 array key warning is fixed along the way. Resolves: #93005 Releases: main, 11.5 Change-Id: Ib1ef4b81ab862657950a38e5ee6847dd82abb13f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67039 Tested-by:
-
Benni Mack authored
TYPO3's "makelinks" functionality parses for in-text external URLs and mailto links. This change uses Typolink under the hood now to consistently check for invalid content, and have the chance to use all hooks in typolink for such links as well. This way, typolink is used, but makelinks is executed AFTER possible resolved <a> tags avoiding double-calling parseFunc when <a> tag processing is configured. Resolves: #93012 Releases: main, 11.5 Change-Id: I574915e715793f6eccad1bdfc216e82e329179dd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72871 Tested-by:
-
Benni Mack authored
This change now always checks for the actual page ID in the default language, not of the translated page to see if the page should be excluded. Resolves: #94427 Releases: main, 11.5 Change-Id: I89c67b7955ccb69af28accbcf573576156919481 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72802 Tested-by:
-
Stefan Froemken authored
The HtmlViewHelper is extended for a couple of new arguments, used to influence the initialization of the content object. Following arguments are added: - "data" (array or object) - "current" - "currentValueKey" - "table" This allows to properly work with dynamic data in a custom parseFunc. With the provided data record ("data" argument), the individual entries can now be accessed using TS:field. With the "current" argument, TS:current can be filled individually and with the "currentValueKey" argument, a specific value from the data record can be set as new TS:current. The "table" argument is added for completeness, so that the ContentObjectRenderer can be initialized correctly. Resolves: #92749 Releases: main Change-Id: Ibecdb7530a33462dd5464524ac7aff31abb7432b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72803 Tested-by: -
Christian Kuhn authored
This changes StandaloneView and RenderingContext to accept instances of ServerRequestInterface or no Request at all - in contrast to extbase Request only. This is possible with extbase Request implementing ServerRequestInterface since v11. The patch changes a couple of ViewHelpers like the often used TranslateViewHelper: It can run without triggering extbase magic, which especially avoids the performance wise awful ConfigurationManager. Further patches will refactor backend views to leverage this. Internal method RenderingContext->getUriBuilder() is obsoleted and removed along the way. This is a powerful change since it drops the last hard dependency to extbase in fluid and allows views without extbase being involved at all. Change-Id: I3b447b6f70e9ae6f94b981478cd8c4f43a86e9d4 Resolves: #96473 Related: #94428 Releases: main Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72758 Tested-by:
-
Anja Leichsenring authored
The scenario provided by tables tx_irretutorial_mnattr_* gets its own test extension and gets loaded where needed. Resolves: #96459 Releases: main, 11.5 Change-Id: I48b08772f8c4d64f8a3ea930fc307a8d5d3f2189 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72870 Tested-by:
-
Stefan Bürk authored
Merging #22190 shortly after #96470 has introduced a invalid test case expectation, which fails now core ci execution. This patch adds a missing 'target' expectation for the test added through #22190 to match introduced expectation with #96470. Resolves: #96472 Related: #22190 Related: #96470 Releases: main, 11.5 Change-Id: Ia92c71302a8d875b2b8f5c23aac97bfa7e3bfadc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72869 Tested-by:
-
- Jan 05, 2022
-
-
Benni Mack authored
This change adds tests to a very old issue to ensure that a page with only hidden subpages is not marked as IFSUB etc. MenuProcessor is extended to set a "hasSubpages" flag when IFSUB, CURIFSUB or ACTIFSUB is set. Resolves: #22190 Releases: main, 11.5 Change-Id: Ia9b73e8ae1028eafa94ba4fa5ca0dacf2562c074 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72868 Tested-by:
-
Benni Mack authored
The database field "pages.target" allows to define a custom target attribute for links in menus of external URLs. Before this was (wrongly) built in HMENU but applied after Typolink worked. This option belongs to the actual link building when building links to external URLs where $conf[extTarget] is evaluated. In addition, HMENU tests now also evaluate "target" for regular pages as well. Resolves: #96470 Releases: main, 11.5 Change-Id: I3919b6b13666565687e8ff56dcfc867c871837e2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72866 Tested-by:
-
Benni Mack authored
The linkvalidator backend module was previously built into the Web->Info module. Now, Linkvalidator receives its own module in the "Web" area. This allows to define access permissions for editors via the module access logic, and shapes the functionality in a cleaner way. The Linkvalidator module not only reports but also allows to validate. Through this change, the module is now accessible via a dedicated speaking backend URL. This change makes the feature much more prominent and allows for further refinements such as pagination. Resolves: #96465 Releases: main Change-Id: I83a4ed3f31cfbe59d61778b0d527f5f4704a404a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72701 Reviewed-by:
-
Oliver Bartsch authored
With the introduction of the multi record selection, the workspace actions, shown above and below the records, got prepended with labels. While the mass action targets the entire workspace, the label just read "all", which is misleading because one could think the action only targets all records of the current view and then accidentally publish or even worse, discard the entire workspace. This is fixed by changing the label. Resolves: #96468 Releases: main, 11.5 Change-Id: Id2205e843656af7576f7038dddc81ae53308a185 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72863 Tested-by:
Claus-Peter Eberwein <claus-peter.eberwein@b13.com> Tested-by:
-
Stefan Bürk authored
With #96393 forward-compatible prepared statement suport has been added, which lacks support for the broadly known doctrine/dbal 'PARAM_STR_ARRAY' and 'PARAM_INT_ARRAY' types. Internal methods as alternatives were introduced as core internal methods with #92493 in the internal 'QueryHelper' class. This patch now moves these internal implementations to the 'QueryBuilder' to provide an forward-compatible public alternative, which is needed to prepare statements with 'in()' or 'notIn()' expression with array values, which can only be used as non-placeholder, which is not supported by PHP PDO implementation. Further usage of internal implementation which was introduced with #92493 are replaced with new public methods and internal methods in QueryHelper removed. Resolves: #96434 Related: #96393 Related: #92493 Releases: main, 11.5 Change-Id: I1f7f532eb82a248a28d8d7ec707d678d59a73ec0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72804 Tested-by:
-
Stefan Froemken authored
We removed the SQL query on pages (column: pid) for TYPO3 administrators, because this group of people has access to all pages anyway. Especially in large TYPO3 instances the collection of all pages UIDs took a lot of time. Resolves: #96356 Releases: main, 11.5 Change-Id: I436e15e79ce590c4228b9a9034f83497fa1db92e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72661 Tested-by:
-
Susanne Moog authored
Once a user simulated a time with the admin panel, it has not been easy to see the status of the field or to understand how to disable it. To make it easier for the user to handle a separate checkbox has been added that allows enabling or disabling the simulate time feature. Resolves: #94596 Releases: main, 11.5 Change-Id: I309475f19f64dd8324f2466082d979d0afdbd501 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72826 Tested-by:
Sybille Peters <sypets@gmx.de> Tested-by:
-
Ingo Fabbri authored
Some methods have the wrong type declaration. E.g. string instead of mixed. Add type-hints for completeness. Resolves: #96463 Releases: main, 11.5 Change-Id: I415e8fa572ecbe278aa8323fd206494d314c559f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72862 Tested-by:
-
Benni Mack authored
This change moves the method resolveShortcutPage() into PageRepository as it is now also used in determining if a page is marked as active / current. The method `resolveShortcutPage()` is much more convenient when working with $page records instead of the properties, instead of `getPageShortcut()`. This also allows MenuProcessor to have a proper "active" and "current" values set properly without any workarounds. Resolves: #85138 Resolves: #80841 Resolves: #87923 Releases: main, 11.5 Change-Id: Ic401fb42696757199c5974120f24250c467d9b75 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72860 Tested-by:
-
Stefan Bürk authored
If a page slug ends with 'index' and site has a routing configuration with a PageTypeSuffix with index and suffix '.php' as default suffix, route resolving cuts 'index.php' from the uri, ending with a slug without index in it and thus not resolving the page and displaying 404 page. The reason for this is the code fragment which strips the document root from the uri as a cleanup for some systems, and fixes an issue for calling id/type parameters with index.php (main entry point), which has been added as a bugfix in v9 with #88028. There was a first attempt to fix this page resolving issue with #94537, which has been a regression and reverted with issue #94968. To ensure everything works and regression is covered before a new patch, there has been two patches with #95096 and #95362. After the regression there has been a really deep analysis, to get all puzzle pieces together over the time, which ended in the pre-patches and finally in this patch. The stripping of the document root has been implemented to late in the resolving chain to solve #88028, thus the followup fixes interferred with the resolving concept. This patch moves this stripping from the page-resolving point some steps early to the site-resolving step, and doing the stripping only on the left site of the uri and avoiding a generall str_replace(), thus fixing past issues and the current issue in the correct place. Furthermore tests for this issue are (re)added with this patch, as they were removed with the revert. Resolves: #94905 Related: #95096 Related: #95362 Related: #94537 Related: #94968 Related: #88028 Releases: main, 11.5 Change-Id: I2e10689893047e2d8f19057dfac2fb3b5f0bdcde Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70640 Tested-by:
-
Benjamin Franzke authored
Simplify tsconfig.json by removing unneded lookup configurations for typo3/sysext/*/Resources/Public/JavaScript/ folders, as actually no files are included from there. The configuration originates back from #81416 where TypeScript sources have been stored in typo3/sysext/. It is no longer needed, now that all Sources are located in Build/Sources/TypeScript. As a slight bonus, tsconfig.json will now automatically be updated if a new extension is added in Build/Sources/TypeScript (previously a JavaScript folder in typo3/sysext/ had to be added beforehand). Executed commands: # executed to regenerate tsconfig.json grunt tsconfig # produces no changes, since config is equal to prior state grunt build Resolves: #96456 Related: #96323 Releases: main Change-Id: I8f8cc569dce89116eca2440bff1ea52db859fdd8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72853 Tested-by:
-
Ingo Fabbri authored
This patch adds missing 'CompositeExpression' as union type for QueryBuilder methods 'where()', 'andWhere()' and 'orWhere()' to match the ability of the underlaying doctrine/dbal QueryBuilder methods. Resolves: #96457 Releases: main, 11.5, 10.4 Change-Id: Ib9330ffabcdc7680bfd5bb8a991cec60889c9773 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72858 Tested-by:
-
- Jan 04, 2022
-
-
Jan Helke authored
Ensure that in a foreign language context the selected option will be translated in the finishers. Regression fix introduced with #93979. Resolves: #96455 Related: #93979 Releases: main, 11.5 Change-Id: Ie6b33f70d6d9a19232821bda77e37b6f290ea061 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72855 Tested-by:
Marc Willmann <mw@f7.de> Tested-by:
-
Anja Leichsenring authored
The scenario provided by tables tx_irretutorial_mn_sym_* gets its own test extension and gets loaded where needed. Resolves: #96445 Releases: main, 11.5 Change-Id: I55a9c3ba1a5e1d238279a641f4e5380d936c23c9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72821 Tested-by:
-
Nikita Hovratov authored
With the introduction of itemGroups, the index 3 of the select items array has been shifted one position to the right. Before that, the index 3 was used for descriptions and index 4 for an optional keyword EXPL_ALLOW or EXPL_DENY. These are used together with authMode=individual to explicitly allow or deny single items. Since descriptions now occupy the index 4, the former usage of this index needs to be shifted as well to index 5. For backwards compatibility reasons, a TCA migration is added, which will check for these special keywords and move them one index up. Resolves: #96444 Related: #91008 Releases: main, 11.5, 10.4 Change-Id: I32a96f5c6377871551ab4ee60a402a585da7eaa0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72820 Tested-by:
-
Benjamin Franzke authored
With the changes in #95854, database mounts are no longer sorted by the order they are defined in the group/user settings, but undefined by the order the database returns. DB mounts aren't sorted against each other, that means sorting values are not meaningful anyway, and results in uncontrolable orderings. Explicitly preserve the order using usort(). Also revert groupAndSortPages() to the state prior to #95854, as the forcePid parameter would now be unused. Releases: main, 11.5, 10.4 Resolves: #96359 Related: #95854 Change-Id: I64b8d90c68246cc0ac01abcbf3678aa1055189e3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72813 Tested-by:
-
Christian Kuhn authored
The busybox variant as packaged with the test images based on alpine of mktemp needs six 'X' as template in cglFixMyCommit.sh. It otherwise emits a warning executing the command: > Build/Scripts/runTests.sh -s cglGit Resolves: #96432 Releases: main, 11.5, 10.4 Change-Id: I1c1853aabe79186694161c21f5fe0341e1bd2e75 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72852 Tested-by:
-
Susanne Moog authored
The frontend preview aspect may be set from the admin panel or the frontend extension or even from a third-party extension in a middleware. The previous implementation overwrote the preview settings on every initialisation, resulting in lost preview information. Instead of overwriting the setting, this change takes the current preview value into account - if the preview was enabled by a previous instance this is kept. Additionally, the logic to set the preview flag in both frontend and admin panel has been streamlined. Resolves: #91225 Releases: main, 11.5 Change-Id: I9f642bca1928638cac5eb5c1468710f5fad28137 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72825 Tested-by:
-
Georg Ringer authored
The option "autoplay" only works if "mute" is enabled. See https://developer.chrome.com/blog/autoplay/ for reference. Resolves: #96320 Releases: main, 11.5, 10.4 Change-Id: Ic4e2de0576fe3d1619af8e35274adeb013c72b31 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72621 Tested-by:
Daniel Haupt <mail@danielhaupt.de> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
Nikita Hovratov authored
The documentation states "case" and "pidonly" are of type boolean. But in the code in_array was used to decide, whether to utilize these options. This is now fixed by checking for the array keys. Some lines above in the first if-branch, this has been already fixed. Resolves: #96454 Releases: main, 11.5 Change-Id: I04c3638620f7a91612bdc0598ff25893325bb801 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72830 Tested-by:
-
Nikita Hovratov authored
TCA eval config is not required, so it must be checked for existence. Resolves: #96453 Releases: main, 11.5 Change-Id: I95425e3febac70ac2e03478b7385edbaf0c9a601 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72829 Tested-by:
-
- Jan 03, 2022
-
-
Benjamin Franzke authored
A human-readable diff of the applied changes can be inspected on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72768/1/Build/Sources/TypeScript/backend/Resources/Public/TypeScript/FormEngine.ts https://review.typo3.org/c/Packages/TYPO3.CMS/+/72768/1/Build/Sources/TypeScript/backend/Resources/Public/TypeScript/FormEngineValidation.ts Notes: * No major refactoring to keep the diff minimal and prepare behaviour as-is * Map imports to require-style * Added default sections in switch statements * Guard parseInt and Date.parse with typeof/instanceof * Use event.eventTarget instead of this in jQuery event callbacks * Use second method parameter in jQuery.each callbacks * Add @ts-ignore and eslint-disable-next-line where TypeScript adaptions aren't possible without possibly changing behaviour Releases: main Resolves: #82586 Resolves: #82590 Resolves: #96425 Related: #96323 Change-Id: I372c78ae581e2254f150000ad6b75ff4f005916f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72768 Tested-by:
-
Christian Kuhn authored
It seems that symfony >= 5.4.0 has a bug in symfony finder that .gitignore files are no longer always found when the ->in() directive is a non-absolute path with '/../'. This triggers issues with our cgl fixer script in nightly mode. We work around that by using an absolute path instead in the configuration and will report the issue to symfony. Resolves: #96450 Related: #96171 Releases: master, 11.5 Change-Id: Ice865b92c118e26d519fbca7ae49e41fbe4d5110 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72828 Tested-by:
-
