- Jul 05, 2019
-
-
Oliver Hader authored
Extbase argument mapping and request building can be optimized by using json_encode instead of serialize which is a bit more "space-saving". Besides that information in [__referrer][arguments] is dropped which was supposed to have happened in TYPO3 v8 already. Resolves: #88682 Releases: master Change-Id: Ifbb4192803378b1c1984405bdca04c282b8f4335 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61223 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
Alexander Schnitzler <review.typo3.org@alexanderschnitzler.de> Tested-by:
Johannes Seipelt <johannes.seipelt@3m5.de> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
Benjamin Franzke authored
The tests produced a warning which didn't cause CI to abort, but the test was actually skipped: 1) TYPO3\CMS\Core\Tests\Unit\Command\SendEmailCommandTest ::executeWillFlushTheQueue Trying to configure method "flushQueue" which cannot be configured because it does not exist, has not been specified, is final, or is static Resolves: #88692 Related: #88643 Releases: master Change-Id: I3077a011e19050986585e9c788f5db03d18595d3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61233 Tested-by:Benjamin Franzke <bfr@qbus.de> Reviewed-by:
-
Benjamin Franzke authored
These were introduced with the recent extbase configuration manager hardening but are not needed, because there are no singletons triggered via makeInstance in these tests. Change-Id: Iae4d55acd8a02997dd8fc256231c39503a8cfc88 Resolves: #88693 Related: #87628 Releases: master Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61234 Tested-by:
-
Alexander Schnitzler authored
- Use strict type mode - Use type hints whereever possible Releases: master Resolves: #87628 Change-Id: I97ccf3d4ca66828efbb59b49786eb69e7de3c925 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/59624 Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Frank Naegler <frank.naegler@typo3.org> Reviewed-by:
Daniel Goerz <daniel.goerz@posteo.de> Reviewed-by:
-
Andreas Fernandez authored
The options `options.popupWindowSize` and `options.rte.popupWindowSize` used to configure popup sizes have been removed. Most of the popups are rendered as modals that don't allow configured sizes, the remaining popups have hardcoded sizes. Resolves: #88657 Releases: master Change-Id: Ide212d0669e8c4bc199263c5fe868529cbbc7930 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61195 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Björn Jacob <bjoern.jacob@tritum.de> Reviewed-by:
-
Alexander Schnitzler authored
- Use strict type mode - Use type hints whereever possible - Use type casts according to phpstan results Releases: master Resolves: #88663 Change-Id: Ic4cf7fe508f62b2a2fd4d2e809f17628c3ad347b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61201 Tested-by:
-
Alexander Schnitzler authored
- Use strict type mode - Use type hints whereever possible - Use type casts according to phpstan results Releases: master Resolves: #88603 Change-Id: I54d3a036a7acdfe75e075269c000c03b7db3401b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61109 Reviewed-by:
-
- Jul 04, 2019
-
-
Benni Mack authored
Various places (Trees, Inline Data) can be optimized by using a more "space-saving" and faster approach. By using json_encode/decode instead of serializing the data, the stored information in "uc" of Backend Users will be vastly smaller when dealing with larger installations. Resolves: #88680 Releases: master Change-Id: I59e83c8c7615e9da63b04ebb4930c2b68b38ad7c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61220 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
Benni Mack authored
SwiftMailer is not in active development anymore as the author created the successor symfony/mailer and symfony/mime packages to create and send emails. This is a breaking change, as PHP mail() is not supported anymore. This is now automatically switched to "sendmail". In addition \Symfony\Mime\Email has a different signature than \Swift_Message, which will cause some trouble, however we've managed to overcome most of that functionality to stay backwards-compatible. Also, all extensions extending from SwiftMailer will fail as the package is be removed with this patch. Spooling has been reimplemented as direct transport methods (DelayedTransportInterface) instead of Symfony Messaging for the time being. Used composer commands: * composer require symfony/mailer symfony/mime * composer remove swiftmailer/swiftmailer Resolves: #88643 Releases: master Change-Id: Ic02db633392f1d0d7b7061e7b322435f892d2c04 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61152 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
-
- Jul 03, 2019
-
-
Benni Mack authored
The functionality, which was only allowed for admins, does not consider FAL restrictions. In order to be consistent with FAL, this is removed. Resolves: #88681 Releases: master Change-Id: I7a42539b5391af7d730deabffbe638a2ceed1a05 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61221 Tested-by:
-
Simon Gilli authored
__METHOD__ already includes the class name so __CLASS__ has to be removed. Resolves: #88679 Releases: master Change-Id: I9a5fb6a4622a811f18547b55b22fdde0ea4ad62c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61219 Tested-by:
-
Benni Mack authored
Some methods are not in use anymore, and also some FQCN can be shortened in order to clean up this class for further refactorings. Resolves: #88673 Releases: master Change-Id: I642caec9386945d0217984b76f586a9a24e13d14 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61214 Tested-by:
Sven Juergens <typo3@blue-side.de> Reviewed-by:
-
Andreas Fernandez authored
With the refactoring of client-side IRRE, some functions in TBE_EDITOR became obsolete. Those are removed now. Resolves: #88658 Related: #88182 Releases: master Change-Id: I3e667b70b9108befd88f1a7ee067d73cfffafeb2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61196 Tested-by:
-
- Jul 02, 2019
-
-
Jan Stockfisch authored
Rename ext:felogin's flexform fields. Add prefix `settings.` to all of them. This is for the later extbase change to easily access the flexform values via $this->settings in the extbase controllers. An update wizard is provided to migrate all existing felogin plugins which are stored in the database. Resolves: #88129 Releases: master Change-Id: I76158d8c73d5510fc537fcd5d5bbb376b156c1e7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60450 Tested-by:
-
- Jul 01, 2019
-
-
Daniel Siepmann authored
* Add examples to ViewHelpers that did not have any example yet. * Add cross references between ViewHelpers where a different ViewHelper was mentioned. * Add full stop to end if sentences. * Fix indentation within examples. * Add some syntax like code. * Fix escaping of PHP classes with namespaces by wrapping them with :php:`` text role. * Use https for urls to php.net. * Remove '/en/' path from urls to php.net. This ensures the current user language is auto detected. Not forcing anyone to keep english. Relates: #88600 Releases: master, 9.5 Change-Id: I2394890a20adba06719fa35990044057346dfb2b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61104 Tested-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Reviewed-by:
-
Georg Ringer authored
Due to an unrelated change within #76257, BasicFileUtility never accounts for proper creating a randomly unique name. Resolves: #88455 Related: #76257 Releases: master, 9.5, 8.7 Change-Id: I41fe95a9b5b68a7d29cf529f0877331197990940 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60885 Reviewed-by:
-
Markus Poerschke authored
To set multiple cookies at the same request, the "Set-Cookie" header must be sent as multi line. The default behavior, a comma separated list, will cause that only the first cookie is set. Resolves: #88482 Releases: master, 9.5 Change-Id: Ife4dfeb9e4e7c0452d8da10740450c8cbd26ac3e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60867 Tested-by:
-
Alexander Schnitzler authored
- Use strict type mode - Use type hints whereever possible Releases: master Resolves: #88606 Change-Id: I44ed34b1dc81b22b9e1f68f7523d3c1f5311f20a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61112 Tested-by:
-
Alexander Schnitzler authored
With #87623, a couple of fixture classes have been added to the Classes folder instead of the Tests folder. With this patch the fixture classes are moved to their proper location. Releases: master Resolves: #88607 Relates: #87623 Change-Id: Ib90f3c7e628270bd5bb16a7d95c1df5cf5fe8e9a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61113 Tested-by:
-
Benni Mack authored
A database querybuilder for sys_language is requested, however the database query is made on the "pages" table. Resolves: #88661 Releases: master, 9.5 Change-Id: Ibb4ed52a87321af3d1ce80cf8a25053f62349dba Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61200 Tested-by:
Achim Fritz <af@achimfritz.de> Reviewed-by:
-
Jonas Schwabe authored
ImmediateResponseException were not handled correctly during content object rendering when running in a production environment. This patch makes sure that ImmediateResponses are handled as such instead of just printing them during template rendering. Resolves: #88080 Releases: master, 9.5 Change-Id: Id211b4064b438b3df0744c7a0de90b642ed872de Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60370 Tested-by:
Jonas Schwabe <jonas.schwabe@eyeworkers.de> Tested-by:
-
Benni Mack authored
When using beginAtLevel = 1 is set, then HMENU should not include the current page at all, so this is now fixed by "getTreeList" handing in a positive page ID. Resolves: #23255 Releases: master, 9.5 Change-Id: Ie596323950c961b86e4ec80fb4ef17a0d412a3e2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60462 Tested-by:
Riccardo De Contardi <erredeco@gmail.com> Tested-by:
Daniel Gorges <daniel.gorges@b13.de> Tested-by:
-
- Jun 29, 2019
-
-
Daniel Siepmann authored
Do not use inline notion of providing a whole block of code. Relates: #88630 Releases: master, 9.5 Change-Id: I2f691cbdd4d617bf1a0ac4a82000f809f865c069 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61169 Tested-by:
-
Claus Due authored
Fixes an invalid syntax occurrence in the "PageZero.html" template from EXT:tstemplate. And fixes a logical error plus incorrect XML tag nesting in the partial template "DocHeader.html" from EXT:backend. Change-Id: Ib38fbb2d80cd8e24a2400ec7d2dbd12dee5605ec Resolves: #88422 Releases: master, 9.5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60802 Tested-by:
Jonas Eberle <flightvision@googlemail.com> Tested-by:
Guido Schmechel <guido.schmechel@brandung.de> Tested-by:
-
- Jun 28, 2019
-
-
Alexander Schnitzler authored
- Use strict type mode - Use type hints whereever possible Releases: master Resolves: #88604 Change-Id: Ie2641c04a7e97313c657152c14bcf5b15d9d6a74 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61110 Tested-by:
-
Benni Mack authored
Resolves: #88287 Releases: master Change-Id: I4e6efbd00caca8c1ed01252f1dde30f36330640e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61151 Tested-by:
-
mstaatz authored
Releases: master, 9.5 Resolves: #88591 Change-Id: I45588bfd8f1dd26debec6e06d6a3466a7458496a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61092 Reviewed-by:
-
Jonas Eberle authored
Wrap potentially long version strings to prevent a horizontal scrollbar in the modal content. Introduces CSS class "text-wrap-allowed". Resolves: #88522 Releases: master, 9.5 Change-Id: I848ecc111ec4879caf12b77f5308f5eadd403ffa Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61041 Tested-by:
-
Benni Mack authored
The special handling "nextLevel" in TypoScript templates to only load a specific sys_template on the next level (subpages and further down the rootline) but not on the current level, is removed. It is recommended to use proper inclusions and TypoScript conditions instead. This reduces complexity within the TemplateService parser, and for newcomers a very confusing option after gathering some feedback on this topic. The database field "sys_template.nextLevel" is therefore removed. Resolves: #88640 Releases: master Change-Id: I06e14d6dfbde82eb36f2ffc30b61bd9870906246 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61158 Tested-by:
Benjamin Kott <benjamin.kott@outlook.com> Reviewed-by:
-
Alexander Schnitzler authored
When the patch https://forge.typo3.org/issues/87550 changed the controller configuration of plugins and modules to use fully qualified controller class names instead of just controller aliases, the override mechanism called switchable controller actions, that can be used via typoscript and flexforms broke. This is due to the fact that switchable controller actions are usually still used with controller aliases rather than fully qualified controller class names. To fix this, method overrideSwitchableControllerActions of class \TYPO3\CMS\Extbase\Configuration\AbstractConfigurationManager has been adjusted to convert controller aliases to FQCN's before overriding the controller configuration. Releases: master Resolves: #88513 Relates: #87550 Change-Id: Ie2d1eb4b64d03d4e17d08a85aa7f8e548bff92bb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60906 Tested-by:
-
Andreas Fernandez authored
Since FormEngine doesn't use split buttons anymore with TYPO3 v9, the JavaScript module `TYPO3/CMS/Backend/SplitButtons` has been replaced with `TYPO3/CMS/Backend/DocumentSaveActions`. The old module is still in place, but usage will trigger a deprecation warning in the browser's console. Resolves: #88651 Releases: master Change-Id: If180f080b956804d49ca928afe4d86d07d1939bb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61164 Tested-by:
-
Andreas Fernandez authored
Resolves: #88523 Releases: master Change-Id: I26404c120702bac669b3ad3aaf9280a76eb8f0e2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60899 Tested-by:
-
Alexander Schnitzler authored
With the introduction of symfony/property-info, the class \Symfony\Component\PropertyInfo\Extractor\PhpDocExtractor has been used to extract property types from the php doc. Unfortunately said extractor class doesn't cache the so called context object, which is created repeatedly for each property of each class. The context object is used to determine non FQCN's and its creation comes at very high costs. To fix this issue, a custom PhpDocExtractor class has been created which acts just like the original one, but which caches the context objects. Releases: master Fixes: #88033 Change-Id: I54bec5b8adadeb6bde107547cbd115fa8be97526 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61076 Tested-by:
-
Richard Haeser authored
This option will make it possible to select a type of Twitter Card that should be used when your page is shared on Twitter. Resolves: #88648 Releases: master Change-Id: I9b487cf51ae6380fe771e1bcbbfd196d8b952f0f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61163 Tested-by:
Riny van Tiggelen <info@online-gamer.nl> Tested-by:
Richard Haeser <richard@maxserv.com> Reviewed-by:
-
Benni Mack authored
The current Authentication Service API looks like this: AbstractService -> AbstractAuthenticationService -> AuthenticationService Most of the functionality of AbstractService is not used and leads to a confusing PHP inheritance structure, where most functionality is not needed actually. Since there are no proper contracts APIs for neither makeInstanceService / Service API nor Authentication, the first step is to decouple the logic of both areas and allow Authentication to continue without a strong dependency on AbstractService. This is a pre-patch to decouple Authentication logic from Service logic. Resolves: #88646 Releases: master Change-Id: I525f7510d06747fcb1e204c63cf7cbc3296a54a2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61125 Tested-by:
-
Benni Mack authored
Since Versioning is completely handled via the Context API and set within PageRepository directly since TYPO3 v9, using the fourth parameter would result in an invalid scenario. Instead PageRepository->where_hid_del in a live scenario now always contains (pid!=-1) which filters out all non-versioned records. This is a breaking change to avoid confusion, however in regular scenarios this does not affect the system, as PageRepository->versionOL() filters out these cases in live workspace anyways. Resolves: #88574 Releases: master Change-Id: I538c04997cb67e30c58a4dfa515acd751f868e9c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61073 Tested-by:
-
Benni Mack authored
Since bugfix #87831 it is possible to also add base variants for specific languages, however this was not documented. See https://review.typo3.org/c/Packages/TYPO3.CMS/+/59840 for the related change. Related: #87831 Resolves: #88647 Releases: master, 9.5 Change-Id: I9c170fde6a02f98843eddc3388ced90bb1997849 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61162 Tested-by:
-
mstaatz authored
Releases: master,9.5 Resolves: #88589 Change-Id: If71c06dd3033e7d73abc2baf3cf3b786cd45e331 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61091 Tested-by:
-
Benni Mack authored
The database field "static_lang_isocode" in the DB table "sys_language" is configured via static_info_tables, however due to legacy reasons, this was added in TYPO3 Core, as some references were put there. It is now possible to remove any references to this field, and have the third-party extension deal with it. Resolves: #88583 Releases: master Change-Id: I5c366c84d21e0d291ec32d44c0b2c2e1064f669d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60887 Tested-by:
-
Benni Mack authored
Due to the introduction of Site Handling, the public property `$TSFE->sys_language_isocode` is not necessary anymore, as this value is used outside of TSFE fully, and not needed as public property to hold the state. It is marked as deprecated. Resolves: #88559 Releases: master Change-Id: If02eb5b342fec4f83a9585dbc29fc13c8adda88e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61002 Tested-by:
-
