[BUGFIX] Improve performance with symfony/property-info
With the introduction of symfony/property-info, the class \Symfony\Component\PropertyInfo\Extractor\PhpDocExtractor has been used to extract property types from the php doc. Unfortunately said extractor class doesn't cache the so called context object, which is created repeatedly for each property of each class. The context object is used to determine non FQCN's and its creation comes at very high costs. To fix this issue, a custom PhpDocExtractor class has been created which acts just like the original one, but which caches the context objects. Releases: master Fixes: #88033 Change-Id: I54bec5b8adadeb6bde107547cbd115fa8be97526 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61076 Tested-by:TYPO3com <noreply@typo3.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de>
Showing
- typo3/sysext/extbase/Classes/Reflection/ClassSchema.php 3 additions, 6 deletionstypo3/sysext/extbase/Classes/Reflection/ClassSchema.php
- typo3/sysext/extbase/Classes/Reflection/PropertyInfo/Extractor/PhpDocPropertyTypeExtractor.php 121 additions, 0 deletions...on/PropertyInfo/Extractor/PhpDocPropertyTypeExtractor.php
- typo3/sysext/extbase/Tests/Unit/Reflection/PropertyInfo/Extractor/PhpDocPropertyTypeExtractorTest.php 264 additions, 0 deletions...ropertyInfo/Extractor/PhpDocPropertyTypeExtractorTest.php
Please register or sign in to comment