Skip to content
Snippets Groups Projects
  1. Mar 25, 2011
  2. Mar 23, 2011
  3. Mar 22, 2011
  4. Mar 21, 2011
  5. Mar 19, 2011
    • Marco Huber's avatar
      [BUGFIX] TCA type="select", renderMode="tree", maxitems=1 doesn't work · 290529a7
      Marco Huber authored
      Description
      Problem:
      I want to use the new TCA tree, but when I configure 1 as maxitems I
      can't select a tree node.
      
      This happens, because this.countSelectedNodes in
      t3lib\js\extjs\tree\tree.js is 1 even when I create a new record.
      And this.countSelectedNodes is 1 because $valueArray in
      t3lib\tceforms\class.t3lib_tceforms_tree.php in the function
      renderField always has at least one entry.
      
      $valueArray is created by exploding $PA['itemFormElValue']. In fresh
      records $PA['itemFormElValue'] is 0 and not NULL (or not set) and
      has no other effects. But $valueArray has an entry and that's why
      count($valueArray) is 1 and then this.countSelectedNodes is also 1.
      
      To reproduce this issue you can use this TCA (Thanks to Steffen:
      http://lists.typo3.org/pipermail/typo3-team-core/2010-November/044931.html):
      $GLOBALS['TCA']['pages']['columns']['fe_group']['config']
      ['renderMode'] = 'tree';
      $GLOBALS['TCA']['pages']['columns']['fe_group']['config']['maxitems'] = 1;
      $GLOBALS['TCA']['pages']['columns']['fe_group']['config']['treeConfig']
      = array(
           'parentField' => 'subgroup',
           'appearance' => array(
               'expandAll' => TRUE,
               'showHeader' => TRUE,
           )
      );
      
      Solution:
      To fix this issue $PA['itemFormElValue'] should be only exploded if it's
      not 0. Like I wrote before, this is done in
      t3lib\tceforms\class.t3lib_tceforms_tree.php and fixed in the appended
      patch.
      
      Fixing this issue causes a little follow up in t3lib\js\extjs\tree\tree.js.
      This is also fixed in the patch.
      
      Change-Id: I5d23ea1d63b1107925e265392f4d13f4db3d1063
      Resolves: #M17976
      Reviewed-on: http://review.typo3.org/1188
      
      
      Reviewed-by: default avatarMoritz <moemos@gmail.com>
      Tested-by: default avatarMoritz <moemos@gmail.com>
      Reviewed-by: default avatarSteffen Ritter <info@rs-websystems.de>
      Tested-by: default avatarSteffen Ritter <info@rs-websystems.de>
      290529a7
  6. Mar 16, 2011
  7. Mar 12, 2011
  8. Mar 11, 2011
  9. Mar 10, 2011
  10. Mar 09, 2011
  11. Mar 08, 2011
  12. Mar 07, 2011
  13. Mar 06, 2011
  14. Mar 05, 2011
  15. Mar 04, 2011