Skip to content
Snippets Groups Projects
  1. Nov 29, 2011
  2. Nov 28, 2011
    • Oliver Hader's avatar
      [BUGFIX] Invalid query part on menu rendering · 4b6e987a
      Oliver Hader authored
      Each page can have a target defined, which can also be a
      typeNum that gets added to the generated URL. Now if RealURL
      is used, the "&type=" part will be just added to the final
      URL which looks like "page.html&type=1". A question mark
      is missing here to get a valid query part.
      
      Change-Id: I7c8c95db7eeb80709f5a9628d56be431ce1bdd76
      Fixes: #31622
      Releases: 4.7, 4.6, 4.5, 4.4
      Reviewed-on: http://review.typo3.org/6565
      Reviewed-by: Philipp Gampe
      Tested-by: Philipp Gampe
      Reviewed-by: Stefan Neufeind
      Reviewed-by: Simon Schaufelberger
      Reviewed-by: Steffen Ritter
      Tested-by: Steffen Ritter
      4b6e987a
    • Markus Klein's avatar
      [!!!][TASK][CONF] Remove deprecated code for 4.7 · 97a6f07f
      Markus Klein authored
      Removes all deprecated code marked for deletion in 4.7.
      
      Change-Id: Ice9c95b62d08cc6e6f3c0854f9cf12837f8df7aa
      Resolves: #32108
      Releases: 4.7
      Reviewed-on: http://review.typo3.org/6943
      Reviewed-by: Steffen Ritter
      Tested-by: Steffen Ritter
      97a6f07f
    • Lorenz Ulrich's avatar
      [FEATURE] Make filelinks icons configurable · 6b07fcc5
      Lorenz Ulrich authored
      The changeset introduces new Typoscript properties for setting the path
      to the filetype icons, the extension of the filetype icons and
      the width and height attribute of the img tag when using
      the Filelinks/"uploads" cObject.
      
      If no special configuration is set, the old defaults are taken (icons
      from tslib/media/fileicons/, extension gif, width 18, height 16).
      
      New sub properties of filelink.icon:
      * path : path to icon set (default: tslib/media/fileicons/)
      * ext : extension of icons (default: gif)
      * widthAttribute : width of icons (default: 18)
      * heightAttribute : height of icons (default: 16)
      
      Change-Id: I69781a5ece9ff32ae51220e669b0c740638f5329
      Resolves: #23624
      Releases: 4.7
      Reviewed-on: http://review.typo3.org/3921
      Reviewed-by: Markus Klein
      Reviewed-by: Philipp Gampe
      Tested-by: Philipp Gampe
      Reviewed-by: Lorenz Ulrich
      Tested-by: Lorenz Ulrich
      Reviewed-by: Simon Schaufelberger
      Tested-by: Simon Schaufelberger
      Reviewed-by: Stefan Neufeind
      Reviewed-by: Steffen Ritter
      Tested-by: Steffen Ritter
      6b07fcc5
  3. Nov 25, 2011
    • Helmut Hummel's avatar
      [BUGFIX] Respect linkVars for generating the cHash · 149ae315
      Helmut Hummel authored
      When implementing #28352 the linkVars have been skipped from
      the calculation of the cHash, resulting in wrongly calculated cHash
      parameters when linkVars are in place.
      
      Add the linkVars again for creating the cHash
      
      Change-Id: I10bc5e93d59294b6ec7fd2383e094b9f134beb44
      Fixes: #32025
      Related: #28352
      Releases: 4.6, 4.7
      Reviewed-on: http://review.typo3.org/6875
      Reviewed-by: Xavier Perseguers
      Tested-by: Xavier Perseguers
      Reviewed-by: Dmitry Dulepov
      Reviewed-by: Steffen Ritter
      Tested-by: Steffen Ritter
      149ae315
    • Mario Rimann's avatar
      [BUGFIX] Log password attempt with empty password · 789b9914
      Mario Rimann authored
      Adds logging for login attempts where an empty password is
      submitted.
      
      Change-Id: I8733f388d3d919a7e7ff67fecd5704db20e78fe6
      Resolves: #18176
      Releases: 4.7, 4.6, 4.5
      Reviewed-on: http://review.typo3.org/6904
      Reviewed-by: Jigal van Hemert
      Tested-by: Jigal van Hemert
      Reviewed-by: Mario Rimann
      Reviewed-by: Steffen Ritter
      Tested-by: Steffen Ritter
      789b9914
    • Dmitry Dulepov's avatar
      [TASK] Remove a message about non-existing TypoScript error · 9b9792ce
      Dmitry Dulepov authored
      When using "< .xyz" TS constructs, TS object browser may show a
      error like "1: Line 5902: Object copied in this line
      "ACT < .NO" would leave either the value or properties untouched
      in TypoScript Version 1. Please check that this is not a problem
      for you.". The message is unclear and scary. It is shown as error
      but there is, in fact, no error.
      
      Change-Id: I51e811829cfe2d0f264861c4bb4adcdabf9d0546
      Resolves: #32012
      Releases: 4.7
      Reviewed-on: http://review.typo3.org/6866
      Reviewed-by: Xavier Perseguers
      Tested-by: Xavier Perseguers
      9b9792ce
    • Dmitry Dulepov's avatar
      [FEATURE] Add a rel="nofollow" on the "Forgot your password" link · c2179b3b
      Dmitry Dulepov authored
      There is no reason for search engines to crawl the "Forgot your
      password?" page. Add a rel="nofollow" in the felogin to advice
      search engines not to crawl the page.
      
      Change-Id: I98f9dd4ffd385bc273437200feeefc09317bfd6b
      Resolves: #22025
      Releases: 4.7
      Reviewed-on: http://review.typo3.org/6889
      Reviewed-by: Georg Ringer
      Reviewed-by: Mario Rimann
      Reviewed-by: Simon Schaufelberger
      Tested-by: Simon Schaufelberger
      Reviewed-by: Steffen Ritter
      Tested-by: Steffen Ritter
      c2179b3b
  4. Nov 23, 2011
    • Marco Bresch's avatar
      [BUGFIX][SECURITY] XSS vulnerability in BE-User Admin module · eae75337
      Marco Bresch authored
      Fix XSS at column 'workspace membership'.
      
      How to test:
      * choose a workspace title like "<b>test</b>"
      * assign a user as member to the workspace
      * select the BE-module "Admin Tools->User Admin"
      * select the checkbox "Workspace membership"
      * press update
      * take a look at column "Workspace membership"
      
      Change-Id: I29bb7d05a2740cc9c88eb67c224e942dfc9165dc
      Fixes: #32040
      Releases: 4.7, 4.6, 4.5, 4.4
      Reviewed-on: http://review.typo3.org/6878
      Reviewed-by: Oliver Klee
      Reviewed-by: Georg Ringer
      Tested-by: Georg Ringer
      eae75337
  5. Nov 22, 2011
  6. Nov 21, 2011
  7. Nov 18, 2011
    • Francois Suter's avatar
      [BUGFIX] Fatal error when exporting from root · ad18a753
      Francois Suter authored
      An uncaught exception happens when trying to export records from a
      singe table view in List mode on the page tree root. This is due to
      the tree root being handled as a normal page record.
      
      With this patch the tree root is handled as it should. Some cleanup
      (CGL) is also applied.
      
      Change-Id: Ia5c46044f5040472846f3e7fb4adbf203e5e1e6a
      Fixes: #31350
      Releases: 4.7, 4.6, 4.5
      Reviewed-on: http://review.typo3.org/6551
      Reviewed-by: Philipp Gampe
      Tested-by: Philipp Gampe
      Reviewed-by: Georg Ringer
      Reviewed-by: Steffen Ritter
      Reviewed-by: Francois Suter
      Tested-by: Francois Suter
      ad18a753
    • Bjoern Pedersen's avatar
      [BUGFIX] checkstyle/CGL errors in indexed search · 65cf0944
      Bjoern Pedersen authored
      Jenkins reports 2 checkstyle errors in indexed search,
      probably introduced by http://review.typo3.org/6657.
      
      Change-Id: I8ac5046152357111e614a3555c7a6f4236e15137
      Resolves: #31904
      Releases: 4.7
      Reviewed-on: http://review.typo3.org/6730
      Reviewed-by: Markus Klein
      Tested-by: Markus Klein
      Reviewed-by: Stefano Kowalke
      Tested-by: Stefano Kowalke
      Reviewed-by: Christian Kuhn
      Tested-by: Christian Kuhn
      65cf0944
  8. Nov 17, 2011
    • Benjamin Mack's avatar
      [FEATURE] Indexed Search: add mySQL fulltext support · 512b9c07
      Benjamin Mack authored
      Adds some minor modifications for restructuring in the pi code,
      and some hooks in order to allow for other search engines to be
      used.
      Additionally, a new extension "indexed_search_mysql" is added
      to the core that allows the mysql fulltext search with it.
      Thanks to Michael Stucki for all the work!
      
      Change-Id: I7e739baa6d35b6678d008f19737f86c3bdaa6dd5
      Resolves: #28613
      Reviewed-on: http://review.typo3.org/6657
      Reviewed-by: Steffen Ritter
      Tested-by: Steffen Ritter
      512b9c07
  9. Nov 12, 2011
    • Markus Klein's avatar
      [BUGFIX] Core calls deprecated ADMCMD_preview() · 8d94e305
      Markus Klein authored
      The Core still calls tslib_fe->ADMCMD_preview() in index_ts.php.
      Remove the whole code block, since this has been moved to Tx_Version.
      
      The corresponding function in Tx_Version_Preview is already called in
      the connectToDB hook.
      
      Change-Id: I24152ecd3183a17257eb79a58f5270d0fce3a04d
      Fixes: #31290
      Relates: #27931
      Releases: 4.7, 4.6
      Reviewed-on: http://review.typo3.org/6344
      Reviewed-by: Oliver Klee
      Reviewed-by: Simon Schaufelberger
      Tested-by: Simon Schaufelberger
      Reviewed-by: Georg Ringer
      Tested-by: Georg Ringer
      Reviewed-by: Andreas Wolf
      Tested-by: Andreas Wolf
      8d94e305
  10. Nov 11, 2011
    • Francois Suter's avatar
      [BUGFIX][!!!] Slider wizard misuses "max" property · 05ac7b98
      Francois Suter authored
      TYPO3 4.6 introduced a slider wizard for select-type and
      input-type fields. For input-type fields it is possible
      to define a minimum and maximum value for the slider.
      Unfortunately the wizard misuses the "max" TCA property
      for the maximum value, which is normally used for the
      "maxlength" attribute of the input field.
      
      The slider wizard should instead rely on the "range" property,
      which already exists and serves exactly the purpose of defining
      a minimum and maximum value for the field.
      
      Change-Id: I0cf34c78f5109ce244357471a122be0f24f1aeef
      Fixes: #31724
      Releases: 4.7, 4.6
      Reviewed-on: http://review.typo3.org/6618
      Reviewed-by: Georg Ringer
      Tested-by: Georg Ringer
      Reviewed-by: Kay Strobach
      Tested-by: Kay Strobach
      Reviewed-by: Stefan Neufeind
      Reviewed-by: Francois Suter
      Tested-by: Francois Suter
      05ac7b98
  11. Nov 07, 2011
    • Michael Stucki's avatar
      [!!!][FEATURE] Remove typo3/index.html (and more) · c860aa01
      Michael Stucki authored
      Remove typo3/index.html which does nothing else than redirecting to
      index.php.
      It uses a meta redirection, which has been deprecated by the W3C:
      http://www.w3.org/TR/WCAG10-HTML-TECHS/#meta-element
      
      If this change will break your setup, make sure to change the
      "DirectoryIndex" setting of your Apache webserver so it looks for files
      named index.php: DirectoryIndex index.php
      
      The patch will also remove other files with a similar functionality:
      - typo3/index.htm
      - typo3/index.html
      - typo3/install/index.htm
      - typo3/install/index.html
      
      It will NOT remove index.html in t3lib/ and some other places, where the
      redirect is rather used as a security feature to avoid directory
      listings on poorly configured servers...
      
      Change-Id: I0097c62213cde9cec056e4a6b864cba9f2e828f6
      Resolves: #31614
      Reviewed-on: http://review.typo3.org/6561
      Tested-by: Philipp Gampe
      Reviewed-by: Christian Kuhn
      Reviewed-by: John Galt
      Tested-by: John Galt
      Reviewed-by: Georg Ringer
      Tested-by: Georg Ringer
      c860aa01
  12. Nov 05, 2011
    • Francois Suter's avatar
      [BUGFIX] Log date picker broken · 3f21feaf
      Francois Suter authored
      The date picker in the Admin Tools > Log when selecting a user-defined
      time range is broken. Adapt it to new skinning API for the JS to act
      on it properly again.
      
      Change-Id: I8471eff878015dd2ff078921b6947a3beae8d25f
      Resolves: #31450
      Releases: 4.7, 4.6, 4.5, 4.4
      Reviewed-on: http://review.typo3.org/6560
      Reviewed-by: Francois Suter
      Tested-by: Francois Suter
      3f21feaf
    • Francois Suter's avatar
      [BUGFIX] Disambiguate labels in exclude fields list · bc9050a8
      Francois Suter authored
      When defining access lists for be_groups, all exclude fields are
      listed for selection, ordered alphabetically per table and field
      label. It may happen that some fields have the same label within
      the same table. This causes confusion.
      
      This patch adds the field's name next to its label to avoid
      confusion.
      
      Change-Id: I503c8a2e547c749a8bdcc19d70abe2d2471e6650
      Fixes: #25236
      Releases: 4.7, 4.6, 4.5
      Reviewed-on: http://review.typo3.org/6543
      Reviewed-by: Philipp Gampe
      Tested-by: Philipp Gampe
      Reviewed-by: Georg Ringer
      Tested-by: Georg Ringer
      Reviewed-by: Francois Suter
      Tested-by: Francois Suter
      bc9050a8
    • Oliver Hader's avatar
      [BUGFIX] Handling file upload fields is broken · cae3e8e7
      Oliver Hader authored
      The handling of file upload fields in the new system extension
      form was broken and not fully implemented. Fetching the
      contents, type and size of the file is missing. Besides that,
      sending these files via mail was not fully implemented.
      
      Change-Id: I9ad7aa2df1e037f1ac8d50031300af9a030a617c
      Fixes: #31085
      Releases: 4.7, 4.6
      Reviewed-on: http://review.typo3.org/6003
      Reviewed-by: Peter Beernink
      Tested-by: Peter Beernink
      Reviewed-by: Jigal van Hemert
      Tested-by: Jigal van Hemert
      cae3e8e7
  13. Nov 04, 2011
    • Simon Schaufelberger's avatar
      [BUGFIX] Error after hide/show element in list module · af755f8f
      Simon Schaufelberger authored
      Showing or hiding an element with workspace selected will result in
      Error: Could not be edited in offline workspace...
      
      Change-Id: I43ceaf2443dff7c3d666811726353f3b17b81182
      Resolves: #20598
      Releases: 4.7, 4.6, 4,5
      Reviewed-on: http://review.typo3.org/5633
      Reviewed-by: Georg Ringer
      Reviewed-by: Simon Schaufelberger
      Tested-by: Simon Schaufelberger
      Reviewed-by: Francois Suter
      Tested-by: Francois Suter
      af755f8f
  14. Nov 03, 2011
    • Markus Klein's avatar
      [BUGFIX] Options checkboxes are hidden in BE admin user form · 05884206
      Markus Klein authored
      The options field is hidden in the BE user form if the user is admin.
      This is a problem if the admin has assigned groups with db_mounts,
      as the default value for the options is to mount also the group's mounts,
      which is undesired for most instances.
      
      Change-Id: Ia18f6179c0029f6063c0a72b8e4775e6ce120bf5
      Fixes: #30492
      Releases: 4.7, 4.6, 4.5, 4.4
      Reviewed-on: http://review.typo3.org/6401
      Reviewed-by: Francois Suter
      Tested-by: Francois Suter
      Reviewed-by: Thierry Brodard
      Reviewed-by: Steffen Ritter
      Tested-by: Steffen Ritter
      05884206
    • Marcus Krause's avatar
      [BUGFIX] alt_doc.php uses deleted alternative page languages for translations · 7bc236c4
      Marcus Krause authored
      The backend script alt_doc.php even considers deleted
      pages_language_overlay records when determining in which language a
      record can be/is localized.
      
      This patch improves method documentation and applies
      t3lib_BEfunc::deleteClause() on the respective database query.
      
      Change-Id: I2f34cfb888a452136120b9e5d94cf2866b909fb1
      Fixes: #31379
      Releases: 4.3, 4.4, 4.5, 4.6, 4.7
      Reviewed-on: http://review.typo3.org/6386
      Reviewed-by: Helmut Hummel
      Tested-by: Helmut Hummel
      Reviewed-by: Markus Klein
      Tested-by: Markus Klein
      Reviewed-by: Steffen Ritter
      Tested-by: Steffen Ritter
      7bc236c4
    • Benjamin Mack's avatar
      [TASK] deprecate userAuthGroup:inList · 8ad8099e
      Benjamin Mack authored
      The class userAuthGroup has its own "inList"
      functionality that is not really needed,
      as there is an optimized version in t3lib_div
      
      Thus, this function should be deprecated and
      all occurences would be replaced with the
      according calls to t3lib_div::inList.
      
      Change-Id: Ica7566807112589c69d70f311a6ac84da280c0e2
      Resolves: #31068
      Releases: 4.7
      Reviewed-on: http://review.typo3.org/5961
      Reviewed-by: Tolleiv Nietsch
      Tested-by: Tolleiv Nietsch
      Reviewed-by: Oliver Klee
      Reviewed-by: Benjamin Mack
      Tested-by: Benjamin Mack
      Reviewed-by: Georg Ringer
      Tested-by: Georg Ringer
      8ad8099e
    • Rens's avatar
      [TASK] Add missing tslib_content_abstract::getContentObject() · 1b3ff844
      Rens authored
      Without this getter method there's no clean way to access the current
      tslib_cObj object from a custom media renderer for example.
      
      Resolves: #30994
      Releases: 4.5, 4.6
      
      Change-Id: I065f2c94c586237963e553fddc4ebbea7d199915
      Reviewed-on: http://review.typo3.org/5890
      Reviewed-by: Oliver Klee
      Reviewed-by: Thierry Brodard
      Reviewed-by: Markus Klein
      Tested-by: Markus Klein
      Reviewed-by: Georg Ringer
      Tested-by: Georg Ringer
      1b3ff844