Releases: 6.3
Change-Id: Ie6aef74f866ac9b93e752a777ce6313126d8a32f
Reviewed-on: https://review.typo3.org/30786
Reviewed-by: Christian Kuhn
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader

PHP fatal error due to the invalid call to non-existing method
ExtensionManagementService::resolveDependenciesAndInstall during
upgrading an existing extension to a newer version from TER.

Resolves: #59624
Releases: 6.2
Change-Id: I84ff3685a94625cbc94af1967ac65b61cf9f5e43
Reviewed-on: https://review.typo3.org/30777
Reviewed-by: Alexander Opitz
Tested-by: Alexander Opitz
Reviewed-by: Francois Suter
Tested-by: Francois Suter
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader

If moving an element to a different page, the page tree only
visualizes the change in the source page, but does not visualize
the target page.

The reason is that the move-pointer is used (t3ver_state=4)
instead of the move-placeholder (t3ver_state=3) in that case.

Resolves: #59114
Releases: 6.2
Change-Id: Iefa01e4c85e9fb753873d03e7638ac592c09a657
Reviewed-on: https://review.typo3.org/30473
Reviewed-by: Wouter Wolters
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader

The workspace module defines several states:
edited, moved, created, hidden, unhidden, deleted

The states "hidden" and "unhidden" are currently applied
after the action states. This change only uses the hidden
states if a record has been modified.

Resolves: #59118
Releases: 6.2
Change-Id: I95981306d61df38939a47579cb320dd93d51ce5b
Reviewed-on: https://review.typo3.org/30467
Reviewed-by: Wouter Wolters
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader

If e.g. a content element gets moved to a different page, the
workspace preview link opens the source page (which does not
contain the element anymore, because it was moved).

Since the elements are shown on the correct page in the
workspace backend module, using the target page in the preview
link for the frontend is just obvious.

Resolves: #59143
Releases: 6.2
Change-Id: Ib84e65766e825cc26a66cbda9ffa8132c3a3ec18
Reviewed-on: https://review.typo3.org/30474
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader

This reverts commit 76741dff
(https://review.typo3.org/29626)

This change is not needed any more as the fix done
for #58713 also fixes the issues targeted with this fix.

This should be reverted not only because it is not needed
any more but especially because it "abuses" the property
->newSessionID which should only be set when really
a new ID has been generated and not to force the cookie
to be set again.

Releases: 6.2
Resolves: #59614
Reverts: #57751
Related: #58713
Change-Id: I5324769b0795bcc1b1f1e385c73fd085d7b3f571
Reviewed-on: https://review.typo3.org/30753
Reviewed-by: Markus Klein
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

Field labels are not shown if opening the history of an
element in the workspace module.

Resolves: #59546
Releases: 6.2
Change-Id: I3f522957dad8e36046b508dde658496f1cec6008
Reviewed-on: https://review.typo3.org/30713
Reviewed-by: Wouter Wolters
Reviewed-by: Alexander Opitz
Tested-by: Alexander Opitz
Reviewed-by: Tymoteusz Motylewski
Tested-by: Tymoteusz Motylewski
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader

Issue #31951 introduced a breaking change in changing the order
of constructor arguments in the form PostProcessor. This could
have been avoided since new TypoScriptFactory object is and was
a singleton.

Resolves: #59549
Releases: 6.2
Change-Id: I1134d4440437e9fe03129241e63c0f0004712176
Reviewed-on: https://review.typo3.org/30714
Reviewed-by: Marc Bastian Heinrichs
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader

With this patch it is possible to configure custom layouts
for the form, confirmation, and each type of post processor.
The backward compatibility is given, because this does not override
or break already existing configurations but provides some more
options to configure specific steps of the form process independent
of each other.
Therefore it prevents from breaking the layout of the confirmation view
and the HTML mail.

Resolves: #31951
Releases: 6.2
Change-Id: I3c015b53cd6d6efbd070d16bdc2111c7d60671aa
Reviewed-on: https://review.typo3.org/28526
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Markus Klein
Reviewed-by: Dmitry Dulepov
Tested-by: Dmitry Dulepov

In the scope of enabling Extbase frontend rendering during
functional test runs, the response object contains multiple
data values for TypoScript ("default") and the called Extbase
actions. Processing them all at once just has practical reasons
to avoid additional frontend requests for each aspect.
To decouple the actual testing structure from assertions
and constraints, a new Contraint namespace has been introduced.

The irre_tutorial extension has been enriched with an accordant
frontend rendering for Extbase context to return structured JSON
data like in the current frontend tests.

This change contains Extbase TypoScript which will be activated
in a separate bugfixing change.

Resolves: #59521
Releases: 6.2
Change-Id: I42c0bf8957d9c4c1e4389049695512851b436d14
Reviewed-on: https://review.typo3.org/30687
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader

The functional frontend tests are extended with basic FAL
use-cases in the live workspaces, as well as for modifying,
publishing single records and publishing all records in a
particular workspaces scenario.

The frontend is tested by using the TypoScript FILES cObject.

Resolves: #59276
Releases: 6.2
Change-Id: I3a1e59f70015b1168e4f29458c8d6ff77c0b3dcf
Reviewed-on: https://review.typo3.org/30516
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader

During workspace move operations sometimes a warning like
this can be found:

  102: These fields are not properly updated in database:
  (t3ver_label) Probably value mismatch with fieldtype.

The reason is, that the t3ver_label field in almost every
record is limited to 30 characters in the SQL definition.
Besides that the error code "102" of the mentioned warning
is invalid and should just be "1" to be recognized by the
accordant functional tests as well.

Resolves: #59110
Releases: 6.2
Change-Id: Ia97a32dbefd1d27e33f186c19c5a6a495dcc194a
Reviewed-on: https://review.typo3.org/30466
Reviewed-by: Wouter Wolters
Reviewed-by: Krzysztof Adamczyk
Reviewed-by: Marcin Sągol
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader

Having a parent-child structure spanning three levels, only the
first and second level elements are moved to a different page.
All child elements below the second level are not changed.

The reason is, that the move-placeholder is only created for
the first level of children.

Resolves: #59111
Releases: 6.2
Change-Id: Ia044a1241b8b1e4885cabbbc44b777f847b4c9e5
Reviewed-on: https://review.typo3.org/30463
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader

Clicking the "all workspaces" tab in the workspace backend
module as regular editor does not have any action and actually
misses the accordant action parameter "fullIndex".

Resolves: #59016
Releases: 6.2
Change-Id: I29d47cb82f1bbe1ea51f2a144f24964ab7328f7f
Reviewed-on: https://review.typo3.org/30267
Reviewed-by: Wouter Wolters
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader

Testing the frontend behavior in functional tests creates
currently an own PHP sub-request to execute TypoScript in
frontent context.
Several hooks collect called cObjects and try to find the
correct nesting levels. Albeit this is working for the
current tests, it is way too complex for extending the
tests for further scenarios like for FAL and Extbase.

The hook magic is resolved and explicit render functions,
called via TypoScript, collect the data an output aggregated
JSON data in the end. Besides that the PHP sub-request
execution now re-uses the PHPUnit utilities to determine
and run the accordant executables.

Resolves: #59487
Releases: 6.2
Change-Id: Ic9eeadee5471a3e0e40d2dffb69b38dec16a0aa1
Reviewed-on: https://review.typo3.org/30515
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader

Preview links should not be shown in the backend, if pages are
deleted in a workspace. Currently both page tree context menu
and workspaces module offer a preview for deleted pages which
results in a "broken rootline" error once being clicked.

Resolves: #59142
Releases: 6.2
Change-Id: Id398ace2deb7dc6f000c7960d23f940b694d6229
Reviewed-on: https://review.typo3.org/30471
Reviewed-by: Wouter Wolters
Reviewed-by: Krzysztof Adamczyk
Tested-by: Krzysztof Adamczyk
Reviewed-by: Zbigniew Jacko
Tested-by: Zbigniew Jacko
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter

The DragUploader implementation prevents most of its JavaScript
API to be interacted with from outside the module. Especially
there is no public event allowing interaction based on ajax
responses such as "uploadComplete" or "uploadError".

This patch adds a couple of events being triggered on the $trigger
property of the DragUploader module. That's meant to be the "add"
button in DragUploader context, so it's a mandatory DOM node.

The introduced events are:
* uploadStart
* uploadError
* updateProgress
* uploadComplete

Change-Id: I983d5528247f88d319c2385e3fb032cbd701fa33
Resolves: #57454
Releases: 6.2
Reviewed-on: https://review.typo3.org/28976
Reviewed-by: Stefan Neufeind
Reviewed-by: Helmut Hummel
Tested-by: Stefan Neufeind
Reviewed-by: Wouter Wolters
Tested-by: Frans Saris
Reviewed-by: Frans Saris
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers

Set RteHtmlParser in dontHSC_rte modus to fix garbled output.

Resolves: #25188
Releases: 6.2, 6.1
Change-Id: Ib01c3f6dcf1729b1979003c207aa622cc5c9b5c3
Reviewed-on: https://review.typo3.org/30642
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers

Classes implementing the hook cObjTypeAndClass are instantiated each
time a contentObjectRender is created, even if they are not needed.

This patch introduces lazy loading.

Change-Id: Ifdae8c35fccc8d5070e8b7b30b5e275d9b26561d
Resolves: #59449
Releases: 6.2
Reviewed-on: https://review.typo3.org/30644
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Steffen Ritter
Reviewed-by: Fabien Udriot
Reviewed-by: Christian Zenker
Tested-by: Christian Zenker
Tested-by: Steffen Ritter

Uri parameters are overwritten when using both POST and GET parameters
with the addQueryStringMethod functionality of uri generation.

The problem is solved by using the method
GeneralUtility::array_merge_recursive_overrule() instead of array_merge
when merging the POST and GET parameters.

Resolves: #53450
Releases: 6.2
Change-Id: I39926ebbaa08f6810e440bad1f238aeb2af17e5b
Reviewed-on: https://review.typo3.org/25211
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Tested-by: Wolfgang Wagner
Reviewed-by: Stefan Froemken
Tested-by: Stefan Froemken
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

This patch adds a check to the SystemEnvironment checks to test
whether any method for retrieving external files is available.
This involves allow_url_fopen PHP setting and the usage of curl.
Either of these two must be available otherwise any download
(e.g. from TER) fails.

Resolves: #58316
Releases: 6.2
Change-Id: I7dd7d2d7d2ce102723af3315f4ad4342610b4147
Reviewed-on: https://review.typo3.org/30486
Reviewed-by: Stefan Neufeind
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Fabien Udriot
Reviewed-by: Marcin Sągol
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers

Add a loading mask effect, whenever the User has clicked
on one of the two buttons of the compatibility check message
in the Extension Manager.

Resolves: #59498
Releases: 6.2
Change-Id: I5aed3bb5ffc4b2f0b490ec3da608b9cf33d22d06
Reviewed-on: https://review.typo3.org/30664
Reviewed-by: Fabien Udriot
Reviewed-by: Marcin Sągol
Reviewed-by: Nicole Cordes
Tested-by: Nicole Cordes
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers

Constant categories may now be localized using a construct similar
to defining custom subcategories:

Fixes: #57369
Documentation: #57371
Releases: 6.2
Change-Id: I6bea094d98897756772a6f616c8a2f3ab5fe7844
Reviewed-on: https://review.typo3.org/28903
Reviewed-by: Wouter Wolters
Reviewed-by: Fabien Udriot
Tested-by: Fabien Udriot
Tested-by: Wouter Wolters
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers

When running the Database Analyzers "Execute" without checking at least
one checkbox you get a PHP Warning "array_merge(): Argument #2 is not
an array" because instead of returning an array with a message only the
message string was returned.

Fix this by returning the correct variable, which is of type array.

Resolves: #59504
Releases: 6.2
Change-Id: Ifd73d617a4a97f07151fe0e6c6971bcd79c9709c
Reviewed-on: https://review.typo3.org/30670
Reviewed-by: Markus Klein
Tested-by: Markus Klein

When fixing language overlay of cObject FILES, the mocking in the unit
test was not adapted.

Resolves: #58352
Resolves: #47869
Releases: 6.2
Change-Id: I8f939e31a13e437e437624dfccddf5f39526fb8b
Reviewed-on: https://review.typo3.org/30666
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

The extbase query cache is enabled by default. This patch
adds a TypoScript setting to enable or disable the cache in general
and on a plugin level.

Resolves: #57280
Releases: 6.2
Change-Id: I620a3c4d2c4e508630d97731f12cc11c617aae75
Reviewed-on: https://review.typo3.org/29763
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Wouter Wolters
Reviewed-by: Marcin Sągol
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers

Whenever installing an extension, the file located at
EXT:ext_key/Initialisation/data.t3d is detected and its content imported.
This patch adds support for EXT:ext_key/Initialisation/data.xml file as
well.

Resolves: #59154
Releases: 6.2
Change-Id: Ie5cf843ed7fff24c0cc022892d68fa86ba14a674
Reviewed-on: https://review.typo3.org/30464
Reviewed-by: Tymoteusz Motylewski
Tested-by: Tymoteusz Motylewski
Reviewed-by: Fabien Udriot
Tested-by: Fabien Udriot
Reviewed-by: Zbigniew Jacko
Tested-by: Zbigniew Jacko
Reviewed-by: Xavier Perseguers
Reviewed-by: Steffen Ritter
Tested-by: Xavier Perseguers

The array key that is used to check if a Backend user is logged in
is fixed.

Resolves: #59495
Releases: 6.2
Change-Id: Ida6609c3bde998e17a0d9e9184adb48f227507f5
Reviewed-on: https://review.typo3.org/30663
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring

The TypoScript cObject FILES does not consider localization
overlays and behavior correctly when it comes additional 
translation table (e.g. for pages).

Concerning pages_language_overlay.media, there is no default
fallback to the values of the default language. This behavior
is the same to TYPO3 4.5. If the localization shall fallback
to the default language, the "mergeIfNotBlank" property needs
to be used for the accordant field.

For having the localization handling working properly the
FILES cObject section "references" must not set the properties
"table" and "uid" - otherwise the values will just be overriden
by those TypoScript settings.

Resolves: #58352
Resolves: #47869
Releases: 6.2
Change-Id: I8e915654e5ab1ed1eafe86411930f9fbfcc225ae
Reviewed-on: https://review.typo3.org/29739
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter

This patch adds a new action to show all unresolved dependencies and
adds the possibility to bypass all system and version checks. Required
extensions are still tried to be fetched from TER.

Resolves: #54512
Releases: 6.2
Change-Id: I11cca622875d013ab6fd385d2c659477e803f6a2
Reviewed-on: https://review.typo3.org/29845
Reviewed-by: Markus Klein
Reviewed-by: Zbigniew Jacko
Tested-by: Zbigniew Jacko
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers

The placeholder PAGE_TSCONFIG_ID may be used in a foreign_table_where
TCA condition but is not available as parameter when using a wizard
to create new records. This patch fixes this issue.

Fixes: #59245
Releases: 6.2
Change-Id: I19ae9d72e14c047a08107fe6152093a4b04c27f6
Reviewed-on: https://review.typo3.org/30498
Reviewed-by: Wouter Wolters
Reviewed-by: Marcin Sągol
Reviewed-by: Fabien Udriot
Tested-by: Fabien Udriot
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers

The sorting by date fails in the Filelist module when more
than 9 files with the same date are found since the numerical
suffix used to avoid overwriting existing entries in the
sorting array is not properly padded.

Fixes: #59458
Releases: 6.2
Change-Id: I2c80a00dd1692b0987da3d461cc5a21fcea4c97d
Reviewed-on: https://review.typo3.org/30657
Reviewed-by: Francois Suter
Tested-by: Francois Suter
Reviewed-by: Fabien Udriot
Tested-by: Fabien Udriot
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers

Add a new configuration in Install Tool (['SYS']['clearCacheSystem']).
If set, the toolbar of clearing system cache is visible (only for
admin users).

Add it also for Configuration Preset. For Production it is set to FALSE,
for Development it is set to TRUE.

Resolves: #57230
Releases: 6.2
Change-Id: Id45496c6bc1e64b4454ed7ff78e8db1179387b0f
Reviewed-on: https://review.typo3.org/30656
Reviewed-by: Krzysztof Adamczyk
Tested-by: Krzysztof Adamczyk
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers

The file repository used to resolve all sys_file_references
handles enable fields manually currently, which is bad because
it forgets to handle the workspace-related where clause.

The attached patch splits the behavior into frontend and
backend context. In backend the RelationHandler is capable
of automatically resolving IRRE structures. In frontend mode
the enableFiels and version preview settings are relevant to
show correct results.

Resolves: #43916
Releases: 6.2
Change-Id: I6c19e5d7b4cd7a2134921c669b82ab90b54844de
Reviewed-on: https://review.typo3.org/29712
Tested-by: Lorenz Ulrich
Reviewed-by: Fabien Udriot
Tested-by: Fabien Udriot
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter

When calling ResourceFactory::getInstance()
->getFileObjectFromCombinedIdentifier($identifier)
with $identifier === NULL or $identifier === ''
an index entry is written for storage 0 which contains the
last path segment of PATH_site as identifier.

Guard the API in two places by throwing exceptions
when an invalid file identifier is given.

Resolves: #59295
Releases: 6.2
Change-Id: Ie2d6d811193ee21b865161984ddbac240388573b
Reviewed-on: https://review.typo3.org/30526
Reviewed-by: Fabien Udriot
Tested-by: Fabien Udriot
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter

The styling of sys_action "Create Backend User" is outdated
and should be slightly improved to enhance usability of
this module.

Releases: 6.2
Resolves: #59338
Change-Id: Ifaba21a78687589af9ba0decad8bc2b9fdc4d29d
Reviewed-on: https://review.typo3.org/30646
Reviewed-by: Fabien Udriot
Tested-by: Fabien Udriot
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers

Loading extensions TS, that provide contentRenderingTemplates, like
css_styled_content, using INCLUDE_TYPOSCRIPT was fixed in
https://review.typo3.org/#/c/21679/.

Since making TS content templates more flexible in
https://review.typo3.org/#/c/27587/ the contentRenderingTemplates wasn't
added to "defaultTypoScript_setup." and "defaultTypoScript_constants."
arrays anymore and breaks the mentioned fix.

Solution is to check the required key in contentRenderingTemplates and
add the defaultContentRendering string now.

Resolves: #59318
Releases: 6.2
Change-Id: I8a367f462f304e07bbcec99fd26818bc98148eb4
Reviewed-on: https://review.typo3.org/30544
Reviewed-by: Benjamin Mack
Reviewed-by: Krzysztof Adamczyk
Tested-by: Krzysztof Adamczyk
Reviewed-by: Tymoteusz Motylewski
Tested-by: Tymoteusz Motylewski
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter

The IRRE option useCombination enables to use bi-directional
relations with IRRE items. This enables you to re-use IRRE
items multiple times (similar as FAL is working with IRRE).

To prevent the same child record from being used multiple
times, items already used are removed from the select box.
The code removing the item was written to remove an item
from a select box, but (accidentially) also targets a hidden
item which causes the JavaScript to break so that the field
values of the child objects are not filled on expanding.

By adding an additional check, this can be prevented.
For steps to reproduce refer to #46477.

Resolves: #46477
Releases: 6.2
Change-Id: Ie7fd89f6ef887b5d45c734dea8ec6ad9ac2a8d2c
Reviewed-on: https://review.typo3.org/19337
Reviewed-by: Fabien Udriot
Tested-by: Fabien Udriot
Reviewed-by: Zbigniew Jacko
Tested-by: Zbigniew Jacko
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers

TCA manipulation code must no longer reside in ext_tables.php, but
moved to Configuration/TCA/Overrides/<tablename>.php. Leftovers
in ext_tables might disturb loading order of TCA changes.

Change-Id: Ie919a856fbd8242d19110c8db8d01ff7865c913c
Resolves: #59397
Releases: 6.2
Reviewed-on: https://review.typo3.org/30620
Reviewed-by: Krzysztof Adamczyk
Tested-by: Krzysztof Adamczyk
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter

Instead of generating and saving the public/private keys for
an RSA enabled login form on rendering the form the keys are
fetched on submit. This resolves the issue with outdated keys
and the problem that the login box on first page doesn't work
anymore when a page in a second tab is opened.

Resolves: #59041
Releases: 6.2
Change-Id: I0ad13775f029a29f6f67e302a1a63f3860e902b5
Reviewed-on: https://review.typo3.org/30364
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Zbigniew Jacko
Tested-by: Zbigniew Jacko
Reviewed-by: Steffen Ritter
Reviewed-by: Markus Klein
Tested-by: Markus Klein