- Apr 19, 2020
-
-
Oliver Hader authored
Fluid variable `previewUrl` is generated, but never used in templates. Resolves: #91120 Releases: master Change-Id: Ia5397f9ef63700fda2a84aee245ed2ba2bf8bc55 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64240 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
Guido Schmechel <guido.schmechel@brandung.de> Reviewed-by:
-
- Apr 15, 2020
-
-
Alexander Schnitzler authored
With this patch, the header comment of php files is automatically added by the php-cs-fixer, which guarantees that its format and place of occurrence remain the same in all files. Files that are copied over from other projects are excluded. Furthermore, files that are kind of inspired by other projects also get the same header comment but may have a second, additional comment explaining its origin. Used command: bin/php-cs-fixer fix --config=Build/php-cs-fixer/header-comment.php Releases: master Resolves: #91024 Change-Id: I5a040517e0fbde6e5a27d589bf2f222078326dc8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64159 Tested-by:Benni Mack <benni@typo3.org> Reviewed-by:
-
- Apr 14, 2020
-
-
Benni Mack authored
This change adds two changes 'blank_line_after_opening_tag' => true, 'single_trait_insert_per_statement' => true, to our PHP-CS Fixer configuration, adopting more rules related to PSR-12. Resolves: #91020 Releases: master Change-Id: I180b2cbceb077911bddeb42d9f131e5b32244ed2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64158 Tested-by:Josef Glatz <josefglatz@gmail.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Alexander Schnitzler <git@alexanderschnitzler.de> Tested-by:
-
- Jan 16, 2020
-
-
Benni Mack authored
The permission access module allows for AJAX calls to dynamically updating page permissions on the fly, where DataHandler is used. When using the form to do a more customizable change, plain SQL was used previously to update the pages. This circumvented the change to also update any translated pages (which DataHandler does by default). This wasn't a problem until TYPO3 v9.0, where pages_language_overlay was merged with "pages", where the permissions of translated pages should reflect the changes of the default language page. The change updates the PermissionController->updateAction to call DataHandler for the changes as well. Resolves: #89838 Resolves: #88311 Releases: master, 9.5 Change-Id: I9e56b279ddcbb43ee7bb11b330c288b12a0e7439 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62930 Tested-by:
Susanne Moog <look@susi.dev> Tested-by:
Jörg Bösche <typo3@joergboesche.de> Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Reviewed-by:
-
- Oct 07, 2019
-
-
Christian Eßl authored
Make spelling in TYPO3 great again. Resolves: #89290 Releases: master Change-Id: I520840dd0774aa5d658ce6a45811aa6282c9e461 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61845 Tested-by:
-
- Oct 01, 2018
-
-
Benni Mack authored
All specific controllers for specific Backend actions, Backend-module related modules, all hook implementations (where the core uses hooks by itself), and module-specific ViewHelpers are now marked as @internal to ensure developers what is part of the public TYPO3 Core API. within - EXT:backend (except ViewHelpers) - EXT:beuser - EXT:about - EXT:belog All @api methods have been removed. Resolves: #86505 Releases: master Change-Id: I1fd1e16f7885e81fb994999e5873a1a3a1aa6c3b Reviewed-on: https://review.typo3.org/58524 Reviewed-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
-
- Sep 02, 2018
-
-
Wouter Wolters authored
Resolves: #86084 Releases: master Change-Id: I6ebbe0756d799a3c04386c854f6e5e385eeac54f Reviewed-on: https://review.typo3.org/58124 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
-
- Aug 09, 2018
-
-
Paweł Rogowicz authored
This patch fixes a bug which occured when deleting a currently selected node. After deleting this node the first element of the tree is displayed. Releases: master Resolves: #85431 Change-Id: I64cd7c4ebd8415a2c261da3f62f8e412575b0075 Reviewed-on: https://review.typo3.org/57791 Tested-by:
Łukasz Uznański <l.uznanski@macopedia.pl> Tested-by:
Joerg Kummer <typo3@enobe.de> Tested-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Tested-by:
-
- May 29, 2018
-
-
Tymoteusz Motylewski authored
Resolves: #85107 Releases: master Change-Id: I218ae9ae3a2eb6bcd23eef2073bf8b11139d58bc Reviewed-on: https://review.typo3.org/57078 Reviewed-by:
-
- Apr 25, 2018
-
-
Wouter Wolters authored
This commit moves any language file of EXT:lang into a proper destination, which renders EXT:lang obsolete. This change requires an update of typo3/testing-framework, done with this command: composer update typo3/testing-framework Resolves: #84680 Releases: master Change-Id: I7ba59c1a10015121ed444a9c98082bad0348e03d Reviewed-on: https://review.typo3.org/56017 Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Riny van Tiggelen <info@online-gamer.nl> Reviewed-by:
Susanne Moog <susanne.moog@typo3.org> Tested-by:
-
- Nov 21, 2017
-
-
Andreas Fernandez authored
The returnUrl is not available if the access module is accessed via context menu of the page tree. The module now checks whether the returnUrl is available and renders the close button only in such case. Resolves: #83053 Releases: master, 8.7 Change-Id: I37c5c65c1505b42acf7ac734fbc7a9f53629a6a1 Reviewed-on: https://review.typo3.org/54713 Tested-by:
Riccardo De Contardi <erredeco@gmail.com> Reviewed-by:
-
- Nov 02, 2017
-
-
Markus Klein authored
With this fix the access module again returns to the correct page the user expects it to return to. Resolves: #82883 Releases: master, 8.7, 7.6 Change-Id: I76953aa1547365db6fbbea772d786e1ad9bfc184 Reviewed-on: https://review.typo3.org/54504 Reviewed-by:
-
- Sep 09, 2017
-
-
Matthias Vogel authored
This patch removes the separate request handler for backend modules, which was accessed via "&M=moduleName" GET parameter. This is now migrated into the RouteDispatcher which can dispatch modules as well. Now, modules are called via the "&route" parameter like all other routes. Additionally, the requested URLs for modules were requested with the additional "moduleToken" which is now called "token". This way, special treatment for modules when dispatching is removed, however the security checks are still in place so this is kept as is. All places where URLs are generated can now still be accessed via `BackendUtility::getModuleUrl()` which can deal with routes, module names and routePaths (from the URL) to keep backwards-compatibility. Next Steps: - Migration wizard for bookmarks + Streamline bookmarks code (see todos) - Check what needs to be added in ExtensionManagementUtility - Introduce slugs in routes for BE, e.g. /file-edit/{fileId}/ and /module/page/view/{id} - Document reserved GET parameters "id", "route" and "token" - Cleanup usage of determineScriptId and getModuleUrl to use new API Resolves: #82406 Releases: master Change-Id: If11c3d5289e14bc9ea766468b8e94cce95c23c71 Reviewed-on: https://review.typo3.org/53881 Reviewed-by:Stefan Neufeind <typo3.neufeind@speedpartner.de> Tested-by:
Matthias Vogel <typo3@kanti.de> Tested-by:
-
- Jul 15, 2017
-
-
Christian Kuhn authored
The ancient field 'hide_in_lists' is of very little use within the group administration. The documented use case of having this field set for base groups doesn't make much sense, since especially those groups are used for page ownerships and the permission module is the only backend usage which then hides groups with this field set. All in all, this field is probably extremely rarely used and only increases complexity of access rights management. For the sake of a cleaner backend, the field is dropped. Change-Id: Id41be5e563dfe16f380d36446646951507d8e5d1 Resolves: #81534 Releases: master Reviewed-on: https://review.typo3.org/53179 Tested-by:
-
- May 12, 2017
-
-
Benni Mack authored
The main $GLOBALS['LANG'] class has been moved to the core extension into the "Localization" namespace, where all other related XLF/XML factory, store and parser classes reside. This is done in order to streamline the localization of core-relevant files, since this class will also be used in frontend context. EXT:lang now contains the backend module, as well as most XLF files. Resolves: #81196 Releases: master Change-Id: I0e5d8260f5c5a28254658c68766990b4f4662a2a Reviewed-on: https://review.typo3.org/52774 Tested-by:
Jan Helke <typo3@helke.de> Tested-by:
-
- Mar 31, 2017
-
-
Marco Christian Krenn authored
The following icons which were previously used in the Install tool were all replaced by "actions-close" which acts as a synonym. * actions-document-close * actions-message-error-close Resolves: #80601 Releases: master Change-Id: I95358aa6e34237f0fa27049aadf0ae788fef2172 Reviewed-on: https://review.typo3.org/52285 Reviewed-by:
Frank Naegler <frank.naegler@typo3.org> Tested-by:
Benjamin Kott <benjamin.kott@outlook.com> Tested-by:
-
- Mar 28, 2017
-
-
Wouter Wolters authored
The TYPO3 Core currently has no guidline how to handle phpdoc comments regarding @return annoations related to "void" and "null". In practice, these annotations have no additional value if no additional documentation is given. With this change, the php-cs-fixer will remove any unnecessary linebreaks within the comments above the @return annotation, as well as remove completely empty phpdoc comments because the @return annotation is removed. Please be aware, that once PSR-5 is accepted, this coding standard within the TYPO3 Core will change again, where there are currently some further proposal details like inheritance information. Resolves: #80454 Releases: master Change-Id: Ie969d720684c0a75919fe5addd1c36ef5b12eb04 Reviewed-on: https://review.typo3.org/51686 Reviewed-by:
Nicole Cordes <typo3@cordes.co> Tested-by:
-
- Feb 17, 2017
-
-
Georg Ringer authored
If the root page is selected, the following is improved: - show the sitename instead of '[root-level]' - show the world icon for the first pages (all with pid = 0) Resolves: #79857 Releases: master Change-Id: I449a34e356ec43f8679bb9cdcd4c790fd4701004 Reviewed-on: https://review.typo3.org/51719 Tested-by:
Thomas Hohn <thomas@hohn.dk> Reviewed-by:
-
- Dec 01, 2016
-
-
Wouter Wolters authored
Move languages files from the root of ext:lang to Resources/Private/Language/ Resolves: #78647 Releases: master Change-Id: I9271442c98f2fcf705a38a639a6d503caeba1759 Reviewed-on: https://review.typo3.org/50584 Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
- Aug 30, 2016
-
-
Wouter Wolters authored
As decided during T3ACME we will use the short array syntax in master. The 7.6 branch will also be done to make backporting easier. Resolves: #77692 Releases: master,7.6 Change-Id: I37e9484b1012fc9161148257a842054c24d162ba Reviewed-on: https://review.typo3.org/49651 Reviewed-by:
-
- Jul 07, 2016
-
-
Michael Oehlhof authored
Resolves: #76917 Releases: master Change-Id: I0faa3d5dfb2c05c1b2284f20fb0e7a823300c72a Reviewed-on: https://review.typo3.org/48775 Reviewed-by:
Morton Jonuschat <m.jonuschat@mojocode.de> Tested-by:
Bamboo TYPO3com <info@typo3.com> Reviewed-by:
-
- Jun 10, 2016
-
-
Nadir Sunar authored
The wording of "1 levels" is corrected to "1 level". "Set recursively 1 levels (N pages affected)" is also corrected. "pages affected" has a singular-form as well now. Resolves: #76541 Releases: master Change-Id: Ie33a8caeb225fb259f892f6b115911dd62d675fe Reviewed-on: https://review.typo3.org/48524 Reviewed-by:
-
- Apr 14, 2016
-
-
Georg Ringer authored
To improve the usability, add tool tips to the icons. Resolves: #75616 Releases: master, 7.6 Change-Id: Iceffc8d15625aa02da55ce533463951546d8d890 Reviewed-on: https://review.typo3.org/47666 Reviewed-by:
Daniel Goerz <ervaude@gmail.com> Tested-by:
-
- Apr 07, 2016
-
-
Andreas Fernandez authored
Resolves: #75433 Releases: master Change-Id: Ic73beb093efc5c0648d2ea6e66286b0a6b439e4e Reviewed-on: https://review.typo3.org/47526 Reviewed-by:
-
- Mar 23, 2016
-
-
Andreas Fernandez authored
The save / abort buttons in the edit view of the permission controller are replaced by DocHeader buttons to ensure are more consistent UI. Change-Id: Ic035f2bd1f5063a8d0b52310b1f011078f7e6c25 Resolves: #68378 Releases: master, 7.6 Reviewed-on: https://review.typo3.org/47186 Reviewed-by:
-
- Mar 05, 2016
-
-
Andreas Bouche authored
Editing permissions in the access module has no effect on the frontend. Therefore, the view button is unnecessary here. Resolves: #68376 Releases: master Change-Id: Ic5f48320ca54e46e89c8f3b740b457cfcfbbaaae Reviewed-on: https://review.typo3.org/41718 Reviewed-by:
Bjoern Jacob <bjoern.jacob@tritum.de> Tested-by:
Andreas Bouche <andreas.bouche@flagbit.de> Tested-by:
Eugen Lang <laeu1011+gerrit@gmail.com> Tested-by:
-
- Jan 11, 2016
-
-
Daniel Goerz authored
Change-Id: I8533ad590ae30a37346f41a33fa25a7e8e15b58c Resolves: #72511 Releases: master, 7.6 Reviewed-on: https://review.typo3.org/45557 Reviewed-by:
Stefan Froemken <froemken@gmail.com> Tested-by:
Michael Oehlhof <typo3@oehlhof.de> Tested-by:
-
- Nov 29, 2015
-
-
Nicole Cordes authored
Multiple button settings are double encoded with htmlspecialchars. This patch removes the hsc within the setters as the button settings are already escaped during render method. Resolves: #71915 Releases: master Change-Id: I470b6e4ce42859d4147e21acf9e7b6334a776848 Reviewed-on: https://review.typo3.org/45014 Reviewed-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
-
- Nov 20, 2015
-
-
Wouter Wolters authored
Resolves: #71726 Releases: master Change-Id: I4a356c8da668acee555149eee9cf56ccdb4dc0ee Reviewed-on: https://review.typo3.org/44822 Reviewed-by:
Andreas Fernandez <typo3@scripting-base.de> Tested-by:
-
- Nov 08, 2015
-
-
Helmut Hummel authored
* Reverts the change that allowed HTML tags by default in flash messages * Simplifies flash message markup to be bootstrap alert style * Delegate flash message rendering completely to module template * Deprecate render method in flash message * Minor cleanups in flash message view helper and flash message class Resolves: #71249 Releases: master Change-Id: Idbb4bc31372fbc435519496168715e0bcc5cebf2 Reviewed-on: https://review.typo3.org/44592 Reviewed-by:
Philipp Gampe <philipp.gampe@typo3.org> Tested-by:
Helmut Hummel <helmut.hummel@typo3.org> Tested-by:
-
- Oct 15, 2015
-
-
Michael Oehlhof authored
Make sure we deal with the correct view class before accessing any members of it. Resolves: #70728 Releases: master Change-Id: I0cd8c2d775f7c0fd7202b314f1fc3ce3c71b58dc Reviewed-on: http://review.typo3.org/44070 Reviewed-by:
Marcus Schwemer <ms@schwemer.de> Tested-by:
-
Michael Oehlhof authored
During implementation of the ModuleTemplate API for ext:beuser, the changes for the access module were only half done. Resolves: #70724 Releases: master Change-Id: Id6557576f9e78a30706e88e3ed170eae0d42cb78 Reviewed-on: http://review.typo3.org/44066 Reviewed-by:
-
- Oct 09, 2015
-
-
TYPO3 Release Team authored
In our efforts to achieve a better interoperability with other PHP projects, the PHP code base of the TYPO3 Core switches to the PHP coding guideline standard PSR-2. See http://www.php-fig.org/psr/psr-2/ for more information. Resolves: #70515 Releases: master Change-Id: I734c0d838af157003decfeb5fc0a11dddcb87bf5 Reviewed-on: http://review.typo3.org/43918 Reviewed-by:
TYPO3 Release Team <typo3cms@typo3.org> Tested-by:
-
- Aug 07, 2015
-
-
Christian Kuhn authored
Resolves: #68829 Releases: master Change-Id: Ibf9b0a1c7884b68eb27f880e1d42369580d3ec04 Reviewed-on: http://review.typo3.org/42354 Reviewed-by:
-
- Jul 17, 2015
-
-
Benjamin Mack authored
Fix tree indentation in Info and Access modules. Resolves: #68233 Releases: master Change-Id: I37e43e83b803ea521b9563722ffc6801bfb05c5a Reviewed-on: http://review.typo3.org/41486 Reviewed-by:
Andreas Wolf <andreas.wolf@typo3.org> Tested-by:
Benjamin Kott <info@bk2k.info> Tested-by:
-
- Jul 03, 2015
-
-
Andreas Fernandez authored
Replace occurences of count() with matching empty() pendants. Affected extensions: - aboutmodules - beuser - compatibility6 - cshmanual - css_styles_content - dbal - felogin - sys_action - t3editor - taskcenter - tstemplate Resolves: #67777 Releases: master Change-Id: I6986c71866c4f27f0c9bccc7d7d0dd14ea5695ac Reviewed-on: http://review.typo3.org/40685 Reviewed-by:
Stephan Großberndt <stephan@grossberndt.de> Reviewed-by:
Markus Sommer <markussom@posteo.de> Reviewed-by:
-
- Jun 03, 2015
-
-
Helmut Hummel authored
Deprecate renderMode in favor of a flexible deferred rendering of flash messages in the Fluid template. This means that flash messages should no longer contain HTML tags but only plain text, if rendered by the default rendering. The rendered output will by default now be a <ul> list. The usage of renderMode in the Core is removed and styles are adapted to match the previous output. The core is adapted to now use htmlspecialchars in a controller context for user input. Encoding is now taken care of during rendering of the Fluid template. Resolves: #63453 Releases: master Change-Id: Ie02d2e1441ca2b3c7c159ffa917f7040f50327b5 Reviewed-on: http://review.typo3.org/34818 Reviewed-by:
-
- Jan 25, 2015
-
-
Christian Kuhn authored
* Move most rendering from PermissionController and PermissionAjaxController to fluid * PermissionController no longer calls methods from PermissionAjaxController * PermissionController no longer loops over the result set of getTree() in indexAction to prepare view data * Fix a couple of minor edge cases and bugs, especially some missing labels * Deprecate some now unused public methods in PermissionAjaxController Even with additional fluid rendering, the module is about 20% quicker with applied patch rendering longish tree lists, mostly by suppressing tons of calls to the sprite icon API. Change-Id: Ib3104d147270bc0ccf65f73773baed2a31418953 Resolves: #64489 Releases: master Reviewed-on: http://review.typo3.org/36246 Reviewed-by:
Mathias Schreiber <mathias.schreiber@wmdb.de> Tested-by:
-
- Jan 22, 2015
-
-
Christian Kuhn authored
A removed class property was still in use and results in a wrong SQL query. Related: #64416 Resolves: #64416 Releases: master Change-Id: I4b2d17fe307a9137487101eacf64610a13f8a2db Reviewed-on: http://review.typo3.org/36181 Reviewed-by:
-
Christian Kuhn authored
The access module is restricted to admin users since core 6.0. The patch removes left over code checks for non admin users. Resolves: #64416 Related: #41229 Releases: master Change-Id: I6fddc2eb1ae8a720c3d157993621fe201bd692e7 Reviewed-on: http://review.typo3.org/36169 Reviewed-by:
-
