- May 01, 2021
-
-
Alexander Schnitzler authored
EnvironmentService is an API class for constant TYPO3_MODE, which has been deprecated with v11. Core API class ApplicationType can be used instead, which obsoletes EnvironmentService. The code adapts usages and deprecates EnvironmentService. Releases: master Resolves: #92494 Related: #92947 Change-Id: Id6f818a8f312e735904d79e7b372fe70db97c9a1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66060 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
Christian Kuhn authored
Jobs are sometimes stuck, for instance when they run into infinite loops. With the default job timeout of one hour and a default retry, it takes two hours until those report negative. Jobs are usually done in less than 15 minutes. We now set the timeout to generous 30 minutes, a pipeline with a stuck job will thus report after one hour, latest. Resolves: #94033 Related: #94001 Releases: master, 10.4, 9.5 Change-Id: I80c26783f5ff0a5900c849d84f57c77e22ca4f63 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68954 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
-
- Apr 30, 2021
-
-
Benjamin Franzke authored
A custom Lit-based web componenent router is added which reflects module URLs into the browser adress bar and at the same time prepares for native web components to be used as future iframe module alternatives. Such modules will be implemented as JavaScript modules, that provide an implementation for a custom HTML Web Component. The first of such components (added within this change) is a wrapper component for traditional iframe-based backend modules. Module state changes are advertised via DOM events and propagated to the browser address bar, browser title, and the module menu. Adress bar updates ================== The module URL to address bar synchronisation enables sharable module deeplinks to be copied from the browser address bar. Whenever a component advertises a state change (e.g. iframe change), a sharable deep link is generated and shown in the browser adressbar. Technical preparation for the required deeplinking has been added with #93674. History Management ================== Browser history state is managed via the iframe history context of the content module frame (that is unlike other modern Single Page Applications which use history.pushState and history.replaceState). This approach required some synchronisation work, but there are technical limitations that prevent a combination of iframe history updates in combination for newer API like history.pushState. (The limitation is: state added by history.pushState is skipped by iframe history handling). The advantage of this compromise is: All "traditional" modules will preserve their state handling as before, no breaking/behavioral changes for iframe-based modules. Routing ======= The router uses two parameters to perform routing: * module – Module name as defined in ext_tables.php * endpoint – (json) api to be used by the component (= module URL) The module attribute is used to perform the actual routing to the respective backend module component, while the endpoint attribute serves as API to parse/fetch the state of the module. A named slot is used to switch between the available module components. That means only one of the routers childNodes will be visible at a time, while all modules are actively attached to the DOM. State is therefore preserved when switching between modules and the iframe is always kept active, allowing to act as history state-container (as described in "History Management"). Example of two modules that are attached to the DOM, where only <typo3-configuration-module> is visible as the <slot> in the shadow root puts a reference to this childNode: <typo3-backend-module-router module="system_config" endpoint="…"> #shadow-root <slot name="TYPO3/CMS/Lowlevel/ConfigurationModule"></slot> <typo3-iframe-module endpoint="…" slot="TYPO3/CMS/Backend/Module/Iframe"></…> <typo3-configuration-module endpoint="…" slot="TYPO3/CMS/Lowlevel/ConfigurationModule"></…> </typo3-backend-module-router> Note: The "TYPO3/CMS/Lowlevel/ConfigurationModule" component is not yet part of this commit, and only serves as an example (will be implemented later on). The slot name is resolved from the module key. Out of scope for this patch (will follow later) =============================================== * Link based routing interception via data-module tag for anchor tags. To be added as an additional convenience API on top of the router module and endpoint attribute (current API). * Convenience components for module layout * Integration into shortcut handler * Install-tool URLs do not reflect into addressbar right now Install-tool modules are redirected, therefore url updates can not be mapped as backend URLs right now Solution will probably be to integrate the install tool components as web component into the backend. Resolves: #93988 Related: #93674 Releases: master Change-Id: I682e89649b597c8c74b6a0a8f198f6bcf5bbc347 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67464 Tested-by:Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
-
Christian Kuhn authored
* Store an array in uc instead of serialized objects * PHP 7.4 strictness in some classes * Simplified inheritance chain * Drop a service class of little use by merging calls to controller * Avoid another ObjectManager->get() call * Minor bugfix that a shortcut to 'compare users' is not reflected in module menu drop down * Minor cosmetics Change-Id: I73bd2f884573807a819e4ae0d68c93897641b0f1 Resolves: #94025 Releases: master Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68924 Tested-by:
-
Oliver Bartsch authored
The tablist inside the element information modal in the workspaces module did not longer set the active state on the correct tab item. This is due to a change in bootstrap 5, since an active tab is highlighted by setting the `active` class on the tab item link (`nav-link`) instead of the tab item (`nav-item`) itself. This is fixed by adding the `active` class to the correct element again. Further reference: https://getbootstrap.com/docs/5.0/components/navs-tabs Resolves: #94028 Related: #93119 Releases: master Change-Id: I21ee8ede69876feef047c6303c4fbe890f898a65 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68928 Tested-by:
-
Benni Mack authored
When having JOINs in SQL selects, which typically happens when a MM property is resolved via Extbase's ORM, versionOL() threw an SQL error because versionOL() also queried "uid_local" which did not exist in e.g. sys_category. This change splits up the massive "overlayLanguageAndWorkspace()" method into smaller chunks and takes a different route when doing workspace overlays for JOINs. By re-fetching the main tables' record, all known fields can be identified via array_key_intersect() and then chunked together again with the JOINed information via array_replace(). The added tests show that the assertion for MM relations now work (if the fix is not applied, the included tests fail due to a SQL error in tests), but deliver a wrong result, which will be fixed with https://review.typo3.org/c/Packages/TYPO3.CMS/+/68913 Resolves: #81208 Resolves: #93484 Releases: master, 10.4 Change-Id: Iaba70be0cf5b7a36ab13380940286628ac976f9a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68915 Tested-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
Ralf Merz <mail@merzilla.de> Reviewed-by:
-
Oliver Bartsch authored
The input field of both, TOTP and recovery codes, was wrapped into a container having `form-control` and `form-control-clearable` classes set. Those classes have no effect, since they belong to the clearable functionality of TYPO3 and will be added automatically on initialization. Since MFA does not use this functionality, the container is removed. Resolves: #94027 Releases: master Change-Id: I563fd55629f002df3617306a52da20c379cfcd75 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68927 Tested-by:
-
Benni Mack authored
Various parts of TYPO3 Core are not ready yet to be used with Fluid Engine 3.0-dev, which people might accidentally install. This change sets the fluid dependency back to ^2.6.10 Used commands: - composer req "typo3fluid/fluid:^2.6.10" - composer req "typo3fluid/fluid:^2.6.10" -d typo3/sysext/adminpanel --no-update - composer req "typo3fluid/fluid:^2.6.10" -d typo3/sysext/core --no-update - composer req "typo3fluid/fluid:^2.6.10" -d typo3/sysext/fluid --no-update - composer req "typo3fluid/fluid:^2.6.10" -d typo3/sysext/redirects --no-update Resolves: #91850 Releases: master, 10.4 Change-Id: If46475fd3fdbca3ce23a652a253c0ac28d9a6149 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68919 Reviewed-by:
-
Markus Klein authored
Add a usage of {__currentTimestamp} to the example in the ApiReference. The feature has been added at a later point and is only mentioned in the concepts, but never in the reference. Resolves: #94023 Releases: master, 10.4 Change-Id: I4e1568343a8fa56e41f6549b4beae292523b8754 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68920 Tested-by: -
Oliver Bartsch authored
Since there is no guard clause, dealing with non workspace aware records, it's possible that `t3ver_state` is not set at this point. To prevent the InvalidEnumerationValueException on processing the value, the null coalescing operator, together with a proper typecast is now used. Resolves: #94024 Releases: master, 10.4 Change-Id: I7cb420dfd887e34a89bd7042ae5c407171907eba Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68922 Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
-
- Apr 29, 2021
-
-
Christian Kuhn authored
Releases: master Resolves: #94022 Related: #90803 Change-Id: If030a4cb6a1015e618f0968dab693ccd4c54640f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68914 Tested-by:
-
Maik Schneider authored
RelationHandler cannot handle vanilla uids, pass 0 instead to correctly parse defVals for MM-relations in TCA type=group Resolves: #93289 Releases: master, 10.4, 9.5 Change-Id: I5258bbc5ef164fc9ed2d14ed1062b54e1f9eec92 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67447 Tested-by:
Maik Schneider <schneider.maik@me.com> Tested-by:
Richard Haeser <richard@richardhaeser.com> Reviewed-by:
-
Oliver Bartsch authored
Fixes ===== * Fix DateTimePicker by adding the correct format as required since updating to flatpickr in #91606 * Restore clearable functionality of DateTime fields by adding a new TypeScript Module, which properly initializes those fields. * Unify size of form fields again and fix position of the submit button and the `groupByPage` checkbox * Add bootstrap v5 compatible markup to the `groupByPage` checkbox Cleanup ======= * Unify UX by using the `actions-calendar` icons, like FormEngine does, instead of font awesome. * Add type annotations and return types, where possible * Avoid usage of ObjectManager->get() Resolves: #94020 Releases: master Change-Id: I5ae684871c7ba5003d6c873604a2ca81067f7f27 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68912 Tested-by:
-
Christian Kuhn authored
Even though ContainerInterface->get() can return 'mixed', it returns 'object|null' with our symfony DI based implementation. To help IDE's object resolving, dynamicReturnTypeMeta.json now declares an instance of the first argument is returned. Resolves: #94016 Releases: master, 10.4 Change-Id: I67904feb86c4dc421f2038d9352795ce73f062d1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68909 Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Tested-by:
-
Benni Mack authored
The PagePositionMap uses the ElementBrowserPageTreeView which is a specific implementation for the Element Browser (now unused). However, the PageTreeView is the correct implementation, as this is also used in all subclasses of PagePositionMap, handling links properly for moving records or creating new records / pages. Resolves: #94006 Releases: master Change-Id: I1b7de4827732afb201c8bb0ee0a16112df27948e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68900 Tested-by:
-
Oliver Bartsch authored
The path for the Belog module changed in v11 and does now contain the `/module` prefix. Since it's obviously never a good idea to use such hard-coded values, as can be seen in this example, the route path is now generated by the UriBuilder. This will prevent further bugfixes in case the path structure will change again. Additionally, the $GLOBALS['TYPO3_REQUEST'] declaration is removed, since #93853 was already merged. Resolves: #94018 Releases: master Change-Id: I260357370da0b7a6bd7b9e8ea6f5ea0c8503f9ea Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68911 Tested-by:
-
Oliver Bartsch authored
The `workspacesExtensionLoaded` variable is removed from the Template, since it is never set and therefore always equals to FALSE. The previous "is workspaces loaded" check is now directly integrated in the already existing `showWorkspaceSelector` check. Resolves: #94017 Releases: master, 10.4 Change-Id: Ib63fa549028a875951b8940183b610f7943774f5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68910 Tested-by:
-
Larry Garfield authored
Resolves: #93996 Releases: master Change-Id: I1071d8aa69e92beb4ff8ee12e4c75535a11bb8af Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68886 Tested-by:
-
Riny van Tiggelen authored
When TYPO3 is in composer mode (var is outside public path), GeneralUtility::writeFileToTypo3tempDir now returns NULL for successful operation as stated in the docblock. Resolves: #90063 Releases: master, 10.4 Change-Id: I670503e68275047f511f3821f97b1b56d62bb7f8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68721 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Riny van Tiggelen <info@online-gamer.nl> Reviewed-by:
-
Oliver Bartsch authored
Additionally, add a missing @param to the PHPDoc. Resolves: #94014 Releases: master Change-Id: I1deafe6ddd07c0a1881cfaa7bc3a82d0954dce50 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68906 Tested-by:
-
Oliver Bartsch authored
Resolves: #94012 Related: #90803 Releases: master Change-Id: I64d84f9b31ba250e95090b67e3ae9542cff6e719 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68905 Tested-by:
Torben Hansen <derhansen@gmail.com> Reviewed-by:
-
Christian Kuhn authored
Change-Id: If5228b848dabd67615ee4ecdb3ebcd5c1f75421e Resolves: #94010 Related: #90803 Releases: master Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68903 Tested-by:
-
Christian Kuhn authored
By default, gitlab passes all artifacts from previous stages to each job. Thus, the negative-vote job was not executed in case previous jobs with artifacts failed. Since those jobs don't need artifacts anyways, not downloading them solves the issue. See: https://docs.gitlab.com/ee/ci/yaml/README.html#dependencies Change-Id: Id38354949ddc7b9f059dc4203208b4e949568b2d Resolves: #94013 Releases: master, 10.4, 9.5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68904 Tested-by:
-
Benni Mack authored
This change simplifies the ExportPageTreeView to extend from AbstractTreeView directly, making the intermediate subclassing to BrowseTreeView obsolete. In addition, several properties which are only used within ExportPageTreeView are moved into this class, reducing the actual logic within AbstractTreeView. Unused properties such as "MOUNTS", "bank" and "stored" are moved to the respective usage'd subclasses. Resolves: #94007 Releases: master Change-Id: Ieba1fd4fa6d8df33d1ebdb047f6d76b1b3413bfb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68901 Tested-by:
-
- Apr 28, 2021
-
-
Alexander Schnitzler authored
To further phase out extbase ObjectManager, the functional tests now use container->get() to set up tests. Some fixture files are moved to over to full test extensions to supply a Services.yaml file. Releases: master Resolves: #94008 Change-Id: I990e95b05b17b648db3861aa4e5618d59ac6ade9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65639 Tested-by:
-
Dmitry Dulepov authored
If the user does not have "edit" persmission, she will not be able to see the "Copy" action in the content menu. Since copy operation is read-only, this action should be allowed. This fix will allow copying without "edit" permissions. The fix is contributed by the University of Basel. Resolves: #92708 Releases: master, 10.4, 9.5 Change-Id: I018442e148ba1b4e9801a778bd5a00f433b9d0e0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66556 Tested-by:
Marcus Schwemer <ms@schwemer.de> Tested-by:
-
Benni Mack authored
Various logic can be simplified within the ElementBrowser / LinkPicker code base, where unused properties are handed around JS / PHP without any usages anymore, due to previous refactorings. Resolves: #94000 Releases: master Change-Id: Ie673db2877adfb563a35e4efd79c2296740621d3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68894 Tested-by:
-
Andreas Fernandez authored
With #93975 the LinkBrowser was not able to write back a selected page to FormEngine. The reason is that the input field has no `onchange` attribute anymore, thus its event handlers cannot get processed. The `change` event is now dispatched properly to trigger both, event listeners and "old-school" onchange handlers. Resolves: #94002 Related: #93975 Releases: master Change-Id: I97505c078602f3670c390e48cff0cc6fc96bcdcd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68899 Tested-by:
-
- Apr 27, 2021
-
-
Rico Sonntag authored
current() returns FALSE if array is empty or internal array pointer is beyond the end. Without this change, this currently leads to the following exception: Return value of TYPO3\CMS\Extbase\Error\Result::getFirstError() must be an instance of TYPO3\CMS\Extbase\Error\Error, bool returned Releases: master, 10.4 Resolves: #93834 Relates: #88608 Change-Id: I9a01c232ac456ebfba7aa10f0946c3d639b2f47e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68656 Tested-by:
-
Stephan Großberndt authored
This patch fixes a regression introduced by change https://review.typo3.org/c/Packages/TYPO3.CMS/+/65126 which lead to an HTTP 500 exception instead of returning HTTP 404 by making sure that FileDumpController->isFileValid() is not called with NULL as parameter. Resolves: #92957 Related: #91754 Releases: master, 10.4, 9.5 Change-Id: I824606867063f421f1a6fdfde4788846ddcc41a7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66947 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
Oliver Bartsch authored
The PageRenderer `inlineJavaScriptWrap`, used for wrapping general JavaScript such as spam protection, is adjusted to remove the "text/javascript" type in case the the doctype is not XHTML. Resolves: #92126 Releases: master, 10.4 Change-Id: I45f0e0fab0b89989c7abd5754465357ebf393ee8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68891 Tested-by:
-
Oliver Bartsch authored
Resolves: #93999 Releases: master, 10.4 Change-Id: I949ccee64cab9081d93d668fc57812cea487d118 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68893 Tested-by:
-
Lina Wolf authored
Deprecates both Hooks and adds the fact to the changelog. Resolves: #92992 Releases: master Change-Id: Iaa17c0f5c91cf423bc27e408827d9e882a7d37f5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67005 Tested-by:
-
Andreas Fernandez authored
TBE_EDITOR has some old code still managing FormEngine today, even with substitutions available since at least TYPO3 v7. This patch replaces the last occurrences of TBE_EDITOR.fieldChanged() and deprecates the method. Resolves: #93975 Releases: master Change-Id: I58b9e40284495a15e327d2ab2c8caaebc0107e95 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68757 Reviewed-by:
-
Benni Mack authored
This change adds a getFile() implementation within the FAL Folder object, which is very convenient compared to $folder->getStorage()->getFileInFolder("filename.ext", $folder) Resolves: #93209 Releases: master Change-Id: I44a24764a1b7228840254204a51c241619005325 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67433 Tested-by: -
medarob authored
Releases: master, 10.4 Resolves: #93991 Change-Id: Ia2f47aa329347e8c239e2979c9def6efc5ed5d71 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68889 Tested-by:
-
Uwe Trotzek authored
To determine the opened page branch, the uc path must be BackendComponents.States.Pagetree.stateHash instead of browseTrees.browsePages. The configuration must also contain the following structure [ 1_1234 => 1, 1_3456 => 1 ] instead of [ 1 => [ 1234, 3456 ] ] Otherwise the page won't be expanded properly. Resolves: #90985 Releases: master, 10.4 Change-Id: I63fb967c3d47286f24e4e469c4947a3c09047605 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64109 Tested-by: -
Daniel Goerz authored
Resolves: #93997 Releases: master Change-Id: Idf0591125371cc25f53b8c9cc178a5c595c7be2d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68887 Tested-by:
-
Anja Leichsenring authored
This one occurence of the infamous getIndpEnv method can be replaced with the requests normalizedParams information. Resolves: #93861 Releases: master Change-Id: I8afeae1b9a07738205f6841f67d372e7b67a045c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67493 Tested-by:
-
Nikita Hovratov authored
The parameters array of TCA itemsProcFunc is extended for several (inline) parent table related properties. These are especially useful for manipulation of the items array, depending on e.g. the parents' record type. Additional properties added: * inlineParentUid * inlineParentTableName * inlineParentFieldName * inlineParentConfig * inlineTopMostParentUid * inlineTopMostParentTableName * inlineTopMostParentFieldName Resolves: #93508 Releases: master, 10.4 Change-Id: I476054271b37688b5c2d57285a1d739d25955cce Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67917 Tested-by:
-
