- May 20, 2021
-
-
Christian Kuhn authored
Brings a PHP 8 fix and adaptions to recent core works. composer req --dev typo3/cms-styleguide:~11.2.2 Change-Id: Ie74b225ff23990a3d2b6dd0964b5cc6d16bc7c0c Resolves: #94161 Releases: master Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69186 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
-
- May 19, 2021
-
-
Oliver Bartsch authored
Since #93519, the form-control-wrap class did not longer define any margin-top. Therefore TCA field descriptions were displayed right above the field without any space. This is fixed by adding the margin again. Also the labels' margin is adjusted to use the correct variable. Resolves: #94159 Related: #93519 Releases: master Change-Id: I750312b5a1311cd6466edf2c72a20d3e7464fe28 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69184 Tested-by:
-
Oliver Bartsch authored
The input fields for entering the one-time password in the authentication views of TOTP and recovery codes are improved by adding two new attributes: autocomplete="one-time-code" ======================== In supporting browsers (mostly on mobile devices), this allows them to suggest or even insert one-time passwords, received e.g. via SMS. See: - https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes/autocomplete#values - https://developer.apple.com/documentation/security/password_autofill/enabling_password_autofill_on_an_html_input_element As a side effect this might also prevent browsers from auto completing the fields with unsuitable data, since this feature is usually enabled by default (autocomplete attribute not set). See: https://developer.mozilla.org/en-US/docs/Web/Security/Securing_your_site/Turning_off_form_autocompletion inputmode="numeric" ================= In supporting browsers (mostly on mobile devices), this changes the keyboard layout to numeric. This is helpful, since only digits of 0-9 are required / allowed. See: - https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/inputmode - https://css-tricks.com/everything-you-ever-wanted-to-know-about-inputmode/#numeric Resolves: #94157 Releases: master Change-Id: Ifd3551b9a918f164bdc618a81555f573a91d2bd5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69182 Reviewed-by:
Richard Haeser <richard@richardhaeser.com> Reviewed-by:
Torben Hansen <derhansen@gmail.com> Reviewed-by:
Benjamin Franzke <bfr@qbus.de> Tested-by:
-
Benjamin Franzke authored
The HTTP_HOST verification failed if the proxy server port was different to the local webserver port, due to an assumption in hostHeaderValueMatchesTrustedHostsPattern() that concluded that the local webserver port needs to match the default port of the proxy server. In case a HTTPS termination proxy is used, that assumption can not be made, as it is common practice to use HTTP backends behind a HTTPS proxy in private networks. Therefore the port is now verified against the default port of the current webserver, not a possible proxy server. Scenario: * Proxy Server HTTPS (SSL termination) => Port 443 * Application Server HTTP => Port 80 * Default trustedHostsPattern setting It was previously required to configure a (slow) trustedHostsPattern to circumvent this issue. Releases: master, 10.4 Resolves: #94113 Change-Id: I294b87164aee834d8c0b5e0a75da3e19051fe592 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66613 Tested-by:
-
Christian Kuhn authored
This allows to disable editing of text in FormEngine t3editor, while syntax highlighting is still applied. ext:styleguide master brings the t3editor_2 field as example. Change-Id: I4a74f186a0183e2eafd69140ea13517d4f1d1a22 Resolves: #94081 Releases: master Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69037 Tested-by:
-
Benjamin Franzke authored
This change performs the following optimizations: * Detach spinner from content flow using a relative+absolute position normalization, allowing an equivalent positioning to the regular backend icons. This is to ensure that both, <typo3-backend-spinner> and <typo3-backend-icon> render equally when used in inline(-block) containers (for example .svg-toolbar__drag-node). <typo3-backend-spinner> used to cause vertical alignment offsets, when the spinner was positioned in inline text-flow and therefore caused the vertical flow to cause offsets. * Add a variant="light|dark" attribute to select between the available TYPO3 spinner variants. By default the current color is now used. * Adapt sizing to inherit size from current font-size when used without a specific size attribute. Also apply that to the backend icon component to stay interchangeable. * Render spinner via SVG and only animate the spinning part instead of the entire shape. This is to avoid the bouncing-icon effect that CSS animations on the entire element cause (as often seen with font-awesome spinners for example). Releases: master Resolves: #94149 Change-Id: I00d2e4915a0644726f78abe485fd9e276b539259 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69162 Tested-by:
-
Johannes Seipelt authored
increase z-index for extbase-debugger to from 999 to 99990 (same as the admin-panel) to prevent the debug output to be hidden behind elements with z-index values >1000 which is quite common, f.e. happens with the introduction package. Side note: this impacts the debug viewhelper output as it uses the DebuggerUtility::var_dump. Resolves: #93357 Releases: master Change-Id: I77e0696dfd19b74d2e8e5d76795965b443fe65ea Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69153 Tested-by:
-
Daniel Goerz authored
* EXT: backend * EXT: belog * EXT: beuser In addition an adjustment is added that was forgotten in https://review.typo3.org/c/Packages/TYPO3.CMS/+/69038 Resolves: #94126 Releases: master Change-Id: I610b39268d417344517e76d7cc436da50d3db898 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69134 Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Reviewed-by:
-
Daniel Siepmann authored
The given condition should check if two fields are configured within TCA. Both fields are required in order to query the database. The given condition didn't check for existence of both fields. The new condition actually checks if both fields are defined. Resolves: #94154 Related: #94057 Releases: master Change-Id: I76a71dd7db46b809d717aa9090aa1efa111f1396 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69180 Tested-by:
-
- May 18, 2021
-
-
Oliver Hader authored
To "encapsulate" resources that were uploaded using a form element, a new PseudoFileReference class was introduced in TYPO3-CORE-SA-2021-002, extending Extbase's FileReference domain model. When trying to persist those files using Extbase's PersistenceManager, the corresponding database table is assumed to be (inferred from class) `tx_form_mvc_property_typeconverter_pseudofilereference` instead of correct `sys_file_reference`. In order to solve this issue, a corresponding mapping for the new domain model is introduced. Resolves: #94153 Releases: master, 10.4, 9.5 Change-Id: I8325a5c78e1e2e37ff75711a10725be796c22d9d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69176 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
-
Benni Mack authored
Extbase's throwStatus() method is mentioned that the execution workflow indeed should be stopped right away, but never did, as all of TSFE's code was executed again and again. Since TYPO3 v11 (#93007) we now have a "PropagateResponseException" and native PSR-7 Responses in Extbase, which allows us to do exactly that: Stop and have the Application emit the response directly with the status code. Resolves: #94131 Releases: master Change-Id: I3a6d2785603abcce4399378d0dabc2a5d05d6017 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69135 Reviewed-by:
Susanne Moog <look@susi.dev> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
-
Richard Haeser authored
For some widgets it makes sense for users to be able to refresh the widget without reloading the complete dashboard. A new refresh action will be available on widgets which have the refresh option enabled. Besides that, a new event is created so developers can dispatch an event to refresh a specific widget even when no refresh option is available for the user. Resolves: #93210 Releases: master Change-Id: I0d08c4fa745b806bf05cb9c2b91d4107ebbfb606 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69149 Tested-by:
-
Oliver Bartsch authored
To improve the usability of the "Redirects hit count" feature, the creation date is now also shown in the "Statistics" tab. This is especially useful to set the amount of hits in relation to the period of the redirect existence. Resolves: #94143 Releases: master Change-Id: I06435a71ac96dac6d744437a4f7e41c11d877d83 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69157 Tested-by:
-
- May 17, 2021
-
-
Oliver Hader authored
Resolves: #94148 Releases: master, 10.4, 9.5 Change-Id: If1378f2d471f18099b55b05a84dc81adc247bc69 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69158 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
Benni Mack authored
When using Drag+Drop in Page Module a different functionality is used than using Clipboard (Move+Paste) while moving a record in the page module. This results in a different behaviour when dealing in Workspaces. The patch uses the same "cmd" instead of "data" for DataHandler now for Drag+Drop than in Clipboard. Resolves: #92849 Releases: master, 10.4 Change-Id: Idb8566b166a18c514d149e53699489b7b9eb9247 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69137 Tested-by:
-
Thomas Löffler authored
This fixes display issues of the description list in the distribution detail view, which were introduced with the bootstrap v5 upgrade. The alignment of description lists in bootstrap v5 is described in the official documentation: https://getbootstrap.com/docs/5.0/content/typography/#description-list-alignment Resolves: #94145 Releases: master Change-Id: I14cd954efd071b69b18eb5b33adf38bb98af3989 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69156 Tested-by:
-
Benjamin Franzke authored
Pass startup module and bust parameter as data tags to avoid inline javascript initialization. Resolves: #94136 Releases: master Change-Id: If4a79b338d121f0a01d15adadf5b86501f4dac52 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69142 Tested-by:
-
Chris Müller authored
The @return annotation for the following FileReference methods is set to "string", but these methods can also return null: - getTitle() - getAlternative() - getDescription() To avoid problems with code quality tools and to ensure type safety the return value of these methods is always casted to a string. Resolves: #94144 Releases: master, 10.4 Change-Id: Id28281ca9b55f20fb02e0de3adfe510f88580141 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69155 Tested-by:
-
- May 14, 2021
-
-
Andreas Fernandez authored
Executed command: yarn add "bootstrap@^5.0.1" Also, some minor coding issues were solved that popped up with the update. Resolves: #94138 Releases: master Change-Id: Ie80eff09efba43cfb9ae60862cb2167b0bc3f12f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69146 Tested-by:
-
Larry Garfield authored
PHP 8 promotes a lot of notices (previously ignored) to warnings. That means they can no longer be ignored. Resolves: #94057 Releases: master Change-Id: I37de1b7e8e31eb2be78b8e90af015bc88e121791 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69012 Tested-by:
-
Andreas Fernandez authored
Despite its name, the method `ArrayUtility::arrayDiffAssocRecursive()` mimics the behavior of `array_diff_key()` and not of `array_diff_assoc()`. The method has been adjusted to act like `array_diff_assoc()`. As this is considered being a breaking change, the behavior must be enabled explicitly by passing a 3rd parameter `$useArrayDiffAssocBehavior` being true. If the argument is either omitted or false, the old behavior is kept but a deprecation warning will be thrown. Resolves: #94137 Releases: master, 10.4 Change-Id: I3cfa9581596ca4114bce4daca461187e9b87fe99 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69143 Tested-by:
-
Andreas Fernandez authored
Resolves: #94139 Releases: master Change-Id: I645c03ae9ddb411dae7ef6b55a8e3fde479785c0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69148 Tested-by:
-
Benni Mack authored
The SVG Tree now builds a SVG-in-SVG element around all icons (icon + overlay) to ensure the sizes are consistent and can be positioned properly. This fixes the issue that possible custom icons have a different size. Resolves: #86280 Releases: master Change-Id: Icf39e74c398d149a9216a64551bdeb250ed2bf00 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69147 Tested-by:
-
Benjamin Franzke authored
The test setup used to initialize the DateAspect from a string, that means the local php timezone has been taken into account, and test verficiation fails with date offsets if the local timezone is not UTC. Adapt to initialize from a unix timestamp, as this ensures the local timezone has no effect on the test. Note that the real application does the same, as the DateAspect in initialized from the timestamp in GLOBALS['EXEC_TIME']. Releases: master, 10.4, 9.5 Resolves: #94135 Change-Id: I0494ac3e1911f34a3a79c3063caaabad1c0027b7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69141 Tested-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Tested-by:
-
- May 13, 2021
-
-
Oliver Bartsch authored
Resolves: #94133 Releases: master Change-Id: I2101f3acc5c32c45efa3a8330bb7b6aa1d9716ce Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69138 Tested-by:
-
Andreas Fernandez authored
TCA's value picker uses a lot inline JavaScript for its picker handling, therefore, the handling has been moved into a dedicated web component. As a side-effect a bug in TextElement and InputTextElement is fixed. Both elements previously used exactly the opposite insert mode. Resolves: #94112 Releases: master Change-Id: Ib3a1f9697477cab4b9a00c606fcd0bd6524450b5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69108 Tested-by:
-
- May 12, 2021
-
-
Benni Mack authored
When UriBuilder is used outside of an initialized ExtbaseAction and not within StandaloneView, the cObj is not properly initialized inside Extbase's UriBuilder Resolves: #91625 Releases: master, 10.4 Change-Id: I850257f0a5d47d3ec18e7eb791894c90258394f7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69132 Tested-by:
-
Oliver Klee authored
In some rare cases (e.g., for some Console commands), RootlineUtility::enrichWithRelationFields might be run without any TCA, which leads to a crash. This is now avoided. Resolves: #93949 Releases: master, 10.4 Change-Id: I7725b99341f55aa20279abccb35a79e4fb574409 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68802 Tested-by:
-
Benni Mack authored
This change adapts certain areas within EXT:extbase Persistence to avoid ObjectManager and rely on constructor DI and GeneralUtility::makeInstance() where it's not easily possible to switch to DI yet. Resolves: #94111 Releases: master Change-Id: I731d5b8f791bd34410aa3bf86bc7dc4e6098fa20 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69101 Tested-by:
-
Alexander Schnitzler authored
in * EXT:workspaces * EXT:tstemplate * EXT:setup * EXT:scheduler * EXT:recycler * EXT:lowlevel * EXT:linkvalidator * EXT:install * EXT:info Releases: master Resolves: #94121 Change-Id: Idb153afd9763cd9c3238be68d2290bde68e88b35 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69038 Tested-by:
-
Benni Mack authored
This change removes the internal BackendRequestHandler of Extbase as TYPO3 Backend modules are now dispatched directly via Extbase's Bootstrap. This takes away one layer of indirection for Backend modules which are built with Extbase. Resolves: #94118 Releases: master Change-Id: I5c1b323c75363521f49c93f16976f866961fcddf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69111 Tested-by:
-
Benni Mack authored
This change ensures that writing to EditDocumentController only happens for POST requests, as EditDocumentController currently takes care of rendering the form AND saving a record via DataHandler. Resolves: #94114 Releases: master Change-Id: If6dc8930d0fa0cb2ed5d1165d6a42d9639013556 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68714 Tested-by:
-
- May 11, 2021
-
-
Nikita Hovratov authored
Since the bootstrap v5 update, the inputLinkElement is styled with flex form instead of display table. This became a problem, because this broke the appearance of the explanation toggling. The initial idea to hide the complete clearable wrap didn't work properly as it is loaded dynamically and it's not ensured it exists when trying to hide it. To circumvent this problem, the styling is now done with some extra css. Additionally the wrong form-control class is removed from the clearable wrap and the styling is now also moved to own css. Resolves: #93941 Releases: master Change-Id: I0bb0d1cf26ed40dd3c87a58e08cc39e449b96c0d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69064 Tested-by:
-
Daniel Windloff authored
Use the standard layout for toolbar items to make recurring elements look the same in the various core modules. Resolves: #92018 Releases: master Change-Id: I2c34d0e977652bd247c0dd983308385cdf865042 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65341 Tested-by:
-
Dmitry Dulepov authored
This change adds a normalization for slug source before converting it to ascii. This helps to avoid issues with various ways to encode the same Unicode characters. Used command: composer req symfony/polyfill-intl-normalizer Resolves: #93764 Releases: master, 10.4 Change-Id: I9982fafd9c34c69bb6ca47ee8242f504b9974121 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68492 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
-
Daniel Dorndorf authored
When overriding aspect ratios via TCA overrides, one can also now disable allowed aspect ratios in cropVariants. Resolves: #93854 Releases: master, 10.4 Change-Id: I10f5ac16ce6bb6ca776e483c525ee6e4268e5e8d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68670 Tested-by:
-
Benni Mack authored
Shona is a Bantu language of the Shona people of Zimbabwe. It is one of the most widely spoken Bantu languages. Also see https://en.wikipedia.org/wiki/Shona_language This change adds support for Shona to be selected as TYPO3 Language and to connect to TYPO3 Localizations (XLF files, Site Configuration) by default. Resolves: #93114 Releases: master Change-Id: Id25823fc5021d9cc3480fb57627fe3cfcfbcb614 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68987 Tested-by:
-
Andreas Fernandez authored
With #93979, `BackendUtility::translationCount()` was changed and always returned the message "This record has X translation(s) [...]!" even if there are no translated records at all. This patch initializes `$count` as 0 and changes the message handling as similar as in `BackendUtility::referenceCount()`. Resolves: #94091 Related: #93979 Releases: master Change-Id: I43dfa860d1c278a239bd88e83feddf239b8b01a8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69066 Tested-by:
-
Stephan Großberndt authored
This patch makes sure tx_scheduler_task.task_group contains an integer in order to avoid a SQL error when saving the task which in turn may lead to an endless fetch-and-save loop. Resolves: #94102 Releases: master, 10.4 Change-Id: Ie81d2c3a7eb193f4fd1ed59c34fe2de9fad023f4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69097 Tested-by:
Simon Gilli <typo3@gilbertsoft.org> Tested-by:
Guido Schmechel <guido.schmechel@brandung.de> Reviewed-by:
-
Benjamin Franzke authored
The Router dependency should not be optional and rather always be injected, and in reality it always was, as the nullable fallback to GeneralUtility::makeInstance was only used in unit tests. The UriBuilder factory is now provided via the backend service provider. That is because it became an ondemand dependency for the backend request handler in #93674. We now properly inject it via constructor which makes it a lowlevel service (a service that needs to defined via service provider to be available when TYPO3 has not yet been installed). Releases: master Resolves: #94083 Change-Id: I75b39cdae8c41d1ce38860c50713d749bbe8e348 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69056 Tested-by:
-
