To prevent a sql error the insert query for creating sys_history
records in Datahandler must only be executed, if argument
$logId is a valid uid. This could happen, if logging in
Datahandler is disabled.

Resolves: #55472
Releases: 6.2
Change-Id: Idacced5cb0af24a6c9f34165a8d0598ae9c91998
Reviewed-on: https://review.typo3.org/27162
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

The fix for issue #54226 introduced a bug
with FileReferences as it did not implement the
change of the interface.

Resolves: #54226
Releases: 6.2
Change-Id: I9f67f3f23b96569cdfadba1505e4881103a86ccb
Reviewed-on: https://review.typo3.org/27170
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack

TYPO3 checks if a redirect is needed for a domain by issuing a
select on sys_domain. In the where clause the columns redirectTo
and hidden are used. These columns have no index, thus the
select is slow.

This patch adds the combined key to the sql definition.

Resolves: #55181
Releases: 6.2
Change-Id: I7d7463e0d3e6abb53c4b0fccf205e4b1eb867878
Reviewed-on: https://review.typo3.org/27167
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack

We don't have the t3lib-directory anymore.

Change-Id: Icef845e0ae1fc25a51cd01fa2452751d14b362c5
Resolves: #55433
Releases: 6.2
Reviewed-on: https://review.typo3.org/27125
Tested-by: Georg Ringer
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack

If a user has listing rights on a folder which contains
folders he does not have access to the user currently
will end up with Exceptions in folder trees, file lists
as well as element browsers.

Before FAL these folders just have been shown "locked".

This change introduces an "InaccessibleFolder" object
which will be created by the storage if a Folder is
requested which exists but there is no read access while
the user is allowed to list the contents of the parent
folder.

In addition the components have been adapted to use this
new information for a graceful behaviour.

WIP: Did not adapt the tests yet, since I need to do some
urgent customer work. Feel free to go on with that.

Resolves: #51512, #53854
Releases: 6.2
Change-Id: If5c234fe66d1930e4cc0cb16279d2f77874d82db
Reviewed-on: https://review.typo3.org/26905
Tested-by: Ingo Schmitt
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Ingo Schmitt
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter

When you have a folder opened in the filelist and then delete it
via the folder-tree the file-module shows an error after its reload.

This patch checks for existence of the folder before it is created.
If it is not existent it checks wether the parent folder exists and
is accessible. If, so the parent folder will be shown instead.

If the parent folder is not accessible the usual exception is thrown.

Releases: 6.2
Resolves: #54554
Change-Id: I7a21c76fd476ebce439489040f3b4c6786afd10a
Reviewed-on: https://review.typo3.org/27030
Reviewed-by: Marcin Sągol
Tested-by: Marcin Sągol
Reviewed-by: Marcel Wieser
Tested-by: Marcel Wieser
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter

When the processing folder does not exist,
it is created on the fly in ResourceStorage.

However the returned object is at a later point
as string, leading to a fatal error in the end.

Solution is to just store the retuned object directly.

Resolves: #55471
Releases: 6.2
Change-Id: I97b4b5c7992db942812ae033fb963908a4abffde
Reviewed-on: https://review.typo3.org/27137
Reviewed-by: Steffen Ritter
Reviewed-by: Marcin Sągol
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

Currently if some code needs the parent directory or folder
object of some files or folders it either needs to query the
storage object for the identifier of the parent folder and then
create the folder object manually or needs to fiddle around with
the identifier manually, assuming that all identifiers are a
representation of a hierarchical path as it is for the local
driver.

The latter not only will fail for all storages having non-path
identifiers it is more overhead to create the folder objects
manually anyhow.

This patch adds "getParentFolder" to the ResourceInterface and
implements the method in AbstractFile and Folder as well as it
replaces the manual resolval in the file list module.

Releases: 6.2
Resolves: #54226
Change-Id: I651d62340186dd9ac57277b498f8f98ee160dfd2
Reviewed-on: https://review.typo3.org/26724
Reviewed-by: Alexander Opitz
Reviewed-by: Marcin Sągol
Reviewed-by: Sebastian Fischer
Tested-by: Sebastian Fischer
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny

The FileAbstractionLayer currently only provides the possibility to
retrieve the contents of a file as a string. If you want to output
a file this would lead to a massive memory overhead for large files
when building some kind of download/jumpurl/access-restricted download
script.

This change adds a method "dumpFileContents" to the ResourceStorage
allowing to directly output the contents of the file including setting
correct headers.

In addition it introduces a new method (same name) in the DriverInterface
and implements it in the LocalDriver.

Resolves: #52589
Releases: 6.2
Change-Id: I050da59b136fafbf3f05ac814bd3f11f20ae2396
Reviewed-on: https://review.typo3.org/26835
Reviewed-by: Frans Saris
Reviewed-by: Philipp Gampe
Reviewed-by: Ingo Schmitt
Reviewed-by: Sebastian Fischer
Tested-by: Sebastian Fischer
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack

When a BE User deletes a file in the file module all file references
as well as processed files are removed, too. If then aprocessed files
is missing for some reason an alert is displayed in the backend module:

Could not delete file "foo.jpg". Write-permission problem?

The patch fixes the situation by adding a check whether before deleting.

Change-Id: I228624a3470340382950d3f54d8b428bfe831715
Releases: 6.2
Resolves: #55428
Reviewed-on: https://review.typo3.org/27123
Reviewed-by: Stefan Froemken
Tested-by: Stefan Froemken
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter

This reverts commit 495afb59

The patch is reverted because it does not work when there is paging in 
the filelist or a file has no thumb shown.
Further the filename canonicalization done by the storage driver is 
not respected when checking the new file name.

Change-Id: I6f4b91bbf28e7b6f0cb8d7bcfb42f0cfb5eeacc6
Reviewed-on: https://review.typo3.org/27158
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter

In previous efforts the calls to the FileRepository, when retrieving
File objects have been relocated to the ResourceFactory, since the
coexistence causes problems when it comes to metadata and multiple
instances of the same entity.

As findByUid is defined in the AbstractRepository it was overlooked
until now. This patch overrides the base method, deprecated it and
calls the ResourceFactory, too.
In addition all calls in core are replaced with the direct call.

Resolves: #53690
Releases: 6.2
Change-Id: I89a665211bd7d400f339e27bd2b155958fe5daf1
Reviewed-on: https://review.typo3.org/26850
Reviewed-by: Ingo Schmitt
Tested-by: Ingo Schmitt
Reviewed-by: Frans Saris
Tested-by: Frans Saris

When the meta-data extraction services have been introduced it
silently has been assumed that the defined priority can be
used as execution order. In fact the priority just defines which
data takes precedence of another. In fact you might have an
extraction service which has highest priority for the fields it
serves but on the opposite should run as first, so other
extraction services already can use the data.

This change adds a second "priority" for that purpose and adapts
the indexing process accordingly.

Resolves: #54228
Releases: 6.2
Change-Id: I649fc8b91103ab518e5a692bf73c54851e8b70b1
Reviewed-on: https://review.typo3.org/26696
Reviewed-by: Frans Saris
Reviewed-by: Wouter Wolters
Reviewed-by: Stefan Neufeind
Reviewed-by: Ingo Schmitt
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter

The rendering of the plugin menu gets messed up if a plugin hasn't any
description. This patch clears floating for every list item to ensure
it is displayed on the left side.

Resolves: #53895
Releases: 6.2
Change-Id: Ib64b99865fda1359ade4b7c22d160fbfe28350c9
Reviewed-on: https://review.typo3.org/25655
Reviewed-by: Wouter Wolters
Reviewed-by: Marcin Sągol
Reviewed-by: Stefan Froemken
Tested-by: Stefan Froemken
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter

Resolves: #55464
Releases: 6.2
Change-Id: I1891763db8a8edc5ddb8077a1cc32c8184a7e0c1
Reviewed-on: https://review.typo3.org/27156
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny

Adds toggle all functionality.

Resolves: #55453
Releases: 6.2
Change-Id: Ie798e229a8a8751f82ffc6c14d1b1ca0caf949e1
Reviewed-on: https://review.typo3.org/27147
Reviewed-by: Frans Saris
Tested-by: Frans Saris
Reviewed-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring

On splitting sys_file table to extract metadata tca ctrl settings
crdate and cruser_id have been left out, but the columns were
removed. This results in a SQL error on creating sys_file records
with the datahandler.

Resolves: #55462
Related: #52726
Releases: 6.2
Change-Id: I9e856f607868c545ee4e1398a5031e47fc8c39fc
Reviewed-on: https://review.typo3.org/27151
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter

Change-Id: I252da74973c3dc4157717139c95ad0605e16fce1
Releases: 6.2, 6.1, 4.5
Resolves: #55458
Reviewed-on: https://review.typo3.org/27148
Reviewed-by: Wouter Wolters
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring

Move background-style from JS to CSS. Since other skinning-
extensions might override color-settings in TBE_STYLES we need
to generate CSS dynamically and late in the process inside t3skin.

Since backend-CSS is concatenated/compressed this will be included
in the generated merged CSS-file.

Change-Id: Ib04bdf0be172081eb463bdeb9dbd846f7c32cea3
Resolves: #54286
Releases: 6.2
Reviewed-on: https://review.typo3.org/26092
Reviewed-by: Stefan Neufeind
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

For FAL, the concept of "hidden" files was introduced with the sysext
"metadata". The field is called "visible", its usage is to be
implemented by the plugin.

The default value for visible is FALSE, making it error-prone for users
uploading new files: They are hidden by default, requiring additional
work by the end-user (or the plugin/backend module doing the work) to
un-hide the files.

This commit changes the default of ``sys_file_metadata:visible`` to
``1``, making *new* files visible by default.

Change-Id: Id760ac92042e3235259ae78509187d3535cc25ca
Releases: 6.2
Resolves: #55410
Reviewed-on: https://review.typo3.org/27111
Reviewed-by: Andreas Wolf
Tested-by: Andreas Wolf

The message when having a hook for the wizard items
is still the same, although the interface has been
renamed. So the check is valid, but if the check
fails then the message is misleading.

Releases: 6.2
Resolves: #55455
Change-Id: If1b9e4285c02e8a3ab92eee562b6516f24bae9a8
Reviewed-on: https://review.typo3.org/27146
Reviewed-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Tom Ruether
Tested-by: Tom Ruether
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter

tx_saltedpasswords_autoloader was used in old install tool only
and is obsolete now.

Change-Id: If398a197a18bfda20789afd0aa0104fcd8ba5993
Resolves: #55446
Releases: 6.2
Reviewed-on: https://review.typo3.org/27138
Reviewed-by: Thomas Maroschik
Reviewed-by: Marcin Sągol
Reviewed-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

This patch does not change functionality.
It just fixes formatting issues of the code and
corrects phpdoc.

Resolves: #53580
Releases: 6.2
Change-Id: I39a7ec757e6dfce8282053c3259a84edc2ba5588
Reviewed-on: https://review.typo3.org/25360
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack

File are categorizable by default as of TYPO3 6.2
When a BE User deletes a file, associated categories
must be removed as well.

Change-Id: I82175bbd207e68590c20de8fd536bab0de001fe3
Releases: 6.2
Resolves: #55430
Reviewed-on: https://review.typo3.org/27124
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Andreas Wolf
Tested-by: Andreas Wolf

There are signals for most filestorage operations performed
in the ResourceStorage, but not for adding a folder.

This patch adds the two missing signals.

Resolves: #54964
Releases: 6.2
Change-Id: Ia7e3970ea278bf5e74856008afe53083e91f0649
Reviewed-on: https://review.typo3.org/26863
Reviewed-by: Stefan Neufeind
Reviewed-by: Andreas Wolf
Tested-by: Andreas Wolf

The canonicalizeAndCheckFolderIdentifier does now check if the given
folder path is just a simple slash (/) and return it before really
canonicalizing the identifier.

This prevents the method returning a double slash (//) which will result
in an error in the isWithin() checkin the local driver.

Resolves: #55420
Releases: 6.2
Change-Id: Ibe189180a459377d042731931066a410e1e5ac51
Reviewed-on: https://review.typo3.org/27122
Reviewed-by: Frans Saris
Tested-by: Frans Saris

The variable $pageCache in TypoScriptFrontendController misses "Core" in
the namespace.

Change-Id: I5f9ee3bf36951194c74627e4e2bc9d17f5c639e5
Fixes: #55448
Reviewed-on: https://review.typo3.org/27141
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

TYPO3's deprecation_log is disabled by default. The Install Tool
shows an incorrect help text for the configuration
$GLOBALS['TYPO3_CONF_VARS']['SYS']['enableDeprecationLog'], claiming
that the default value is "file". In addition, enableDeprecationLog
is set to "file", which should be empty.

The patch removes the value of enableDeprecationLog and removes the
statement about the default value: other values in this area do not
state the default value either and since TYPO3 CMS 6.2 LTS, the
default value depends on the Application Context.

Resolves: #53653
Releases: 6.2
Change-Id: I2061a66b03e1c194f86d346e4183e95d3e959922
Reviewed-on: https://review.typo3.org/25417
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

The phpdoc notation of TableGarbageCollectionTask has some
pre namespaces config example.

This patch changes the phpdoc notiation.

Change-Id: Iaa0a70635893091c0ba99ce17404194c47e9a16c
Resolves: #54529
Releases: 6.2
Reviewed-on: https://review.typo3.org/26507
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Resolves: #53963
Releases: 6.2
Change-Id: I0dd51f2d256c153d6b6a1e247d86c69c5cfd7a7b
Reviewed-on: https://review.typo3.org/25681
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring

It is not possible to set $GLOBALS['TSFE']->altPageTitle
in USER_INT extensions anymore to modify the page title.

This has been possible before in the 4.x branches.

Fix this by implementing the title generation like all
other header data.

Resolves: #54467
Releases: 6.2, 6.1
Change-Id: I3d5be34b95cb295b92732d2f2f9bd1f123812365
Reviewed-on: https://review.typo3.org/26785
Reviewed-by: Stefan Neufeind
Reviewed-by: Alexander Opitz
Tested-by: Alexander Opitz
Reviewed-by: Xavier Perseguers
Reviewed-by: Bill Dagou
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

Each database table has configured title column through
TCA configuration. This values are used by List Module
to render first (title) column on records list table.

Long values are truncated to some predefined number of
characters but since we now use larger font size (12px
instead of 11px), long titles can break to two lines due
to a fixed 300px column size.

This change increases title column width to 350px to
cope with the increased font size.

Resolves: #55406
Releases: 6.2
Change-Id: Ib8277a88bd831a0f0efea40d9500df7df06dc40e
Reviewed-on: https://review.typo3.org/27107
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Change-Id: I3892f88bdd094b390a22fe94d9b089bd9b8aef71
Resolves: #54112
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/27102
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-by: Xavier Perseguers
Reviewed-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Change-Id: I623d243ea504b0e646bd969e55ed7686ad3e9caf
Releases: 6.2, 6.1, 6.0
Resolves: #55407
Reviewed-on: https://review.typo3.org/27106
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

In the installer fatals can happen during updates of
very outdated extensions. Many updates can lead to a
redirect to the extension check where the user gets
displayed a message that a fatal has been detected.
But the detected fatal error itself is not displayed.

This patch passes the error as url parameter to the
extension check and displays it there.

Fixes: #54943
Releases: 6.2
Change-Id: I111df5d5411015b21c4b2b5e9be3b83b311c8bc5
Reviewed-on: https://review.typo3.org/26781
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Reviewed-by: Thomas Maroschik
Reviewed-by: Wouter Wolters
Reviewed-by: Stefan Neufeind
Reviewed-by: Markus Klein
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Functional test bootstrap creates a full new instance
within typo3temp together with an own database. Goal is
a controlled environment without dependencies to the
parent instance.

The patch introduces separation of PackageStates.php. The file
is now compiled based on a static list of active core extensions
and optional additional extensions for specific functional tests.

Change-Id: I39e37a16b5cef5b6b1dab2ce3c4e8efc42cecbe7
Resolves: #55409
Releases: 6.2
Reviewed-on: https://review.typo3.org/27108
Reviewed-by: Thomas Maroschik
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Remove two count calls in the often called stdWrap function
to increase the performance. Furthermore remove the
is_callable calls, because the hook interface take care
that the methods exist and are callable.

Resolves: #55372
Releases: 6.2
Change-Id: Ifc8f831a7b101c5c56f717c23024fae7b71b71a9
Reviewed-on: https://review.typo3.org/27078
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Michiel Roos
Tested-by: Michiel Roos
Reviewed-by: Xavier Perseguers
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack

If lockSSL is set to 1 and the backend is not
accessed via SSL currently a 404 header is sent
with no message body. The same happens when the
client IP address does not mach the configured
list of allowed addresses.

Give a more useful hint for users in these cases
by throwing an Exception.

Resolves: #51378
Releases: 6.2
Change-Id: Ic76d8415c482e78bdea7e57e1cb5dab21a49969f
Reviewed-on: https://review.typo3.org/26718
Reviewed-by: Michiel Roos
Tested-by: Michiel Roos
Tested-by: Georg Ringer
Reviewed-by: Oliver Klee
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Marcin Sągol
Reviewed-by: Felix Kopp
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

The introduction of a TypeConverter for Enumaration
types in #52762 added is_subclass() calls to
getPlainValue() in the DatabaseBackends. These methods
are meant to convert objects to simply types but are
regularly called with simple types, in particular strings.

Since is_subclass() also works with strings,
The class loader is triggered when these methods
are called with a table name like "tx_ext_domain_model_foo".

This triggers an issue #55418 in the class loader especially
on case insensitive filesystems.

Instead of is_subclass we now use instanceof to make sure
we only check for conversion if the value is an object.

Additionally this change fixes a wrong case statement which
also was introduced in #52762

Resolves: #54275
Change-Id: If1b2a28a2623e49dfb47720641935c6f24447c19
Reviewed-on: https://review.typo3.org/27079
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

The JavaScriptEncoder class is used a lot in the TYPO3 backend. It does
expensive character conversions, character by character.

It would improve performance a lot if we use PHP native json_encode to do
the encoding for us.

Change-Id: I3cb3bd6d887d49565fda496f9b13852cbeb9dfa1
Resolves: #54560
Releases: 6.2
Reviewed-on: https://review.typo3.org/26545
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Michiel Roos
Tested-by: Michiel Roos
Reviewed-by: Marcin Sągol
Tested-by: Marcin Sągol
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind