[TASK] Add declare(strict_types=1) in all FunctionalTests

Strip declare declaration from concatenated ext_localconf files.

Resolves: #94739
Releases: master
Change-Id: I006278888b950a3a4aa105dc6bb822390cd29aef
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70281


Tested-by: core-ci <typo3@b13.com>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benni Mack <benni@typo3.org>

typo3/sysext/backend/Tests/Functional/Clipboard/ClipboardTest.php

 <?php
 
+declare(strict_types=1);
+
 /*
  * This file is part of the TYPO3 CMS project.
  *

typo3/sysext/backend/Tests/Functional/Configuration/SiteConfiguration/Fixtures/Extensions/conf_overriding/a/ext_emconf.php

 <?php
 
+declare(strict_types=1);
+
 $EM_CONF[$_EXTKEY] = [
     'title' => '',
     'description' => '',

typo3/sysext/backend/Tests/Functional/Configuration/SiteConfiguration/Fixtures/Extensions/conf_overriding/b/ext_emconf.php

 <?php
 
+declare(strict_types=1);
+
 $EM_CONF[$_EXTKEY] = [
     'title' => '',
     'description' => '',

typo3/sysext/backend/Tests/Functional/Controller/FormInlineAjaxControllerTest.php

 <?php
 
+declare(strict_types=1);
+
 /*
  * This file is part of the TYPO3 CMS project.
  *

typo3/sysext/backend/Tests/Functional/Form/FormTestService.php

 <?php
 
+declare(strict_types=1);
+
 /*
  * This file is part of the TYPO3 CMS project.
  *
@@ -59,6 +61,6 @@ class FormTestService
      */
     public function formHtmlContainsField(string $fieldName, string $formHtml): bool
     {
-        return strpos($formHtml, '[' . $fieldName . ']');
+        return (bool)strpos($formHtml, '[' . $fieldName . ']');
     }
 }

typo3/sysext/core/Classes/Utility/ExtensionManagementUtility.php

@@ -1548,6 +1548,7 @@ tt_content.' . $key . $suffix . ' {
         $phpCodeToCache = implode(LF, $phpCodeToCache);
         // Remove all start and ending php tags from content
         $phpCodeToCache = preg_replace('/<\\?php|\\?>/is', '', $phpCodeToCache);
+        $phpCodeToCache = preg_replace('/declare\\s?+\\(\\s?+strict_types\\s?+=\\s?+1\\s?+\\);/is', '', (string)$phpCodeToCache);
         $codeCache->set(self::getExtLocalconfCacheIdentifier(), $phpCodeToCache);
     }
 

typo3/sysext/core/Tests/Functional/Cache/Backend/MemcachedBackendTest.php

 <?php
 
+declare(strict_types=1);
+
 /*
  * This file is part of the TYPO3 CMS project.
  *

typo3/sysext/core/Tests/Functional/Cache/Backend/RedisBackendTest.php

 <?php
 
+declare(strict_types=1);
+
 /*
  * This file is part of the TYPO3 CMS project.
  *

typo3/sysext/core/Tests/Functional/Cache/Backend/Typo3DatabaseBackendTest.php

 <?php
 
+declare(strict_types=1);
+
 /*
  * This file is part of the TYPO3 CMS project.
  *

typo3/sysext/core/Tests/Functional/Cache/Core/ClassAliasLoaderTest.php

 <?php
 
+declare(strict_types=1);
+
 /*
  * This file is part of the TYPO3 CMS project.
  *

typo3/sysext/core/Tests/Functional/Cache/Core/Fixtures/Extensions/aliases_test/Migrations/Code/ClassAliasMap.php

 <?php
 
+declare(strict_types=1);
+
 return [
     'TYPO3\\CMS\\Fluid\Core\\ViewHelper\\AliasAbstractViewHelper' => \TYPO3Fluid\Fluid\Core\ViewHelper\AbstractViewHelper::class,
 ];

typo3/sysext/core/Tests/Functional/Cache/Core/Fixtures/Extensions/aliases_test/ext_emconf.php

 <?php
 
+declare(strict_types=1);
+
 $EM_CONF[$_EXTKEY] = [
     'title' => '',
     'description' => '',

typo3/sysext/core/Tests/Functional/Cache/Frontend/VariableFrontendTest.php

 <?php
 
+declare(strict_types=1);
+
 /*
  * This file is part of the TYPO3 CMS project.
  *

typo3/sysext/core/Tests/Functional/Category/Collection/CategoryCollectionTest.php

 <?php
 
+declare(strict_types=1);
+
 /*
  * This file is part of the TYPO3 CMS project.
  *

typo3/sysext/core/Tests/Functional/Category/Collection/Fixtures/Extensions/test/Configuration/TCA/tx_test_test.php

 <?php
 
+declare(strict_types=1);
+
 return [
     'ctrl' => [],
     'columns' => [],

typo3/sysext/core/Tests/Functional/Category/Collection/Fixtures/Extensions/test/ext_emconf.php

 <?php
 
+declare(strict_types=1);
+
 $EM_CONF[$_EXTKEY] = [
     'title' => 'test extension',
     'description' => '',

typo3/sysext/core/Tests/Functional/DataHandling/AbstractDataHandlerActionTestCase.php

 <?php
 
+declare(strict_types=1);
+
 /*
  * This file is part of the TYPO3 CMS project.
  *

typo3/sysext/core/Tests/Functional/DataHandling/DataHandler/DeleteTranslatedSubpagesTest.php

 <?php
 
+declare(strict_types=1);
+
 /*
  * This file is part of the TYPO3 CMS project.
  *

typo3/sysext/core/Tests/Functional/DataHandling/FAL/AbstractActionTestCase.php

 <?php
 
+declare(strict_types=1);
+
 /*
  * This file is part of the TYPO3 CMS project.
  *

typo3/sysext/core/Tests/Functional/DataHandling/FAL/Modify/ActionTest.php

 <?php
 
+declare(strict_types=1);
+
 /*
  * This file is part of the TYPO3 CMS project.
  *