Skip to content
Snippets Groups Projects
Commit e02e8ef2 authored by Benjamin Kott's avatar Benjamin Kott Committed by Stefan Bürk
Browse files

[TASK] Fix acceptence tests window size with php-webdriver 1.15

The configured browser capabilities (`chromeOptions`) are passed by
`codeception/module-webdriver` to `php-webdriver` as is.
php-webdriver expects the PHP constant ChromeOptions::CAPABILITY to be
used instead of hardcoding any strings. Therefore php-webdriver 1.15
changed this constants value from `chromeOptions` to
`goog:chromeOptions` [1], which means that the option `chromeOptions`
is no longer respected and the configured window size (and the headless
flag) is ignored.

We now use the newer W3C webdriver comaptible `goog:chromeOptions`
option and define window size definition via codeception's respective
option `window_size` while we are at it.

[1] https://github.com/php-webdriver/php-webdriver/commit/235c2aa07

Resolves: #103081
Releases: main, 12.4
Change-Id: Iec345b5ec0226d38b62081aa8c3a51dd3100bdb7
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82840


Tested-by: default avatarOliver Klee <typo3-coding@oliverklee.de>
Tested-by: default avatarBenjamin Franzke <ben@bnf.dev>
Reviewed-by: default avatarOliver Klee <typo3-coding@oliverklee.de>
Tested-by: default avatarStefan Bürk <stefan@buerk.tech>
Reviewed-by: default avatarBenjamin Franzke <ben@bnf.dev>
Reviewed-by: default avatarStefan Bürk <stefan@buerk.tech>
Tested-by: default avatarcore-ci <typo3@b13.com>
parent bf7bb906
Branches
Tags
No related merge requests found
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment