Skip to content
Snippets Groups Projects
Commit 280bbccb authored by Benni Mack's avatar Benni Mack Committed by Wouter Wolters
Browse files

[BUGFIX] Do not depend on global TSFE for link generation

Handing in the dependency of TSFE into
AbstractLinkBuilder allows to use a custom TSFE
object, when working within middlewares (e.g. Redirects)
thus, not depending on global state directly.

As a drive-by-fix, using AbstractTypolinkBuilder now does not
generate a global TSFE anymore, which can have ugly side-effects.

Tests are now simplified because the original constructor can be
called directly instead of relying on $GLOBALS[TSFE].

Resolves: #87143
Releases: master, 9.5
Change-Id: I77f2da501d1a78f0579626ebb50ef47a0026f1f7
Reviewed-on: https://review.typo3.org/59036


Reviewed-by: default avatarDaniel Goerz <daniel.goerz@posteo.de>
Tested-by: default avatarDaniel Goerz <daniel.goerz@posteo.de>
Tested-by: default avatarTYPO3com <no-reply@typo3.com>
Reviewed-by: default avatarAndreas Wolf <andreas.wolf@typo3.org>
Reviewed-by: default avatarJörg Bösche <typo3@joergboesche.de>
Reviewed-by: default avatarWouter Wolters <typo3@wouterwolters.nl>
Tested-by: default avatarWouter Wolters <typo3@wouterwolters.nl>
parent 8119b978
Branches
Tags
No related merge requests found
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment