[BUGFIX] Do not depend on global TSFE for link generation
Handing in the dependency of TSFE into AbstractLinkBuilder allows to use a custom TSFE object, when working within middlewares (e.g. Redirects) thus, not depending on global state directly. As a drive-by-fix, using AbstractTypolinkBuilder now does not generate a global TSFE anymore, which can have ugly side-effects. Tests are now simplified because the original constructor can be called directly instead of relying on $GLOBALS[TSFE]. Resolves: #87143 Releases: master, 9.5 Change-Id: I77f2da501d1a78f0579626ebb50ef47a0026f1f7 Reviewed-on: https://review.typo3.org/59036 Reviewed-by:Daniel Goerz <daniel.goerz@posteo.de> Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Andreas Wolf <andreas.wolf@typo3.org> Reviewed-by:
Jörg Bösche <typo3@joergboesche.de> Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
Wouter Wolters <typo3@wouterwolters.nl>
Showing
- typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php 2 additions, 1 deletion.../frontend/Classes/ContentObject/ContentObjectRenderer.php
- typo3/sysext/frontend/Classes/Typolink/AbstractTypolinkBuilder.php 25 additions, 16 deletions...ext/frontend/Classes/Typolink/AbstractTypolinkBuilder.php
- typo3/sysext/frontend/Tests/Unit/Typolink/AbstractTypolinkBuilderTest.php 4 additions, 10 deletions...ntend/Tests/Unit/Typolink/AbstractTypolinkBuilderTest.php
- typo3/sysext/redirects/Classes/Service/RedirectService.php 2 additions, 1 deletiontypo3/sysext/redirects/Classes/Service/RedirectService.php
Please register or sign in to comment