Skip to content
Snippets Groups Projects
Commit 1ac0809a authored by Tilo Baller's avatar Tilo Baller Committed by Helmut Hummel
Browse files

[BUGFIX] Add "suggests" as valid dependency type

Currently extensions with "suggests" contraint in ext_emconf.php
fail to install in Extension Manager with exception
"suggestwas not a valid dependency type.".

Example (taken from EXT:saltedpasswords ext_emconf.php):
    'constraints' => array(
        [...]
        'suggests' => array(
            'rsaauth' => ''
        )
    ),

NOTE: This patch does not implement the missing handling
for suggested extensions.

Fixes: #42594
Releases: 6.0

Change-Id: I326de368508c5c9a350d7b7e84b07f3bc1582437
Reviewed-on: http://review.typo3.org/16367
Reviewed-by: Francois Suter
Tested-by: Francois Suter
Reviewed-by: Oliver Hader
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
parent 198c4234
No related merge requests found
......@@ -60,7 +60,8 @@ class Dependency extends \TYPO3\CMS\Extbase\DomainObject\AbstractEntity {
*/
static protected $dependencyTypes = array(
'depends',
'conflicts'
'conflicts',
'suggests'
);
/**
......@@ -125,7 +126,7 @@ class Dependency extends \TYPO3\CMS\Extbase\DomainObject\AbstractEntity {
if (in_array($type, self::$dependencyTypes)) {
$this->type = $type;
} else {
throw new \TYPO3\CMS\Extensionmanager\Exception\ExtensionManagerException($type . 'was not a valid dependency type.');
throw new \TYPO3\CMS\Extensionmanager\Exception\ExtensionManagerException($type . ' was not a valid dependency type.');
}
}
......
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment