From 1ac0809a50912a490f09d35d23e50b7c9d03d8d8 Mon Sep 17 00:00:00 2001
From: Tilo Baller <baller@cosmocode.de>
Date: Fri, 9 Nov 2012 21:14:41 +0100
Subject: [PATCH] [BUGFIX] Add "suggests" as valid dependency type
Currently extensions with "suggests" contraint in ext_emconf.php
fail to install in Extension Manager with exception
"suggestwas not a valid dependency type.".
Example (taken from EXT:saltedpasswords ext_emconf.php):
'constraints' => array(
[...]
'suggests' => array(
'rsaauth' => ''
)
),
NOTE: This patch does not implement the missing handling
for suggested extensions.
Fixes: #42594
Releases: 6.0
Change-Id: I326de368508c5c9a350d7b7e84b07f3bc1582437
Reviewed-on: http://review.typo3.org/16367
Reviewed-by: Francois Suter
Tested-by: Francois Suter
Reviewed-by: Oliver Hader
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
---
.../extensionmanager/Classes/Domain/Model/Dependency.php | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/typo3/sysext/extensionmanager/Classes/Domain/Model/Dependency.php b/typo3/sysext/extensionmanager/Classes/Domain/Model/Dependency.php
index 106f536438be..9e03f851bae6 100644
--- a/typo3/sysext/extensionmanager/Classes/Domain/Model/Dependency.php
+++ b/typo3/sysext/extensionmanager/Classes/Domain/Model/Dependency.php
@@ -60,7 +60,8 @@ class Dependency extends \TYPO3\CMS\Extbase\DomainObject\AbstractEntity {
*/
static protected $dependencyTypes = array(
'depends',
- 'conflicts'
+ 'conflicts',
+ 'suggests'
);
/**
@@ -125,7 +126,7 @@ class Dependency extends \TYPO3\CMS\Extbase\DomainObject\AbstractEntity {
if (in_array($type, self::$dependencyTypes)) {
$this->type = $type;
} else {
- throw new \TYPO3\CMS\Extensionmanager\Exception\ExtensionManagerException($type . 'was not a valid dependency type.');
+ throw new \TYPO3\CMS\Extensionmanager\Exception\ExtensionManagerException($type . ' was not a valid dependency type.');
}
}
--
GitLab