Booleans should be written in uppercase.

Change-Id: Ib29abc6e1e658e3a1b65cd1873a3a3edac7dba57
Resolves: #26346
Releases: 4.6
Reviewed-on: http://review.typo3.org/1790
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

The test fixPermissionsSetsPermissionsWithRelativeFileReference
(t3lib_divTest) used a (wrong) relative path to a test file in the chmod
call. Thus the test failed.

Prepend PATH_site have the correct absolute path.

Change-Id: Ifab5649272952a626381e8562ca018d087efc789
Resolves: #26423
Reviewed-on: http://review.typo3.org/1780
Reviewed-by: Peter Beernink
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

The unit test cropIsMultibyteSafe (class tslib_contentTest) fails, if
error reporting includes E_WARNING. In this case mb_strlen() throws an
error, as it is called with an empty string as second parameter
$charset. Initializing $GLOBALS['TSFE']->renderCharset in the setUp
method solves this.

Change-Id: If04278e3cbd01ad2f4b6b02c1b3df7cf89b251f0
Resolves: #26491
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/1785
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader

When EXT:felogin is not installed, a FE login content element is available, that is
out of date and should not be used anymore.
As we ship felogin since 4.2 and install it by default, the default login form is
useless and confusing.

Thanks to naw.info for sponsoring 135 beers at the bug auction for this fix.

Change-Id: I765b3d391b06dac34550f46f19992c9cf9d1c5c7
Resolves: #22408
Reviewed-on: http://review.typo3.org/1369
Reviewed-by: Björn Pedersen
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert

Additionally throw exceptions instead of a return string if directory could
not be created.

Change-Id: I90da96e1b62d28997573d821c62b7b24b3ef2ba3
Resolves: #26240
Depends: #26230
Releases: 4.6
Reviewed-on: http://review.typo3.org/1716
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog

The message has TYPO3_CONF_VARS['SYS']['requiredExt'] instead of
TYPO3_CONF_VARS['EXT']['requiredExt'] as in config_default.php.

Change-Id: I46a3559b4b4da028b55b8cc8cda63aaa81fb91ea
Resolves: #26354
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/1765
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Change "$includeEmtpyValues" into "$includeEmptyValues"

Change-Id: I8527373b7b5934025f8ef44bde8ef76ee9036a07
Resolves: #26351
Releases: 4.5, 4.6
Reviewed-on: http://review.typo3.org/1763
Reviewed-by: Björn Pedersen
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Change "else if" into "elseif"
This is a follow-up because I forgot one "else if".

Change-Id: I51eeab3ced57a7f9ffc84ad05ee952e529ed533b
Resolves: #26295
Releases: 4.6
Reviewed-on: http://review.typo3.org/1731
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Change "else if" into "elseif"

Change-Id: I7db545131851b2bb99dfe25c80fef6b26f5504dd
Resolves: #26295
Releases: 4.6
Reviewed-on: http://review.typo3.org/1725
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

The methods addReplyTo and addCc accept strings as parameters, but we
need the setReplyTo and setCc which accept arrays. This will make the
reply-to and recipient-copy options work in formMail.

Change-Id: Ia3826d51f53ffe497f4c3b25957f0332fb89e81e
Resolves: #25301
Releases: 4.6
Reviewed-on: http://review.typo3.org/1442
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Adds a helper functions for easier handling of arrays.
New class t3lib_utility_Array adds a method to reduce an
array by a search value.
New method in t3lib_extMgm adds a method to add new items
to a TCA select list at a spcified position.

Change-Id: I589294525a7eacc7af6e54c5b78f5ee411574f12
Resolves: #26069
Relates: #22408
Reviewed-on: http://review.typo3.org/1647
Reviewed-by: Alexander Stehlik
Tested-by: Alexander Stehlik
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

A few files are containing inconsistent linebreaks.
Since all of these files are taken from external projects,
someone needs to make sure that they get fixed during future
imports.

Change-Id: I49e482add2f991356a4ad335f13c9c60719e9e44
Resolves: #26126
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/1661
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Change-Id: Ib8dd5576d4400cb4da38c86384ce6dd31f734508
Resolves: #25709
Reviewed-on: http://review.typo3.org/1408
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Add new unit tests for mkdir_deep() to document current behavior.
Clean up variable names in mkdir_deep (no functional change).

Change-Id: Ied48fbb5c23d7e9152464b4f71ace60be04f6074
Resolves: #26230
Depends: #26228
Releases: 4.6
Reviewed-on: http://review.typo3.org/1714
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Remove code from t3lib_div::fixPermissions and t3lib_div::mkdir that remove
a trailing slash from a given directory. This was a workaraund for PHP functions
like mkdir, they fail with trailing slashes if safe_mode is on.
Additionally the according unit tests are cleaned up and completed.

Change-Id: I44b330a3542bfd172736b103feec895b46494346
Resolves: #26228
Related: #25332
Releases: 4.6
Reviewed-on: http://review.typo3.org/1713
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

It is neccessary to hold more than 120 characters in redirectTo field,
thus changes in ext_table.sql and tbl_cms.php are neccessary. This fix
changes the max-value to 255 chars.

Resolves #25780
Releases 4.6

Change-Id: I228f636b529ca75c9b1820a8cff622970b00cd42
Reviewed-on: http://review.typo3.org/1472
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Stefano Kowalke
Reviewed-by: Björn Pedersen
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog

According to CGL the files which contain a class must have a prefix "class." in filename.

Change-Id: I1b636b6b64e7202d4c6fc4a6741478817295ce99
Resolves: #26231
Related: #25868
Releases: 4.6
Reviewed-on: http://review.typo3.org/1715
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

The file SVNreadme.txt in the root of the repository contains
information, which should help people coming from older versions bevore
4.0 and using an SVN checkout.

Not only the name is outdated, most of the information is also wrong.
So remove this file.

Change-Id: If08c6b835278d2bb2b83f100f9f68a60406d1cae
Reviewed-on: http://review.typo3.org/1706
Reviewed-by: Stefano Kowalke
Tested-by: Stefano Kowalke
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

TYPO3_DB must be added to $backupGlobalsBlacklist.

Change-Id: I1a4642d563f67582f5a300859a2ecc2ae2e96390
Resolves: #26174
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/1700
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

This is a CGL cleanup.

Change-Id: I761fe8983c35e2dbe002728c54d547e590004d26
Resolves: #26173
Releases: 4.6
Reviewed-on: http://review.typo3.org/1698
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Change-Id: I8fd91f031634e43a34ab1d3b75869452a8dd4d6a
Resolves: #25090
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/1696
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

This is a CGL cleanup.

Change-Id: I30ef7ff173b91a14f8562c094ed071917a4918cb
Resolves: #26171
Releases: 4.6
Reviewed-on: http://review.typo3.org/1693
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

This is a CGL cleanup to get rid of all trailing newlines at EOF.

Change-Id: I905d04317303f000a5e71eaf61973bf7cadea119
Resolves: #26162
Releases: 4.6
Reviewed-on: http://review.typo3.org/1684
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Change-Id: Ic068f31188e09e9d55cc7ada246e5d192a70fbc7
Resolves: #26164
Releases: 4.6
Reviewed-on: http://review.typo3.org/1685
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert

The HTML template for EXT:felogin should be configurable.

Therefore, add a new constant to css_styled_content named
styles.content.loginform.templateFile

As default it holds the previously hardcodede value from
EXT:felogin/ext_typoscript_setup.txt (EXT:felogin/template.html)

Change-Id: I98a55c3d2ed9f782450436194f95275e0ee307c7
Resolves: #26103
Reviewed-on: http://review.typo3.org/1658
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

the register['count_menuItems'] is set, before a possible userfunc filters the menu items -> wrong register value.

Solution: change call sequence

Change-Id: I0425d04602110a5f6707022cb88077cc75e81f02
Resolves: #25405
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/1471
Reviewed-by: Tolleiv Nietsch
Reviewed-by: Frederic Gaus
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

tslib_menu_filterMenuPagesHook::tslib_menu_filterMenuPagesHook expects a
tslib_tmenu object as fourth parameter $obj.
$obj should hint for tslib_menu and not as wrongly specified tslib_tmenu.
If hook is used and for example a GMENU will be processed an exception
will be thrown.

Change-Id: I0a61737755afbda6e2ab6c02ba59c078a77cc020
Resolves: #25979
Releases: 4.6, 4.5, 4.4
Reviewed-on: http://review.typo3.org/1649
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

According to the CGL the files which contains a class must have a prefix "class." in filename.

Change-Id: I5ac0214236dc248a7d2b37d5981278fd65bc6c91
Resolves: #25868
Releases: 4.6
Reviewed-on: http://review.typo3.org/1646
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

When editing TypoScript in the template module and using the "Include
TypoScript file content" option with more than 9 files, then the 10th
and all later files gets screwed up.

Thanks to André Spindler for reporting and providing a patch.
Thanks to Kilian Hann (futureconnection AG Zürich) for sponsoring
100 beers during the bug auction.

Change-Id: I2b1363506e5b01a9fb8fa47b792d3351d302eaa9
Resolves: #25374
Reviewed-on: http://review.typo3.org/1362
Reviewed-by: Michael Stucki
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Reviewed-by: Sebastian Fischer
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Change-Id: Iae45d949855ceec1e9dc9bf6e27d4885749375d5
Resolves: #25332
Reviewed-on: http://review.typo3.org/1447
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog

Global declaration such as global $TCA or global $BE_USER should
be changed to $GLOBALS['TCA'], $GLOBALS['BE_USER'], ...

Change-Id: I68f801ff6934a7e16db78cb3f10d1c2b64aef351
Fixes: #25334
Reviewed-on: http://review.typo3.org/1446
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Tested-by: Christian Kuhn
Reviewed-by: Christian Kuhn

This change makes it possible to write unit tests for "tx_scheduler_module".

Change-Id: I85b977687c24966aadba11248a58ee081b8bef67
Resolves: #25925
Releases: 4.6
Reviewed-on: http://review.typo3.org/1588
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

The value of the FF field "Forgot Password Message" in felogin is not working. Solution is to rename FF field name from "forgot_message" to "forgot_reset_message".

Change-Id: I5a08196f8a26c73a27b65d3456e242ea86fc5707
Resolves: #23134
Releases: 4.6, 4.5, 4.4, 4.3
Reviewed-on: http://review.typo3.org/1285
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Using PHP_SCRIPT_INT throws an Exception "Expected parameter
$conf['scriptSuffix'] was not given.", in its render() method.

As the parameter is useless and not used in other places, this check
can be removed.

Change-Id: I64fd656e0af78e711290aea597353c7194dd613d
Resolves: #25145
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/1466
Reviewed-by: Björn Pedersen
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Adding the requested URL in the log message for uncaught Exceptions can
ease the task of finding the particular page causing an error.

Change-Id: I39ffb7943c39a406c651dc30b2b2351347f0cad4
Resolves: #25924
Reviewed-on: http://review.typo3.org/1587
Reviewed-by: Stefano Cecere
Tested-by: Tim Duelken
Reviewed-by: Andy Grunwald
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Simply removes the console.log debugging output. This line causes
JavaScript errors if there is no console object present.

Change-Id: I060b96f47b95d4265899ccff027009fe54f565cb
Resolves: #25721
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/1584
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader

The method fixUsername() is defined as private, but should be
protected instead.

Change-Id: I0513416a0d1cf07793708e86e7f1c7fde619f4d5
Resolves: #25219
Releases: 4.6, 4.5, 4.4
Reviewed-on: http://review.typo3.org/1104
Reviewed-by: Jacob Rasmussen
Tested-by: Jacob Rasmussen
Reviewed-by: Oliver Klee
Reviewed-by: Andy Grunwald
Tested-by: Andy Grunwald
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

For changes to CSS Styled Content in TYPO3 version 4.6 we need new
static templates and a compatibility version.

Change-Id: I4e36f465c057982ed3b66ceffe8fcc9b4ff6a73c
Resolves: #25606
Reviewed-on: http://review.typo3.org/1363
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

The module DB check > Record statistics is using old icons for
pages. Additionally the icons for the different doktypes are
broken.

Change-Id: I64de9b55bf0a2fe32378aa9ce9c7bf3756da1224
Resolves: #24835
Releases: 4.6, 4.5, 4.4
Reviewed-on: http://review.typo3.org/1530
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader

Disable the TCA Tree if $PA['fieldConf']['config']['readOnly'] is true.
This happens for example in translations of records if
$TCA['my_table']['columns']['my_column']['l10n_display'] = 'defaultAsReadonly'.

Change-Id: I18195bbc3fc6369d56669a5fd5c81103140e7a6c
Resolves: #25888
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/1548
Reviewed-by: Marco Huber
Tested-by: Marco Huber
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader