Skip to content
Snippets Groups Projects
  1. Jan 21, 2014
    • Benjamin Mack's avatar
      [TASK] Move Tidy functionality to a TER ext · f8b812dd
      Benjamin Mack authored
      As discussed in the Core newsgroup, the Tidy functionality
      should be removed from the TYPO3 CMS Core. The checks
      and options are removed, and a NEWS note is added. An
      already released replacement was added to the TER.
      
      As the importance is very low, and the drop-in
      replacement in the TER fits nicely, IMHO there is no need
      for an upgrade wizard, as nothing breaks if the
      functionality is missing.
      Every upgrader should read the NEWS anyway in order
      to know what to do to have the functionality back.
      
      Releases: 6.2
      Resolves: #55190
      Change-Id: I3101b7e09f36cbaa63b6b5d8930f61242e4e2cc6
      Reviewed-on: https://review.typo3.org/26952
      Reviewed-by: Wouter Wolters
      Reviewed-by: Markus Klein
      Tested-by: Markus Klein
      Reviewed-by: Georg Ringer
      Tested-by: Georg Ringer
      f8b812dd
  2. Jan 20, 2014
    • Philipp Gampe's avatar
      [TASK] Streamline usage of BackendUtility::getPagesTSconfig() · fb91cb8c
      Philipp Gampe authored
      Avoid calling BackendUtility::getPagesTSconfig() with default or useless
      parameters.
      
      Resolves: #53502
      Releases: 6.2
      Change-Id: I842c33022a00f5633b1ef5a250d143b6a253dde1
      Reviewed-on: https://review.typo3.org/25249
      Reviewed-by: Markus Klein
      Tested-by: Markus Klein
      Reviewed-by: Benjamin Mack
      Tested-by: Benjamin Mack
      fb91cb8c
    • Georg Ringer's avatar
      [BUGFIX] Improve layout of Install Tool with long lines · 97e53286
      Georg Ringer authored
      There might be situation where very long 'words' (line text without
      spaces) are rendered in System environment check and that leads to some
      visual issues.
      
      As a solution apply a CSS rule to break the text.
      
      Change-Id: Ic096a6a81052f42787cea93a88e05665b50dce5e
      Resolves: #55120
      Releases: 6.2
      Reviewed-on: https://review.typo3.org/26937
      Reviewed-by: Marcin S?gol
      Tested-by: Marcin S?gol
      Reviewed-by: Benjamin Rau
      Tested-by: Benjamin Rau
      Reviewed-by: Wouter Wolters
      Tested-by: Wouter Wolters
      97e53286
    • Markus Klein's avatar
      [BUGFIX] Flow\Utility\Exception missing · 06685fd3
      Markus Klein authored
      This exception is required by PackageManager
      
      Resolves: #55132
      Releases: 6.2
      Change-Id: I80d966d581da78802dffd15c6bf27f50633a2f35
      Reviewed-on: https://review.typo3.org/26925
      Reviewed-by: Oliver Klee
      Reviewed-by: Wouter Wolters
      Tested-by: Wouter Wolters
      Reviewed-by: Philipp Gampe
      Tested-by: Philipp Gampe
      06685fd3
    • Stefan Froemken's avatar
      [BUGFIX] Repair f:image VH for Backend · 2e463036
      Stefan Froemken authored
      ImageMagick command was executed from directory
      typo3/, but output file is relative and starts
      with typo3temp.
      This patch adds absolute path to output file
      when in BE mode.
      
      Resolves: #54886
      Releases: 6.2
      Change-Id: I6216a9bb74b9619c090c1ef70322cb6788a73c92
      Reviewed-on: https://review.typo3.org/26729
      Reviewed-by: Oliver Klee
      Reviewed-by: Xavier Perseguers
      Tested-by: Xavier Perseguers
      Reviewed-by: Marcin S?gol
      Tested-by: Marcin S?gol
      Reviewed-by: Stefan Neufeind
      Tested-by: Stefan Neufeind
      2e463036
    • Markus Klein's avatar
      [BUGFIX] TCA pages:subtitle is missing eval=trim · bf81f39a
      Markus Klein authored
      The TCA pages misses 'trim' as eval setting for column subtitle.
      The title field and the subtitle field of pages_language_overlay
      already have a trim setting applied.
      
      Releases: 6.2, 6.1, 6.0, 4.7, 4.5
      Resolves: #55113
      Change-Id: Icfa441c0010214e3718ed6923ffd7443ce032f81
      Reviewed-on: https://review.typo3.org/26933
      Reviewed-by: Wouter Wolters
      Tested-by: Wouter Wolters
      Reviewed-by: Marcin S?gol
      Reviewed-by: Oliver Klee
      Reviewed-by: Georg Ringer
      Tested-by: Georg Ringer
      bf81f39a
  3. Jan 19, 2014
    • Felix Kopp's avatar
      [TASK] Make use of .t3-table in EXT: beuser *compare · 82ce800d
      Felix Kopp authored
      Use <table class="t3-table"> in backend module compare view.
      
      Change-Id: Icd8fb361a61c6bbfd933fc4b1b011838f18868e8
      Resolves: #55139
      Releases: 6.2
      Reviewed-on: https://review.typo3.org/26929
      Reviewed-by: Marcin S?gol
      Tested-by: Marcin S?gol
      Reviewed-by: Wouter Wolters
      Tested-by: Wouter Wolters
      82ce800d
    • Claus Due's avatar
      [TASK] Remove css_styled_content legacy templates before 4.5 · 849fc573
      Claus Due authored
      This change simply removes legacy files - no other changes.
      
      Resolves: #54621
      Releases: 6.2
      Change-Id: Ief7287eee5a2f6ccfecdb274ae7c54a04f1a2247
      Reviewed-on: https://review.typo3.org/26573
      Reviewed-by: Nikolas Hagelstein
      Reviewed-by: Helmut Hummel
      Reviewed-by: Marcin S?gol
      Tested-by: Marcin S?gol
      Reviewed-by: Tom Ruether
      Tested-by: Tom Ruether
      Reviewed-by: Felix Kopp
      Reviewed-by: Steffen Ritter
      Tested-by: Steffen Ritter
      849fc573
    • Benjamin Mack's avatar
      [TASK] Cache menu needs clear namings and permissions · 1b83cad8
      Benjamin Mack authored
      With the introduction of the grouping mechanisms of the
      caching framework and the sensitivity of the system
      caches group, the re-ordering and re-naming of cache
      menu entries is necessary to ensure that admins and
      editors use the caching mechanisms right.
      
      Therefore there are new labels as well as "Clear all caches"
      below "Clear page content" as it has a higher impact on
      the system. The option to clear the Configuration Cache
      / System Caches is now disabled by default, even for
      admins. It is active when the TSconfig option
      options.clearCache.system = 1 is set or if the system is in
      development context. This avoids slow page rendering
      after clearing the system caches.
      
      A new title attribute is added to explain the menu items
      when hovering.
      
      Resolves: #55119
      Releases: 6.2
      Change-Id: Ifd6026279a890b743c6c3cda09def19f9b7d59b7
      Reviewed-on: https://review.typo3.org/26912
      Reviewed-by: Philipp Gampe
      Tested-by: Philipp Gampe
      Reviewed-by: Marcin S?gol
      Tested-by: Marcin S?gol
      Reviewed-by: Wouter Wolters
      Tested-by: Wouter Wolters
      1b83cad8
    • Xavier Perseguers's avatar
      [BUGFIX] Broken links to online TSconfig in two language labels · 590ca478
      Xavier Perseguers authored
      Old links pointing to http://typo3.org/documentation/ should be updated
      and point to the official TYPO3 documentation.
      
      Fixes: #28808
      Releases: 6.2
      Change-Id: Id9943b23e5811bc2f00182111fed98cd17541fd6
      Reviewed-on: https://review.typo3.org/26932
      Reviewed-by: Markus Klein
      Tested-by: Markus Klein
      Reviewed-by: Wouter Wolters
      Tested-by: Wouter Wolters
      590ca478
    • Felix Kopp's avatar
      [TASK] Make use of .t3-table in EXT: wizard_sortpages · fcef7221
      Felix Kopp authored
      Use <table class="t3-table"> in backend module.
      Also removes few markups and improves CGL compliancy.
      
      Change-Id: I4f53affc0a6130965d8c3dc516ed800bc5094f50
      Resolves: #55131
      Releases: 6.2
      Reviewed-on: https://review.typo3.org/26926
      Reviewed-by: Philipp Gampe
      Tested-by: Philipp Gampe
      Reviewed-by: Wouter Wolters
      Tested-by: Wouter Wolters
      fcef7221
  4. Jan 18, 2014
    • Markus Klein's avatar
      [BUGFIX] Fatal error in indexed_search · 551d382f
      Markus Klein authored
      FileContentParser misses one backslash for RuntimeException
      to be in global namespace.
      Only master is affected, since backports got corrected already.
      
      Releases: 6.2
      Resolves: #55128
      Change-Id: I015c1236847c4963dd28f400d14a5fe97b7868e6
      Reviewed-on: https://review.typo3.org/26922
      Reviewed-by: Wouter Wolters
      Tested-by: Wouter Wolters
      Reviewed-by: Markus Klein
      Tested-by: Markus Klein
      551d382f
    • Xavier Perseguers's avatar
      [BUGFIX] Cannot download manuals · f5aae21a
      Xavier Perseguers authored
      Since the UX renaming, it is not possible anymore to download
      manuals from docs.typo3.org.
      
      Fixes: #55126
      Releases: 6.2
      Change-Id: Iee5d8fda83dc9ad6b9b2ecfa668f7587a99170ff
      Reviewed-on: https://review.typo3.org/26917
      Reviewed-by: Wouter Wolters
      Tested-by: Wouter Wolters
      f5aae21a
    • Philipp Gampe's avatar
      [TASK] Install Tool: System Information shows empty values · e68cc6f5
      Philipp Gampe authored
      Adopt the list such that either port or socket is shown.
      Print "default socket" for an empty socket definition.
      
      Resolves: #52712
      Releases: 6.2
      Change-Id: I28bd59f9f66ce314d31908c3790c9f75ca5e2a44
      Reviewed-on: https://review.typo3.org/24611
      Reviewed-by: Markus Klein
      Reviewed-by: Marcin S?gol
      Tested-by: Marcin S?gol
      Reviewed-by: Wouter Wolters
      Tested-by: Wouter Wolters
      e68cc6f5
    • Oliver Hader's avatar
      [BUGFIX] No placeholder attribute in backend forms · c631a58f
      Oliver Hader authored
      The disposal of the placeholder feature in backend forms needs
      to be enabled using the mode setting "useOrOverridePlaceholder"
      in TCA. However, the implementation for checking this needs to
      be inverted, since it returns an empty string if it's enabled,
      but should be the opposite way instead.
      
      Fixes: #53594
      Releases: 6.2, 6.1, 6.0
      Change-Id: I3d3fe5ac76c05f4601860c79d7f514bffea13963
      Reviewed-on: https://review.typo3.org/25365
      Reviewed-by: Markus Klein
      Tested-by: Markus Klein
      Reviewed-by: Wouter Wolters
      Tested-by: Wouter Wolters
      c631a58f
    • Nicole Cordes's avatar
      [BUGFIX] Hide update icon for incompatible extensions · 0d970a77
      Nicole Cordes authored
      Currently the update icon in extension manager is displayed every time
      a higher TER version of the extension exists. But the update fails if
      the TYPO3 version isn't within the extension dependencies. This patch
      adds the dependency check to the isUpdateAvailable function.
      
      Resolves: #53576
      Releases: 6.2
      Change-Id: I109e779037f670ab205b43cbbbb1bc16954860e6
      Reviewed-on: https://review.typo3.org/25348
      Reviewed-by: Philipp Gampe
      Reviewed-by: Marcin S?gol
      Tested-by: Marcin S?gol
      Reviewed-by: Oliver Klee
      Reviewed-by: Wouter Wolters
      Tested-by: Wouter Wolters
      0d970a77
  5. Jan 17, 2014
    • TYPO3 Release Team's avatar
      [TASK] Set TYPO3 version to 6.2-dev · 57ae843b
      TYPO3 Release Team authored
      Change-Id: If5e62f07957ac8a288e028df769eec912d9e134b
      Reviewed-on: https://review.typo3.org/26909
      Reviewed-by: TYPO3 Release Team
      Tested-by: TYPO3 Release Team
      57ae843b
    • TYPO3 Release Team's avatar
      [RELEASE] Release of TYPO3 6.2.0beta4 · 444ee47c
      TYPO3 Release Team authored
      Change-Id: If2de3be4d0ff90088e8e94fbb63c9632b700b147
      Reviewed-on: https://review.typo3.org/26908
      Reviewed-by: TYPO3 Release Team
      Tested-by: TYPO3 Release Team
    • Marcin Sągol's avatar
      [TASK] Remove fixed width for Content Element Wizard tabs content container · 6860bcc3
      Marcin Sągol authored
      When using Content Element Wizard configured to render items with
      tabs their body container has fixed width of 680px. This leads
      to visual problems when using some extra tabs registered - their
      titles are rendered outside body content. This patch removes
      fixed width and some other styles that are not needed. For example
      there are some styles for tables inside tab content but items are
      rendered in lists not tables so we can remove them.
      
      Change-Id: I1d749649ffa86cd2220460f1ebf4894aca98f4bc
      Resolves: #53904
      Releases: 6.2
      Reviewed-on: https://review.typo3.org/26906
      Reviewed-by: Markus Klein
      Tested-by: Markus Klein
      Reviewed-by: Marcin S?gol
      Tested-by: Marcin S?gol
      Reviewed-by: Ernesto Baschny
      Tested-by: Ernesto Baschny
      6860bcc3
    • Alexander Stehlik's avatar
      [BUGFIX] Handle empty tags in language pack index files · 62346415
      Alexander Stehlik authored
      This patch adds a check to the L10n index parser to consider
      whether the value of an XML tag is empty or contains only
      spaces. In this case it is not included in the resulting array.
      
      Resolves: #41450
      Releases: 6.2, 6.1, 6.0
      Change-Id: Ia17a430f3ab2d79e2f97b55feb9d3c4ee60bfb7e
      Reviewed-on: https://review.typo3.org/15138
      Reviewed-by: Markus Klein
      Tested-by: Markus Klein
      Reviewed-by: Stefan Neufeind
      Tested-by: Stefan Neufeind
      62346415
    • Michiel Roos's avatar
      [TASK] Optimize TypoScriptParser · 718d9b6a
      Michiel Roos authored
      The code in \TYPO3\CMS\Core\TypoScript\Parser\TypoScriptParser gets called
      a lot. It needs to be optimised.
      
      * Use language constructs insted of function calls where possible
      * Cleanup method descriptions and parameter defaults
      
      Resolves: #54856
      Releases: 6.2
      Change-Id: Ia52b3f72393288ed8259b25743a7403260eb5d73
      Reviewed-on: https://review.typo3.org/26701
      Reviewed-by: Michiel Roos
      Tested-by: Michiel Roos
      Reviewed-by: Marcin S?gol
      Tested-by: Marcin S?gol
      Reviewed-by: Jo Hasenau
      Tested-by: Jo Hasenau
      Reviewed-by: Markus Klein
      Tested-by: Markus Klein
      718d9b6a
    • Georg Ringer's avatar
      [TASK] Fix typos & grammar issues in Install Tool · fdd08bf6
      Georg Ringer authored
      Change-Id: Iaad158d8e0a67ee839cfd346e33f9cf466620893
      Resolves: #55098
      Releases: 6.2
      Reviewed-on: https://review.typo3.org/26896
      Reviewed-by: Markus Klein
      Tested-by: Markus Klein
      Reviewed-by: Oliver Klee
      Reviewed-by: Wouter Wolters
      Tested-by: Wouter Wolters
      fdd08bf6
    • Benjamin Mack's avatar
      [TASK] BE: Make "Template Analyzer" the last menu item · c059714a
      Benjamin Mack authored
      During the refactoring of the tstemplate extension, the
      Template Analyzer modfunc was inserted at first position
      of the backend module menu. AFAIK this was a
      functionality that was not desired, and confuses
      existing integrators.
      
      Releases: 6.2
      Resolves: #55097
      Change-Id: I153cf3076e6c31b95fa8d40996ffbf9192c48f74
      Reviewed-on: https://review.typo3.org/26894
      Reviewed-by: Tom Ruether
      Tested-by: Tom Ruether
      Reviewed-by: Michael Staatz
      Tested-by: Michael Staatz
      Reviewed-by: Markus Klein
      Tested-by: Markus Klein
      c059714a
    • Jigal van Hemert's avatar
      [BUGFIX] Use system locale when indexing external documents · 9dbb81a4
      Jigal van Hemert authored
      If paths or filenames of external documents contain utf-8 characters the
      system locale must be used. Functions like escapeshellarg and basename are
      locale aware.
      
      Change-Id: I50a73a42d60de569c63e5ba27ad6a6a3a66fd6c8
      Fixes: #30244
      Releases: 4.5, 6.0, 6.1, 6.2
      Reviewed-on: https://review.typo3.org/5312
      Reviewed-by: Markus Klein
      Reviewed-by: Sebastian Fischer
      Reviewed-by: Xavier Perseguers
      Tested-by: Markus Klein
      Reviewed-by: Stefan Neufeind
      Tested-by: Stefan Neufeind
      9dbb81a4
  6. Jan 16, 2014
    • Alexander Opitz's avatar
      [BUGFIX] PackageManager no cache if TYPO3 dir has symlinks · 5444b2fd
      Alexander Opitz authored
      In the PackageManager cache file is a validation of the actual file
      path to the file path the cache was last generated. This was written
      to invalidate the cache if someone moves TYPO3 around. This comparison
      fails on symlinks in path. As you need to clear the complete cache
      after moving the typo3 directory for other purposes and as this is no
      real use case, we can remove this line.
      
      Resolves: #55022
      Releases: 6.2
      Change-Id: I12d0fe09a3a7e1b3aad2f08c4bcde7a337cab769
      Reviewed-on: https://review.typo3.org/26838
      Reviewed-by: Thomas Maroschik
      Tested-by: Thomas Maroschik
      Reviewed-by: Markus Klein
      Tested-by: Markus Klein
      Reviewed-by: Stefan Neufeind
      Tested-by: Stefan Neufeind
      5444b2fd
    • Ingo Schmitt's avatar
      [BUGFIX] Deprecated function call mysql_list_dbs in dbal · 6293aa70
      Ingo Schmitt authored
      replaced mysql_list_dbs by show databases query
      
      Resolves: #53761
      Releases: 6.2
      Change-Id: I2b41b19aa900ba7eef33f2a990c8c029cbc1c08c
      Reviewed-on: https://review.typo3.org/26390
      Reviewed-by: Wouter Wolters
      Tested-by: Wouter Wolters
      Reviewed-by: Oliver Klee
      Reviewed-by: Stefan Neufeind
      Tested-by: Stefan Neufeind
      6293aa70
    • Nico de Haen's avatar
      [TASK] Add FlashMessage API to Extbase AbstractController · 401699ac
      Nico de Haen authored
      Flow comes with an API in AbstractController to add FlashMessages.
      Introducing this API to Extbase provides a convenient way to
      add new FlashMessages to the queue.
      Usage in your controller: $this->addFlashMessage();
      
      Resolves: #54036
      Releases: 6.2
      Change-Id: I3f6b69597d7f972054c5081d1f9e20d65b598848
      Reviewed-on: https://review.typo3.org/25731
      Reviewed-by: Benjamin Mack
      Reviewed-by: Marcin S?gol
      Tested-by: Marcin S?gol
      Reviewed-by: Steffen Müller
      Tested-by: Steffen Müller
      401699ac
    • Georg Ringer's avatar
      [TASK] Fix typo in Install Tool · c2454835
      Georg Ringer authored
      Replace 'chose' with 'choose'.
      
      Change-Id: I5ad978009e20fa420ba888a3deabb86d0d1ae926
      Resolves: #55053
      Releases: 6.2
      Reviewed-on: https://review.typo3.org/26873
      Reviewed-by: Wouter Wolters
      Tested-by: Wouter Wolters
      c2454835
    • Oliver Hader's avatar
      [TASK] Use file_exists() instead of is_file() · 956c2fef
      Oliver Hader authored
      is_file() checks whether a resource exists and whether it
      is actually a file. There are several parts in the core,
      where it is sufficient to check for the existence only,
      which is faster.
      
      Resolves: #55052
      Releases: 6.2
      Change-Id: I57b6d2f68dd3c1c45b603c3f194cc0c53c48e28c
      Reviewed-on: https://review.typo3.org/26872
      Reviewed-by: Wouter Wolters
      Reviewed-by: Tom Ruether
      Tested-by: Tom Ruether
      Reviewed-by: Oliver Klee
      Reviewed-by: Benjamin Mack
      Tested-by: Benjamin Mack
      956c2fef
  7. Jan 15, 2014
    • Marc Bastian Heinrichs's avatar
      Revert "[BUGFIX] Assume pid 0 for global backend context" · df2635c6
      Marc Bastian Heinrichs authored
      formal: the change is not marked as breaking.
      functional: removing the functionality fetching the 
      typoscript from a auto detected page completly without 
      an alternative breaks all extbase backend modules using 
      typoscript configuration.
      
      This reverts commit ba2386e7
      
      Change-Id: I0c4c10b1bd8b5d09c54743a4949cce250d962ede
      Reviewed-on: https://review.typo3.org/26864
      Reviewed-by: Marc Bastian Heinrichs
      Tested-by: Marc Bastian Heinrichs
      df2635c6
    • Benjamin Mack's avatar
      [!!!][FEATURE] Improve caching framework by introducing groups · 1101f392
      Benjamin Mack authored
      The current TYPO3 Core includes different types of caches. There are
      system-related caches (class loading cache, configuration cache,
      l10n_cache, extbase_object, extbase_reflection etc.) and
      frontend-related caches (chash cache, page cache, page section
      cache).
      
      The patch introduces the possibility to group caches. The core uses
      two groups "pages" with all page-related caches, and "system" that
      is used for compile-time caches and configuration caches.
      
      The new API is now used to be more flexible inside DataHandler
      clear_cacheCmd without having hooks, as the Cache Manager is used
      to clear all caches inside one hook.
      
      !!! The "Clear all caches" command does not flush caches for
      system-related caches anymore. Only "Clear Configuration Cache" or
      inside the install tool in the backend removes all the system caches.
      
      A new userTSconfig option is used to non-admins to be allowed to
      clear the system caches.
      
      Resolves: #54991
      Releases: 6.2
      Change-Id: I...
      1101f392
    • Thomas Blaß's avatar
      [BUGFIX] Image CE rendering does not scale images · f273fff1
      Thomas Blaß authored
      When rendering images with CssStyledContent while using the features
      maxW and equalHeight at the same time, the rendering needs to pre-
      calculate the target sizes. Doing this the GifBuilder is used to
      determine the width and height of the file while still relying on the
      being a locally reachable path. Since the introduction of FAL uids will
      be present at that point and therefore this calcuation will fail.
      
      This change extracts the width and height of the image from the
      according file object which not only fixes the the mentioned issue but
      will be way more performant since the values doe not need to be
      derived from the filesystem.
      
      Resolves: #45086
      Releases: 6.2
      Change-Id: Icb03d337bb84851a5c905a45c4941fc9d9539033
      Reviewed-on: https://review.typo3.org/26556
      Reviewed-by: Wouter Wolters
      Reviewed-by: Frans Saris
      Reviewed-by: Thomas Blaß
      Tested-by: Thomas Blaß
      Reviewed-by: Benjamin Mack
      Tested-by: Benjamin Mack
      f273fff1
    • Frans Saris's avatar
      [BUGFIX] Add fileSuffix option to GeneralUtility::tempnam() · 447dba14
      Frans Saris authored
      Currently it is only possible to create a
      temporary file with a given prefix and without
      any file extension. But for some use-cases you
      need a file with a certain file extension.
      
      This patch introduces a new optional parameter to
      GeneralUtility::tempnam() to make it possible to add
      e.g. a specific extension to the created file.
      
      In addition the occurrences in core, which can benefit
      from this, are adapted resulting in less orphaned
      temporary files in typo3temp.
      
      Releases: 6.2
      Resolves: #54750
      Change-Id: I19383bc8f6b387133bff2f4033f05b28e883d427
      Reviewed-on: https://review.typo3.org/26650
      Reviewed-by: Helmut Hummel
      Tested-by: Helmut Hummel
      Reviewed-by: Markus Klein
      Reviewed-by: Steffen Ritter
      Tested-by: Steffen Ritter
      447dba14
    • Oliver Hader's avatar
      [TASK] Extend TypoScriptParser test cases · 52d5bd25
      Oliver Hader authored
      Resolves: #55026
      Releases: 6.2
      Change-Id: Ia1d03b4c3db6bb224b920b7252bd68df70053515
      Reviewed-on: https://review.typo3.org/26842
      Reviewed-by: Oliver Klee
      Reviewed-by: Oliver Hader
      Tested-by: Oliver Hader
      52d5bd25
    • Steffen Ritter's avatar
      [TASK] Skip two tests in LocalDriverTests in PHP 5.3 · 84b6e61f
      Steffen Ritter authored
      For most tests in the LocalDriverTest vfsStream is used to
      emulate the filesystem. This needs PHP filesystem functions
      to use the stream wrappers.
      
      For touch() this has been enabled with PHP 5.4. The reversal
      conclusion is, that this does not work with PHP 5.3 which
      causes failing tests there.
      
      As a result If the PHP version is 5.3 we skip the two tests.
      This is a follow-up to https://review.typo3.org/#/c/26520/
      
      Resolves: #54230
      Releases: 6.2
      Change-Id: I4e92927e1d77f825bab8583318a944a8916051d5
      Reviewed-on: https://review.typo3.org/26845
      Reviewed-by: Steffen Ritter
      Tested-by: Steffen Ritter
      84b6e61f
    • Benjamin Mack's avatar
      [TASK] Extend DB fields for be users/groups of DB/file mounts · 0b6f5d0e
      Benjamin Mack authored
      The maxitems entry for be_users / be_groups fields
      db/file mounts was raised in issue #55018. The DB schema of
      these fields should reflect the changes as well.
      
      Releases: 6.2
      Followup to: #55018
      Resolves: #55025
      
      Change-Id: I475ed18d3210a68e476c1434fa83b0b410937c8a
      Reviewed-on: https://review.typo3.org/26837
      Reviewed-by: Wouter Wolters
      Reviewed-by: Helmut Hummel
      Tested-by: Helmut Hummel
      0b6f5d0e
    • Helmut Hummel's avatar
      [BUGFIX] Bring back final class name cache · 5ecb43f7
      Helmut Hummel authored
      The class name needs to be determined through
      a lookup in the implementation configuration
      (AKA XCLASS).
      
      This runtime cache was removed in favor of
      a cache in the class loader. But this caching
      behavior also changed due to the package management
      API implementation.
      
      Releases: 6.2
      Resolves: #55024
      Change-Id: I8dc101c0c04c88e531907fcfaf82e529af483e01
      Reviewed-on: https://review.typo3.org/26821
      Reviewed-by: Steffen Ritter
      Tested-by: Steffen Ritter
      5ecb43f7
    • Steffen Ritter's avatar
      [!!!][TASK] Driver API has too many crosscutting concerns · f83eddd5
      Steffen Ritter authored
      The Driver within the FileAbstractionLayer is the actual
      abstraction of a concrete file-system meant to unify
      access to several kind of storage-systems the file data
      might reside in. For each way of storing files there
      has to be a driver.
      
      Therefore a driver is solely a unique API to interact with
      an underlying storage system based upon its own identifier
      system.
      
      Opposite to that, the AbstractDriver (defining our Interface)
      knows about its storage, file- and folder-objects as well
      as indexes. The methods within the current driver need to
      implement more FAL-internal logic than one would expect from
      what the driver is purposed to. As a result only a few drivers
      are existing by now. In addition it's nearly impossible to
      change FAL interals without touching every driver out there.
      
      This change deals with these problems. In several steps the
      current driver API has been refactored to have less dependencies
      and only fullfills it's original purpose: the abstraction of a
      file storage system.
      
      The following things are considered:
         1. Change every return value which has been an object to the
            identifier and adapt the ResourceStorage accordingly.
         2. Change every method parameter being FileInterface, File,
            AbstractFile or Folder objects to a string: the identifier.
         3. Get rid of the storage as a member variable, only the uid
            of the storage is needed at two places.
         4. Remove all abstract methods from the AbstractDriver and
            put them in a newly created DriverInterface.
         5. Exchange all references to AbstractDriver to the interface.
         6. Remove unused methods, which came to light doing so.
         7. Merge addFile/removeFile and *Raw since the do the same if
            no objects are in place.
         8. Unify the creation of folder objects and how information
            is retrieved (analogue to files now).
         9. Unify and simplify the methods for retrieving folder
            contents (files / folders).
        10. Adapt the UnitTests of both classes to the changes.
            This also leads to the removal of some tests which are
            superfluous with that change.
        11. Make the DriverRegistry check the implementation of the
            newly created interface.
        12. Unify the parameter names in the methods.
      
      Releases: 6.2
      Resolves: #54230
      Resolves: #54231
      Change-Id: I4a51572c6a10859e6fd5f12f6cb539950444992e
      Reviewed-on: https://review.typo3.org/26520
      Reviewed-by: Frans Saris
      Tested-by: Frans Saris
      Reviewed-by: Benjamin Mack
      Tested-by: Benjamin Mack
      f83eddd5
    • Ernesto Baschny's avatar
      [TASK] Document that TYPO3 is not compatible with MySQL strict mode · 9bbad98c
      Ernesto Baschny authored
      Document that in the requirements section of the INSTALL.md.
      
      Resolves: #54883
      Releases: 6.2
      Change-Id: Idd80528493b9920f4488e359f13fe4304ac5fe25
      Reviewed-on: https://review.typo3.org/26725
      Reviewed-by: Wouter Wolters
      Reviewed-by: Philipp Gampe
      Reviewed-by: Aske Ertmann
      Reviewed-by: Oliver Klee
      Reviewed-by: Stefan Neufeind
      Reviewed-by: Michael Stucki
      Tested-by: Michael Stucki
      Reviewed-by: Markus Klein
      Tested-by: Markus Klein
      9bbad98c
    • Alexander Stehlik's avatar
      [TASK][CONF] Accept other settings in [SYS][setDBinit] · 9c905d15
      Alexander Stehlik authored
      Since the mysqli interface recommends setting the charset using the
      mysqli API the utf8 charset will be initialized when establishing the
      database connection using mysqli_set_charset().
      
      Additionally [SYS][setDBinit] can now be set to any value or can totally
      be removed. To make sure the database connection still uses the correct
      encoding an additional check is added to the database connection process
      that checks the MySQL character set session variables.
      
      Finally the old default value of [SYS][setDBinit] will automatically be
      removed if it is set to the old default value.
      
      Resolves: #41596
      Releases: 6.2
      Change-Id: I8d0a9eba50495d52accb59627147c1c87b6a9bb5
      Reviewed-on: https://review.typo3.org/15369
      Reviewed-by: Wouter Wolters
      Reviewed-by: Alexander Opitz
      Tested-by: Alexander Opitz
      Reviewed-by: Michael Stucki
      Tested-by: Michael Stucki
      Reviewed-by: Markus Klein
      Tested-by: Markus Klein
      9c905d15