- Jun 11, 2014
-
-
Zbigniew Jacko authored
Add a new configuration in Install Tool (['SYS']['clearCacheSystem']). If set, the toolbar of clearing system cache is visible (only for admin users). Add it also for Configuration Preset. For Production it is set to FALSE, for Development it is set to TRUE. Resolves: #57230 Releases: 6.2 Change-Id: Id45496c6bc1e64b4454ed7ff78e8db1179387b0f Reviewed-on: https://review.typo3.org/30656 Reviewed-by: Krzysztof Adamczyk Tested-by: Krzysztof Adamczyk Reviewed-by: Xavier Perseguers Tested-by: Xavier Perseguers
-
Benjamin Mack authored
The file repository used to resolve all sys_file_references handles enable fields manually currently, which is bad because it forgets to handle the workspace-related where clause. The attached patch splits the behavior into frontend and backend context. In backend the RelationHandler is capable of automatically resolving IRRE structures. In frontend mode the enableFiels and version preview settings are relevant to show correct results. Resolves: #43916 Releases: 6.2 Change-Id: I6c19e5d7b4cd7a2134921c669b82ab90b54844de Reviewed-on: https://review.typo3.org/29712 Tested-by: Lorenz Ulrich Reviewed-by: Fabien Udriot Tested-by: Fabien Udriot Reviewed-by: Steffen Ritter Tested-by: Steffen Ritter
-
Helmut Hummel authored
When calling ResourceFactory::getInstance() ->getFileObjectFromCombinedIdentifier($identifier) with $identifier === NULL or $identifier === '' an index entry is written for storage 0 which contains the last path segment of PATH_site as identifier. Guard the API in two places by throwing exceptions when an invalid file identifier is given. Resolves: #59295 Releases: 6.2 Change-Id: Ie2d6d811193ee21b865161984ddbac240388573b Reviewed-on: https://review.typo3.org/30526 Reviewed-by: Fabien Udriot Tested-by: Fabien Udriot Reviewed-by: Steffen Ritter Tested-by: Steffen Ritter
-
Lorenz Ulrich authored
The styling of sys_action "Create Backend User" is outdated and should be slightly improved to enhance usability of this module. Releases: 6.2 Resolves: #59338 Change-Id: Ifaba21a78687589af9ba0decad8bc2b9fdc4d29d Reviewed-on: https://review.typo3.org/30646 Reviewed-by: Fabien Udriot Tested-by: Fabien Udriot Reviewed-by: Xavier Perseguers Tested-by: Xavier Perseguers
-
Marc Bastian Heinrichs authored
Loading extensions TS, that provide contentRenderingTemplates, like css_styled_content, using INCLUDE_TYPOSCRIPT was fixed in https://review.typo3.org/#/c/21679/. Since making TS content templates more flexible in https://review.typo3.org/#/c/27587/ the contentRenderingTemplates wasn't added to "defaultTypoScript_setup." and "defaultTypoScript_constants." arrays anymore and breaks the mentioned fix. Solution is to check the required key in contentRenderingTemplates and add the defaultContentRendering string now. Resolves: #59318 Releases: 6.2 Change-Id: I8a367f462f304e07bbcec99fd26818bc98148eb4 Reviewed-on: https://review.typo3.org/30544 Reviewed-by: Benjamin Mack Reviewed-by: Krzysztof Adamczyk Tested-by: Krzysztof Adamczyk Reviewed-by: Tymoteusz Motylewski Tested-by: Tymoteusz Motylewski Reviewed-by: Steffen Ritter Tested-by: Steffen Ritter
-
- Jun 10, 2014
-
-
Stefan Froemken authored
The IRRE option useCombination enables to use bi-directional relations with IRRE items. This enables you to re-use IRRE items multiple times (similar as FAL is working with IRRE). To prevent the same child record from being used multiple times, items already used are removed from the select box. The code removing the item was written to remove an item from a select box, but (accidentially) also targets a hidden item which causes the JavaScript to break so that the field values of the child objects are not filled on expanding. By adding an additional check, this can be prevented. For steps to reproduce refer to #46477. Resolves: #46477 Releases: 6.2 Change-Id: Ie7fd89f6ef887b5d45c734dea8ec6ad9ac2a8d2c Reviewed-on: https://review.typo3.org/19337 Reviewed-by: Fabien Udriot Tested-by: Fabien Udriot Reviewed-by: Zbigniew Jacko Tested-by: Zbigniew Jacko Reviewed-by: Xavier Perseguers Tested-by: Xavier Perseguers
-
Anja Leichsenring authored
TCA manipulation code must no longer reside in ext_tables.php, but moved to Configuration/TCA/Overrides/<tablename>.php. Leftovers in ext_tables might disturb loading order of TCA changes. Change-Id: Ie919a856fbd8242d19110c8db8d01ff7865c913c Resolves: #59397 Releases: 6.2 Reviewed-on: https://review.typo3.org/30620 Reviewed-by: Krzysztof Adamczyk Tested-by: Krzysztof Adamczyk Reviewed-by: Steffen Ritter Tested-by: Steffen Ritter
-
Frans Saris authored
Instead of generating and saving the public/private keys for an RSA enabled login form on rendering the form the keys are fetched on submit. This resolves the issue with outdated keys and the problem that the login box on first page doesn't work anymore when a page in a second tab is opened. Resolves: #59041 Releases: 6.2 Change-Id: I0ad13775f029a29f6f67e302a1a63f3860e902b5 Reviewed-on: https://review.typo3.org/30364 Reviewed-by: Xavier Perseguers Tested-by: Xavier Perseguers Reviewed-by: Zbigniew Jacko Tested-by: Zbigniew Jacko Reviewed-by: Steffen Ritter Reviewed-by: Markus Klein Tested-by: Markus Klein
-
Steffen Ritter authored
A small follow-up renaming the variable of the loop which has not been renamed after copy and paste. Resolves: #58701 Releases: 6.2 Change-Id: I70af6722200fda48b09734e21c6d90d3a4e9b868 Reviewed-on: https://review.typo3.org/30638 Reviewed-by: Xavier Perseguers Tested-by: Xavier Perseguers Reviewed-by: Steffen Ritter Tested-by: Steffen Ritter
-
Markus Klein authored
Fix this by adding the suggestion already present in the ext_emconf.php also to the composer.json. Resolves: #58694 Releases: 6.2 Change-Id: I9ded17691ed91fce099638bdac4b4f425cb47ea6 Reviewed-on: https://review.typo3.org/30006 Reviewed-by: Loek Hilgersom Tested-by: Loek Hilgersom Reviewed-by: Jacco van der Post Tested-by: Jacco van der Post Reviewed-by: Fabien Udriot Tested-by: Fabien Udriot Reviewed-by: Xavier Perseguers Tested-by: Xavier Perseguers
-
Markus Klein authored
Let the DependencyResolver take the suggest-part of the composer.json or ext_emconf.php files into account. This solves issues where it is necessary to ensure a certain loading order of extensions without having a real dependency between those. Resolves: #57825 Releases: 6.2 Change-Id: Ia771813b7945409e5ddaec3f19da27239be16e67 Reviewed-on: https://review.typo3.org/30005 Reviewed-by: Loek Hilgersom Tested-by: Loek Hilgersom Reviewed-by: Thomas Maroschik Reviewed-by: Fabien Udriot Tested-by: Fabien Udriot Reviewed-by: Stefan Neufeind Reviewed-by: Xavier Perseguers Tested-by: Xavier Perseguers
-
Markus Klein authored
Enhance the Package metadata with information about suggested packages. This information may be loaded from composer.json or ext_emconf.php. Resolves: #58701 Releases: 6.2 Change-Id: Ie7415ebe60d2c6164ccc52976a666fe07fd4afe0 Reviewed-on: https://review.typo3.org/30015 Reviewed-by: Thomas Maroschik Tested-by: Fabien Udriot Reviewed-by: Fabien Udriot Reviewed-by: Stefan Neufeind Reviewed-by: Xavier Perseguers Tested-by: Xavier Perseguers
-
- Jun 07, 2014
-
-
Helmut Hummel authored
We can revert this again as the issue has been resolved upstream: https://github.com/sebastianbergmann/phpunit-mock-objects/issues/172 We can now switch back to phpunit 4.1.* again. This reverts commit 7a876ddc Change-Id: If08d3e7200103e5cab77fdc1e098efd2048bde4c Reviewed-on: https://review.typo3.org/30623 Reviewed-by: Helmut Hummel Tested-by: Helmut Hummel
-
Frans Saris authored
When uploading multiple files in TCEForm the DrapUploader adds all uploaded files directly to the inline element of the form. But when a previous request isn't finished yet, it breaks the processing of last request. This patch changes the use of importElement to delayedImportElement so the next element is only added when the previous is processed. Resolves: #58956 Resolves: #57472 Resolves: #57190 Releases: 6.2 Change-Id: Iccad2ee19a5462cb63ed749ad60cb685460eb66d Reviewed-on: https://review.typo3.org/30609 Reviewed-by: Helmut Hummel Tested-by: Marc Fell Reviewed-by: Markus Klein Tested-by: Markus Klein
-
- Jun 06, 2014
-
-
Helmut Hummel authored
Suddenly build failures occurred on travis which seem to be related to ReflectionClass::newInstanceWithoutConstructor which is used by PHPUnit 4.1.* when available. Downgrade to PHPUnit 3.7.* to have a green build again as the failures are totally unrelated to our code. Change-Id: I6c3c200d5eda372e92ee0fd4c39e7fe79183ecab Reviewed-on: https://review.typo3.org/30616 Reviewed-by: Helmut Hummel Tested-by: Helmut Hummel
-
Mathias Brodala authored
Due to using array_pop instead of array_shift the last line of the command description is dropped instead of the first. Use array_shift instead to get the full description annotated for the command method. Resolves: #59324 Releases: 6.2, 6.1, 4.7 Change-Id: I4d7c320b0ef334adbd15997d15d8e7a56d5739c1 Reviewed-on: https://review.typo3.org/30612 Reviewed-by: Helmut Hummel Tested-by: Helmut Hummel Reviewed-by: Anja Leichsenring Tested-by: Anja Leichsenring
-
Jan-Erik Revsbech authored
When running TYPO3 behind a reverse proxy, which also handles SSL, the setting reverseProxySSL should check if the site is requested from one of the reverse proxies in order to determine whether the site is using SSL. It incorrectly does this check via getIndpEnv('REMOTE_ADDR') which has already translated the proxy IP to the end-users IP, thus always returning FALSE. Resolves: #37467 Release: 6.2, 6.1 Change-Id: I95615b0fea94e0ef0222e958e4e0bba5e6e9f60a Reviewed-on: https://review.typo3.org/30581 Reviewed-by: Wouter Wolters Reviewed-by: Mattias Nilsson Tested-by: Mattias Nilsson Reviewed-by: Jan-Erik Revsbech Tested-by: Jan-Erik Revsbech Reviewed-by: Markus Klein Tested-by: Markus Klein
-
Alexander Stehlik authored
Emit postFileCreate and postFileSetContents signals and add provide the original folder in the postFileMove and the postFolderMove signals. Resolves: #59294 Releases: 6.2 Change-Id: Ia4096b38671f3312a1488587972d4883368de05c Reviewed-on: https://review.typo3.org/30525 Reviewed-by: Frans Saris Tested-by: Frans Saris Reviewed-by: Markus Klein Tested-by: Markus Klein
-
- Jun 05, 2014
-
-
Alexander Stehlik authored
The maxitems value for a group field defaults to 1 instead of 100000 so that it is consistent with the TCA reference and the validation in the DataHandler. Resolves: #55731 Releases: 6.2 Change-Id: I517e45a9227ab9d971a9e7bc4410498319192517 Reviewed-on: https://review.typo3.org/27378 Reviewed-by: Xavier Perseguers Tested-by: Xavier Perseguers Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters
-
Markus Klein authored
The current check does not properly consider the override values. If a override is set, then its value has to be taken. The current check only considered overrides which had boolean value TRUE. Resolves: #58339 Releases: 6.2, 6.1 Change-Id: Ib714432044c6a88fc92dcb8f36a4e37eb3412378 Reviewed-on: https://review.typo3.org/29730 Reviewed-by: Gerrit Mohrmann Tested-by: Gerrit Mohrmann Reviewed-by: Stefan Neufeind Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters
-
Stefan Rotsch authored
On changing the stage of a workspace version, an accordant dialog is shown with recipients to be informed about this action. However, disabled backend users are shown in this dialog as well. Resolves: #54925 Releases: 6.2 Change-Id: Iefae9e35e9c680783769260e8c3e38180bde5703 Reviewed-on: https://review.typo3.org/26773 Reviewed-by: Oliver Hader Tested-by: Oliver Hader Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters
-
Frans Saris authored
For custom content elements with image these are shown as thumbs in the list module but not in the page module. This patch also renders the images when present just like the bodytext. Resolves: #59375 Releases: 6.2 Change-Id: If39e8b22af6144e5d6990a741559bd7574ee5e09 Reviewed-on: https://review.typo3.org/30598 Reviewed-by: Markus Klein Tested-by: Markus Klein Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters
-
Fabien Udriot authored
Change-Id: I13d428c7b8a3964e8c376ad2c8d2a4af8c0059f1 Releases: 6.2 Resolves: #59374 Reviewed-on: https://review.typo3.org/30596 Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters
-
Stefano Kowalke authored
This aligns the description of the command line options. Resolves: #59372 Releases: 6.2 Change-Id: I474f8415d3ed62d583553f915edc3caa8189a803 Reviewed-on: https://review.typo3.org/30594 Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters Reviewed-by: Markus Klein Tested-by: Markus Klein
-
Robert Vock authored
Logoff sets user property to an empty string instead of NULL. This leads to a PHP Warning in PHP 5.4 Change-Id: Ib0e1a31dbf2fd3fcbcf1e7afd972b53d60c3ab5d Resolves: #59364 Releases: 6.2, 6.1 Reviewed-on: https://review.typo3.org/30588 Reviewed-by: Markus Klein Tested-by: Markus Klein Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters
-
Christian Zenker authored
$this->sWArr is not defined SearchController. Fix this to use the correct $this->searchWords variable. Change-Id: Iba888f1a47dcc0952ffbbb1e3bb4413435c2a95e Resolves: #59277 Releases: 6.2, 6.1 Reviewed-on: https://review.typo3.org/30512 Reviewed-by: Alexander Opitz Reviewed-by: Christian Zenker Tested-by: Christian Zenker Reviewed-by: Markus Klein Tested-by: Markus Klein
-
Markus Klein authored
Content elements from hidden pages are no longer shown in previews. Fix this by checking with a strong comparison in enableFields() whether the $show_hidden parameter is set to the default value. Fixes: #58148 Related: #57814 Releases: 6.2 Change-Id: I2e20db88a513adb1a4d7599591fd3affdb60f209 Reviewed-on: https://review.typo3.org/30212 Tested-by: Dirk Klimpel Reviewed-by: Mario Rimann Reviewed-by: David Hoeckele Reviewed-by: Marc Bastian Heinrichs Tested-by: Marc Bastian Heinrichs
-
- Jun 04, 2014
-
-
Helmut Hummel authored
* Allow HTTP_HOST access for all unit tests * Remove allow all in data provider The latter implicitly caused a global allow, as PHPUint parses all data providers before any test is run, thus setting globals there will cause them to be preserved (and restored when backup globals is true). Releases: 6.2, 6.1, 6.0 Resolves: #59343 Change-Id: I646294bb472027e22d6edc0622068698fe9a88fc Reviewed-on: https://review.typo3.org/30560 Reviewed-by: Marc Bastian Heinrichs Tested-by: Marc Bastian Heinrichs Reviewed-by: Markus Klein Tested-by: Markus Klein
-
Frans Saris authored
To make it possible for an editor to find the real location of a used file, the storage and folder are added to the ElementInformation view of a file and folder. Resolves: #57798 Releases: 6.2 Change-Id: I7c8104809bad49a6df1ec625cf3463a96526ede2 Reviewed-on: https://review.typo3.org/30558 Reviewed-by: Einar Gislason Tested-by: Einar Gislason Reviewed-by: Markus Klein Tested-by: Markus Klein
-
- Jun 03, 2014
-
-
Frans Saris authored
The irre elements of FAL items have an info icon which shows some details info about the file_reference. But this is not the info an editor is looking for he wants the file info. This patch changes the link behind the info icon for FAL items so it shows the file info. Resolves: #57302 Resolves: #57832 Releases: 6.2 Change-Id: I3c4b867ceb5bc05e1cb62525450102784793fadc Reviewed-on: https://review.typo3.org/29651 Reviewed-by: Stefan Froemken Tested-by: Stefan Froemken Reviewed-by: Sebastian Fischer Tested-by: Nico de Haen Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters
-
Markus Klein authored
A wrong formula is used to calculate the pointer for the pages. This patch also introduces a central function for calculating the pointer to a page. Resolves: #55320 Releases: 6.2 Change-Id: Ia4eec61f4f87b52d0d5e940e542998f9f82aa140 Reviewed-on: https://review.typo3.org/29949 Reviewed-by: Marcin Sągol Tested-by: Marcin Sągol Tested-by: Tymoteusz Motylewski Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters
-
Wouter Wolters authored
Replace old logo with the new logo. Resolves: #59321 Releases: 6.2 Change-Id: I1b4386e0ee614096b4033f00d9fe9136d11a63c7 Reviewed-on: https://review.typo3.org/30548 Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters
-
Markus Klein authored
Ensure the DataHandler::log() function does return integers in all cases as denoted in the doc header. Resolves: #59185 Releases: 6.2, 6.1, 6.0 Change-Id: I2a6aa0415b7cc19f10b4a290e43bd20065e6c9e1 Reviewed-on: https://review.typo3.org/30479 Reviewed-by: Stefan Neufeind Tested-by: Stefan Neufeind Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters
-
Marc Bastian Heinrichs authored
On creating exports the file hash and size is used from the sys_file table. Since this could be not up-to-date in real live projects, those files fail to be imported. To prevent this, use the correct data for the export and show an error to the user. Resolves: #58761 Releases: 6.2 Change-Id: I7aacc6f00c52bc01c753af4ee32202a9219c02a1 Reviewed-on: https://review.typo3.org/30061 Reviewed-by: Bernd Niehues Tested-by: Bernd Niehues Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters
-
Marc Bastian Heinrichs authored
A folder to be created could change the name by sanitizing. So the name of the created folder could differ from the requested name. For adding the image the returned folder object should be used. To avoid that sanitized ones should be created over and over again a mapping is buffered. Resolves: #58682 Releases: 6.2 Change-Id: Ia3443c36c6dda8531c8791c221d2a835b25b10b2 Reviewed-on: https://review.typo3.org/29984 Reviewed-by: Bernd Niehues Tested-by: Bernd Niehues Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters
-
Markus Klein authored
This is a regression fix for #55983, which introduced additional urlencoding for title, class, ... Remove the encoding again. Resolves: #59199 Releases: 6.2 Change-Id: I28650676f4ae0b74256a770af12054750027cbfa Reviewed-on: https://review.typo3.org/30483 Reviewed-by: Markus Bucher Tested-by: Markus Bucher Reviewed-by: Tymoteusz Motylewski Tested-by: Tymoteusz Motylewski Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters
-
Markus Klein authored
RTE feature "userlinks" generates a wrong JS function name due to the automatic replacement during the namespace conversion. Revert this line to use the correct JS function name. Resolves: #59302 Releases: 6.2, 6.1, 6.0 Change-Id: Ia6b51e7e1b1dfa0e618106f4f039bd0774464a97 Reviewed-on: https://review.typo3.org/30531 Reviewed-by: Alexander Opitz Tested-by: Alexander Opitz Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters
-
Nils Blattner authored
ResourceFactory fails to detect files in symlinked scenarios, because the path is not canonicalized before file existence is checked. Solution is to canonicalize it and check then. Resolves: #59303 Releases: 6.2 Change-Id: I4fd763f7076e909f2163af79ed2b7f8642da8ed7 Reviewed-on: https://review.typo3.org/30532 Reviewed-by: Markus Klein Tested-by: Markus Klein
-
Francois Suter authored
For select-type fields displayed as two side-by-side selectors which are registered as "requestUpdate" fields, the form submission happens before the value is copied to the left-hand selector. The form is thus saved without value. Full description in the bug report, which also contains a test extension and steps to reproduce. Resolves: #58755 Releases: 6.2 Change-Id: Ie94def723537202287655c650cee7dfa09815f4f Reviewed-on: https://review.typo3.org/30044 Reviewed-by: Peter Foerger Reviewed-by: Fabien Udriot Tested-by: Fabien Udriot Reviewed-by: Tomas Norre Mikkelsen Reviewed-by: Lorenz Ulrich Tested-by: Lorenz Ulrich Reviewed-by: Markus Klein Tested-by: Markus Klein
-
- Jun 02, 2014
-
-
Markus Klein authored
The setting for maxitems in the TCA of be_users and be_groups for FAL permissions are wrong. Fix the value to match the number of available options. Resolves: #59263 Releases: 6.2 Change-Id: Ib38aab8bbd1f5fe9287ff0523139f88520f27e37 Reviewed-on: https://review.typo3.org/30518 Reviewed-by: Frans Saris Reviewed-by: Alexander Opitz Tested-by: Alexander Opitz Reviewed-by: Helmut Hummel Tested-by: Helmut Hummel
-