- Aug 03, 2023
-
-
Simon Schaufelberger authored
While the backend already renders preview images of for example YouTube videos in the media module, it doesn't show the preview image anywhere else, for example in the page module and the Media elements within a "Text and Media" content element. This patch shows the generated preview image within the page module and the "Text and Media" content element as well. Resolves: #95454 Releases: main, 12.4, 11.5 Change-Id: I4e404cf41627d5ee9ac165ee46817a456dbecaa8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80167 Reviewed-by:
Henning Liebe <h.liebe@neusta.de> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
HOJA M A <hoja@ymail.com> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
-
Sascha Nowak authored
A new custom PHP attribute "AsEventListener" is added in order to autoconfigure a class as an event listener. The attributes is repeatable, which allows to register the same class to listen for different events. The attribute features the same functionality as the manual registration in Services.(yaml|php) file. Resolves: #101544 Releases: main Change-Id: I81e3da5694f57ee0c7c3dd507d50ca79e2015dc1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80309 Tested-by:
-
Jasmina Ließmann authored
In the page module it is possible to display the content of the languages side by side with the "Language Comparison" mode. With different amounts of text in the content elements of each language, the page TSconfig option `mod.web_layout.defLangBinding = 1` can help to arrange the content in a more structured way. If the `mod.web_layout.defLangBinding = 1` option was activated, the first button for creating new content elements was displayed on a white background. With this patch, the button is now displayed on a gray background, analogous to the rest of the content area. Resolves: #101536 Releases: main, 12.4 Change-Id: I88a47d8010d0520bea84f01f9c21408e0f3908f9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80320 Tested-by:
Jasmina Lie�mann <minapokhalo+typo3@gmail.com> Tested-by:
Annett J�hnichen <mcmietz@web.de>
-
Oliver Bartsch authored
Apply type cast to the input value to prevent a TypeError. Resolves: #101555 Releases: main, 12.4 Change-Id: If2db6d0cc793999f2ce93d16cfedadb12325c316 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80318 Reviewed-by:
Tobi Kretschmann <tobi@tobishome.de> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de>
-
Christian Spoo authored
Invoke `str_ends_with` on lowercased filesystem entries in order to check for allowed extensions. This is more stable than `substr`ing the comma-separated list of extensions. Resolves: #101035 Releases: main, 12.4 Change-Id: I6a0eee1f6ddb7406a8da168ed489aba6bfc83263 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80319 Tested-by:
-
Stefan Bürk authored
With PHP8.3 the `ReflectionProperty->setValue()` method emits a E_DEPRECATED if a value should be set to a class and the context is not set as first argument. For instanciated classes the class needs to be provided, which is not possible for a static class or property. The solution for this is to use `null` as first argument as context object. That avoids the deprecation and keeps the backward compatibility. The testing-framework provides a tool to keep and handle static Framework state, which uses reflection under the hood and therefore needs the null context for `setValue()`. To verify manually use: > Build/Scripts/runTests.sh -s functional -p 8.3 Note: Activating in CI runs will be shuffeld in a dedicated change afterwards. Resolves: #101548 Releases: main, 12.4 Change-Id: I13fae7a20162eb3a48910ca91a5a1b178d5a1821 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80310 Reviewed-by:Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
-
Andreas Fernandez authored
With the introduction in TYPO3 v10, the `DebounceEvent` module had the possibility to shift the event handler execution to the beginning of the debounce sequence, enabled via the optional `immediate` parameter. The parameter is unused in TYPO3 and using this feature has a negative impact on UX. If used, the event handler is directly executed and the user has to wait a specific time after the last event was triggered, before any further execution is possible. The flag `immediate` has been therefore removed. Resolves: #101519 Releases: main Change-Id: Ie0053fbfe3dcce4ae504550d024b1d88d69802f8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80292 Tested-by:
Benjamin Franzke <ben@bnf.dev> Reviewed-by:
-
Christian Kuhn authored
With workspaces and the extbase test related blog_example being fixed, we can finally add a primary key on MM tables that have no uid field. Resolves: #101425 Related: #101528 Related: #101537 Related: #95061 Releases: main, 12.4 Change-Id: I2cd44e3f21dac4b774b8067839a6d2abb8d759fb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80281 Reviewed-by:
Stefan B�rk <stefan@buerk.tech> Reviewed-by:
-
Jasmina Ließmann authored
Several H1 headings are used in some card views. As a result, the semantic structure for these views is not correct. The relevant H1 headings are changed to h2. Resolves: #101545 Releases: main, 12.4 Change-Id: Ic53d92a52b1ae75adda18a63bc76633d7ffcfa44 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80306 Tested-by:
-
Chris Müller authored
Resolves: #101539 Releases: main, 12.4 Change-Id: Id77ae5fb63c0de3d22cb1a4f4302c76476369b67 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80303 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
-
Stefan Bürk authored
Update the typo3/testing-framework to pull in a needed correction as preparation for functional tests with PHP 8.3. Used command(s): > composer update typo3/testing-framework Resolves: #101538 Releases: main, 12.4, 11.5 Change-Id: Id26531be8c49a9b1ee9624c178342659b28d3eab Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80300 Tested-by:
-
- Aug 02, 2023
-
-
Christian Kuhn authored
Similar to the recently fixed other MM TCA setup of blog_example, the "related_posts" is adapted as well. This removes the last mm table definition from ext_tables.sql - the auto-creation kicks in as expected now. Resolves: #101537 Related: #101528 Releases: main, 12.4 Change-Id: Ia92ce6bbc78a493e1a2028bd9ab7a31952181dd3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80298 Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
Torben Hansen authored
The `generateHmac()` function in extbase `HashService` checks for the existence of the TYPO3 encryption key and throws an exception if no encryption key is set. This check is however superfluous, since `TYPO3\CMS\Core\Core\Bootstrap::checkEncryptionKey()` already does the same. The check in extbase `HashService` can therefore safely be removed. Resolves: #101485 Releases: main Signed-off-by:
Torben Hansen <derhansen@gmail.com> Change-Id: Iae448a56ba738ac4f46e8c6b53c27525ffa99635 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80238 Tested-by:
-
Oliver Klee authored
Resolves: #101518 Releases: main Change-Id: Ie28b74c0cebf8a56908334801e218b61af7b4753 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80291 Tested-by:
-
Helmut Hummel authored
While the initial idea to store the current ContentObjectRender (cObj) instance in a request attribute, to pass it along to code that requires both, the request and a cObj, is solid, we missed that cObj itself does not require to hold the request as attribute. The patch changes this: The request attribute is only set for ContentObjects, as these are actually responsible for rendering and eventually evaluating a request or the cObj instance. This makes sure, that an instance of cObj is available for Extbase plugins as well as for Fluid view helpers, which can access the request via RenderingContext. By changing the concept slightly, all places that previously added the cObj to the request can be removed in favor of doing so only in AbstractContentObject and ContentObjectRenderer::callUserFunction. The latter is at least required for TypoScript using the old way of calling Extbase plugins with USER and it's userFunc property. The circular reference is now removed, by not passing the request that contains the cObj attribute to the cObj itself. This means: * When a cObj is available, one can obtain the request using its getter * Such request objects, do NOT contain an attribute containing the cObj * The cObj request attribute can now be obtained in all content objects (such as EXTBASEPLUGIN or FLUIDTEMPLATE) and user functions, that are called from be ContentObjectRenderer. Releases: main, 12.4 Resolves: #101170 Resolves: #100872 Related: #100623 Change-Id: I6acb1a92c8b02f1be2f3a396fe9d9465d6482033 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79519 Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
-
Andreas Fernandez authored
When creating a new site configuration, deleting the default language (English) and importing a new language afterwards now doesn't create an invalid site configuration with languageId 0 missing. Resolves: #100439 Releases: main, 12.4 Change-Id: Ic6a83328e92941e4c9894019aab5162f0b3937d9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78832 Reviewed-by:
-
linawolf authored
They should conform to the settings in `.editorconfig`. When your editor uses the `.editorconfig` file, these files become very hard to edit. I would backport this to make backports easier. Resolves: #101527 Releases: main, 12.4 Change-Id: I41e1782b46bbbf327106089f39dc28d2ca358761 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80293 Tested-by:
-
Christian Kuhn authored
Extension blog_example is used in various extbase tests. It defines invalid relations from tags table over MM to post and persons. The patch fixes the TCA - those relations now work in BE as well, when the fixture blog_example is activated. Essentially all functional tests that works with this extension break with the fixed TCA now. The major part of the patch is to disentangle the .csv import and export files to make them independent from each other per test-case, and to fix the imported and asserted db state along the way. Resolves: #101528 Releases: main, 12.4 Change-Id: I4fb7d6ac82962f8ef7b630b261d543f4ff626bde Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80283 Tested-by:
-
Benjamin Franzke authored
npm update lit lit-html @lit/reactive-element lit-element grunt build Releases: main, 12.4 Resolves: #101496 Change-Id: Ic8de6a200a70ca2721719b531dde2a146692b317 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80260 Tested-by:
-
Benjamin Franzke authored
Imports via bare module specifiers (such that do not start with / or .) are cache busted by their URL mapping in importmap — relative imports (inside lit) are not by default. This is why we used version-suffixed lit package folders in #96511 (pretty much like unpkg.com does). This got removed with #100245, as required updates for configuration files have not been applied automatically and the reason for the version suffix was undocumented and thus unclear. While we could fix those issues and add autoupdate support for configuration files, it is now decided to remap all relative imports, as this logic is present in our build setup anyway and eases future updates by creating smaller diffsets (not every file has to be renamed, only changed ones are updated). Note that technically a new helper grunt task es-module-lexer-init is added, which is required to await the asynchronous es-module-lexer parser initialization (written in web assembly, and therefore not synchronously available). This has worked "by luck" for the copy:ts_files task (because there we earlier tasks that implicitly awaited the initialization), copy:lit is forked off via the concurrent plugin, we need to ensure es-module-lexer is actually ready to be used. Resolves: #101504 Related: #101495 Related: #100245 Releases: main, 12.4 Change-Id: I7c714530d1a645da2d89179282f80bd730d12474 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80268 Tested-by:
-
Andreas Fernandez authored
The icon size constants defined in `\TYPO3\CMS\Core\Imaging\Icon` are moved into a new `TYPO3\CMS\Core\Imaging\IconSize` enum. All method accepting the old string constants are adapted to accept the enum class as well, while triggering a deprecation when a string is passed for compatibility reasons. Resolves: #101475 Releases: main Change-Id: Idd61594ed21b30033d13b4c653992756e66db7c1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80197 Tested-by:
-
- Aug 01, 2023
-
-
Thomas Hohn authored
This change converts class JsConfirmation a BitSet. Resolves: #100229 Releases: main Change-Id: I85372f2116888d5bd30af644086812edd3abfa32 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78188 Tested-by:
Alexander Schnitzler <git@alexanderschnitzler.de> Tested-by:
-
- Jul 31, 2023
-
-
Christian Kuhn authored
Creating reports.xml in acceptance tests and feeding this to gitlab has been added with issue #96628 in the hope to be useful for finding frequently failing ac tests. The gitlab UI however buries this, it's de facto impossible to make use of this information. We drop this definition again. Resolves: #101514 Related: #96628 Releases: main, 12.4, 11.5 Change-Id: I91f13f402f0b9f72f2ca41252db93bb1714efcd6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80286 Reviewed-by:
Jochen Roth <rothjochen@gmail.com> Reviewed-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
-
Christian Kuhn authored
In preparation of upcoming features in this area, the `@internal` class is refactored a bit: * `getPrioritizedFieldNames()` is moved into `SchemaMigrator` - it is logically more bound to this class and can live there as protected method. * Split `enrichSingleTableFields()` into two methods: One for fields created from TCA `ctrl`, one for fields created from `columns`. Resolves: #101510 Releases: main Change-Id: Idf5a45906b189f7492e6fcc97244fcf95cf8713a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80279 Tested-by:
-
Christian Kuhn authored
When select fields with db relations allow pages records, the DatabaseBrowser tries to render an icon from the page row. uid of that row may be an int, which needs to be cast to string to be fed to htmlspecialchars(). Resolves: #101513 Related: #100819 Releases: main, 12.4, 11.5 Change-Id: I52ee031cb0eb09f41ae8ecb6d7005f03e65de3bd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80282 Tested-by:
-
Helmut Hummel authored
The workaround for previous TYPO3 versions to allow nested renderings can now be removed, as instances are not shared any more. Releases: main Resolves: #101212 Change-Id: I661a2f6db860ea938d4809c244f8db1459a9667f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79573 Tested-by:
-
Christian Kuhn authored
> composer u typo3/cms-styleguide Resolves: #101508 Releases: main, 12.4 Change-Id: I824b05025c32eb72d10d908b9e61d6da6a7ca91a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80274 Tested-by:
-
Nikita Hovratov authored
Resolves: #101502 Related: #97330 Releases: main, 12.4 Change-Id: I1171ec0cf44c61480a0dffb0b6105022c8b8efed Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80269 Tested-by:
-
Oliver Klee authored
Resolves: #101506 Related: #101501 Releases: main Change-Id: I773b14ff1533e109d023afc90e3a9b0c23e829d6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80276 Reviewed-by:
-
Christian Kuhn authored
There is a last v13 deprecation removal patch pending, which will be finished next days. We can finish the ReST file now and resolve the epic. The patch gives some minor cleanups and adds a couple of forgotten things. Resolves: #100963 Releases: main Change-Id: Ifec0c7477ffb7c530b50a634aedf5a97965b740c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80270 Tested-by:
-
Susanne Moog authored
Removal of having extbase files as request arguments, use request->getUploadeFiles() instead. Releases: main Resolves: #101501 Related: #100963 Related: #97214 Change-Id: I3cc603428efed0e11f457e694cf1703340ef47fd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80106 Tested-by:
Susi Moog <look@susi.dev> Tested-by:
-
Oliver Klee authored
This method promises to return an int, but actually returns a float. Also add a regression test. > ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #101499 Releases: main, 12.4, 11.5 Change-Id: I85ca63c9b32717641d5926b16ee25e32eeb69310 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80264 Tested-by:
-
Thomas Anders | Naderio authored
The labels of inline FileReference fields were not concatenated but overwritten, in a loop since #92427. This patch corrects the concatenation and adds line-break divs, otherwise the strings are on a single line. Resolves: #99873 Related: #92427 Releases: main, 12.4, 11.5 Change-Id: I368cd0d2cbf7e9ed7fdd1d003f869cc894d6f13e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77782 Reviewed-by:
-
Oliver Klee authored
The fixture class `GeneralUtilityFilesystemFixture` was only needed to add vfsStream-specific workarounds for the tests. Now that the tests are not using vfsStream anymore, we can safely remove this class. Resolves: #101498 Releases: main Change-Id: I136882bbb9c47b9269c543c944e3465f073a917c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80263 Reviewed-by:
-
- Jul 30, 2023
-
-
Christian Kuhn authored
Add some waitFor() to the drag&drop tests and give the filter test a generic wait which hopefully stabelizes this one a bit as well. Resolves: #101494 Releases: main, 12.4, 11.5 Change-Id: I73d4d2415f4e100bed7f1d7e5ead1036d157af93 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80256 Tested-by:
-
Christian Kuhn authored
Those need some additional waitFor checks to be more stable since the v12 refactoring with all the new js magic. Resolves: #101493 Releases: main, 12.4 Change-Id: Ib5cf06f92ced20c5ee97a77ef15a870dcbf0c36a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80255 Tested-by:
-
Christian Kuhn authored
Similar to #101491, the other Application/Frontend acceptance tests get same treatment to wait for the "View webpage" icon being visible, before trying to click it. Resolves: #101492 Related: #101491 Releases: main, 12.4, 11.5 Change-Id: Ie8dd5338a6773baf8850fec0713dcd917699fbfc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80252 Tested-by:
-
Christian Kuhn authored
Fails locally occasionally. The additional explicit waitForElement() before clicking the elemnt stabilized it. Resolves: #101491 Releases: main, 12.4, 11.5 Change-Id: I4072daa0e949d3480f399e99a2f35d8ef889eded Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80249 Tested-by:
-
Oliver Bartsch authored
Additionally remove an outdated warning. Resolves: #101490 Related: #99220 Releases: main, 12.4 Change-Id: I0943ffa2097bd5284aa91d0bb6180a789e28e89f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80248 Reviewed-by:
Chris M�ller <typo3@krue.ml> Reviewed-by:
-
Torben Hansen authored
Add several type casts to avoid notices. Resolves: #101486 Releases: main, 12.4, 11.5 Signed-off-by:
-
