To avoid conflicts with normalize.css, we remove the normalization done by
ExtJS, which is loaded after the normalize.css now.

Resolves: #56418
Releases: 6.2
Change-Id: I8a5b633244c5074755d478d0497b8f438ef86b65
Reviewed-on: https://review.typo3.org/28069
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Felix Kopp
Tested-by: Felix Kopp
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-by: Frans Saris
Tested-by: Frans Saris

Make sure RootlineUtility::enrichWithRelationFields() respects
the setting of $TCA[$table]['ctrl']['enablecolumns']['disabled'] when
fetching foreign data for the rootline.

Otherwise hidden relations from sys_file_reference are added to the
rootline and cause exceptions in the frontend, instead of being ignored.

Resolves: #56150
Releases: 6.2, 6.1
Change-Id: I21917fec1407a10818058da8ea879b0bb39441a4
Reviewed-on: https://review.typo3.org/28277
Tested-by: Wouter Wolters
Reviewed-by: Alexander Opitz
Tested-by: Alexander Opitz
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring

Release PreparedStatementTest from an active DB connection. The
quote tests are refactored a bit to find out in one specific test
if it is done for parameters.

Change-Id: I37853cd49368c2b23d0c2d6926fc806618674279
Resolves: #56922
Related: #51436
Releases: 6.2
Reviewed-on: https://review.typo3.org/28398
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring

Test files and class naming is adapted to subject class names in
ext:core Log/Writer and the DatabaseWriterTests are rewritten to
not depend on initialized database connection anymore.

Change-Id: Ifff4e5a064018bb5b0db3bf9eeb1b9232adfb262
Resolves: #56921
Related: #51436
Releases: 6.2
Reviewed-on: https://review.typo3.org/28396
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring

Some tests still rely on initialized $GLOBALS['TYPO3_DB']. The patch
handles some easy cases in ext:core.

Change-Id: I5b720154035cc5f8b156a9358806673daaf9c9ec
Resolves: #56918
Related: #51436
Releases: 6.2
Reviewed-on: https://review.typo3.org/28394
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring

The JavaScript in the RTE element browser is now initialized at the
end of the initialization process to make sure that all required
class variables (like $this->act) are initialized.

Resolves: #56860
Releases: 6.2
Change-Id: I39d3223921c5b17cffb31d98d62f02fa46663d27
Reviewed-on: https://review.typo3.org/28338
Reviewed-by: Tymoteusz Motylewski
Tested-by: Tymoteusz Motylewski
Reviewed-by: Markus Klein
Tested-by: Markus Klein

Change-Id: I4bd6ff219c3232211106e968fce45ee3f2dd674a
Resolves: #56914
Related: #51436
Releases: 6.2
Reviewed-on: https://review.typo3.org/28390
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring

Mock deterimenRootline to suppress calling database stuff
in dependencies.

Change-Id: I54938f9e20d52eda568c6520fa7bd72ec19b61e2
Resolves: #56912
Related: #51436
Releases: 6.2
Reviewed-on: https://review.typo3.org/28388
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring

ext:backend test getNodesSetsIsMountPointField() works on getNode()
of PageTree DataProvider. The method has tons of dependencies that
are sometimes even static, and the method is recursive. It is very
hard to test properly and the current test is still not mocking
completly. The test is removed for now since it does not give us
much benefit and is hard to maintain in current state, the subject
method should be covered by tests again if it was refactored.

Change-Id: I344c584b4d6e3868471f4857a08223be3a5d03e4
Resolves: #56907
Related: #51436
Releases: 6.2
Reviewed-on: https://review.typo3.org/28384
Reviewed-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

The workspace modify test "changeElementSorting" is failing
in the frontend for the TCA types "select" and "group".

The reason is, that the move placeholder is not selected
via the "uidInList" TypoScript property and thus removed
in PageRepository::versionOL().

To avoid that, "uidInList" gets extended to look-up
move placeholders if versioning preview is enabled.

Resolves: #56782
Releases: 6.2
Change-Id: Ifae30527bead02b38888f326de2615f6bfe35f5b
Reviewed-on: https://review.typo3.org/28278
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
Reviewed-by: Thorsten Kahler
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Do not call __construct of subject.

Change-Id: I7b936efde9220c847b0a6278ea0d5b3606203e17
Resolves: #56894
Related: #51436
Releases: 6.2
Reviewed-on: https://review.typo3.org/28374
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Unittests reveal some warnings which are caused by incomplete mocking.

Change-Id: I42089bb6c9016187d83382a2fa10450310993a84
Resolves: #56700
Related: #51436
Releases: 6.2
Reviewed-on: https://review.typo3.org/28370
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

The checkbox "Include Access Lists" in the be_groups just produces extra
clicks and extra reloads. If you don't need those information in the
current group, just don't look at the tab.

Change-Id: I300f711944e76e4366472cf99011e1b193224239
Resolves: #56893
Releases: 6.2
Reviewed-on: https://review.typo3.org/28373
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

If the FunctionalTestCaseBootstrapUtility::removeInstance() tries to
delete an existing symlink to a folder, the function unlink() is used.
This leads to a warning on Windows systems because unlink can only
delete files and symlinks to files.
This patch adds a rmdir() call for symlinks which works for Windows
system as well.

Resolves: #56892
Releases: 6.2
Change-Id: I2de757daea89a65a0a631c7592287e16218c1452
Reviewed-on: https://review.typo3.org/28371
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind

* Improves the structure
* Removes useless if
* Retrieves the cacheManager only once

Resolves: #56879
Releases: 6.2
Change-Id: Id96a3c74a58a9ebb9eb16aa55f87791afcba6a66
Reviewed-on: https://review.typo3.org/28351
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind

Remove dependencies in BackendUtilityTest with better mocking and
introduce static:: instead of self:: in BackendUtility for late
static binding.
The flexForm test for getExcludeFields() is separated to an own
test and an array duplication bug confusing array key and value
in getExcludeFields() is fixed along the way.

Change-Id: If242bab64075aee5050dfc77317e54dcb2f5e25d
Resolves: #56854
Related: #51436
Releases: 6.2
Reviewed-on: https://review.typo3.org/28331
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind

Use a table with the according styles instead of
the old bgColor4/6 classes

Resolves: #56870
Releases: 6.2
Change-Id: I272f13f3c77a8b174d6a62524ed7a0afa6da90cc
Reviewed-on: https://review.typo3.org/28346
Reviewed-by: Felix Kopp
Tested-by: Felix Kopp
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

* Move modAccess check to constructor
* Move isLoaded check to constructor
* Remove check if extbase is loaded
* Replace $TYPO3_CONF_VARS to $GLOBALS['TYPO3_CONF_VARS']

Resolves: #56831
Releases: 6.2
Change-Id: Ib824d34219bc1afb646fbaf70b572b6bd3a55a47
Reviewed-on: https://review.typo3.org/28308
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind

* Remove deprecated calls to require_once
* Restore license header
* Remove empty TODO file

Resolves: #56832
Releases: 6.2
Change-Id: I291f5469638659d64e9df181017d1588f27317e1
Reviewed-on: https://review.typo3.org/28309
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind

Resolves: #56838
Releases: 6.2
Change-Id: Iac44b90bc96529458a2e452e47cb5548600464b0
Reviewed-on: https://review.typo3.org/28315
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind

Resolves: #56834
Releases: 6.2
Change-Id: Iec646bbae646bb85479f9f19c438e6aa9283e0dd
Reviewed-on: https://review.typo3.org/28311
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind

Resolves: #56837
Releases: 6.2
Change-Id: Ieec0e8f532abd8fab0444e137c31424f1a69b67e
Reviewed-on: https://review.typo3.org/28314
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind

* Remove deprecated require_once call

Resolves: #56835
Releases: 6.2
Change-Id: I7d79b4c9947c5f3da82c66a4dbb0e3d2e0fd9284
Reviewed-on: https://review.typo3.org/28313
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind

Unittests reveal some warnings which are caused by incomplete mocking.

Change-Id: Iee09220d675335aeadd286c2d4544d53c981016f
Resolves: #56700
Related: #51436
Releases: 6.2
Reviewed-on: https://review.typo3.org/28365
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Use native PHP-functionality provided by htmlspecialchars()
with a parameter since PHP 5.2.3 to prevent double-encoding
instead of calling deHSCentities().

Change-Id: I2863181259046f16b554770a3f1ed8b03112fedf
Resolves: #50449
Releases: 6.2
Reviewed-on: https://review.typo3.org/22580
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Alexander Opitz
Tested-by: Alexander Opitz
Reviewed-by: Pascal Dürsteler
Reviewed-by: Stefan Froemken
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring

Method doLanguageAndWorkspaceOverlay of
Extbase\Persistence\Generic\Storage\Typo3DbBackend should not attempt
to get a parent record if the overlays are in a separate table (most
probably pages_language_overlay) by checking whether
$GLOBALS['TCA'][$tableName]['ctrl']['transOrigPointerTable'] is set.

Resolves: #56855
Releases: 6.0, 6.1, 6.2
Change-Id: I2cb53bc4733ee626ca0ae92e5dd91073d88ecc9d
Reviewed-on: https://review.typo3.org/28333
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
Reviewed-by: Marc Bastian Heinrichs
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring

Table sys_file_metadata shares the same title as table sys_file
which makes it impossible to distinguish when granting access
in a be_groups record.

Fixes: #56890
Releases: 6.2
Change-Id: Ibce38f0f878e34c06a0d66c550fe7bf62cc33700
Reviewed-on: https://review.typo3.org/28361
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers

The records of EXT:extensionmanager are also set to adminOnly=TRUE

Resolves: #56808
Releases: 6.2
Change-Id: I79f7dae056c8ede8e041f71200dc1f88b7a5551c
Reviewed-on: https://review.typo3.org/28290
Reviewed-by: Wouter Wolters
Reviewed-by: Markus Klein
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring

PHP issue https://bugs.php.net/bug.php?id=50688 triggers a warning
in ArrayUtility::sortArraysByKey() on some supported PHP versions
like debian wheezy 5.4.4. Since this is a language error and the
code itself is correct and covered by unit tests, the warning is
now suppressed using the @ operator.

Change-Id: Ie169774d8659e55542f0c831078c00958de257c9
Resolves: #56889
Relases: 6.2
Reviewed-on: https://review.typo3.org/28359
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

If an extension manual is available locally, it should be
linked in Extension Manager.

Resolves: #56880
Releases: 6.2
Change-Id: I24572348e0dc79513ece37477e3aee186676d923
Reviewed-on: https://review.typo3.org/28352
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Markus Klein
Tested-by: Markus Klein

So far the entries "Hide/Unhide" and "Visibility settings" always
showed up in the ClickMenu. We need to check via excludefields if the
other has any right to change such a field or hide the icons.

Change-Id: Ib86fbd6d30f2cc0ec52e506d5fa2f12c95a2f178
Resolves: #55683
Releases: 6.2, 6.1
Reviewed-on: https://review.typo3.org/27348
Reviewed-by: Stefan Froemken
Tested-by: Stefan Froemken
Reviewed-by: Markus Klein
Tested-by: Markus Klein

setUp() of memcache cache backend tests checks with fsockopen() if
a connect to memcache is possible to skip the tests if memcache is
not available. If fsockopen fails it throws a warning, this should
be suppressed.

Change-Id: I8590d20201e76f0768e5beb0c9b549b2b48933ec
Resolves: #56885
Releases: 6.2
Reviewed-on: https://review.typo3.org/28357
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring

Resolves: #56683
Releases: 6.2
Change-Id: I471e5b44eeb2dcb29217fbea3a33b4aba95e2cdd
Reviewed-on: https://review.typo3.org/28191
Reviewed-by: Christian Kuhn
Reviewed-by: Wouter Wolters
Reviewed-by: Stefan Neufeind
Tested-by: Christian Kuhn
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring

* Remove deprecated require_once call

Resolves: #56827
Releases: 6.2
Change-Id: Iae4b666f7bb3ff81194ea6a6ff51b84fd9a1112c
Reviewed-on: https://review.typo3.org/28304
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring

This adds a way for third party extensions to process
extensions' available actions in Extension Manager.

Resolves: #56869
Releases: 6.2
Change-Id: I7cbacba7fccfd3178dc1265ad69bf5dec531cf70
Reviewed-on: https://review.typo3.org/28347
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers

Add missing checks if type column exists in a row.

Resolves: #56830
Releases: 6.2, 6.1
Change-Id: Ifafdb0c51266c76620696c6d94471b3efddba112
Reviewed-on: https://review.typo3.org/28342
Reviewed-by: Andreas Kiessling
Tested-by: Andreas Kiessling
Reviewed-by: Alexander Opitz
Tested-by: Alexander Opitz
Reviewed-by: Markus Klein
Tested-by: Markus Klein

There are several calls to check if extensions like extbase are loaded.
As those extensions cannot be removed and are always loaded,
the code can be removed.

Resolves: #56858
Releases: 6.2
Change-Id: I434daaa2e5ae98ac623e8c9c06a0cb41560d3610
Reviewed-on: https://review.typo3.org/28335
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Stefan Neufeind
Reviewed-by: Oliver Klee
Tested-by: Stefan Neufeind
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer

Method array2xml converts elements with value NULL to
nodes with attribute type "NULL" and empty value, e.g.:
<node index="myIndex" type="NULL"></node>
This is not correct transformed back in xml2array and results
in an empty string as value.
This in turn results in wrong imported data using impexp with
xml format.

Resolves: #55082
Releases: 6.2
Change-Id: Icfea2f2b7524c44711866c3f75f06331a1958183
Reviewed-on: https://review.typo3.org/27845
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Markus Klein
Tested-by: Markus Klein

Some constants have been renamed in #10655 but the method comments still
use the old names

Resolves: #54947
Releases: 6.2
Change-Id: Ia40062b190139dd6d1adf9a248247b81986fc402
Reviewed-on: https://review.typo3.org/28339
Reviewed-by: Alexander Schnitzler
Tested-by: Alexander Schnitzler
Reviewed-by: Marc Bastian Heinrichs
Tested-by: Marc Bastian Heinrichs

This patch allows the use of backslashes to escape dots in
TypoScript keys, for example:

my\.escaped\.key = test

will result in a single key "my.escaped.key" with the
value "test".

Additionally it is possible to protect backslashes from beeing
interpreted as escape characters by using double backslashes.

Resolves: #29461
Documentation: #56249
Releases: 6.2
Change-Id: Idcaae75d9a8800134f4a82e0740ddabe35b3df89
Reviewed-on: https://review.typo3.org/19480
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
Reviewed-by: Stefan Neufeind
Reviewed-by: Alexander Stehlik
Tested-by: Alexander Stehlik
Reviewed-by: Markus Klein
Tested-by: Markus Klein