Change-Id: Id427222d16e707dcf19ca67d94fcf03b694dd9ca
Reviewed-on: https://review.typo3.org/19786
Reviewed-by: TYPO3 Release Team
Tested-by: TYPO3 Release Team

Change-Id: I78ce8b1a7b538770bbf3069cebed53e1e0ef58d8
Reviewed-on: https://review.typo3.org/19785
Reviewed-by: TYPO3 Release Team
Tested-by: TYPO3 Release Team

t3lib_userAuth::fetchUserRecord is not callable without a username.
Fix the $usernameClause to generate a correct SQL query.

Change-Id: I56b5f8bf8b326e880f157c3b4a5a15409305c3d9
Fixes: #39248
Releases: 6.1, 6.0, 4.7, 4.5
Reviewed-on: https://review.typo3.org/13041
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Stefan Neufeind
Reviewed-by: Mattias Nilsson
Reviewed-by: Nicole Cordes
Reviewed-by: Dmitry Dulepov
Tested-by: Dmitry Dulepov
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert

Some old code inside css_styled_content is unused, old and just
using disk space. Solution: Remove it.

Change-Id: I0ed50512c7b0f5e1906ff329662cb4662188788a
Resolves: #47088
Releases: 6.1
Reviewed-on: https://review.typo3.org/19773
Reviewed-by: Nicole Cordes
Tested-by: Nicole Cordes
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer

Class and filename are called DbBackendTest, but should be
Typo3DatabaseBackendTest.

Change-Id: I1ae8fca733151e05ae4aedf8a5a479f568e3e998
Fixes: #47082
Releases: 6.1, 6.0
Reviewed-on: https://review.typo3.org/19764
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Change-Id: I737d084412aef6a510be49c2252931854828dd70
Reviewed-on: https://review.typo3.org/19757
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Furthermore there is outstanding code to be
removed which is deprecated.

Resolves: #26508
Releases: 6.1
Change-Id: Ic2fa23d9d87fa81c6ec4526afba2d75064a693bc
Reviewed-on: https://review.typo3.org/1799
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
Reviewed-by: Wouter Wolters
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack

IconUtility::getIconImage
is not used anymore in the core, so deprecated this function.

Change-Id: Ic9d33160d0ca802dcdec929400f7919e39c8aec8
Resolves: #22706
Releases: 6.1
Reviewed-on: https://review.typo3.org/12903
Reviewed-by: Nicole Cordes
Tested-by: Nicole Cordes
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack

Currently the form is not reloaded if you change the storage inside a
file collection record.
You need to save the form before you can select a folder.

Automatically reload the form after changing the storage.

Fixes: #47007
Releases: 6.1,6.0
Change-Id: Ide6dddca64707f7f353aecc98943c79afd9eec78
Reviewed-on: https://review.typo3.org/19718
Reviewed-by: Alexander Opitz
Tested-by: Alexander Opitz
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter

The content object renderer adds absRefPrefix to all
generated image URLs, leading to incorrect URLs for
storages not relative to the siteroot. Additionally,
the URLs generated by the driver are also escaped in
ContentObjectRenderer::cImage(), leading to broken
absolute URLs.

Change-Id: I40c0a7ea55ff3a1155e7a05b1fc37da7d0cf44e4
Resolves: #42223
Releases: 6.1, 6.0
Reviewed-on: https://review.typo3.org/15837
Reviewed-by: Alexander Opitz
Reviewed-by: Nicole Cordes
Tested-by: Nicole Cordes
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter

Process of downloading and installing remote extensions takes
some time - this patch brings visual feedback to inform users
that something complex is happening in the background.

Change-Id: Iae6c8ca90f163b49b0d6a63740eb773f29127d91
Fixes: #46274
Releases: 6.1, 6.0
Reviewed-on: https://review.typo3.org/19722
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

The exception message in ExtensionManagementUtility::makeCategorizable
now refers to namespaces instead of t3lib.

Fixes: #42996
Releases: 6.1, 6.0

Change-Id: Ifd52a2fb96335fa9bde6ec98b6ddcf8dd4c6bf74
Reviewed-on: https://review.typo3.org/16451
Reviewed-by: Steffen Ritter
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack

The function buildUrl in the TYPO3\CMS\Core\Utility\HttpUtility class
does not handle any port setting. This has to be added after the host
setting separated by a colon.

Change-Id: Ie2b24dd076b8abc79ababbd19d6699d6a9fb47a3
Fixes: #47012
Releases: 6.1, 6.0, 4.7
Reviewed-on: https://review.typo3.org/19721
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

All magic images of the RTE are still residing in uploads/
with a name like RTEmagicC_*.

The update wizard moves the files to fileadmin/_migrated_/RTE/
and adds them to the file index.

Resolves: #46614
Releases: 6.1
Change-Id: Ie5fa6bdf84e994e9e1ac3c804ce4eecdce072c86
Reviewed-on: https://review.typo3.org/19232
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack

If a content element is opened from the opendocs module, a warning is
shown because overrideVals is used without checking if it is an array.

Fixes: #46965
Releases: 6.1, 6.0, 4.7, 4.5
Change-Id: If25b21121708226594cfac6436278c297f32ddb9
Reviewed-on: https://review.typo3.org/19636
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Move placeholder are visible in the navigation
during WS preview if they are moved for example
from the first to the second level.

Change-Id: I7e3339488d9d64cdf04154fb0334880f76576f8d
Fixes: #38705
Releases: 6.0,4.7,4.6,4.5
Reviewed-on: https://review.typo3.org/12666
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack

If a file is uploaded within the backend (f.e. file-module)
the file is not automatically indexed. If done within the
file-module the indexing happens when the folder is shown.
If the file is uploaded somehow else using the
ExtendedFileUtility it's not indexed.

Add the indexing to the upload function.

Releases: 6.1, 6.0
Fixes: #46595
Change-Id: I9ea30797390f960a8e382a1f2c456259d3daa60c
Reviewed-on: https://review.typo3.org/19218
Reviewed-by: Alexander Opitz
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack

If you enter HTML to update a field in e.g. TCA to write the value into
extTables.php, then the HTML will be printed into the configuration
module.
htmlspecialchar the output.

Fixes: #46999
Releases: 6.1,6.0,4.7,4.5
Change-Id: I390b4252316b8bdf01e5bbcc5a8b33833bdf73e8
Reviewed-on: https://review.typo3.org/19694
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

The types default and input are deprecated. Removing of this let
the ConstantsView crash, as there is no function configuration for them.

We now readd the config in 6.1 as we have no problems with this lines
in the core and we don't know how much extsnions exists which fail.

Resolves: #46996
Related: #44763
Releases: 6.1, 6.0
Change-Id: I670e80bab6b415997fcfd26de19fba870a0f8446
Reviewed-on: https://review.typo3.org/19697
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

The Fluid IfViewHelper doesn't need any longer array items to perform
string comparison.
The patch removes all occurences in extensionmanager sysext.

Resolves: #46995
Releases: 6.1
Change-Id: If533afd4d0f4522b3455e308a7f01969f4fb0326
Reviewed-on: https://review.typo3.org/19691
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring

On calling upon AllVersionsView in Extension Manager the sorting of
version column should be enabled as default.

Resolves: #46997
Releases: 6.1, 6.0
Change-Id: Id8ce5388f892686cdba0137804e9e093860dfbf5
Reviewed-on: https://review.typo3.org/19693
Reviewed-by: Alexander Opitz
Tested-by: Alexander Opitz
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

The core still access xliff language files as .php or .xml,
although the files themselves are converted to .xlf since quite
some time. This could cause confusion.

This is a cleanup taken all .xlf files in the EXT:lang/.xlf
directory and run via a sed script (thanks to Stucki)

Resolves: #46940
Releases: 6.1
Change-Id: I427776b176ba2c23678689029eaf388dff90d0fa
Reviewed-on: https://review.typo3.org/19579
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

The code for clearing text fields in the extension manager is now
encapsulated in a jquery plugin, and the form for searching the TER
is automatically submitted if it is cleared and a search result was
shown.

Resolves: #46853
Related: #43410
Releases: 6.1
Change-Id: I36ec6b3614cf18551018eba1d0dee15bdaf63b5e
Reviewed-on: https://review.typo3.org/19505
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

The dataTable sortes version string incorrectly:

1.12.1
1.1.1

Intended:
1, 2, 3, ., 9, 10, 11, ., 99, 100, 101, ...

Also disable sorting on column "Actions"
Fixes: #46977
Releases: 6.1, 6.0

Change-Id: Ie6211edee52bf712f4463a57d800f0c1e705f1da
Reviewed-on: https://review.typo3.org/19674
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

The t3InstId option was introduced in version 3.x and never used
by the old EM, and is not even used by the current EM, and also
not with the t3o. As long as there is no functionality
that deals with that option, it should be removed completely again.

Resolves: #46993
Releases: 6.1
Change-Id: Ic506c89375ce012c6ea2bb73649aaa50a2155104
Reviewed-on: https://review.typo3.org/19689
Reviewed-by: Alexander Opitz
Tested-by: Alexander Opitz
Reviewed-by: Wouter Wolters
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring

Change-Id: Iac334745b537a15af9291cd05917a38a9e4eaf95
Releases: 6.1
Reviewed-on: https://review.typo3.org/19688
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Felix Kopp
Tested-by: Felix Kopp
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Magdalena Leichsenring
Tested-by: Magdalena Leichsenring
Reviewed-by: Alexander Opitz
Tested-by: Alexander Opitz
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack
Reviewed-by: Nicole Cordes
Tested-by: Nicole Cordes
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter

Further processing empty header-values with
functions like parseAddress() can lead to
unexpected problems.

Change-Id: Ida436f384a6a6a86d7fbd119083a9037157f48df
Fixes: #42106
Releases: 4.5, 4.7, 6.0, 6.1
Reviewed-on: https://review.typo3.org/15779
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Philipp Gampe
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Filenames of files uploaded in TYPO3 CMS before 6.0.1
can contain problematic characters, because filename
sanitizing of added files was introduced with 6.0.1.

The same happens if files are not uploaded through
the TYPO3 backend and then indexed.

The filenames of processed files are sanitized when
adding them to the storage but the not sanitized
original filename identifier is kept in the database
record of the processed files, which causes wrong
generated paths.

Update the identifier of the processed file along
with all other properties after adding them
to the storage.

Change-Id: I53e4eb42def291ba88ce18209a348b1e2f592185
Resolves: #45221
Related: #42925
Releases: 6.1, 6.0
Reviewed-on: https://review.typo3.org/18529
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack

If you open an extension in the get menu (show all versions), a link to
the manual is rendered.
It currently opens with target _top.

Change it to _blank to force opening the link in a new window.

Fixes: #46983
Releases: 6.0,6.1
Change-Id: Ie4f8bd09e94addc453b13a4fcc9745c39f14fe2c
Reviewed-on: https://review.typo3.org/19669
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Currently the function calcAge returns the value -0 min for zero seconds.
This should be changed as zero is unsigned. Besides some UnitTests are
added to verify the functionality of that function.

Change-Id: Ie0c7572e63bf8d3a6f074f2ccf0db63ac6f5c801
Fixes: #46984
Releated: 6.1, 6.0
Reviewed-on: https://review.typo3.org/19670
Reviewed-by: Alexander Opitz
Tested-by: Alexander Opitz
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

The dataTable was encapsulated within a pagination.
Now there is only the dataTable which displays all versions at once.

Change-Id: I3c82beea56bc225f9197b25b214e10c5c41efe4b
Fixes: #46976
Releases: 6.0, 6.1
Reviewed-on: https://review.typo3.org/19662
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Alexander Opitz
Tested-by: Alexander Opitz
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack

Travis fails to execute some newly introduced Factory
Tests. This patch aims to clean them up and make
Travis happy again :)

Change-Id: I8b57eb9bd3cbcb2cb3fc2831a4d1fbffa1c30877
Resolves: #45748
Releases: 6.1, 6.0
Tested-by: Christian Kuhn
Reviewed-on: https://review.typo3.org/19672
Reviewed-by: Christian Kuhn
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring

Increase the visibility of upload form in "Manage extensions".

Change-Id: I6b3b563aac28d834023dc39d7d79e963f62eb23f
Fixes: #46979
Releases: 6.1, 6.0
Reviewed-on: https://review.typo3.org/19667
Reviewed-by: Alexander Opitz
Tested-by: Alexander Opitz
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Get folder instead file object if a path is given to FAL.

Change-Id: I6d183d319eacbab403079b126685a13eb3ae7d5c
Resolves: #45748
Releases: 6.1, 6.0
Reviewed-on: https://review.typo3.org/18690
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-by: Alexander Opitz
Tested-by: Alexander Opitz
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring

Fixes the "read online" link in extension detail view.

Change-Id: I54cb1c90cb1f11b101a06160a67d2bac34185985
Fixes: #46978
Releases: 6.1, 6.0
Reviewed-on: https://review.typo3.org/19663
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Alexander Opitz
Tested-by: Alexander Opitz
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

* Make use of the "use" statement for GeneralUtility
* Long lines are spread over more lines for readability

Change-Id: I6299913aa83588782b2a27d9e4105811746cf91f
Resolves: #46900
Releases: 6.1
Reviewed-on: https://review.typo3.org/19549
Reviewed-by: Alexander Opitz
Tested-by: Alexander Opitz
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Corrects padding+margins for text, group, container in
configureExtension view.

Change-Id: If6ea1f596e13ae1179e01ad3798e900f64ce8dd2
Fixes: #46958
Releases: 6.1, 6.0
Reviewed-on: https://review.typo3.org/19660
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Because of folder renaming the autoloader of saltedpasswords is not
executed anymore so rsa and saltedpasswords are not installed by default.

Change-Id: Ib4c950e77048f2fcbca20d0f7bf2a0b7f9f11a0e
Fixes: #43241
Releases: 6.1, 6.0
Reviewed-on: https://review.typo3.org/19647
Reviewed-by: Alexander Opitz
Reviewed-by: Wouter Wolters
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Fix three occurences of old class names in phpdoc.

Fixes: #46972
Releases: 6.0,6.1
Change-Id: Ia9b37cecf92dd21b8bea83ef351e1006c420b83f
Reviewed-on: https://review.typo3.org/19650
Reviewed-by: Wouter Wolters
Reviewed-by: Magdalena Leichsenring
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

The showAllVersions view is not easily accessible since only
tiny links point there. This patch adds further links.

Change-Id: I75b7a51a902a43d0ea584d037ee023a695c943ec
Fixes: #46971
Releases: 6.0, 6.1
Reviewed-on: https://review.typo3.org/19648
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn