- Aug 09, 2024
-
-
Christian Kuhn authored
Wait for the modal body iframe being there before switching to it. This is mainly an issue in v11 where the modal takes more time server side and webdriver is 'too quick' switching to it. We still sanitize all branches. Resolves: #104577 Releases: main, 12.4, 11.5 Change-Id: Ida09f1945daae3d0fb396f1e495e91ed5042454a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85566 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
-
- Aug 08, 2024
-
-
Christian Kuhn authored
Youngest patch levels improve detection and obsolete a baseline entry. > composer req --dev phpstan/phpstan:^1.11.10 Resolves: #104575 Releases: main, 12.4 Change-Id: I8ee69c3be26da678a9ba4e0e972769e958b95b43 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85564 Tested-by:
-
Willi Wehmeier authored
Avoid fetching and redrawing the record overview table when the search term input field gets focussed. This prevents breaking the ui state and unwanted deselecting of rows. Resolves: #103802 Releases: main, 12.4 Change-Id: I3ff0f478e1a91a1a785f7093b26d1bf610dac921 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85559 Tested-by:
-
- Aug 07, 2024
-
-
Georg Ringer authored
Moves require statements into a custom method to avoid clashes with local variables. Resolves: #104509 Releases: main, 12.4 Change-Id: I632be874a18787cd75b0a6ff326f57a185a116be Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85465 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
-
Garvin Hicking authored
If an invalid record in `sys_be_shortcuts` is stored like this: ``` INSERT INTO sys_be_shortcuts (userid,route,arguments) VALUES (1,'record_edit','[]'); ``` then the backend cannot be accessed anymore due to PHP errors due to unguarded array key access of the "arguments" contents. This patch guards the array key access to prevent such a situation, so an invalid shortcut can be deleted from the menu. Database records like this might happen for migrated older installations. Resolves: #104496 Releases: main, 12.4, 11.5 Change-Id: I350e620eb403e53d1828cf5dedaab633ba00db55 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85463 Reviewed-by:Stefan Bürk <stefan@buerk.tech> Tested-by:
-
Bastian Stargazer authored
This commit fixes the former hard-coded "allowAttribs" for <span> tags by replacing them with the defined "allowAttributes" values of the YAML/TSconfig processing configuration. In addition, some other fixed lists are moved into class properties. Note that to alter the "span" configuration for example to restrict allowed attributes (or to allow an empty span tag) you can still use the following YAML/TSconfig: YAML: ``` processing: HTMLparser_db: tags: span: rmTagIfNoAttrib: 0 allowedAttribs: 'class,data' ``` TSconfig: ``` RTE.default.proc.HTMLparser_db.tags.span { rmTagIfNoAttrib = 0 allowedAttribs = class,data } ``` Resolves: #104520 Releases: main, 12.4 Change-Id: I170ef6ee0e38e013307ac72c00a13447795e3b8d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85462 Tested-by:Benni Mack <benni@typo3.org> Reviewed-by:
-
- Aug 06, 2024
-
-
Christian Rath-Ulrich authored
The heading structure in the "Dashboard" backend module has been updated and a hidden h1 has been added. Additionally, role attributes have been added to various elements. Resolves: #104070 Releases: main, 12.4 Change-Id: I852ae244ecc399129e99be43f3e9cd58012c9dcc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85461 Tested-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Reviewed-by:
-
Benni Mack authored
Resolves: #103756 Releases: main, 12.4 Change-Id: Ia2ae18406dda05c232546910d73d108a42af7bf2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85540 Tested-by:
-
Christian Kuhn authored
Resolves: #104557 Releases: main, 12.4, 11.5 Change-Id: I1bea6d74fc444007c8787e0a642c86b35a7ccb90 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85537 Tested-by:
-
Georg Ringer authored
The Site Configuration module currently allows to pick a language locale from a list of available locales of the system (via the "locale -a" command). This patch moves this functionality into a reusable method, which is now also utilized from within the Install Tool when configuring the `TYPO3_CONF_VARS[SYS][locale]` option. The description of this "locale" option now holds all possible locale variants. If the "locale -a" execution fails, the output will show an empty list. Resolves: #61189 Releases: main, 12.4 Change-Id: Icf048be100e8e658fb14bb983d7bab5101bd1587 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85533 Tested-by:
-
Christian Rath-Ulrich authored
To improve accessibility in ClearCacheToolbar dropdown menu, the descriptive text of each entry is hidden for screen readers and re-inserted after the link. Resolves: #104086 Releases: main, 12.4 Change-Id: I30f862cb420cb01f837014872174967c1041df2e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85531 Tested-by:
-
Christian Kuhn authored
composer/composer as dev dependency got a security release relevant for monorepo. We should raise to it. > composer u composer/class-map-generator > composer req --dev composer/composer:^2.7.7 Resolves: #104556 Releases: main, 12.4 Change-Id: Ib9b81a942456f1ac78445f27b4b0b198ff204e2d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85532 Tested-by:
-
Andreas Kienast authored
Executed command: npm audit fix Resolves: #104551 Releases: main, 12.4 Change-Id: I44ead5b72e8cba08da196210e4a5eb7d05a1aed4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85514 Tested-by:Andreas Kienast <a.fernandez@scripting-base.de> Reviewed-by:
-
Andreas Kienast authored
The previous implementation of notification tests relied on real browser timeouts, artifically slowing down their execution (roughly 11 seconds). Sinon (the stub library we use) provides API to mock several timing functions (e.g. `setTimeout()`) which can be incorporated for most cases. There's one caveat tho: notifications are visually hidden with an animation that executes for 400 ms and get removed from DOM after that. Sinon cannot mock timings for CSS-driven animations. To workaround this, a new event is introduced that is usually triggered after animation has ended. This reduces the runtime of the affected test from ~11 seconds to ~1.2 seconds. Resolves: #104553 Releases: main, 12.4 Change-Id: Iffd662e0ce9a87332a65ca50fb5ecb17623c764f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85529 Tested-by:
-
Christian Rath-Ulrich authored
The login screen can now be scrolled and is therefore usable even at larger zoom values. In addition, the currently-focused link elements are now highlighted. Resolves: #104405 Related: #92945 Releases: main, 12.4 Change-Id: If75b051a247bdd1b41031bf6956b90dc5cfb97d8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85528 Reviewed-by:
-
Andreas Nedbal authored
Since the file upload button shows the dialog directly it is not necessary to also show the dropzone behind it. This also solves the problem of the dropzone staying visible when a user decides to not upload any file and cancelling the file dialog. Resolves: #101197 Releases: main, 12.4 Change-Id: I33b8c73582c19c94927187e26bf4513d1a1d6e07 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85527 Tested-by:
-
Hannes Lau authored
Fix a bug where backend users without permissions to edit the default language would see an error message once they open the translation of a content element that contains an IRRE field with untranslated elements. Allow the language bound editor to open the translation of the content element and localize untranslated IRRE children. Resolves: #102625 Releases: main, 12.4 Change-Id: Icdbf5cb6a3f994b840c8e26bc4eb5886574823fa Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85526 Tested-by:
-
Oliver Hader authored
Resolves: #104554 Releases: main, 12.4 Change-Id: I4b4c8459526024ad0535d35ec8d43f7ead6e1e1d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85524 Tested-by:
-
Christian Rath-Ulrich authored
Resolves: #104093 Releases: main, 12.4 Change-Id: I6aed9dd862ff284aa0fec9587005b016588cdd42 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85522 Reviewed-by:
-
Christian Rath-Ulrich authored
Resolves: #102997 Releases: main, 12.4 Change-Id: I5ba1df13c4d7b548f6094fbbe4bf98796afe68f7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85520 Reviewed-by:
-
Christian Rath-Ulrich authored
To enhance accessibility, the correlation between column headings and corresponding grid cells in the "Page" backend module has been improved. Resolves: #104011 Releases: main, 12.4 Change-Id: I8b9c37bcd89ad2b4e46ac1584400d69aeee18b4c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85519 Tested-by:
-
Oliver Hader authored
CSP violation reports might contain non-HTTP referrer URIs, like `android-app://com.google.android.googlequicksearchbox/`, which results in an exception, since the `android-app:` scheme is not supported by the model in `\TYPO3\CMS\Core\Http\Uri`. This change introduces the `Uri::fromAnyScheme()` factory method, which instructs the parsing logic to skip the scheme validation. Resolves: #103935 Releases: main, 12.4 Change-Id: I45cad34a797d098e439a1c6fb80945948bf02e34 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85518 Tested-by:
-
Stefan Froemken authored
Move documentation of FormDefinition into its own section as FormDefinition is not part of form elements. Internally FormDefinition will be handled completely different. Add section to FormDefinition how to work with `fluidAdditionalAttributes` as part of `renderingOptions` instead of `properties` Resolves: #98225 Releases: main, 12.4 Change-Id: Iadf8aea2ef2f83756e50dc13a40cc3cc9cf5a038 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85454 Tested-by:
Lina Wolf <112@linawolf.de> Reviewed-by:
Stefan Froemken <froemken@gmail.com> Tested-by:
-
mschmigotzki authored
The button to stop scheduler tasks in the backend was technically a link with certain query parameters. As a result, these parameters were "passed through" after the scheduler task was stopped and falsified the next request (e.g. starting a scheduler task), which led to an incorrect result and a message in the backend. By adapting the link to a submit button with an associated form for stopping tasks in the backend so that a clean form can be sent, and by adapting the corresponding controller, this problem was solved. Resolves: #103002 Releases: main, 12.4 Change-Id: Ib65c42421b28c1d8d70a22aa5378c7406da882ab Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85517 Reviewed-by:
-
Torben Hansen authored
With #102770 the `delete()` method for a FileReference object has been implemented. This was however performed using a hard delete of the file reference record in the database, which is not appropriate, since the delete functionality must take into account, if the table is configured for soft or hard deletes. This patch changes the implementation, so the file reference is either hard or soft deleted depending on the TCA configuration. If the delete operation was successful, the reference index for affected records is now updated. Additionally, functional tests are extended to ensure, that the file used in the file reference remains when the file reference is deleted and that the reference index is updated accordingly. Resolves: #102785 Related: #102770 Releases: main, 12.4 Change-Id: I43beb066c2259441aa2ed7e3fba0e242b7d8fbbb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85516 Tested-by:
-
Georg Ringer authored
Add the CSP headers to the response created by the PageContentErrorHandler. Resolves: #104486 Releases: main, 12.4 Change-Id: Iffc783dc40989abacbab4766a03a865fdd37b5cf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85515 Tested-by:
-
Stefan Bürk authored
Doctrine DBAL retrieves for MariaDB `ENUM()` and `SET()` field default values quotes with single quotes, which leads to an endless field change reporting recursion in the database analyzer. The default value is now trimmed to ensure a working field compare within the extending `TYPO3\CMS\Core\Database\Schema\Comparator` class. Note that TYPO3 v13 (main) may reveal the same issue but is shadowed due to the general `ENUM()` and `SET()` type field issue since Doctrine DBAL 4, reported in #104413. That needs a change on its own for main only. Resolves: #97498 Related: #104413 Releases: 12.4, 11.5 Change-Id: I51b79a7f63db43cca2724958b0355a496a49fd33 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85511 Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Tested-by:
-
Henrik Ziegenhain authored
For nearly all form elements one can pass the fluidAdditionalAttributes property to the corresponding templates. So also allow Fieldset to use this property by default. Resolves: #102291 Releases: main, 12.4 Change-Id: I1c48db94626ba724409dc0d97deb3cde51553bf2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85512 Tested-by:
-
- Aug 05, 2024
-
-
Georg Ringer authored
The information about the allowed content types (typically CType) has been added to the user information in the beuser module. Resolves: #98590 Releases: main, 12.4 Change-Id: Ifb1377424d064071a90e0f5238c037ec4b347e4e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85459 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
-
- Aug 03, 2024
-
-
Corinne van der Zande authored
Previously, using the property cols="inline" doesn't have an effect for checkboxes with renderType checkboxToggle. This patch resolves this issue and introduces a test case in typo3/cms-styleguide. Resolves: #104487 Releases: main, 12.4 Change-Id: I2581bb462af80f2336b0cac76ce955e6b7411463 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85504 Tested-by:
-
Mathias Bolt Lesniak authored
SiteResolving will now correctly interpret a temporary ID of a new page (e.g., "NEW12345678ABCDEF") as an invalid ID and try to infer the site using `$result['effectivePid']`. This makes it possible to access site configuration properties within the TCA also on pages that have yet to be created. Resolves: #103573 Releases: main, 12.4, 11.5 Change-Id: I174e71e084e96b24ebe721ad0336a3dd1a8115d9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85457 Tested-by:
-
- Aug 02, 2024
-
-
Bastien Lutz authored
When creating a page with access set to "Show at any login" and trying to view that page with the admin panel "simulate user group" preview, the page is not displayed. This is because the provided frontend user does not contain the special group -2. Resolves: #104484 Releases: main, 12.4 Change-Id: I4504cdcadbdd6df217f74d258cd7e182ea23796e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85456 Tested-by:
-
Oliver Bartsch authored
In large installations, it's common to add sites, having site root option set, bundled into folders or similar structurs. Therefore, the auto creation of site configurations now also works for pages added with the site root option set on all levels. Resolves: #104531 Releases: main, 12.4 Change-Id: I8c5989754c34fef4a303ff3db497178f3366bf6e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85455 Reviewed-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
-
Anja Leichsenring authored
Used command: composer require --dev phpstan/phpstan:"^1.11.8, !=1.11.9" Resolves: #104536 Releases: main, 12.4 Change-Id: I6e020c6b4a903ad2ad942614f03b96b48317313f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85494 Reviewed-by:
-
- Aug 01, 2024
-
-
Marcel Küpper authored
Namespace declaration did not match Fluid namespaces. This patch fixes the namespaces for the EXT:felogin partials. Also an unnecessary usage of a namespace fluid pointing to the TYPO3Fluid package was moved to the namespace f. Resolves: #104511 Releases: main, 12.4 Change-Id: Idafc5595177b312440e6a7bda18634df73bfb5be Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85453 Tested-by:
-
Georg Ringer authored
With the CKEditor5 unbundling in #102099, we can now ship free (GPL-2 licensed) CKEditor5 modules, that may be useful, for some installations, without the need to ship them for all installations in a big bundle. npm install --save \ @ckeditor/ckeditor5-highlight@41.4.2 \ @ckeditor/ckeditor5-language@41.4.2 \ @ckeditor/ckeditor5-mention@41.4.2 npm run build Releases: main, 12.4 Resolves: #101128 Related: #102099 Related: #99670 Change-Id: Ic7b88985c64c59c65ee8502e50d74c3206636893 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85452 Tested-by:
-
- Jul 31, 2024
-
-
Markus Sommer authored
Resolves: #104513 Releases: main, 12.4, 11.5 Change-Id: I73d4d5eac80e3bd637fa2fabd7b1d1948daf357c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85429 Tested-by:
-
Georg Ringer authored
An editor might not have access to the 1st storage defined (usually fileadmin). To avoid an exception, an additional check compares the default storage to the available ones. Resolves: #103897 Releases: main, 12.4 Change-Id: Ib2d4dc758a2ad95298479122bd7302bb008b3c20 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85424 Reviewed-by:
-
Simon Praetorius authored
This patch-level release resolves an issue with arbitrary ViewHelper arguments introduced with Fluid Standalone 2.12. Now the arbitrary arguments behave in the same way as manually defined tag attributes. > composer u typo3fluid/fluid Resolves: #104490 Releases: main, 12.4 Change-Id: I8480f54d89fb37eb7e75d887a093a44675aba4ed Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85422 Tested-by:
Simon Praetorius <simon@praetorius.me> Reviewed-by:
-
- Jul 30, 2024
-
-
Garvin Hicking authored
In case a `sys_log` entry is deleted via the `belog` backend module, an error was thrown. This only happened for log entries with `details_nr` 11 or 12 (PHP errors) AND where placeholder values in the column `details` were used. Then the backend log module would try to delete all rows only with the exactly matching, substituted log details, so that not too many records would be deleted (with different placeholders). The code for this tried to unserialize the log data, which led to the created delete-query utilizing an array as named parameter placeholder value, which then threw an error. The solution is to use the actual raw data for the query comparison, which is what this patch does. Then the exact contents of the fields `details` and `log_data` will be used to delete all matching rows. Resolves: #104494 Releases: main, 12.4 Change-Id: I393b918919340eb279c62136feec2f27eeac708f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85414 Tested-by:
-
