During the addition of the token check for mod.php the token
in the BE shortcut url was already replaced (#56359) but
not in the returnUrl parameter that can be present.

This patch makes sure that also the module token is replaced in
the returnUrl param.

Resolves: #59963
Releases: 6.3, 6.2
Change-Id: I12b9d6022240d0399825aade21b0879bfbc7eb6c
Reviewed-on: https://review.typo3.org/31386
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Marcin Sągol
Reviewed-by: Markus Klein
Tested-by: Markus Klein

The TypoScript parser does not properly parse the := operator.
It searches for : only and hence wrongly breaks a TypoScript key apart.

Fix this by detecting the full operator sequence ":=", do not rely
on ":" only.

Resolves: #59965
Releases: 6.3, 6.2
Change-Id: I6401c87b45432d4d74c4092edeb333d4d9d5914e
Reviewed-on: https://review.typo3.org/31193
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Tested-by: Wouter Wolters
Reviewed-by: Frans Saris
Tested-by: Frans Saris
Reviewed-by: Stefan Neufeind
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Page-TSconfig ###PAGE_TSCONFIG_STR### not evaluated
correctly in the backend.

Change-Id: Ieda08a1df71117b5ac90f2c68260f5171570ff63
Resolves: #16392
Releases: 6.3, 6.2
Reviewed-on: https://review.typo3.org/20901
Reviewed-by: Markus Klein
Tested-by: Markus Klein

Sysext form overrides TCA for tt_content with some completely outdated
configuration.

Fix this to the new TCA of tt_content.

Resolves: #59837
Releases: 6.3, 6.2
Change-Id: Ic2d1d75b767925755160bd337ec6fdfbddc308ab
Reviewed-on: https://review.typo3.org/31113
Reviewed-by: Marcin Sągol
Reviewed-by: Frans Saris
Tested-by: Frans Saris
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Due to changes in https://review.typo3.org/#/c/29845/ dependency errors
are collected and if one error occurred it is returned for every check
regardless of the key. This patch adds a reset for the error array on
every new dependency check.

Resolves: #60106
Releases: 6.3, 6.2
Change-Id: Id734ba1fe8981ffd270d79d4971ac9de9b72b4b4
Reviewed-on: https://review.typo3.org/31330
Reviewed-by: Oliver Klee
Reviewed-by: Marcin Sągol
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Updated ADOdb from 5.18 to 5.19 fixing several bugs.

Resolves: #59911
Releases: 6.3, 6.2
Change-Id: I3173c8b14b3d653f29d4992029dbaa9129200fa2
Reviewed-on: https://review.typo3.org/31163
Reviewed-by: Marcin Sągol
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers

Add the missing label for "update"-dependencies to EM locallang.xlf

Resolves: #59974
Releases: 6.3, 6.2
Change-Id: I8e8f1681cd486c2fbb7491c41c5f711c86e64ed0
Reviewed-on: https://review.typo3.org/31354
Reviewed-by: Marcin Sągol
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Add lots of type hints and some checks if the correct class is present.

Resolves: #57812
Releases: 6.3
Change-Id: I6f5e4d30dfbfb73cedf10c0efdbb271ee3bdcecf
Reviewed-on: https://review.typo3.org/29342
Reviewed-by: Oliver Klee
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring

The extension manager's DownloadQueue does now properly check
the stack when adding extensions to the queue.

Resolves: #59975
Releases: 6.3, 6.2, 6.1
Change-Id: I90e9699608c6d0f3ebd44dd54eb0f471a4e082d9
Reviewed-on: https://review.typo3.org/31214
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Stefan Neufeind
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

If a palette is placed directly after a form field the icon to
open the pallete is placed inside the formfield wrapper. As result
the position of the required field icon is wrong.

This patch moves the palette icon outside of the wrapper.

Resolves: #59865
Releases: 6.2, 6.3
Change-Id: I35a3d4728a0dfb5ed315731366cc5ca04a7aa87e
Reviewed-on: https://review.typo3.org/31130
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Marcin Sągol
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

"ExtensionCompatibilityTesterTests" triggers loadBaseTca() that
loads TCA and TCA overrides of all active packages. Since the
unit test package manager activates all extensions found, this
may lead to unexpected effects with extensions hanging around
in typo3conf/ext.
The patch creates a backup of the package manager and mocks it
properly in some tests.

Change-Id: Ia5b1ccb449f1611837e6436cab226820b22a9047
Resolves: #60120
Related: #59770
Releases: 6.3, 6.2
Reviewed-on: https://review.typo3.org/31355
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Markus Klein
Tested-by: Markus Klein

ExtensionManagementUtility::addPlugin() may raise a warning if
a subarray of TYPO3_LOADED_EXT is not set for whatever reason.
The patch sanitizes this.

Change-Id: I4fb8c24bcdebd6b04e856ecad5da07e624d95da4
Resolves: #60122
Related: #59770
Releases: 6.3, 6.2
Reviewed-on: https://review.typo3.org/31357
Reviewed-by: Marcin Sągol
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring

The method uses two different approaches to get a list of active
packages, this is cleaned up to use the package manager only.

Change-Id: Ifc73d36ed0020914b0f7cf0b479010f91d1eba7f
Resolves: #60121
Related: #60120
Related: #59770
Releases: 6.3, 6.2
Reviewed-on: https://review.typo3.org/31356
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring

The header icon in the ElementInfo screen has a click link added
but this doesn't work and doesn't make sense as shown links would
be in the wrong context.

This patch removes the javasript to open the clickmenu from the icons.

Resolves: #56250
Releases: 6.3, 6.2
Change-Id: I2b907188958f166a129617da36585c07be3a143c
Reviewed-on: https://review.typo3.org/30883
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Markus Klein
Tested-by: Markus Klein

Change check for TYPO3_MODE:

if (!defined('TYPO3_MODE')) {
	die('Access denied.');
}

to

defined('TYPO3_MODE') or die();

Resolves: #60112
Releases: 6.3
Change-Id: I2b4493509c912f620a993dc4ba69c4449fcac04d
Reviewed-on: https://review.typo3.org/31338
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring

TCA manipulation code must no longer reside in ext_tables.php, but
moved to Configuration/TCA/Overrides/<tablename>.php. Leftovers
in ext_tables might disturb loading order of TCA changes and spoil
proper caching.

Change-Id: Ia2ae5e6c9a00aade1a65a6a89ecf809a0931025f
Resolves: #59464
Related: #59414
Releases: 6.3, 6.2
Reviewed-on: https://review.typo3.org/30649
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Marcin Sągol
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

TCA manipulation code must no longer reside in ext_tables.php, but
moved to Configuration/TCA/Overrides/<tablename>.php. Leftovers
in ext_tables might disturb loading order of TCA changes and spoil
proper caching.

Change-Id: I328cbcb718ee33beec19379ea6047a18cdc370b0
Resolves: #59704
Related: #59414
Releases: 6.3, 6.2
Reviewed-on: https://review.typo3.org/30943
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Markus Klein
Reviewed-by: Marcin Sągol
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

Prevent the Update image dialog box to crash when trying to access
an empty class selector.

Resolves: #59938
Releases: 6.2, 6.3
Change-Id: Ida2c3dfb185064071fcdcda158f64e330562aa01
Reviewed-on: https://review.typo3.org/31169
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

* Update phpDoc where needed
* Import use statements where possible

Resolves: #59857
Releases: 6.3, 6.2
Change-Id: I786db3b377dbe0cc90441ea6618ce05fc67b087b
Reviewed-on: https://review.typo3.org/31059
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring

Resolves: #59791
Releases: 6.3
Change-Id: I71e998b693144e313b1d8dbcf70b488ef143141a
Reviewed-on: https://review.typo3.org/31038
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Marcin Sągol
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring

If you update a deactivated extension it becomes activated afterwards.
This patch change from the installExtension function to
downloadMainExtension function because on updates it is enough to
download the new extension.

Resolves: #59631
Releases: 6.3, 6.2
Change-Id: Idec8c1f3521fa03241def5e171718b42cc31ce6b
Reviewed-on: https://review.typo3.org/31331
Reviewed-by: Marcin Sągol
Tested-by: Marcin Sągol
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

TCA manipulation code must no longer reside in ext_tables.php, but
moved to Configuration/TCA/Overrides/<tablename>.php. Leftovers
in ext_tables might disturb loading order of TCA changes and spoil
proper caching.

Resolves: #59462
Related: #59414
Releases: 6.2
Change-Id: I0bd42865f199b7fcccc1ee9133776271a1af2bcd
Reviewed-on: https://review.typo3.org/30629
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

The variable '$doNothing' was not initialized, leading to PHP notices.

Resolves: #60116
Releases: 6.3, 6.2
Change-Id: I38473b73d4b1ebeb4b1dcbea5ba24d005c520487
Reviewed-on: https://review.typo3.org/31262
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Marcin Sągol
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring

Currently the constant itself is used, which leads to PHP notices if it is
not defined yet.

Resolves: #60115
Releases 6.2,6.3
Change-Id: I6932f958a9cb0d01be5910860ebbd78f2c67c58a
Reviewed-on: https://review.typo3.org/31263
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Marcin Sągol
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring

TCA manipulation code must no longer reside in ext_tables.php, but
moved to Configuration/TCA/Overrides/<tablename>.php. Leftovers
in ext_tables might disturb loading order of TCA changes and spoil
proper caching.

Change-Id: If5998b9c86bc5f7b106fd3f1c9213842b8ae242d
Resolves: #59468
Related: #59414
Releases: 6.3, 6.2
Reviewed-on: https://review.typo3.org/30652
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

TCA manipulation code must no longer reside in ext_tables.php, but
moved to Configuration/TCA/Overrides/<tablename>.php. Leftovers
in ext_tables might disturb loading order of TCA changes and spoil
proper caching.

Change-Id: I3a357ddff0fe5d6f16caa67b4085372c27594234
Resolves: #59465
Related: #59414
Releases: 6.3, 6.2
Reviewed-on: https://review.typo3.org/30650
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Marcin Sągol
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

In the list view the tooltip for a shortcut always shows
id=0 because the field shortcut is not fetched from the database.
Add this to the list of fields to select.

Resolves: #60033
Releases: 6.3,6.2
Change-Id: Id4949e6699657a57975977b3450f54bc3216d06d
Reviewed-on: https://review.typo3.org/31328
Reviewed-by: Marcin Sągol
Tested-by: Marcin Sągol
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

With patch #59770 ExtensionManagementUtility::addPlugin() signature
was extended to get the extensionKey as parameter in order to not
use $GLOBALS['_EXTKEY'] anymore if possible.
The parameter is used to determine correct path to plugin icons if
the icon path is not given otherwise.
The patch changes extbase ExtensionUtility::registerPlugin() to give
the extensionKey to addPlugin, too.
With this patch registerPlugin() can be used in TCA/Overrides.
Some tests are added to verify the icon path calculation since it is
not trivial to follow the code flow with all its options and global
array access.

Change-Id: I2dd709ef7ca304bc8c4fda1e7911f18bfe7ad04c
Resolves: #60109
Related: #59770
Related: #59468
Related: #59414
Releases: 6.3, 6.2
Reviewed-on: https://review.typo3.org/31333
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Marcin Sągol
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

Add unit tests to ExtensionManagementUtility::addPlugin() verifying
the new third parameter $extensionKey is handled properly.

Change-Id: I0257755d0708f12141c78fb97e6e342daf7a6281
Resolves: #60110
Related: #60109
Related: #59414
Related: #59770
Related: #59468
Releases: 6.2, 6.3
Reviewed-on: https://review.typo3.org/31334
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

There are two places where a new item is assigned
to an array with `$myArray[] .= ''`.
This would do the same as `$myArray[] = ''` because
it always adds a new item to the array.

Resolves: #60101
Releases: 6.3
Change-Id: I122b0fe80b1ac026c0c9f353446bb48834eba74e
Reviewed-on: https://review.typo3.org/31321
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Nicole Cordes
Tested-by: Nicole Cordes

When enabling access to the content of ObjectStorages by
integer number, it was overlooked that property access might
be desired too, which has also been working before.

Fix this by not aborting the access when addressing a
non-integer property on ObjectStorages.

Resolves: #59412
Releases: 6.3, 6.2
Change-Id: I59b83ed0bf0c965efcdf0aad9440d634953a221e
Reviewed-on: https://review.typo3.org/30628
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Marcin Sągol
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring

Resolves: #60065
Releases: 6.2
Change-Id: I27917fed2a65f9810176b4afa716e8e752d7eff1
Reviewed-on: https://review.typo3.org/31294
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

At the moment the CacheManager is created by
GeneralUtility::makeInstance(
  'TYPO3\\CMS\\Core\\Cache\\CacheManager'
); within the code. This makes the particular method untestable.

Solution: Create a Getter which creates and returns the instance.
This getter can be mocked.

Resolves: #60059
Releases: 6.2, 6.3
Change-Id: I9f83ec017da94778e542410cc9d03faacddc245c
Reviewed-on: https://review.typo3.org/31288
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Alexander Opitz
Tested-by: Alexander Opitz
Reviewed-by: Thomas Maroschik
Tested-by: Thomas Maroschik

The possibly submitted value to RelationHandler::setWorkspaceId()
is not used for SQL queries to read IRRE foreign field relations.
In that case the current $BE_USER->workspace value is used which
might be different to the requested workspace id.

Resolves: #60053
Releases: 6.2, 6.3
Change-Id: Ib01e4df798ff2e1fcc8c29997f6effb814dc4344
Reviewed-on: https://review.typo3.org/31285
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader

If a workspace placeholder record is generated the field, that
is configured as label for a table, is filled with a placeholder.
This is a hardcoded string.
If database field does not allow strings (integer, double...)
a TYPO3 warning is displayed. "... Propably value mismatch ...".
This message is very confusing because the user does not know
where it comes from.

The label should be evaluated against the TCA eval configuration
before it is written to the database.

Resolves: #31757
Releases: 6.3, 6.2, 6.1
Change-Id: I18261359550dcaddaa9bd9ca0dd77f8300e81da9
Reviewed-on: https://review.typo3.org/22935
Reviewed-by: Alexander Opitz
Tested-by: Alexander Opitz
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Oliver Hader
Reviewed-by: Sascha Egerer
Tested-by: Sascha Egerer

IRRE records with foreign_field instead of MM table
are now listed as a comma separated list instead
of wrongly using the number of records as the UID.

Change-Id: Ib1434561ee823d931cc983e103fb58490ca83719
Resolves: #59671
Releases: 6.3,6.2
Reviewed-on: https://review.typo3.org/30967
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

Due to some changes in Prototype.js the serialized form values
get wrongly escaped with the result that all spaces are replaced
by + chars.

This patch changes the used serialization of the form so the value
is correctly posted.

Resolves: #59950
Releases: 6.3, 6.2
Change-Id: I65d89ab741ae77f5bbef9421923b3878f2295570
Reviewed-on: https://review.typo3.org/31175
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Krzysztof Adamczyk
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

edit_wideDocument option has been removed with #57295 but it was forgotten
to adjust RTE accordingly.

Wide screens are default now, so we remove the check for this option
also in RTE. Furthermore the settings for small screens are superfluous
too.

Documentation is adjusted as well.

Resolves: #59692
Releases: 6.3, 6.2
Change-Id: I9bb5fc2a892f3de446137856e9fa18317f40b5c1
Reviewed-on: https://review.typo3.org/30954
Reviewed-by: Marc Wöhlken
Tested-by: Marc Wöhlken
Reviewed-by: Frans Saris
Reviewed-by: Marcin Sągol
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

Remove unnessessary full qualified class names.
Cleanup docheaders.

Resolves: #57878
Releases: 6.3
Change-Id: I5bcdb80c27da1698fd1446a001907d83c6845507
Reviewed-on: https://review.typo3.org/29444
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

Currently there are two selectors in the bottom toolbar of
the workspace module. One to handle stage changes on selected
elements and one for mass actions (publish, swap, discard) for
the whole workspace. To circumvent this, an additional selector
shall be added for record selections.

Resolves: #59898
Releases: 6.2, 6.3
Change-Id: I5991cc16a65ba5ac473ec380f534379ec925cad3
Reviewed-on: https://review.typo3.org/31158
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters