Removes superfluous parenthesis in sysexts "felogin", "filelist",
"form" and "func".

Change ("a" . "b") . "c" into "a" . "b" . "c" using the lex-pass tool.

Change-Id: I2e9e0b8e339dae93c0361a6ba36e41beb0f54711
Resolves: #40965
Related: #40095
Reviewed-on: http://review.typo3.org/14624
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert

Removes superfluous parenthesis in sysexts "info_pagetsconfig",
"install", "integrity" and "lang".

Change ("a" . "b") . "c" into "a" . "b" . "c" using the lex-pass tool.

Change-Id: I367b1bef893de93964b41d900f29e2dfcedb8aaf
Resolves: #40967
Related: #40095
Reviewed-on: http://review.typo3.org/14626
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert

Removes superfluous parenthesis in sysexts "opendocs", "openid",
"perm" and "recordlist".

Change ("a" . "b") . "c" into "a" . "b" . "c" using the lex-pass tool.

Change-Id: Ibe211f8ff6ba0089ecb086bd645ca55ab6fcc9da
Resolves: #40968
Related: #40095
Reviewed-on: http://review.typo3.org/14627
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert

Removes superfluous parenthesis in sysexts "saltedpasswords",
"scheduler", "setup" and "statictemplates".

Change ("a" . "b") . "c" into "a" . "b" . "c" using the lex-pass tool.

Change-Id: Ie1e7d052f5d8dfac95d01a70ed750e69cf4bb7f6
Resolves: #40970
Related: #40095
Reviewed-on: http://review.typo3.org/14629
Reviewed-by: Thomas Loeffler
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert

Removes superfluous parenthesis in sysexts "sv", "sys_action",
"sys_note" and "t3editor".

Change ("a" . "b") . "c" into "a" . "b" . "c" using the lex-pass tool.

Change-Id: Ib4b3541051a30895d6657b6af367f9c6c58dac44
Resolves: #40971
Related: #40095
Reviewed-on: http://review.typo3.org/14630
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert

Removes superfluous parenthesis in sysexts "css_styled_content",
"extensionmanager", "extra_page_cm_options" and "feedit".

Change ("a" . "b") . "c" into "a" . "b" . "c" using the lex-pass tool.

Change-Id: I9ec62d6b2782e349cef447c7a9c87f4a4fbc2585
Resolves: #40964
Related: #40095
Reviewed-on: http://review.typo3.org/14623
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert

Removes superfluous parenthesis in sysexts "t3skin", "taskcenter",
"tsconfig_help" and "tstemplate".

Change ("a" . "b") . "c" into "a" . "b" . "c" using the lex-pass tool.

Change-Id: I9034b5146aa02651e99ab3651c50d785423e64c2
Resolves: #40972
Related: #40095
Reviewed-on: http://review.typo3.org/14631
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert

Removes superfluous parenthesis in sysexts "tstemplate_analyzer",
"tstemplate_ceditor", "tstemplate_info" and "tstemplate_objbrowser".

Change ("a" . "b") . "c" into "a" . "b" . "c" using the lex-pass tool.

Change-Id: I7724aa9b38d7db641db4bd75c1a059bf8a71038b
Resolves: #40973
Related: #40095
Reviewed-on: http://review.typo3.org/14632
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert

Removes superfluous parenthesis in sysexts "viewpage",
"wizard_crpages" and "wizard_sortpages".

Change ("a" . "b") . "c" into "a" . "b" . "c" using the lex-pass tool.

Change-Id: Ib5818e68f9e21164de8e42da73686cf1327410a9
Resolves: #40974
Related: #40095
Reviewed-on: http://review.typo3.org/14633
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert

Change ("a" . "b") . "c" into "a" . "b" . "c" using the lex-pass tool.

Change-Id: I77e999229bf10bc39757f927bb3386eb2df8ec61
Resolves: #40982
Related: #40095
Reviewed-on: http://review.typo3.org/14634
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert

The DriverRegistry does not throw exception anymore, if the
same Driver is registered twice. The Exception only is
thrown if another driver takes the same key.

Change-Id: I16c0aa5bc98d7da90a47615ea675ab655391e1dc
Releases: 6.0
Fixes: 40843
Reviewed-on: http://review.typo3.org/14669
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter

Removes superfluous parenthesis in sysexts "recycler", "reports",
"rsaauth" and "rtehtmlarea".

Change ("a" . "b") . "c" into "a" . "b" . "c" using the lex-pass tool.

Change-Id: I5786043a52ea50477072c82e039179272e6692ca
Resolves: #40969
Related: #40095
Reviewed-on: http://review.typo3.org/14628
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert

Due to some extension manager processes when installing a new extension
the DriveRegistry has to support to register the same short name with the
same class name multiple times.

Change-Id: I67e409f532f5736b5a4c0a2e7fb822a579cfaa41
Fixes: #40843
Releases: 6.0
Reviewed-on: http://review.typo3.org/14532
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter

Removes superfluous parenthesis in sysexts "func_wizards", "impexp",
"indexed_search" and "info".

Change ("a" . "b") . "c" into "a" . "b" . "c" using the lex-pass tool.

Change-Id: Ib367bc98070cb9bf8350b955f5ba7dee1872f607
Resolves: #40966
Related: #40095
Reviewed-on: http://review.typo3.org/14625
Reviewed-by: Mattias Nilsson
Tested-by: Mattias Nilsson
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert

Removes superfluous parenthesis in sysexts "aboutmodules", "adodb",
"belog" and "beuser".

Change ("a" . "b") . "c" into "a" . "b" . "c" using the lex-pass tool.

Change-Id: I26f72a6d5e18617a0838e64068817e4fd7c1c90e
Resolves: #40962
Related: #40095
Reviewed-on: http://review.typo3.org/14620
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert

Removes superfluous parenthesis in sysexts "cli", "cms",
"context_help" and "cshmanual".

Change ("a" . "b") . "c" into "a" . "b" . "c" using the lex-pass tool.

Change-Id: I0ff0fc33d3c0733498d5821e77b224db20213705
Resolves: #40963
Related: #40095
Reviewed-on: http://review.typo3.org/14621
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert

Setting file contents failed for two reasons:

a) The permissions were incorrectly read from TSconfig and

b) We used a new "update" permission that was not present
   in the default configuration, so without manually setting it,
   a file could never be updated, even by admins.

This commit changes the "update" permission back to "edit", which was
also used in the pre-FAL era.

Change-Id: I408a19257a50868f7978ffac32eefbd410117e2d
Resolves: #37812
Resolves: #39860
Resolves: #39949
Releases: 6.0
Reviewed-on: http://review.typo3.org/14257
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

Take the chance to also clean up the test class a bit.

Change-Id: Ib2835aa4dc4c170d327f56dfcde134cf5871867b
Resolves: #40956
Releases: 6.0
Reviewed-on: http://review.typo3.org/14618
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

Change ("a" . "b") . "c" into "a" . "b" . "c" using the lex-pass tool.

Change-Id: I09b90a58a74a219e6957488a7cca7a591c27ff70
Resolves: #40881
Related: #40095
Releases: 6.0
Reviewed-on: http://review.typo3.org/14566
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

Change ("a" . "b") . "c" into "a" . "b" . "c" using the lex-pass tool.

Change-Id: I818d55a2f00b549fef8377f1c6766c293edd021c
Resolves: #40880
Related: #40095
Releases: 6.0
Reviewed-on: http://review.typo3.org/14565
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Mattias Nilsson
Tested-by: Mattias Nilsson
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

Change-Id: If6d3dfcb0fb095063750eaeb85bdb32aef0f417e
Resolves: #40282
Related: #40095
Releases: 6.0
Reviewed-on: http://review.typo3.org/14144
Reviewed-by: Nicole Cordes
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

Instead of literal characters in single quoted strings it's better
to use doubled quoted strings for control characters to provide
better compatibility across platforms

Change-Id: Icb9722ad0e729c898d458c085f89d0fdf1f13896
Fixes: #40672
Releases: 6.0
Reviewed-on: http://review.typo3.org/14603
Reviewed-by: Felix Kopp
Tested-by: Felix Kopp
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

Change-Id: I69b9d1c81e1215980d4a40b0383de400b26886d7
Fixes: #40952
Release: 6.0
Reviewed-on: http://review.typo3.org/14615
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter

Change ("a" . "b") . "c" into "a" . "b" . "c" using the lex-pass tool.

Change-Id: I8a30e8689c1c567770d0c03beaa12a0bf29e9b09
Resolves: #40878
Related: #40095
Releases: 6.0
Reviewed-on: http://review.typo3.org/14563
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

In the Install Tool All Configuration part all field descriptions
are missing. This patch removes the additional newline characters
which caused the comments used to render the descriptions being
moved away from their fields.

Change-Id: I0c6db43b6940494405eb794a28a684d1894b046e
Fixes: #40939
Releases: 6.0
Reviewed-on: http://review.typo3.org/14607
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

* Skip the IPV6 Test that always fails on darwin/ OSX OS
* Remove the potentially skipped tests concerning t3lib_diff
  since this class is still in use

Change-Id: Iab26c428ff7cf8a8b447d536d820821ed000a8fd
Resolves: #40879
Releases: 6.0
Reviewed-on: http://review.typo3.org/14564
Reviewed-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

Change-Id: Ic4a640c880a59bf322101efb1ab7fb58bb8ace48
Fixes: #40876
Releases: 6.0
Reviewed-on: http://review.typo3.org/14560
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Cleans up ext:belog and activates the test suite:
* Fix some annotations
* Move a test that was put to a wrong location
* Minor CGL and readability changes
* Remove namespace compat layer of new 6.0 classes
* Change module registration and viewhelper to namespace

Change-Id: Ia31b5fcd52b76c40dbc6215c9820fa8c83a8ab86
Resolves: #40871
Related: 6.0
Reviewed-on: http://review.typo3.org/14557
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

The namespace switch removed some linefeeds that 
were there to improve readability of the bootstrap.

Add these again and also remove the compatibility 
files as these files are new to 6.0 anyway.

Resolves: #40877
Releases: 6.0

Change-Id: I1ed4e7d8710f4feb97a0331b5526336075aa7932
Reviewed-on: http://review.typo3.org/14561
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

Next try to add the scheduler tests to the test suites.

The patch applies several changes:

* For some weird reasons PHP does not recognize 'September' as valid
month keyword if the timezone is not Europe/Berlin. The test is removed
since only three letter abbreviations are allowed anyway.

* Make the cron command test system timezone agnostic.
CronCommandTest now explicitly sets the timezone to UTC (GMT) in setUp
and has a backup for tearDown. This is needed because the tests use hard
coded timestamps and the system under test is sensitive for timezones.
This was the main reason for the travis runs to fail in the first place.

* The dataProvider in CronCommandTest do not execute strtotime anymore.
The reason for that is, that the data provider data in phpunit is
executed before setUp and won't get the timezone setting then. The main
data provider is now splitted into two, separating the strtotime()
calculation off from the rest.

Change-Id: Ifb8de929b8e6edb31b24cbf02a9ddaa9dda9ab43
Resolves: #40515
Releases: 6.0
Reviewed-on: http://review.typo3.org/14549
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

The wrong line icon is used in the wizard of
db_new.php

Change-Id: Ifba1d0270b547e11326ffb1c82a48e8c8838b401
Resolves: #40862
Releases: 6.0
Reviewed-on: http://review.typo3.org/14545
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

The margin can be improved.

Change-Id: I5680551fdc7625037d222d627d49a51a49835f26
Resolves: #40858
Releases: 6.0
Reviewed-on: http://review.typo3.org/14536
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
Reviewed-by: Marcus Schwemer
Tested-by: Marcus Schwemer
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

An upgrade wizard is needed to add the default
repository of the EM. Otherwise the EM crashes

Change-Id: I3d254fae0bc1e937fd18b84b42df13d99a1b9ddc
Fixes: #40508
Releases: 6.0
Reviewed-on: http://review.typo3.org/14506
Reviewed-by: Marcus Schwemer
Tested-by: Marcus Schwemer
Reviewed-by: Markus Klein
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

The patch moves the last files in tests/ to a different location:
* FAL functional StorageTest is moved to ext:core as functional test
* A naming mistake of one of the other FAL tests is fixed
* class.removexssTest.php and class.t3lib_formmailTest.php are moved
to ext:core/Tests/Legacy

Change-Id: I7f627c29f3154d07d40a3e11db3730f763f7ff2f
Resolves: #40841
Releases: 6.0
Reviewed-on: http://review.typo3.org/14530
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

This was decided at the latest release manager meeting:
To get rid of the top level tests/ directory, the UnitTests.xml
file is moved to the core extension to a new folder Build/. This
directory will later be used for other build specific things.

Change-Id: Id541f1e0bab3b1d2891f13697f48ea16e6c86d5e
Resolves: #40837
Releases: 6.0
Reviewed-on: http://review.typo3.org/14528
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

* Move BaseSetupTest to SystemEnvironmentBuilderTest and namespace it.
* Introduce an AccessibleProxy for the protected methods instead of eval.
* Merge config_defaultTest to SystemEnvironmentBuilderTest

Change-Id: Ie90857962087e235a7f4a8eb53df120624fd8780
Resolves: #40836
Related: #40095
Releases: 6.0
Reviewed-on: http://review.typo3.org/14527
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Change-Id: I26b501e49d41656eb50996be4d56b4c18f1563ba
Fixes: #40364
Related: #40095
Releases: 6.0
Reviewed-on: http://review.typo3.org/14178
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert

There are still some fixture files within the root tests/ directory.
The patch moves them to Fixtures/ folders below the using tests
within the affected core and backend extensions.

Change-Id: Ied23b542a65becac02c9af576728da886552484d
Resolves: #40834
Related: #40095
Releases: 6.0
Reviewed-on: http://review.typo3.org/14525
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Any zero length string value is replaced with the current timestamp.
(Just like the default value for the second parameter of
strtime/gmstrftime.)

Change-Id: I7cc43a09f75d21ab8db84c0191fa0c1c5d67ddb0
Fixes: #38717
Releases: 6.0, 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/12713
Reviewed-by: Stefan Neufeind
Reviewed-by: Marcus Schwemer
Tested-by: Marcus Schwemer
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert

In the past it happened quite often that some test did not take care
of proper backing up globals or other environment settings. This
usually leads to failing tests if they are run afterwards. Those
side effects are often hard to track down and take quite some time
if searching for the one test that breaks the environment.

Therefor, a new "Integrity" test is added to the system that is
executed as the very last test in the list of test suites. It checks
that important things that were messed up in the past are still working.

Currently it checks that the registered singleton instances are still
there, that $GLOBALS['TYPO3_DB'] still has a valid resource link to
the database, and $GLOBALS['typo3CacheManager'] is still a valid
class instance.

If one of this test fails after any merge (especially combined with
travis), it is now obvious that this merge broke the environment, so
the evil test can be found much quicker and the evil merge can be
reverted directly.

Change-Id: I0dc733081ea9ad0c050a7dbcf4d95dd8f819f1bf
Resolves: #40832
Releases: 6.0
Reviewed-on: http://review.typo3.org/14524
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn