- Sep 23, 2019
-
-
Benni Mack authored
Handling Sites via SiteMatcher is not necessary anymore, as the SiteFinder does all the logic already, except for flushing the rootline caches. The main reason (moving pages within DataHandler) can be managed by adding this functionality into SlugHelper directly. Resolves: #89225 Releases: master Change-Id: I0e3fe151ebb99a154900f3335bef4a1db92ca4bf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61778 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Frank Nägler <frank.naegler@typo3.org> Reviewed-by:
-
Benni Mack authored
The new IPlocker (supporting IPv6) also removed the public property AbstractUserAuthentication->lockIP. However, the original assignments are still in place, as they were forgotten before the 10.0 release. The change removes the two assignments. Resolves: #89226 Releases: master Change-Id: I9fb7bc2c5dbf523a13e6ba6faa0cd51fe3beffdc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61780 Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
-
Andreas Fernandez authored
To slim down the usage of jQuery even further a bit, the jQuery plugin `jquery.clearable` has been marked as deprecated. A new plugin `TYPO3/CMS/Backend/Input/Clearable` may be used instead. The new plugin extends the prototype of `HTMLInputElement` by a new function called `clearable`. Resolves: #89215 Releases: master Change-Id: Id6e64b983561af0327cc3308499756b8fafbc883 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61758 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
Henrik Elsner authored
Enables the functionality to add an inline element inside of an unsaved inline element Resolves: #89201 Releases: master, 9.5, 8.7 Change-Id: I077c75326b021b9bacc53d10c9584659391726ce Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61756 Tested-by:
-
Devid Messner authored
Avoids an exeption about incompatible type to the call, caused by double encoding. Resolves: #89081 Releases: master, 9.5 Change-Id: Ia974227f0e9ca68a8f37a0e205bda1f27f015c7f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61622 Tested-by:
-
Andreas Fernandez authored
Since the build chain can generate ES6, the TypeScript code should incorporate these changes. Namely, this patch changes: - Use native NodeList over arrays generated by Array.from() where possible - Use explicit string search functions instead of indexOf Resolves: #89118 Releases: master Change-Id: I6e03ade35c545ece05ecca222cd1fde876fc22d4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61649 Tested-by:
Susanne Moog <look@susi.dev> Reviewed-by:
-
Naderio authored
Added missing closing quote in cObjGetSingle-docblock Releases: master Resolves: #89224 Change-Id: If35976e5e2236fbf6209349c9ee346f52f5d3ac3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61775 Tested-by:
-
Oliver Bartsch authored
The PHPDocs of GeneralUtility::_GET and GeneralUtility::_POST have been revised. In detail, statements have been removed that those methods would strip slashes and should `ALWAYS` be used. Resolves: #89221 Releases: master, 9.5 Change-Id: Ic05f31998b8af5205cd6847c403b95172eeb709a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61773 Tested-by:
Björn Jacob <bjoern.jacob@tritum.de> Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Reviewed-by:
-
Oliver Bartsch authored
The PHPDoc of GeneralUtility::_GP has been revised. In detail, the outdated and misleading part about security has been removed and the return annotation now also includes NULL as possible return type. Resolves: #89222 Releases: master, 9.5 Change-Id: Iccfbfc43b15b28c035f5e93805d41e858b816d6a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61774 Tested-by:
-
- Sep 21, 2019
-
-
Claus Due authored
Fixes a missing closing tag which makes (X)HTML validation fail and causes Fluid 3.0 to report a parsing error in the templates. Resolves: #89210 Releases: master, 9.5, 8.7 Change-Id: Ia8fe59df2f92761ba44ac649bd6907fa2c58ab66 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61763 Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Tested-by:
-
- Sep 20, 2019
-
-
Benni Mack authored
BackendUser has some tight integration with workspaces, however it also contains some legacy non-workspace related functionality whereas checks against $pid is done for branch versioning. This has been removed and some new internal methods are now used with a clearer return value and internal code structure. Resolves: #88155 Releases: master Change-Id: I7b902085e53bd6bd8a8522df4815d31482468102 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60483 Tested-by:
Achim Fritz <af@achimfritz.de> Reviewed-by:
-
Frank Naegler authored
With #89129 the containerClassAttribute.rst include for Fieldset was removed but the file which is now unused was not removed. Reaolves: #89214 Related: #89129 Releases: master Change-Id: Ib0055bcf3f8f9d256b50c167b37d454ebed145b2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61769 Tested-by:
-
Elias Häußler authored
The "containerClassAttribute" property is not respected by elements of type "Fieldset" as the partial "Field/Field" takes care of its rendering. Therefore, it has been removed from the official documentation to avoid confusions. Releases: master, 9.5, 8.7 Resolves: #89129 Change-Id: I5f2ed92ad2477a0eed20dcd8ad402e7894e568ee Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61660 Tested-by:
-
someplace53 authored
Since includeCssFiles and includeJsFiles are registered as arrays, the given types in the example should be arrays, too. Releases: master, 9.5 Resolves: #89200 Change-Id: Ic9ba160deb01bd4f2f86484ff2d8da517d417fc1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61754 Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
-
Benjamin Franzke authored
Support for PSR-17 HTTP Message Factories has been added. PSR-17 HTTP Factories are intended to be used by PSR-15 request handlers in order to create PSR-7 compatible message objects. Classes may use dependency injection to use any of the available PSR-17 HTTP Factory interfaces. The Request/Response base class (Message) is adapted to be able to lazily initialize a stream when getBody() is called. This is done as the PSR (Stream)RequestFactoryInterface does not allow to control Stream properties. Therefore it is a performance optimization to defer initialization. It is likely, that a new Stream will be added to a Request with withStream() anyway. (Which would mean resources for the intermediate stream would have been wasted) Furthermore some DocBlocks are adapted to reflect the variadic UriInterface/StreamInterface parameters that are already handled in code but were not documented. These cases are needed/required by the PSR-17 factory implementation now. composer require psr/http-factory:^1.0 Releases: master Resolves: #89018 Change-Id: Ie6b9d865679bbf6f5d3d030b0ed1a3f277c47a3d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61558 Tested-by:
-
Benjamin Franzke authored
Due to an inverse condition the deprecation message that constructor arguments shoud *not* be passed was triggered when actually no arguments where passed. Also fix the generation of the related non-object exception, the string concatenation used a wrong variable name. Change-Id: Icb387b666d2bf249e34eb7bae2d1ed9b3382a8b4 Releases: master Resolves: #89207 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61760 Tested-by:
-
Benni Mack authored
Allows to override index_config titles that are rendered in the dropdown of the Form in Indexed Search and as headline when a configuration is selected. Resolves: #9070 Releases: master Change-Id: I1b013af529ba4985266535b2955bf4a32bba9ebd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61446 Tested-by:
Daniel Gorges <daniel.gorges@b13.com> Tested-by:
Jörg Bösche <typo3@joergboesche.de> Reviewed-by:
-
Georg Ringer authored
The info module must show potential TSconfig values of TCAdefaults. Resolves: #89196 Releases: master, 9.5 Change-Id: I0ac8c90517a4ba5a9ab1f7c397f8ea5a964ae273 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61762 Tested-by:
Josef Glatz <josefglatz@gmail.com> Tested-by:
-
Benni Mack authored
If a site has "/" as its entrypoint but the languages have FQDNs or subdomains or a mixture between subdomain the base without domain always gets found and the subdomains are not considered. Currently this situation is handled in SiteMatcher->getRouteCollectionForAllSites() which does not fit a certain scheme if there is a mixture. This change corrects this and adds tests to handle any cases: - just / as base, and then /de and /en as language base - just / as base, and then subdmoains or full domains+path as language base - a full URL as base, and then path parts as language base - a full URL as base and then full URLs + subdomains as language base - Also check for http and http variants. Resolves: #89183 Releases: master, 9.5 Change-Id: If570118ac371e1a1589f064605c0176a53220f0f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61650 Tested-by:
Nicole Cordes <typo3@cordes.co> Tested-by:
-
- Sep 19, 2019
-
-
Benjamin Kott authored
Executed tasks: cd Build yarn add -D @typo3/icons@1.10.0 yarn build Resolves: #89206 Releases: master Change-Id: I47ae87e522acdce57e07804c46e3b8b8f29bc848 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61759 Tested-by:
-
Chris Müller authored
Remove the eliminated extension configuration option "enableBELog" in the documentation. Additionally the unused language setting for extension configuration "scheduler.config.listShowTaskDescriptionAsHover" was deleted. Resolves: #89202 Relates: #83866 Releases: master, 9.5 Change-Id: I6b2b343d1a07f158edf72803acd791ff891c6a32 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61757 Tested-by:
-
Benni Mack authored
FormEngine does not show and handle IRRE records when they are deleted (connected records from the live workspace are shown). When removal and refactoring of code in this ares was done for v9, "too much" code got removed. Which is why workspace overlays are not handled properly anymore. In addition, the ElementInformationController now correctly resolves a workspace record when finding the pageInfo and access. Resolves: #88502 Related: #82634 Releases: master, 9.5 Change-Id: Ib2d70ffa92c78752626b43ec5012d9dba036e7b8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60890 Tested-by:
-
Susanne Moog authored
Since #88799 the wrong log levels were used for configuration and level comparison (strings where ints were required, ints where strings should have been). The patch streamlines the use of the log levels to re-introduce a working log module. Resolves: #89155 Releases: master Change-Id: I1faf2b8df77fd6e412eea7cb63180026e6c19969 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61693 Tested-by:
Benjamin Franzke <bfr@qbus.de> Tested-by:
-
- Sep 18, 2019
-
-
Christian Eßl authored
Fixes a small comment typo in the checkGdLibJpgSupport function, replacing "jgp" with "jpg". Resolves: #89198 Releases: master, 9.5 Change-Id: I9c0cafda7a000b5e0d801cb12af361f2c70467d3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61752 Tested-by:
-
Benni Mack authored
When in workspace mode, overlays are made but if there is a different sorting (reordering of items in a workspace), the FileRepository does not consider this, as the workspace overlays are applied later-on. As this patch is making Workspaces with FAL finally usable, and is non-intrusive, and fixes a minor data / repository issue, I consider backporting this down to 8.7 as well. Resolves: #71973 Releases: master, 9.5, 8.7 Change-Id: Ie230558242e3ebfef541e8eb969fa21dd15708af Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61714 Tested-by:
-
- Sep 17, 2019
-
-
Andreas Fernandez authored
Due to scoping issues if a notification is generated in an iframe, the actions are now generated when the notification is rendered. This requires a change how the payload is passed to the notification, instead of the action instance it now contains the action type and the callback. The action instance is generated by a factory class. To bypass issues with browser's garbage collection that kicks in when an iframe changes, the callback methods are stringified and immediately recovered by eval(). Resolves: #89173 Releases: master Change-Id: I45624a26bad1527f9d6222ad10e1f9a1384ee07e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61706 Tested-by:
Tobi Kretschmann <tobi@tobishome.de> Tested-by:
Steffen Frese <steffenf14@gmail.com> Reviewed-by:
-
Andreas Fernandez authored
In case the redirect integrity check has never been executed before, the code now uses an empty array as fallback value to fix issues with wrong variable types. Additionaly, a repeated typo has been fixed. Resolves: #89172 Releases: master Change-Id: Ib3f2815ad355dc9d8161c845f3b0dba9efc07ce9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61705 Tested-by:
Michael Schams <typo3@2018.schams.net> Tested-by:
-
- Sep 13, 2019
-
-
Benni Mack authored
There are a few spots in TYPO3 Core where manual queries are built, and the WorkspaceRestriction would just work as dropin now. In addition, some few changes are adapted to check for t3ver_oid instead of "pid". Resolves: #89157 Releases: master Change-Id: I9d3a6f132ba20c0c603a6ab1664adf9d1dc06fd9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61669 Tested-by:
-
Susanne Moog authored
Extensions can ship their own site settings default values, that get provided to all available site configurations. A UI in sites module enables the user to edit all values from any active extension in the system. Inactive extension settings will be preserved in the site settings for later recovery. Resolves: #89134 Releases: master Change-Id: I6bb4335460ccb5f6b0f609f4f0876507804d5821 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61661 Tested-by:
-
Oliver Hader authored
When a record was modified in a workspace, and then discarded, TYPO3 previously set the t3ver_wsid to "0", which basically meant "we release it to live workspace as a offline version with pid=-1". However, this turns out to be ugly, as this information is then floating in live workspace, without any information where this record was from. Instead, "discarding versioned records" now keeps the t3ver_wsid=X, and just marks the versioned record as "deleted" - or removes it completely if the database table does not support to mark records as deleted. As a result, there will be no records in live workspace anymore with "pid=-1" in the future anymore. To remove any "old" discarded records, an upgrade wizard will follow in a followup patch. Resolves: #89166 Releases: master Change-Id: I8ccab3cd2053c27d9b0ecd9f171a83b9097f29dd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61671 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
Andreas Fernandez authored
The package phpdocumentor/reflection-docblock introduces major regressions starting with 4.3.2 that leads to getting nullable compound types (e.g. `?string|int`) parsed completely wrong, which currently also breaks in symfony/property-info. Also, it became stricter about type annotations which currently collides with Fluid. For this reason, the package is marked as conflicting starting with version 4.3.2. Resolves: #89167 Releases: master Change-Id: Ife9d14c01de5bea2179dafc572820f292039a202 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61702 Tested-by:
-
Andreas Fernandez authored
Incoming field values are now also checked for being plain integers to be able to handle timestamps properly. Resolves: #89154 Related: #84588 Releases: master, 9.5 Change-Id: I220096faa563b3700eceb8a85839eed2a70d2170 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61670 Tested-by:
-
- Sep 12, 2019
-
-
Elias Häußler authored
Labels of records provided by the suggest wizard should not contain any HTML content as they are directly applied as <option> element to the <select> element of the appropriate database field in backend forms. As the suggest wizard may generate such labels in case of stripped record titles, this commit strips away all HTML tags in order to apply the labels in a clean way to the appropriate element in the DOM. Resolves: #89161 Releases: master, 9.5 Change-Id: Ibe5bb81f79c663cf7cfc30bbe896fdf4492c4c3c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61698 Tested-by:
-
Anja Leichsenring authored
The view helper will provide form fields for extension configuration based on ext_template.txt files in install tool. A similar functionality is to be implemented into the site module, so the view helper is moved into sysext:core to be used from both places. Resolves: #89160 Releases: master Change-Id: I76dfefadcbe44271bed445717861cc01835ca793 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61697 Tested-by:
-
Frank Naegler authored
To allow a rollback for a set of RecordHistory entries, this patch adds a correlation_id to allow a kind of grouping of changes. The rollback itself is not part of this patch. Resolves: #89143 Releases: master Change-Id: Id1c4aee675805e2f00639072cf324b582decaa6b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61665 Tested-by:
-
Benni Mack authored
When the translation wizard in the Page Module fetches translations and possible languages, it queries the sys_language records - however since SiteMatcher/SiteFinder already does this on a per-page level (currently via TranslationConfigurationProvider) the LocalizationRepository can find allowed language IDs directly instead of querying the sys_language table, which might contain 20 languages, but only 2 are available for this pagetree. Resolves: #89140 Releases: master, 9.5 Change-Id: I8e755e4cc3bdbae7dc4dd71319b8ffc8120200a4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61664 Tested-by:
-
Benni Mack authored
DataHandlerHook originally extracted most of the versioning functionality of DataHandler, and can now be cleaned up: - Most of the protected methods have better type definitions and return types, where it was safe to do so - Some properties / methods / arguments was not used and could be cleaned up Resolves: #89136 Releases: master Change-Id: I73734f57356e31381062043be7a6056a13d16b0b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61662 Tested-by:
-
- Sep 11, 2019
-
-
Frank Naegler authored
Resolves: #89150 Releases: master Change-Id: If00904ea940e45f03b3871c4e0146ab717cf9c14 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61667 Tested-by:
-
Albrecht Köhnlein authored
Respect the `expire` field when selecting realurl cache data to generate page slugs from realurl cache. And also only the first found result will be used to simulate original behavior of realurl, where `exec_SELECTgetSingleRow()` with internal LIMIT 1 is used. Resolves: #88971 Releases: master, 9.5 Change-Id: Ic008fc42c80d7c797c082fef1274d1ad925f09c1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61508 Tested-by:
Richard Haeser <richard@maxserv.com> Reviewed-by:
-
Andreas Fernandez authored
This patch fixes some flaws in the IRRE uniqueness handling: - Validation is triggered once a record has been removed from DOM - Removed records are now added to their selector again if not opened before - Uniqueness handling now works for records with uid "0", which is relevant for a site's language handling - The unique update is now triggered only when the value of its selector in a record actually changes Resolves: #87711 Releases: master, 9.5 Change-Id: I9fe15d8e8790eff305024b706450cd2c37da9340 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61578 Reviewed-by:
-
