- Feb 16, 2018
-
-
Christian Kuhn authored
To further support the PSR-7 / PSR-15 and removal of GeneralUtility::_GP() and friends efforts, all controllers no longer use the second 'ResponseInterface $response' argument given by dispatchers: Dispatchers should not assume which type of response a controller returns, there is no point in preparing this object. Instead, controllers now always create one of HtmlResponse, JsonResponse or RedirectResponse on their own and return these objects. Changes overview: * Always use "new" to instantiate a response, PSR-15 middlewares allow fiddling with the object if needed, xclassing these classes is never needed, we instead can rely on proper API usage. * All controller actions drop the second $response argument and add ResponseInterface return type hint. * Some controllers action also drop first $request argument, but only if the action does not need access to ServerParams at all. Those controllers that access _GP or _POST or similar currently, keep $request for now - they have to be refactored later anyway and then need $request. Change-Id: Icce283b3c19be14ef1adeec761cfd63c90ab24c5 Resolves: #83939 Releases: master Reviewed-on: https://review.typo3.org/55754 Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Mathias Schreiber <mathias.schreiber@typo3.com> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Benjamin Kott <benjamin.kott@outlook.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
-
Alexander Opitz authored
Take into account empty and "off" values for the HTTPS request variable to support ISAPI with IIS. Resolves: #81837 Releases: master, 8.7 Change-Id: I5937c506d3e36a2009a8da6e66724728654b4001 Reviewed-on: https://review.typo3.org/55750 Reviewed-by:
-
Christian Kuhn authored
Property page_cache_reg1 is a poor man limited way to manipulate page cache tagging. It has been of very little use and is deprecated now. The usage in indexed_search (which always only added the default "0" to database) is dropped along the way. Change-Id: I9ea129fc6d20adb7a35a719f3d9d630aa663952f Resolves: #83905 Releases: master Reviewed-on: https://review.typo3.org/55723 Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
-
Georg Ringer authored
Move the templating code into the template instead of using a ViewHelper. Resolves: #83919 Releases: master Change-Id: I3df5fc096cbb7d53406f46abca1ab83fdaabc709 Reviewed-on: https://review.typo3.org/55735 Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Reviewed-by:
-
Mathias Schreiber authored
Resolves: #83938 Releases: master, 8.7 Change-Id: I71ddeb358cea2b24a4db46545a35ca956c6bc320 Reviewed-on: https://review.typo3.org/55756 Reviewed-by:
Frank Naegler <frank.naegler@typo3.org> Tested-by:
-
Christian Kuhn authored
Add a unit test to support the change from issue #83870. Change-Id: Ic8a1006c56989a1aa2ef2734e1320447875f1138 Resolves: #83909 Related: #83870 Releases: master Reviewed-on: https://review.typo3.org/55727 Tested-by:
-
Andreas Fernandez authored
Change-Id: I8a54c72090fc9e9d39fae1ddd13d8f72f691fcc0 Resolves: #83929 Related: #82414 Related: #79972 Related: #77127 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/55744 Tested-by:
-
Benni Mack authored
Output Compression should be separated from the request handling, and is now moved into a PSR-15 middleware. This change also decouples Output Compression from Bootstrap, and the Request Handler, so it can be re-used in other areas. Intentionally omitted is a proper cleanup (ob_get_clean) and an explicit write to the response object (in the middleware). That's up for later patches. The idea of this patch is to keep functionality identical for now. Resolves: #83931 Releases: master Change-Id: Ic84707cac6c858698f290069f6aa492724ce0602 Reviewed-on: https://review.typo3.org/55746 Reviewed-by:
Benjamin Franzke <bfr@qbus.de> Tested-by:
-
- Feb 15, 2018
-
-
Benni Mack authored
In order to have the main request handler only deal with content creation, and especially to move fe_user / be_user initialization out of the RequestHandler, and to remove dependencies from Bootstrap of the RequestHandler, TSFE is now instantiated in a PSR-15 compatible middleware. Resolves: #83928 Releases: master Change-Id: I8a4dd4c10f5ea2eeb60f9870c34d04979a330826 Reviewed-on: https://review.typo3.org/55742 Tested-by:
Susanne Moog <susanne.moog@typo3.org> Tested-by:
-
Tomas Norre Mikkelsen authored
The label for the "Save and create new document" in the scheduler module, will be change to a more appropriate label "Save and create new task" Resolves: #83920 Releases: master, 8.7, 7.6 Change-Id: Ic4d6ad9d4598aafbc16c03b5bc50789451f6cdaf Reviewed-on: https://review.typo3.org/55736 Tested-by:
-
Benni Mack authored
This patch improves the workflow readability by replacing variables, simplifying if() clauses and orderings etc. Resolves: #83922 Releases: master Change-Id: I893ad348f8976dd65bf11a117f54433b46d0d896 Reviewed-on: https://review.typo3.org/55738 Reviewed-by:
-
Susanne Moog authored
Resolves: #83924 Releases: master, 8.7 Change-Id: If9f435c64addea63793586e131da19768749857c Reviewed-on: https://review.typo3.org/55739 Reviewed-by:
Helmut Hummel <typo3@helhum.io> Tested-by:
-
Benni Mack authored
The check if the frontend is in "maintenance mode", set by $GLOBALS['TYPO3_CONF_VARS']['FE']['pageUnavailable_force'], is moved into a custom PSR-15 based middleware, effectively decoupling this logic from TSFE object. Resolves: #83917 Releases: master Change-Id: I38c42069b82ca2403df9aa4b0e66410a3dfe6404 Reviewed-on: https://review.typo3.org/55721 Tested-by:
-
Benni Mack authored
This patch uses the newly introduced normalizedParams, marking the first step away from GeneralUtility::getIndpEnv(), relying on a given configuration instead of a superglobal option. Resolves: #83915 Releases: master Change-Id: I4b843a1b99c0ea4f30490ff80c4383653177c13b Reviewed-on: https://review.typo3.org/55731 Reviewed-by:
Mathias Brodala <mbrodala@pagemachine.de> Reviewed-by:
-
Susanne Moog authored
Resolves: #83921 Releases: master Change-Id: Icaa53e211ed2ca6ea9824a930960c2d9cee688ef Reviewed-on: https://review.typo3.org/55737 Tested-by:
-
Christian Kuhn authored
Change-Id: I77a4782f250a4b37051eb321fd5c6670b4366e24 Resolves: #83908 Releases: master Reviewed-on: https://review.typo3.org/55726 Tested-by:
Jan Stockfisch <jan.stockfisch@googlemail.com> Tested-by:
-
Benni Mack authored
The goal is to decouple error handling from TSFE. For that, a new ErrorController is added which can be called and returns a Response object instead of exits the current request. In order to keep full backwards-compatibility, TSFE currently does not return a response, but instead exists with a response object. Next step: - Move the pageUnavailable_force functionality into a middleware - See what can be further abstracted to return a response Resolves: #83883 Releases: master Change-Id: I41f5f1a32a3f7edd48eb5c0464a26762ad4a946f Reviewed-on: https://review.typo3.org/55690 Tested-by:
-
Christian Kuhn authored
For slightly more dense code ModuleTemplate now returns $this on setter methods to allow chaining. Change-Id: Icd92d37370529a0535b4c2d5dcf2e588bd50a6ae Resolves: #83910 Releases: master Reviewed-on: https://review.typo3.org/55728 Tested-by:
-
Andreas Fernandez authored
To avoid having stale TypeScript builds, Bamboo now recompiles every TypeScript via grunt and checks for unwanted modifications. Change-Id: I1d96bb81eff4d5c42332d0a27cce0a98a7d27478 Resolves: #83914 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/55716 Tested-by:
-
Gianluigi Martino authored
It is unnecessary to show the "Group by page" checkbox if "This page" is selected in the "Depth" dropdown. Thus, the checkbox is hidden in that case. Resolves: #83896 Releases: master, 8.7 Change-Id: Idd3e0252c6bb06d2442ed4db95056e1e6d292c6c Reviewed-on: https://review.typo3.org/55718 Reviewed-by:
Stefan Neufeind <typo3.neufeind@speedpartner.de> Tested-by:
-
Frank Naegler authored
Resolves: #83892 Related: #77685 Releases: master Change-Id: I16a7d57efa7d75e712bba24724d4da365b0aa40a Reviewed-on: https://review.typo3.org/55713 Tested-by:
-
- Feb 14, 2018
-
-
Georg Ringer authored
Instead of using a ViewHelper the logic can be moved to the controller where it belongs. As the ViewHelper is not a public API it can be dropped without a RST file. Resolves: #83900 Releases: master Change-Id: I8d089761b8a168f00cb0739742fa658d40687379 Reviewed-on: https://review.typo3.org/55719 Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
Benni Mack authored
The whole Extbase stack for the about module is not necessary, as there is only one action in this controller, and it's a simple Fluid action. The module name is kept as "help_AboutAbout" due to the uncool naming handling of Extbase magic. Resolves: #83899 Releases: master Change-Id: I6353c30528d619f849ea77774b16ff0eb499e820 Reviewed-on: https://review.typo3.org/55714 Tested-by:
-
Christian Kuhn authored
composer update typo3/cms-styleguide Version 9.0.2 brings examples of the new checkbox renderTypes and a fal example using allowLanguageSynchronization Change-Id: Ia5e8f6627a15a1db9aa20f9a7c9be39a375fc401 Resolves: #83893 Releases: master Reviewed-on: https://review.typo3.org/55715 Tested-by:
-
Benni Mack authored
In order to find out what middlewares are called in which order, the Configuration module now has an additional list of all registered middlewares for "frontend" and "backend" stack. Resolves: #83882 Releases: master Change-Id: I99d8478bb07437efa65d292221ccdb03d5dd3161 Reviewed-on: https://review.typo3.org/55597 Reviewed-by:
-
Christian Kuhn authored
To slowly substitute GeneralUtility::getIndpEnv() with a better API, a new class is introduced that calculates all normalized server parameters. The object is added as PSR-7 request attribute in a frontend and backend middleware. For a transition phase, the request is made available as $GLOBALS['TYPO3_REQUEST'] until enough core code has been refactored to get rid of this again. Resolves: #83736 Releases: master Change-Id: I96c8cb6dda4cc38bbb51b64439b8e81f2c00d7ac Reviewed-on: https://review.typo3.org/55506 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
-
Benni Mack authored
When the about module (EXT:about) was refactored into Extbase, a Repository and Domain Model for Extensions was added to render title, key and authors of an extension. For modules this was done directly in the controller, which is 100% sufficient in this one-time case, instead of doing it the Extbase(tm) persistence way. This way, all data is fetched the same way in the about module. The two domain model / repository classes are removed, and due to the fact that they are not part of the API, a RST file is not added. Resolves: #83890 Releases: master Change-Id: I1169336452d7497ea0ed2e1a99553c164ec78612 Reviewed-on: https://review.typo3.org/55710 Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
-
Wolfgang Klinger authored
Since the session API has been adjusted it is no longer possible to access the (now protected) sesData property of the fe_user object. Using TSFE:fe_user|sesData|foo|bar in a TS condition will trigger a deprecation log entry. Instead a cleaner approach is now available: [globalVar = session:foo|bar = 1234567] Resolves: #83506 Releases: master Change-Id: Idbb079334186eac1dfe062a71a601e556a9bd247 Reviewed-on: https://review.typo3.org/55310 Tested-by:
-
Christian Kuhn authored
Raise typo3/testing-framework from 2.0.4 to 3.0.0: composer require --dev typo3/testing-framework ^3.0 The new typo3/testing-framework version comes with a change that no longer suppresses E_NOTICE PHP errors by default and lets tests fail that raise them. The static property $suppressNotices in unit test files is set to true for all test cases that currently raise E_NOTICE errors to suppress them on a by-file basis. Further patches should remove this property one-by-one again by fixing the system under test the unit test case handles. Change-Id: I7d44fe3723ce5820a37051ae31f16b2f142ffba6 Resolves: #83889 Related: #83888 Releases: master Reviewed-on: https://review.typo3.org/55697 Reviewed-by:
-
Benni Mack authored
The default file path is not set, so the admin has to set this to a sensible default outside the web folder when he/she wants to use it. Additionally, some CGL fixes and cleanups are applied. Resolves: #83880 Related: #76349 Releases: master Change-Id: Ibb3ce564cdfeb474f963c5900fc4bb21e4b7d1a4 Reviewed-on: https://review.typo3.org/55707 Reviewed-by:
-
- Feb 13, 2018
-
-
Christian Kuhn authored
Raise from 2.0.3 to 2.0.4 in master and from 1.2.2 to 1.2.3 in v8. Brings a patch to hopefully stabilize acceptance tests again. composer command used: composer update typo3/testing-framework Change-Id: I87d5a65b52bca6eceae805c5edbb13c7eccd1010 Resolves: #83887 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/55708 Tested-by:
-
Andreas Fernandez authored
Resolves: #83886 Related: #83844 Releases: master Change-Id: I2eca96de481c9b3d4a660f7cfded99099ea87743 Reviewed-on: https://review.typo3.org/55706 Tested-by:
-
Thorben Nissen authored
The level and link type checkmark options are now handled seperately for the "Report" and "Check Links" tab. This way, the options can be changed independantly on each tab. Resolves: #81035 Releases: master, 8.7 Change-Id: I772f885940791a17269c413185d3bea46695ff19 Reviewed-on: https://review.typo3.org/52628 Tested-by:
Tobi Kretschmann <tobi@tobishome.de> Tested-by:
Joerg Boesche <typo3@joergboesche.de> Tested-by:
Sybille Peters <sypets@gmx.de> Tested-by:
-
Richard Haeser authored
When the option $GLOBALS['TYPO3_CONF_VARS'][GFX][processor_interlace] is set, all images will be generated with the given interlace scheme. Resolves: #48013 Releases: master Change-Id: I9b78f8f27dd5223ac8e96ff33d1c26b5d1d6e1c9 Reviewed-on: https://review.typo3.org/47753 Tested-by:
-
Stephan Großberndt authored
Add missing htmlspecialchars() calls in EXT:core/Classes/Database/QueryView.php and do cleanup. Resolves: #83354 Releases: master, 8.7 Change-Id: I71c463e1a2912aa20535c7a1bbc0c690560f7e63 Reviewed-on: https://review.typo3.org/55111 Tested-by:
Sascha Rademacher <sascha.rademacher+typo3@gmail.com> Tested-by:
-
Christian Kuhn authored
The two (internal) settings 'SYS/isInitialInstallationInProgress' and 'SYS/isInitialDatabaseImportDone' have been obsoleted with the install tool rewrite in v9 and can be removed from LocalConfiguration using the SilentConfigurationUpgradeService. Change-Id: I6c80506f2389004093f43ff9fc3df49b002e1438 Resolves: #83878 Releases: master Reviewed-on: https://review.typo3.org/55696 Tested-by:
-
Willi Wehmeier authored
This patch provides a new "duplicate" button inside of the topbar of the edit record form next to the close button. This button creates and opens a new copy of the current element which is positioned right below the existing one. If there are unsaved changes in the currently open record, a modal appears with options to cancel, dismiss the changes and clone or save the changes and clone the changed record. Resolves: #77685 Releases: master Change-Id: I9e2a0f02fc9c4452f0a7d868ea17aeacb9375d95 Reviewed-on: https://review.typo3.org/53101 Reviewed-by:
Wolfgang Klinger <wolfgang@wazum.com> Tested-by:
-
Wolfgang Klinger authored
DataHandler::clearPrefixFromValue is missing a space in the regular expression when removing the prependAtCopy label. That leads to wrong headers in copied elements. Releases: master Resolves: #83870 Change-Id: I49cde9a9a20686715d9b042173f89bfeb2bd112f Reviewed-on: https://review.typo3.org/55694 Reviewed-by:
-
- Feb 12, 2018
-
-
Benjamin Franzke authored
Uncaught Error: Call to a member function isBackendUserLoggedIn() on null in […]/typo3/sysext/core/Classes/Error/ProductionExceptionHandler.php:103 Change-Id: I0052c2c1cd617282dbc65320933f8577038ab41c Releases: master, 8.7 Resolves: #83867 Reviewed-on: https://review.typo3.org/55688 Tested-by:
-
Tymoteusz Motylewski authored
Install tool now shows an ImageMagick command which failed. Resolves: #83868 Releases: master Change-Id: I4555d2ccdf68eea9180b8c7d2671b11e9b637709 Reviewed-on: https://review.typo3.org/55689 Tested-by:
-
