- Sep 15, 2024
-
-
Elias Häußler authored
The TSFE->cacheExpires property was removed in #102422. This patch removes an existing property access and replaces it with its successor in PrepareTypoScriptFrontendRendering middleware. Resolves: #104975 Related: #102422 Releases: main Change-Id: I106209ac5aa896abdd7838f6922cbb20f8411106 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/86105 Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
-
Andreas Nedbal authored
The usability of a "OS default" option isn't the greatest. Depending on the active color scheme, the "auto" option doesn't change anything visually. Having the imminent result options left in the dropdown is better. The "OS default" (auto) option is still provided in the User Settings and as default when the feature is initially enabled (and no setting was saved by the user). Resolves: #104942 Releases: main Change-Id: I12e1f48446478a84069299cbb975f6fe176348e5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/86051 Tested-by:
Andreas Nedbal <andy@pixelde.su> Tested-by:
Benjamin Franzke <ben@bnf.dev> Reviewed-by:
-
Garvin Hicking authored
This patch adds functional tests to verify the SysNoteRepository fetches proper/valid data to be displayed in widgets for example, and respects personal/foreign/deleted attributes in sys_note records. Resolves: #104898 Related: #104844 Releases: main Change-Id: Ia1d3d16661776785e8840d96f67469eadb7fc154 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/86006 Tested-by:
-
Benni Mack authored
Instead of config.sendCacheHeaders which might have your users see the same content for a long time, it is recommended to use config.sendCacheHeadersForSharedCaches = auto instead, because this now sends the following HTTP Header: Cache-Control: max-age=0, s-maxage=12345 where as s-maxage is the number of seconds how long the proxy / CDN is allowed to cache, while the browser/client should never cache this. This way, the proxy can decide on how long to cache things. See: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Cache-Control Resolves: #104914 Releases: main Change-Id: If121df42b22dd0027a8fd17e5bc434c4e67e612a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/86007 Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
Stefan Bürk authored
With #102422 the new `CacheDataCollector API` has been introduced which also implemented a middleware functional test. Mocking the request to verify that the `withAttribute()` method gets called with the correct identifier and that the passed value is the expected object instance. It seems that PHPUnit relies on type declaration when createing mocks and and eventually returning the same object if the return type matches the object type. During nightly composer minimum version test this fails now. Instead of raising packages and determine which one includes type declaration to let PHPUnit kick in some magic here the request method mock is explicitly set to return the same object when calling the method with the expected value. Resolves: #104971 Related: #102422 Releases: main Change-Id: If3f438f5c62096784d8fd0790f52e4a7d1637b34 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/86099 Tested-by:
-
Ayke Halder authored
This makes FileClipboardCest check if the content-iframe is reloaded before clicking on a button to open a dropdown-menu. Before this change the button click and opening of the dropdown-menu did sporadically happen in the old iframe-content - and before the iframe-reload. As soon as the iframe reloads, the popup-menu is closed again. The subsequent click on a dropdown-menu-entry therefore fails. Resolves: #104714 Related: #104585 Related: #104702 Releases: main, 12.4, 11.5 Change-Id: Id7fd4d993ab563ab530e8c26f741a4ed0cbeb95d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85744 Tested-by:
Garvin Hicking <gh@faktor-e.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
-
Stefan Bürk authored
This change adds a integration check which scans for spaces in file and folder names which would otherwise lead to issues on some systems. Resolves: #104923 Related: #104922 Related: #104868 Releases: main, 12.4, 11.5 Change-Id: I8560ebcfae6f959289b3e64ae8292e08e4e7e036 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/86038 Tested-by:
-
- Sep 14, 2024
-
-
Garvin Hicking authored
The CKEditor v5 configuration API allows to specify Regular Expression JavaScript objects, for example in :javascript:`editor.config.typing.transformations.extra.from` or :javascript:`editor.config.htmlSupport.allow.name`: When TYPO3 passes YAML configuration of the CKEditor forward to JavaScript, it uses a html-entity encoded representation, which does not allow to utilize Regular Expression objects, and also the CKEditor API method `buildQuotesRegExp()` is not usable in this scenario. This was remedied already for the configuration key :yaml:`htmlSupport` with its sub-keys, so that when a YAML key named :yaml:`pattern` was found, TYPO3 automatically converted that to a proper JavaScript Regular Expression. This is now also possible for the `editor.config.typing.transformations` structure: ``` editor: config: typing: transformations: extra: - { from: { pattern: '(tsconf|t3ts)$'}, to: 'TYPO3 TypoScript TSConfig' } ``` From searching the CKEditor v5 documentation it seems there are no other usages where Regular Expressions are used, but this is not easily revealed. Future places can be added easily. Resolves: #104827 Releases: main, 12.4 Change-Id: Ideeab2b22a177afaba2b434ef0d71920b6c7e296 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85910 Reviewed-by: -
Sybille Peters authored
The page layout module now displays a close button if the query parameters contain returnUrl. This can be used by extension authors, for example in combination with the Fluid backend:moduleLink ViewHelper. The patch also introduces this feature into widgets provided by sysext:sys-note as an example. Resolves: #103789 Releases: main Change-Id: I04c55d5291ef8ceec62eb54500aa6bed3e68aebc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84143 Reviewed-by:
-
Garvin Hicking authored
The database table `sys_file_metadata` set a limit of 45 characters for the `publisher` column (via TCA configuration), which was not enough in some cases, for example: macOS Version 10.14.6 (Build 18G103) Quartz PDFContext The character limit has now been raised to 120 characters. The database column is not (by default) part of an index column, and the table `sys_file_metadata` still has enough column space available to rectify this change. Resolves: #104872 Releases: main Change-Id: I368654544f6d1cda0bfaf8880a86f87f6f658951 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/86087 Tested-by:
-
Garvin Hicking authored
Similar to EXT:seo, the sys_note widgets now only soft-depend on EXT:dashboard (as a suggestion). Service registration has been adapted. Resolves: #104959 Related: #104844 Releases: main Change-Id: I4834b0687c2b8edaead0480403c3ac257a0566d9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/86089 Reviewed-by:
-
Sascha Nowak authored
A new API has been introduced to collect cache tags and their lifetime during frontend rendering. This API is used in the core to collect cache tags from page cache and content object cache. The API is implemented as a new PSR-7 request attribute `frontend.cache.collector` to remove the dependency from TSFE. Every cache tag has a lifetime. The minimum lifetime is calculated from all given cache tags. API users don't have to deal with it individually. The default lifetime for a cache tag is 86400 seconds (24 hours). The current TSFE api is deprecated in favor of the new API as the current API implementation does not allow to set a lifetime and extension authors have to workaround it. The TSFE api will be removed with the next major version. The frontend employs the following strategy: A relatively early middleware adds an empty new cacheDataCollector instance as attribute to request. Extensions rendering code based on database records can then add cache tags t...
-
- Sep 13, 2024
-
-
Sybille Peters authored
If a custom linktype is registered for the Linkvalidator, it is now possible to define the label which will be displayed in the backend module. A new interface `LabelledLinktypeInterface` provides a method `getReadableName()` to return the custom label. It is implemented by default in the `AbstractLinktype` class, so any custom linktype extending from this will be able to override the method. When no abstract class is extended, compositing a class with the `LabelledLinktypeInterface` implementation is possible. Resolves: #103090 Releases: main Change-Id: I8255aca6529d104be19c8af2b7cd505cd8749d7d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82876 Tested-by:
-
Marc Willmann authored
In frontend context the field scope in table sys_http_report may filled with a concatenation of "frontend." and the site configuration identifier. When the site identifier is too long, new entries in sys_http_report fail for frontend requests. Resolves: #104431 Related: #102404 Releases: main, 12.4 Change-Id: I88031aa518b98a167ed54b9bfd47c702da153e7b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85295 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
-
Torben Hansen authored
This change introduces file upload handling in Extbase, aiming to simplify and standardize the process of managing file uploads and deletions in TYPO3 extensions with simple attributes/annotations. Recognizing the complexity of file upload scenarios, this feature is designed to cover direct domain model properties only. It provides support for handling file uploads and deletions for properties of types `FileReference`, and `ObjectStorage<FileReference>` in non-nested domain models. The new API uses extbase validators to validate file size, allowed MIME types and image dimensions, ensuring the integrity and security of uploaded files. The feature also supports custom validators, allowing developers to extend validation logic according to specific needs. Resolves: #103511 Related: #103022 Releases: main Change-Id: I311d9e10bc692a849e79f67d4d12246cdbccb37f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83749 Tested-by: Oliver Hade...
-
Benni Mack authored
Since the removal of CSS Styled Content in TYPO3 v8, the usage for the DB fields in tt_content: - Menu block title [accessibility_title] - Add link to bypass navigation block [accessibility_bypass] - Link text to bypass navigation block [accessibility_bypass_text] have been unused, and are not needed anymore. If someone still uses them with CSS Styled Content, they need to add the fields and the TCA definitions to their own schema again. Resolves: #101535 Releases: main Change-Id: Ia841d700c5cf48eefc43b277edcec2a5ff3dde71 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85933 Tested-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Reviewed-by:
-
Benjamin Kott authored
Resolves: #104960 Releases: main Change-Id: If61cd197ab64051199a533f63118cd13b185771b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/86086 Reviewed-by:
Andreas Kienast <a.fernandez@scripting-base.de> Tested-by:
-
Andreas Nedbal authored
Resolves: #104916 Releases: main Change-Id: Ib141c009df491ac1d403865ee8cf11febf38453e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/86024 Reviewed-by:
Benjamin Kott <benjamin.kott@outlook.com> Tested-by:
-
Torben Hansen authored
Extbase controller argument mapping can result in several exceptions being thrown. Extension authors however have no public API method for handling those exceptions, resulting in possibly overwriting internal methods of `ActionController`. This change introduces the method `handleArgumentMappingExceptions` in `ActionController` and the configuration options: * `mvc.showPageNotFoundIfTargetNotFoundException` * `mvc.showPageNotFoundIfRequiredArgumentIsMissingException` Extension authors can now either configure handling of commonly thrown exceptions during argument mapping, or implement a custom exception response handling. Resolves: #104321 Releases: main Change-Id: I351e5cfee5f80995aae5c95722b21218dffb9886 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85138 Reviewed-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Reviewed-by:
Mathias Brodala <mbrodala@pagemachine.de> Tested-by:
-
Benjamin Franzke authored
Apply an additional form token (send via POST) for the site settings save action, additionally to the get-based route token. Releases: main Resolves: #104951 Change-Id: I33beefbf15172274a593b0889583eaa7008ef874 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/86081 Tested-by:
-
Benjamin Franzke authored
Drop the `$force` parameter, which is intended to create a fresh (ignoring existing cache) instance everytime. This parameter was probably forgotten during development. Resolves: #104946 Related: #104521 Releases: main Change-Id: I11d0e75ea69f741e8a466ae08231d72d123f81c3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/86075 Reviewed-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
-
- Sep 12, 2024
-
-
Benjamin Franzke authored
Implement ContainerInterface in order for fluid[1] to be able to access settings properties directly, instead of using `{settings.all.property}`, e.g. when accessing site settings directly via `{site.settings.mysite.brandColor}`. [1] https://github.com/TYPO3/Fluid/issues/1001 (raised in #104896) Releases: main Related: #104858 Related: #104896 Resolves: #104906 Change-Id: Ia6cd703dfc2faca5f6324174ee343610cc32a6b3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/86013 Reviewed-by:Oliver Bartsch <bo@cedev.de> Tested-by:
-
Benjamin Franzke authored
Site settings rely on the Settings base class __set_state() method to recreate the object from cache. Since the base class used `new self` instead of `new static`, the object received an invalid type and was therefore ignored. Use `new static` to ensure the correct constructor is invoked. Resolves: #104945 Related: #104858 Releases: main Change-Id: I09eee1043902b5e62243258a080a64f026a6783e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/86074 Tested-by:
-
Oliver Bartsch authored
Prevent UndefinedSchemaException for records, which contain a no longer valid record type. Resolves: #104943 Related: #104938 Releases: main Change-Id: Ife408dd2ab7b2361583c77bb4f622548495bf9ca Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/86072 Tested-by:
-
Andreas Kienast authored
Resolves: #104939 Related: #104913 Releases: main Change-Id: Ie3486041db6ffe31c10da32c5e281cbb6b2d0017 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/86048 Reviewed-by:
-
Oliver Bartsch authored
A new generic way of defining record preview template paths is introduced. Corresponding TSconfig syntax: `record.preview.<table_name>.paths` Using this option to define template paths, the templates for the record previews as well as related layouts and partials are auto-discovered. Those templates receive the fully transformed record object. The functionality is first used for content element previews in the page module but will be used in other areas of the backend in the future. Therefore, the corresponding service has been renamed to `FluidBasedRecordPreviewRenderer`, while the event listener method for the content preview got the speaking name `renderPageContentPreview`. Resolves: #104938 Releases: main Change-Id: I15f136c50a4161366afd18f59a2188ec17750c38 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/86032 Tested-by:Jochen Roth <rothjochen@gmail.com> Tested-by:
-
Andreas Kienast authored
To make managing content across pages easier, a backend user may now drag content elements from the "Page" module into a page in the page tree. Once dropped, a modal window will open where the backend user may select the position where the content element shall be placed to, and also change the target page again. Resolves: #104935 Releases: main Change-Id: Id4de849d02e36478af1c6fa780c2e4d495d6b41e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/86018 Tested-by:
-
Mathias Brodala authored
The templates can be replaced by integrators via configuration. They probably expect to be able to use the EditRecordViewHelper. This one uses the current request for its returnUrl. The request was missing which would lead to an "Call to a member function getAttribute() on null" error. Resolves: #99287 Releases: main, 12.4 Change-Id: I6a696bf176051b7c5eb4c1b762b10ebc33e7a4b1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76939 Reviewed-by:
-
Benni Mack authored
This change prepares some code areas within the Fluid-based page module to be re-used at a later point, especially within the PagePositionMap. This is a pre-patch to make life easier. Resolves: #104934 Releases: main Change-Id: I2296db0e5d4ab4ef9b150a20e02964b0c2fc4af4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/86044 Tested-by:
-
Oliver Bartsch authored
In case a sub schema, e.g. `tt_content.list` makes use of the "subtypes" feature by defining the "subtype_value_field", corresponding configuration ("subtypes_addlist" and "subtypes_excludelist") is now evaluated in the TCA schema and added as further schema (third level) to the corresponding sub schema (second level). This will therefore look like the following: Schema "tt_content" -> Sub Schema "list" -> Subtype Schema "tx_blog_pi1" Via the "subtypes" feature it's only possible to add or remove existing fields from the corresponding sub schema. Also note that the subtype schemata can only be accessed using the getSubSchema() and getSubSchemata() methods on a sub schema. This means calling `$schemaFactory->getSchema('tt_content.list.tx_blog_pi1')` does not work intentionally! Resolves: #104929 Releases: main Change-Id: I10428e1129d5d23acce91cd7756f4f255a45c29b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/86043 Tested-by:Frank Nägler <frank.naegler@typo3.com> Reviewed-by:
-
Benjamin Kott authored
Corrects z-index to not hide module menu and other important actions behind the modal backdrop on mobile Resolves: #104933 Releases: main Change-Id: I3d6fe35f811a01ee674adae1a1acf7c79d6edf34 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/86045 Tested-by:
-
Benjamin Kott authored
Resolves: #104930 Releases: main Change-Id: Ib481c76706e2544688ff8137ba4584aed67ddf46 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/86042 Tested-by:
-
Benjamin Kott authored
We are dropping the Bootstrap CSS definitions for all list-group to have more control about the styling of the list-group elements. From now on we are shipping custom css adapted to our needs. The new list-group element styling is context aware and adapts to light and dark color schemes. Resolves: #104927 Releases: main Change-Id: I9212f0e668a00591f1351b1a56daec99eadc420b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/86041 Tested-by:
-
Stefan Bürk authored
The frontend implementation of `EXT:adminpanel` has been revamped in TYPO3 v9 with #84584, #84044 and #84892 including the refactor of AJAX request using backend ajax routing. This makes the `eID` handler implementation obsolete for quite a long time now but has not been removed meanwhile. This change removes the `eID` handler mapping towards the ajax controller without further notice as they are not called anyway. [1] https://review.typo3.org/c/Packages/TYPO3.CMS/+/56826 Resolves: #104924 Related: #84892 Related: #84044 Related: #84584 Releases: main Change-Id: I49ae7721adc9937bcca0d0b774aefd07c446ad35 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/86039 Tested-by:
-
Garvin Hicking authored
The Extension Scanner of the EXT:install module allows to scan custom extensions based on several static code analysis rules. Most of these rules depend on analyzing code to see if deprecated or removed methods are called, or if argument names change, annotations/attributes get removed and so on. This patch adds a `AbstractMethodImplementationMatcher` matcher which can analyze definitions of specific methods within an extended abstract class that need to be migrated. A good example for this is the change in Fluid ViewHelpers deprecating the "renderStatic" method, which could previously not be matched. Because ViewHelpers themself do not execute a `renderStatic` method, any custom ViewHelper implementing `renderStatic` would not be revealed in the Extension Scanner before. The Matcher receives a configuration like: ``` return [ 'TYPO3Fluid\Fluid\Core\ViewHelper\AbstractViewHelper::renderStatic' => [ 'restFiles' => [ 'Deprecation-104789-RenderStaticForFluidViewHelpers.rst', ], ], ]; ``` and based on this, iterates every custom code to check if any class inherits from this `TYPO3Fluid\Fluid\Core\ViewHelper\AbstractViewHelper` abstract, and then checks for a given method name (here `renderStatic`). Both static (`::`) and "local" ( `->`) methods can be configured for matching. These matches will be reported as strong matches. Resolves: #104799 Related: #104789 Releases: main Change-Id: I9021ecc021a45770e2e4c8b0295f4d1afe55adfd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85853 Tested-by:Simon Praetorius <simon@praetorius.me> Reviewed-by:
-
Frank Naegler authored
The method \TYPO3\CMS\Core\Utility\ExtensionManagementUtility::addPItoST43() has been marked as deprecated and will be removed with TYPO3 v14. Resolves: #102821 Releases: main Change-Id: Iab5c665e9ec8c0aef0c21affac7bb2b5f40a5d88 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83320 Tested-by:
Torben Hansen <derhansen@gmail.com> Reviewed-by:
-
Simon Praetorius authored
A new option `external` is added to the `AssetCollector` API, which prompts `AssetRenderer` to skip any processing of the supplied asset URI. Resolves: #102255 Releases: main Change-Id: I6016f814af0b0ef92a172eb0538fe949affce6cc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/86035 Reviewed-by:
-
Andreas Kienast authored
The wizard to move or copy a content element into another page is now moved into a modal window. This is a preparation patch to allow dragging content elements from the page module. Resolves: #104915 Releases: main Change-Id: I4e69bbcc2f43ea889491a1383648dbc17a233812 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/86023 Tested-by:
-
Sybille Peters authored
The following fields have been added to the default configuration: * `pages.canonical_link` * `sys_redirect.target` * `sys_file_reference.link` Other non-working fields (`pages.media`, `tt_content.records`) are kept for forward-compatibility. Resolves: #83835 Related: #103478 Related: #103477 Releases: main Change-Id: Ic598a2a78bb9c103def9a692370f118ee2fa11b3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83612 Tested-by:
-
Andreas Kienast authored
To avoid flickering in the TYPO3 backend, the body and iframe elements are now styled to have a background color matching the selected color scheme. Resolves: #104917 Releases: main Change-Id: Ib5c7ee67e29912f35aa97fb4ef3718b9cee32bee Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/86025 Tested-by:
-
