- Jun 28, 2024
-
-
Christian Kuhn authored
DataHandler is now DI aware and gets a bunch of services injected. We're not injecting any potentially possible service blindly - we're omitting stateful ones, and declare some common classes readonly along the way to make this more clear. The DataHandler unit test receives a slightly bigger update to deal with this properly. This needs a raise of TF, which had a `new DataHandler()` in one place: > composer u typo3/testing-framework Resolves: #104253 Related: #104245 Related: #104241 Related: #104240 Releases: main Change-Id: Ie1e296b9884d8299ce699ed525fdd2b69d460ebd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84993 Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
Christian Kuhn authored
Resolves: #104249 Releases: main, 12.4 Change-Id: I2e56c967ab27ddc855261ff53f654d5916f3dce6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84997 Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
-
Christian Kuhn authored
filter() retrieves 'DataHandler|DatabaseRecordList $dataHandler' as argument to call $dataHandler->deleteAction on it. DatabaseRecordList and extending classes have no such method. Resolves: #104248 Related: #98479 Releases: main Change-Id: I2fd425c5503a546e6cbf8ed3dae94145e2cb85d7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84994 Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
Oliver Bartsch authored
Instead of calling the PageDoktypeRegistry in the TcaFactory, the PageDoktypeRegistry does now initialize the TCA for registering the allowed record types for the default doktype on-demand. Resolves: #104234 Releases: main Change-Id: Iefe400fe24e890af8a748d0894aa3f914eec4ad5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84945 Tested-by:
Mathias Brodala <mbrodala@pagemachine.de> Reviewed-by:
-
Philipp Kuhlmay authored
This adds an example on how to use a custom icon inside the Infobox Fluid-Viewhelper. Resolves: #104123 Releases: main Change-Id: Ie1fd9f2c13fb426f7c3d3243fe29ebcc8921f046 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84929 Tested-by:
-
Stefan Bürk authored
With PHP 8.4 marking method parameter implicitly nullable is deprecated and will emit a `E_DEPRECATED` warning. One recommended way to resolve this, is making it explicitly nullable using the `?` nullable operator or adding a null tyype to an union type definition. [1] This prepares the way towards PHP 8.4 compatibility. [1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated Resolves: #104247 Releases: main, 12.4, 11.5 Change-Id: I71d8f59eaba6dd22b00f8eb7400f2b49d748e430 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84990 Reviewed-by:
-
Stefan Bürk authored
With PHP 8.4 marking method parameter implicitly nullable is deprecated and will emit a `E_DEPRECATED` warning. One recommended way to resolve this, is making it explicitly nullable using the `?` nullable operator or adding a null tyype to an union type definition. [1] This prepares the way towards PHP 8.4 compatibility. [1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated Resolves: #104246 Releases: main, 12.4, 11.5 Change-Id: Id7713c10014da20bcd4e7976e64434c71d319bda Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84987 Reviewed-by:
-
Oliver Bartsch authored
Resolves: #104244 Releases: main Change-Id: I9619e380bc32f7966ff6804390207312f9e7da3e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84986 Reviewed-by:
-
Christian Kuhn authored
PagePermissionAssembler is a DataHandler related helper that calculates the permission fields of page records. The patch removes pollution of __construct() by manual arguments: $GLOBALS['TYPO3_CONF_VARS'] is runtime static and can just be used when needed. This avoids a class property, making the class stateless. Minor further clean ups, an improved comment, and an @todo that we should consider changing the API. Resolves: #104245 Releases: main Change-Id: I85d125612af02b54627a4c9efd525d4349ce868c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84985 Reviewed-by:
-
Oliver Bartsch authored
This unifies the paths to backend modules below "system", such as "webhooks" or "scheduler". Additionally, the module identifier of the "Backend Log" module is changed to "system_log", matching the usual naming convention. A corresponding module alias is in place and usages are adjusted. Resolves: #104165 Releases: main Change-Id: Idc4f86eb03943e68c3f4c896e42524edffdc7696 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84806 Tested-by:
-
Oliver Bartsch authored
Some FormEngine related JS components, e.g. the slug element rely on input and text fields to have the field name set via either the special `data-formengine-input-name` - if pointing to a hidden input field - or via the standard `name` attribute. All those FormEngine elements support the readonly state, which renders only the field with the `disabled` attribute set by omitting any JS functionality. For this use case no `name` attribute is required. However, to use them in combination with other fields, e.g. as generator field for TCA type slug, the field name is now added as `name` attribute in readonly state. Resolves: #104178 Releases: main, 12.4 Change-Id: Ibd28c563c8184078805a64aa123f86d538077180 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84910 Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
-
Christian Kuhn authored
ReferenceIndexUpdater as established with #92356 is a stateful object designed to "gather" refindex update jobs and perform them in DH "outer most instance". An object like this is not something that should be injectable via DI, but should be hand over at runtime. DataHandler already has a (clumsy) solution to hand over state: method start(). The patch switches from handing ReferenceIndexUpdater over as constructor argument to start() instead. This essentially frees DH::__construct() for DI, which is a great benefit for this class and will be used with further patches. Note DH tends to create 'sub instances'. API calls work on the 'outer most instance' only. The patch is not considered breaking since the API of 'outer most instance' does not change: The additional argument to start() is optional, and used only internally for sub instances. Resolves: #104240 Related: #92356 Releases: main Change-Id: Iffb42eb7582d2d6c1ab1024ffd13dd3347e54e0f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84982 Reviewed-by:
-
Christian Kuhn authored
Get more state in DH periphery right: DataMapProcessor is an `@internal` construct of DataHandler. It has a static instance() method, used once. The patch removes __construct() with it's current arguments to free it towards DI in upcoming patches. State is set explicitly after object instantiation. Note ReferenceIndexUpdater is no longer optional. Resolves: #104241 Related: #104240 Releases: main Change-Id: I6cb2e9ccc86552bf569d3d05ba8ccb703643ab11 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84983 Reviewed-by:
-
Jasmina Ließmann authored
The display of the table in the recycler module has been slightly revised. To improve clarity, the page UID information has been moved to its own table column. The table column for the last edit has been moved to the position in front of the action column. Previously, the two table columns "Record" and "Page Title" took up as much space as their content allowed, which could lead to unwanted horizontal scrolling. This patch sets a maximum width for these fields. The background color of the opened accordion has been changed to make it easier to distinguish between the individual table rows. In addition, its content has been rearranged for better readability. If available, the real name of the backend user is now displayed in addition to the user name. Longer, connected path information could also lead to unwanted horizontal scrolling. This patch inserts word breaks when necessary. Minor label adjustments were also made in the process. Resolves: #104239 Releases: main Change-Id: I5b3bfa0ccadd620532a4a0e0f328657c9c7a4042 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84979 Tested-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Tested-by:
-
Stefan Bürk authored
With PHP 8.4 marking method parameter implicitly nullable is deprecated and will emit a `E_DEPRECATED` warning. One recommended way to resolve this, is making it explicitly nullable using the `?` nullable operator or adding a null tyype to an union type definition. [1] This prepares the way towards PHP 8.4 compatibility. [1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated Resolves: #104238 Releases: main, 12.4, 11.5 Change-Id: I340f35379b74d1ca05527a6950eab5ba66ffaae6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84976 Tested-by:
-
Stefan Bürk authored
With PHP 8.4 marking method parameter implicitly nullable is deprecated and will emit a `E_DEPRECATED` warning. One recommended way to resolve this, is making it explicitly nullable using the `?` nullable operator or adding a null tyype to an union type definition. [1] This prepares the way towards PHP 8.4 compatibility. [1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated Resolves: #104237 Releases: main, 12.4, 11.5 Change-Id: Ieb8d05b2e44dc448f7a2142c5ad6a91e68cf98c0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84973 Tested-by:
-
Oliver Bartsch authored
Also adds the type to the corresponding test. Resolves: #104230 Releases: main, 12.4 Change-Id: Ica9e6b63d5a2fe52cc775642562cf8f9036db081 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84940 Reviewed-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Torben Hansen <derhansen@gmail.com> Reviewed-by:
-
Georg Ringer authored
Provide an additional test to check for correct usage of numeric keys. Resolves: #94852 Releases: main, 12.4 Change-Id: I01c73fb3e1aa0f4d458e9d349484856cb416387d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84980 Tested-by:
-
Stefan Bürk authored
With PHP 8.4 marking method parameter implicitly nullable is deprecated and will emit a `E_DEPRECATED` warning. One recommended way to resolve this, is making it explicitly nullable using the `?` nullable operator or adding a null tyype to an union type definition. [1] This prepares the way towards PHP 8.4 compatibility. [1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated Resolves: #104236 Releases: main, 12.4, 11.5 Change-Id: Iba5e99b526ca37d7bb36044cd6ee1027b6c5245a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84950 Tested-by:
-
Garvin Hicking authored
Currently only `siteLanguage` was documented as usable, now also `site` is explained with the most common public getter methods and an example. Resolves: #99723 Releases: main, 12.4 Change-Id: I8cb6de70b481322c31bd6fa7b3319c74f8af517a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84896 Tested-by:
-
- Jun 27, 2024
-
-
Garvin Hicking authored
The migration wizard BackendGroupsExplicitAllowDeny ('Migrate backend groups "explicit_allowdeny" field to simplified format') returns Symfony formatted error messages for specific single rows. Before this patch, it was still reported as a successful migration, and the success message is formatted with "everything is great" green background, so that errors may not receive attention. This patch changes the wizard to return a failure state. This will then return the messages formatted as errors. Since the wizard migrates all rows (even the faulty ones), the wizard can then be re-executed to be marked as "done". This is not ideal, but because of the way Symfony output streams cannot reveal if they contain an error when the stream is retrieved, there is little other choice. Otherwise the Wizard API would need to receive a breaking API change to allow to carry additional meta information about "warnings" rather than just errors, which is beyond scope for current development state. Resolves: #104208 Related: #104225 Releases: main, 12.4 Change-Id: Ibde1d977bc8747a053da1360aea6c0e3f8b77f7f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84933 Tested-by: -
Georg Ringer authored
Resolves: #104216 Releases: main, 12.4 Change-Id: Ifbd5499fe8c50661cec4ec198b479978bd839084 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84938 Tested-by:
Riccardo De Contardi <erredeco@gmail.com> Reviewed-by:
-
Jasmina Ließmann authored
The "Owner" information in "Recycler" backend module is broken and never shows a valid value. This patch ensures that the correct owner information such as user name and UID is now displayed. Resolves: #104228 Releases: main, 12.4 Change-Id: Ib1ddd570e1bfe2fe86e114e946cb57413a766692 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84937 Reviewed-by:
-
Garvin Hicking authored
The CKEditor YAML files support a lot of configuration options to adjust the Link Browser appearance, adding additional CSS class selection, link-target selection, title attribute and others. The Link Browser configuration is mostly revealed through TCA configuration, but the YAML format was not documented yet. The documentation is updated to reflect all configuration options, and an example YAML file `EXT:rte_ckeditor/Configuration/RTE/Editor/LinkBrowser.yaml` has been added. Resolves: #104157 Resolves: #101711 Releases: main, 12.4 Change-Id: Iffed9f87a35038c01d43947e6e57a0c363cf7c1a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84921 Tested-by:
Lina Wolf <112@linawolf.de> Tested-by:
-
Torben Hansen authored
This change cleans up and streamlines Extbase type converters by: * using typed properties * adding proper return types for the `convertFrom` method * marking all `convertFrom` methods `@internal` * make `$configuration` attribute in `convertFrom` method explicitly nullable * removing unnecessary qualifiers * removing superfluous comparisons Additionally, more tests have been added for the `ArrayConverter` and `FloatConverter`. Resolves: #104226 Releases: main Change-Id: Ie56a7275969963f47f8ab538300718a3a63dced7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84936 Tested-by:
-
Benni Mack authored
12.0 allowed the option to show "scheduled records", that is: Records that are timed with starttime / endtime. However, the backend should always show records (based on the Context) with starttime / endtime ignored, but that was simply forgotten in the original patch. Resolves: #104235 Related: #91082 Releases: main, 12.4 Change-Id: I2fbc2023efbcd1039cfa0ee37b7f1c32ed743b94 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84947 Tested-by:
-
Simon Praetorius authored
The XSD schema generator, added with Fluid Standalone 2.12, is applied to TYPO3's Fluid integration. This provides autocompletion for supporting IDEs (like PhpStorm) by executing the CLI command added with this patch. Resolves: #104114 Releases: main Change-Id: Id9f996820483e5af21506cdde2221b2be65a38d8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84720 Tested-by:
-
Benni Mack authored
This feature introduces a schema for *reading* information out of TCA, especially when working with data from the database that is TYPO3-specific only to be based on "types" (e.g. tt_content) or a specific "subtype" (e.g. the value from tt_content.CType, such as "tt_content.textmedia"), or detecting information from the global TCA definition. The basic structure works as follows: TcaSchemaFactory serves as the basic entry point for fetching the schema for e.g. tt_content.textmedia which then resolves all information from TCA based on the "tca" schema. A Schema can be the main TCA table information (with everything) or the "subSchema". A Schema contains a list of "Capabilities" (typically within "ctrl" section), possible sub schemata, and all fields registered in "showitem" (for a subtype). The Fields are divided by the "type=..." information in TCA. Non-recognized type fields are skipped for the time being. Only TcaSchemaFactory knows about the actual full TCA information and builds objects out of it. Schemas and Fields are put in collections so they can never be modified after the Boostrap process is completed. Before the schema objects are built, the RelationMap is built, which contains information which fields contain information that records "might" have a connection to another database field or table. These are then attached to the Schema and Field objects as Active and Passive Relations. Building the Schema API as graph thus in turn needs to run two times over all TCA information and all registered FlexForm data structure definitions (as flexforms might also contain relations to tables). Relations are built as loose DTO relation informations and not as pointers to Schema objects. Missing parts to be evaluated later-on: - Can this be used for Site Configuration definitions as well? - "Subsubtype" resolving (tt_content.list and list_type) - childTca resolving (if this is possible) - having a colon ":" in type field (maybe related to childTca) - Add tests for Flex once it is clear how it is needed in DataHandler Resolves: #104002 Releases: main Change-Id: I75cf20d491364f60be7f284615eea65086085801 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75486 Tested-by:
-
Benni Mack authored
Since HTML Sanitizer was introduced, lib.parseFunc does "transformations", instead of ensuring that HTML is "safe", which wasn't possible anyways (that was one of the reasons why htmlSanitize is introduced). A quick explanation to the existing functionality of allowTags and denyTags: * If parseFunc stumbles across a tag, which is NOT a typotag (tags.a for example), and NOT an external block, it will be checked if it is in "allowTags" or NOT in "denyTags", then it gets rendered, otherwise the tag including its contents is htmlspecialchar'ed. The tags are thus NOT removed, but instead hsced. In order to simplify the process, allowTags and denyTags can now be omitted, with the following result: If allowTags = a,b,em... ONLY these tags are allowed, and denyTags does not matter anymore already. allowTags can now be set to "*", thus denyTags can be used to mark explicitly use "denyTags". It now makes little sense to define allowTags AND denyTags at the same time. Resolves: #104220 Releases: main Change-Id: I817109a896e8ebde8cccdf502bf24b38c05a4502 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84824 Tested-by:
-
Oliver Bartsch authored
This makes passing the PSR-7 Request to the PolicyMutatedEvent optional, since there are use cases where the available request is not relevant for CSP / the Event. Those usages are adjusted accordingly. Resolves: #104141 Releases: main, 12.4 Change-Id: Id4597e26850f42a444a16fe986e2136b6a543075 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84930 Reviewed-by:
-
- Jun 26, 2024
-
-
Georg Ringer authored
Apply the latest rules of cs-fixer also on the Build directory Resolves: #104227 Releases: main, 12.4 Change-Id: Ief38397cb0870e358caa43ca505f04fbb89a86c0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84935 Tested-by:
-
Simon Praetorius authored
This patch updates Fluid to the latest version. It also adds a RST file which describes the new ViewHelper capabilities that were added with 2.12. Executed command: composer req typo3fluid/fluid:^2.12.0 Resolves: #103560 Releases: main Change-Id: I24edbc6552e05779dfbea0157b0184799bff6f6b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84931 Tested-by:
Simon Praetorius <simon@praetorius.me> Reviewed-by:
-
Stefan Bürk authored
With PHP 8.4 marking method parameter implicitly nullable is deprecated and will emit a `E_DEPRECATED` warning. One recommended way to resolve this, is making it explicitly nullable using the `?` nullable operator or adding a null tyype to an union type definition. [1] This prepares the way towards PHP 8.4 compatibility. [1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated Resolves: #104210 Releases: main, 12.4, 11.5 Change-Id: Id20216f2b920b5f5c0d665a370536c447590f53c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84915 Reviewed-by:
-
Benni Mack authored
Resolves: #104219 Releases: main Change-Id: I18609bb963eae8dd1aa918d74ea40293ea2c5e3a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84928 Reviewed-by:
-
Stefan Bürk authored
With PHP 8.4 marking method parameter implicitly nullable is deprecated and will emit a `E_DEPRECATED` warning. One recommended way to resolve this, is making it explicitly nullable using the `?` nullable operator or adding a null tyype to an union type definition. [1] This prepares the way towards PHP 8.4 compatibility. [1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated Resolves: #104209 Releases: main Change-Id: Iea94673b0d04d80f7b71f1cc9e936ccdbd7784e9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84914 Tested-by:
-
Stefan Bürk authored
With PHP 8.4 marking method parameter implicitly nullable is deprecated and will emit a `E_DEPRECATED` warning. One recommended way to resolve this, is making it explicitly nullable using the `?` nullable operator or adding a null tyype to an union type definition. [1] This prepares the way towards PHP 8.4 compatibility. [1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated Resolves: #104211 Releases: main, 12.4, 11.5 Change-Id: Ic086fc77872c54f763d774f4118517658d8d52e3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84918 Tested-by:
-
Stefan Bürk authored
Since recently upgraded PHP-version the 10mb big xml unit test failes. The `\LIBXML_PARSEHUGE` xml option could be used to mitigate this case but would not explain the change from PHP yet. Thus the decision has been made to disable the failing data set as a temporary solution to avoid disturbance for core contribution until this issue has been investigated and reported to PHP itself. Resolves: #104218 Releases: main, 12.4, 11.5 Change-Id: Ifef4f18818e661312b9e56e013bb8f479146b806 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84926 Tested-by:
Markus Hofmann <typo3@calien.de> Reviewed-by:
-
Oliver Bartsch authored
For additional context does the PolicyMutatedEvent now provide the current PSR-7 Request. Resolves: #104141 Releases: main, 12.4 Change-Id: I1817366e77f20f6c43eef0ee209fbb419e7237e2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84913 Tested-by:
-
Christian Kuhn authored
typo3/testing-framework v8 has been branched, dev-main modernizes the codebase and removes some deprecated details. > composer u typo3/testing-framework Resolves: #104213 Releases: main Change-Id: Iaf5770905c8c9cad1d3d15dbc3c6ad1559334f3e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84882 Tested-by:
-
- Jun 25, 2024
-
-
Stefan Bürk authored
With PHP 8.4 marking method parameter implicitly nullable is deprecated and will emit a `E_DEPRECATED` warning. One recommended way to resolve this, is making it explicitly nullable using the `?` nullable operator. [1] This prepares the way towards PHP 8.4 compatibility. [1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated Resolves: #104206 Releases: main, 12.4, 11.5 Change-Id: I0d82e0474143f63870f772002de52d26c6c960fd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84906 Reviewed-by:
-
