- Aug 23, 2020
-
-
Daniel Windloff authored
The information about collapsed tables is only needed in the getTable method. So the information could be collected there and the property tableCollapsed has been dropped. Releases: master Resolves: #92077 Change-Id: If6c6bc6d6b7108975a2b1b4e0fdfb01fe2e06fbe Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65437 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Daniel Haupt <mail@danielhaupt.de> Reviewed-by:
-
Daniel Windloff authored
The property has been dropped, as it doesn't do anything useful. It is internal (see section), it could be dropped without further notice. Releases: master Resolves: #92074 Change-Id: Iced7f072c180467c1ee0473477e1d10369cc17ec Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65434 Tested-by:
-
Daniel Windloff authored
The internal property addElement_tdParams is always empty. So it has been removed. Releases: master Resolves: #92078 Change-Id: If6900b8aec4cbc96230ef07a6889a1015775e709 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65438 Tested-by:
-
Daniel Windloff authored
Respect the configuration mod.newContentElementWizard.override and make it work again. Releases: master, 10.4 Resolves: #92075 Change-Id: I5d9d6ada2c502629a4cae67794d9d3a251de600f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65435 Tested-by:
-
Christian Kuhn authored
This reverts commit 99b0da83. Reason for revert: The patch breaks bookmarks handling of info sub modules. Change-Id: Ie2ae033508728c55557bb5bd4f2d508a5dd3cd2e Reverts: #92070 Releases: master Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65425 Tested-by:
-
- Aug 22, 2020
-
-
Markus Hofmann authored
Symfony expects a colon after the class name. Releases: master, 10.4 Resolves: #92073 Change-Id: I5476acb035875fa55a1ec00a57d0b34c74242750 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65433 Tested-by:
Simon Gilli <typo3@gilbertsoft.org> Tested-by:
-
Helmut Hummel authored
Use IMAGECROPSCALEMASK to render IRRE thumbnails, so that the crop area is properly respected and the TCA configuration for the rendering is applied as well. Also fix the resolving of the crop area, which remained undiscovered, as the crop configuration is ignored with IMAGEPREVIEW processing. Releases: master, 10.4, 9.5 Resolves: #91978 Change-Id: Ia986bc4ec77ce06a9dacbced0b536462f19db1a3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65278 Tested-by:
Tim Schreiner <schreiner.tim@gmail.com> Tested-by:
Helmut Hummel <typo3@helhum.io> Reviewed-by:
Simon Praetorius <simon@praetorius.me> Reviewed-by:
Markus Klein <markus.klein@typo3.org> Reviewed-by:
-
Helmut Hummel authored
Due to the fact that configurable processors weren't present when online media handling was introduced, a lot of code needed to be duplicated to make the processing work in a pre process event. Since we have configurable processors now, the code should is moved to a processor and the code duplication removed. This change is also a prerequisite to make deferred image processing work more smoothly, because the online media preview processing should be handled after a deferred image processor but before regular local image processing. Resolves: #92024 Releases: master, 10.4 Change-Id: Ifbc1159a0e98d2e42fedf6a57764778293b6035d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65346 Tested-by:
-
Helmut Hummel authored
Instead of spreading (similar) code that handles SVG files in multiple classes with conditional code branching, processing SVG files (mostly calculating new width and height according to the configuration) is now placed in an own file processor. Cropping SVGs is still done like before using IM/GM and resulting in an png image. In this case the new processor is skipped and the file is passed to the existing LocalImageProcessor. A new class is introduced, which calculates resulting image dimension from an original dimension and a given processing task. Releases: master, 10.4 Resolves: #92014 Change-Id: I5799c09b06d32a495a917da523506a6cc1f8e45d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65339 Tested-by:
-
Benni Mack authored
This change makes sure to set up the page in the TYPO3 Backend, to load JS and CSS directly in PageRenderer when the ModuleTemplate object is instantiated, allowing to load custom JavaScript or CSS. Before, renderContent (the last call in ModuleTemplate) was used to add default CSS and JS. Resolves: #91812 Releases: master, 10.4 Change-Id: I87c8392d3784d3ac63a086846e85fae76663d4a2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65236 Tested-by:
Marcus Schwemer <ms@schwemer.de> Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Reviewed-by:
-
Kevin Appelt authored
So far always the SKIP action was executed. But in the drop-down of the actions the correct option was already selected. Now the default action is also executed and not only displayed. Resolves: #91985 Releases: master, 10.4 Change-Id: I1b03019eb6b0ed112abc2e6afb528094faf83018 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65398 Tested-by:
Kevin Appelt <kevin.appelt@icloud.com> Tested-by:
-
Christian Kuhn authored
Since #90272 the PageLayoutView works well without the SOBE assignment. Drop that from InfoModuleController. Resolves: #92070 Related: #90272 Releases: master Change-Id: I3cc243cfabe5728b3e6dc93a7340386165aff501 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65409 Tested-by:
Björn Jacob <bjoern.jacob@tritum.de> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
-
Christian Kuhn authored
The $GLOBALS['SOBE'] = $this; assignment has been kept in EditDocumentController together with two public properties to keep an old working version of the ConditionMatcher. This has been resolved meanwhile, the code can be dropped. Resolves: #92069 Related: #87607 Releases: master Change-Id: I89598d13f68c17451c0acad1f6e04b501f5fd792 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65408 Tested-by:
-
Daniel Windloff authored
Releases: master Resolves: #92072 Change-Id: Ife789cdff756261b59785ad816af35d58cc7bb4e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65411 Tested-by:
-
Daniel Windloff authored
For each TCA table a query to determine if a result exists is made. It could have been some kind of performance optimization, but it results in an additional query for each table with records in place. Such optimizations should be done in the getTable method by using the existing query to count the total number of records of the table. Therefore, the query result (the total number of records of the table) has been used for a guard clause. Releases: master Resolves: #92071 Change-Id: Idc2026eaaa699ab358625d00670a5bc1e8ab341f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65410 Tested-by:
-
Daniel Windloff authored
Furthermore, there is no need to query the references for each record twice. So this has been dropped as well. Releases: master, 10.4 Resolves: #92049 Change-Id: Ia873baaad5ace7f0713ccba293eeaccf5b2a985b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65432 Tested-by:
-
Helmut Hummel authored
The patch for issue #91210 introduced a side effect that bookmarks to controllers which are not directly registered as backend modules do not show up again because the ModuleLoader->checkMod() call does not return an array anymore. Bookmarks to records of FormEngine / EditDocumentController are affected by this and are simply not rendered as bookmark toolbar items. The patch applies a hack to the ShortcutRepository to deal with this. We need a better module / controller access API substituting TBE_MODULES to deal with this properly. EditDocumentController does it's own access checks for records, so the patch shouldn't add security harm. Releases: master, 10.4 Resolves: #91368 Related: #91210 Change-Id: I0add57326b12182a1c11ee6bd09e61b0f1c204f8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64476 Tested-by:
-
- Aug 21, 2020
-
-
Eric Chavaillaz authored
Resolves: #92048 Release: master, 10.4 Change-Id: I5fa64c5559e53864eb36a0bea01e51cd3ebf8702 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65364 Tested-by:
Jörg Bösche <typo3@joergboesche.de> Tested-by:
-
Andreas Fernandez authored
The events dispatched by AjaxDataHandler are changed to be always named `typo3:datahandler:process`. This is done to ease registering event listeners as the executed action is part of the sent payload already. Since this feature is not documented and propagated yet, this is considered being not breaking. Resolves: #92028 Releases: master, 10.4 Change-Id: Ibe69d7297bbc6e17fd744ebf96c3f88f719e533d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65349 Tested-by:
Richard Haeser <richard@richardhaeser.com> Tested-by:
-
Daniel Windloff authored
Move table related query parts to getQueryBuilder: * Move the hook "getTable" to getQueryBuilder * Move query constraints from getTable to getQueryBuilder * Set field list as parameter to getQueryBuilder * Set limit, offset, addSorting as add. parameters to getQueryBuilder * Move code from prepareQueryBuilder to getQueryBuilder Related to the usage of getQueryBuilder: * Use getQueryBuilder to calculate if a table has any result. * Use getQueryBuilder to calculate the total number of hits. Move getSearchString to makeSearchString. Releases: master Resolves: #92065 Change-Id: Ic9dcdca3172b3229986c065e8aa0fd2f5ebb6078 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65402 Tested-by:
-
Kevin Ditscheid authored
This commit changes the return hint of TYPO3\CMS\Core\Domain\Repository\PageRepository::getRecordOverlay to mention that the function returns NULL instead of FALSE, if $OLmode is "hideNonTranslated" and no translation is found Resolves: #92052 Releases: master, 10.4 Change-Id: I5ee9504d234b230f80a6108ad53698770cc56f60 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65392 Tested-by:
-
Georg Ringer authored
The setting `detectDomainRecords` and its sub configuration `detectDomainRecords.target` must be created by using the TypoScriptService. Resolves: #91979 Releases: master, 10.4 Change-Id: Iaeaa97487be62b10364a9ac2f87430ee2b47bd94 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65285 Reviewed-by:
-
Christian Kuhn authored
The class seems to be unused for a while. Drop without substitution. Don't confuse this removal with class TYPO3\CMS\Backend\Tree\View\PageTreeView. Resolves: #92060 Releases: master Change-Id: Ic35f42bc3fe0cb6803482f29f8a205e0b14795d8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65397 Tested-by: Daniel Windloff Tested-by:
-
Benjamin Franzke authored
`import = require('…')` should only be used when the required module exports via the respective `export =` instruction. As MessageUtility exports only one named export (called `MessageUtility`), we should import via ES6 named import syntax. Note: Technically (in the generated source) this change makes no difference, as the named export was available as property of the AMD export-object, and therefore `import = ` worked. Therefore there are no changes to the generated files when executing: grunt build Resolves: #92064 Releases: master, 10.4 Change-Id: Ie2376890e23a6d233387ab5cc3914e9dc57a8015 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65404 Tested-by: -
Christian Kuhn authored
In extension 'recycler', the DeletedRecordsController is only used from within the RecyclerAjaxController. Controller calling other controllers this way is bad code smell. The patch merges the transform() method together with its helper methods into the RecyclerAjaxController and applies minor cleanups to the class along the way. Resolves: #92055 Releases: master Change-Id: I75f39375a55cca7f640836f8550204e4a5da3475 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65393 Tested-by:
-
Daniel Windloff authored
Remove the unnecessary wrapper method initCSV. Use addHeaderRowToCSV instead. Releases: master Resolves: #92063 Change-Id: I7d5b710cf174c172c0d327f6e8dd070654e6b4c6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65403 Tested-by:
-
Christian Kuhn authored
The patch fixes a couple of database restrictions to prevent the recycler from showing workspace related records in live workspace. Note there are further issues with the recycler in workspace context. Those need work on workspace record lifecycles first, and are not tackled with the patch. Resolves: #92056 Related: #21299 Releases: master, 10.4 Change-Id: Ib2d9a14231d01a861c731f4ce39b8f0cf5eddc73 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65394 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Achim Fritz <af@achimfritz.de> Tested-by:
-
Daniel Windloff authored
- Set translateTools without wrapper method - Remove the unnecessarily duplicate IconFactory Releases: master Resolves: #92061 Change-Id: I367a4bc1d324003fdb02b0ac98f4dd5f6cd02f1f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65399 Tested-by:
-
Markus Klein authored
Since #91354 the Core has security checks for valid and secure HTTP responses. Add additional configuration in the default .htaccess template to ensure those checks are green by default. Resolves: #91893 Releases: master, 10.4, 9.5 Change-Id: Ibcb7d9b9b5fde3b1a9054d0cbf51fda710cd8f0d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65350 Tested-by:
-
- Aug 19, 2020
-
-
Kevin Ditscheid authored
This commit hardens the extbase ImageService to not hard crash if $processedImage->getPublicUrl() returns a NULL value. Resolves: #92032 Releases: master, 10.4 Change-Id: I09ed122362b6202ee971a4e886490334a25f0502 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65353 Tested-by:
-
- Aug 18, 2020
-
-
Benni Mack authored
Make sure the cookie is removed after logout. Resolves: #90568 Releases: master, 10.4 Change-Id: I12b3c78b08e09f8e31411fabe2c09eb8b2d8e9ae Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63629 Tested-by:
-
Markus Klein authored
Using FE permalogin sets a cookie expire time once. While the session timestamp on the server side is updated continuously to keep a session alive. This led to the situation that an actually valid session was abandoned due to cookie expiry. The code is adjusted to always update an existing cookie if it is a non-session cookie. Resolves: #61074 Releases: master, 10.4 Change-Id: I3a0eb9888546e3906a572540b69795ae5ad2365e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65356 Tested-by:
-
Anja Leichsenring authored
Due to yet unknown side-effects the editExistingRecord of SiteModuleCest fails. As this needs depper investigation why the markup cannot be found anymore, the test gets disabled for now. Resolves: #92040 Releases: master, 10.4 Change-Id: I5e6f07a99ee4d9828fd3a3ab2328d99a7bc506c4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65361 Tested-by:
-
Benni Mack authored
The array key 'shared' already contains the full workspace record from $BE_USER->checkWorkspace(), so it is not needed to actually fetch the record (which previously always returned the workspace with ID 1). The change removes a superfluous call to fetch the actual sys_workspace database record. Resolves: #92002 Releases: master, 10.4 Change-Id: Ieca9f7ad12392721be0c573599b7a89bb04c3446 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65324 Tested-by:
mhuber20 <m.huber@itconsulting-ulm.de> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
Georg Ringer authored
This section was overlooked during deprecated code removal, but is removed now. Resolves: #91655 Releases: master Related: #87479 Related: #82110 Change-Id: I474487a5b80a991f9231131674d3d001863d0b46 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65315 Tested-by:
-
Georg Ringer authored
The LF constant must not be escaped to make it possible to save multiline values in the Install Tool. Resolves: #91151 Releases: master, 10.4 Change-Id: I211a921ea9994f217f4cdf37973f4d5348f810a6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64265 Tested-by:
-
Georg Ringer authored
Readonly relations to sys_file_reference records should still show the placeholder values which is filled by the meta data coming from sys_file_metadata. Resolves: #91966 Releases: master, 10.4 Change-Id: I88b299bc31fde18239ae0e1680e8d199e93b7b00 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65286 Tested-by:
-
Christian Kuhn authored
System extension 'version' has been merged into 'workspaces'. Releases: master, 10.4 Resolves: #92043 Change-Id: Icc87265b04d0033b02b2621ae21dfa47a82ceec3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65363 Tested-by:
-
Oliver Hader authored
Resolves: #92037 Releases: master, 10.4, 9.5 Change-Id: I1278496485ead10a46f82c1d681db1e48a0aac1d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65360 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
- Aug 17, 2020
-
-
Christian Kuhn authored
The workspace preview not only has the default view with the slider to show differences between live and workspace version. It additionally contains a full workspace module accessible through the 'List View' button. This view is notoriously broken and not fully thought through. For instance the 'Open version of page' button breaks out of the module to a different place of the backend, restricted to the main module frame, and there is no way back. For simple workspace stage editing, the default preview mode has the 'send to stage' and 'discards' buttons already, so there is little reason to have the backend module rendered in the preview in the first place. The patch drops the 'List View' from the preview. Next to a cleaner interface, this increases the performance of the preview since a full backend call plus various ajax calls are no longer executed. Resolves: #92031 Releases: master, 10.4 Change-Id: I33d21931e157aed2ef64cca3808cc4b6c28a8ef1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65352 Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
