Removes excessive top margin above Web>Page backend layout
cells. Brings gridCells equal heights and bottom spacing. Replaces
full white borders with adequate margins.

Change-Id: Ic5e7d3279c4facd969f171280d881b5620df4be7
Resolves: #55150
Related: #39971
Releases: 6.2
Reviewed-on: https://review.typo3.org/26936
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

Integrate the definition of packages that should be activated at
first installation and packages that are required for a minimal
usable system in the package manager.

There are now three possible properties in Classes/Package.php:

* protected - Package can not be uninstalled in em.
* partOfFactoryDefault - Package is activated at first installation.
* partOfMinimalUsableSystem - Package is activated if
  PackageStates.php is missing. extensionmanager and t3skin are
  affected here, if PackageStates.php is deleted, the install tool
  will create a new one with those packages activated, so the backend
  is "usable" enough to activate further packages.

Resolves: #53988
Releases: 6.2
Change-Id: I4f5d3f0a7d3bcf332d1e8e6c29156f93bae8029c
Reviewed-on: https://review.typo3.org/27226
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-by: Thomas Maroschik
Tested-by: Thomas Maroschik
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring

Brings button style to "Download" link with download icon.

Change-Id: I4edae8b861d9c6f98f156d8b538031dd8ca8f62c
Resolves: #55597
Releases: 6.2
Reviewed-on: https://review.typo3.org/27267
Reviewed-by: Marcin Sągol
Tested-by: Marcin Sągol
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

Brings an icon for download action. Icon is based on the
action-edit-upload sprite icon.

Change-Id: I4327c85c14dea3b69d8184259c5ac8729396d2e8
Resolves: #55594
Releases: 6.2
Reviewed-on: https://review.typo3.org/27266
Reviewed-by: Cedric Ziel
Tested-by: Cedric Ziel
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

Moves definitions to CSS/structure.
Also fixes right margin for a.t3-button.

Change-Id: Ib51e8b7e3c11e0a4cf474b6322aaeaed11c63b55
Resolves: #55588
Related: #55539
Releases: 6.2
Reviewed-on: https://review.typo3.org/27260
Reviewed-by: Marcin Sągol
Tested-by: Marcin Sągol
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

This change-set adds new functional tests for the DataHandler
to ensure the correct behaviour in the Live Workspace. The
difference to current functional tests is, that here a more
complete picture is checked in the database instead of only
particular ids and values.

The tests use a DataSet, which is basically only a CSV file
that hold the record values for required tables. These CSV
files can easily be modified by any spreadsheet application.
The "Scenario" DataSets are used to define the scenario each
test case is based on - the "Assertion" DataSets are used to
acutally assert that the correct processing was done in
the DataHandler.

Resolves: #54855
Releases: 6.2
Change-Id: I5d748cde04a70b9c158d09f9a0bd337ef809fd02
Reviewed-on: https://review.typo3.org/27188
Reviewed-by: Peter Kuehn
Tested-by: Peter Kuehn
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader

Before FAL a default upload folder has been retrived by setting
$GLOBALS['TYPO3_CONF_VARS']['BE']['fileadminDir'] . 'user_upload'.
With FAL this even could be placed on a remote system. Furthermore
we do not won't users to fiddle around with path like that anymore.

Each Storage already provides "getDefaultFolder" meant for uploads.
But still, if there are several storages, there is no way to figure
out which storage should be the default one for uploads, if it is
legacy code or just not configurable.

This patch introduces the concept of a default storage as a flag
which can be set within the storage record. The automatic creation
of /fileadmin/ - storage will have this flag already set.

Resolves: #55177
Releases: 6.2
Change-Id: I6684670c5acb023bc26596e9a55ca84bb5c41b40
Reviewed-on: https://review.typo3.org/26945
Reviewed-by: Frans Saris
Tested-by: Frans Saris
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack

Adds taller tree icons to EXT:t3skin and put them into a new
sprite category "treeline".

This allows to use these icons without breaks in line-height of 1.5em.

Icons are 30px tall due to:

- line height: 18px = 12px * 1.5em
- Padding top+bottom: 12px = 6px * 2

Change-Id: I8a295dbf55b6847e89250c9c221259386aa362e6
Resolves: #52599
Related: #52501
Related: #49592
Releases: 6.2
Reviewed-on: https://review.typo3.org/24474
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
Reviewed-by: Felix Kopp
Tested-by: Felix Kopp
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Allow the max items evaluation for checkboxes by setting the
accordant 'eval' property in the field configuration in TCA.

This makes it possible to have only e.g. 5 records that have a
checkbox set system-wide or PID-wide. If an editor
sets a another checkbox in record #6, it gets reverted
until another record was unchecked.

Parameters are "maximumRecordsChecked" and
"maximumRecordsCheckedInPid".

$tcaFieldConf = array(
'type' => 'check',
'eval' => 'maximumRecordsChecked',
'validation' => array(
 'maximumRecordsChecked' => 5
)
);

Change-Id: Ic33571fec15dcc9f83a61e2409256cce7dae8b12
Documentation: #55188
Resolves: #55187
Releases: 6.2
Reviewed-on: https://review.typo3.org/26946
Reviewed-by: Ingo Schmitt
Tested-by: Ingo Schmitt
Reviewed-by: Frans Saris
Tested-by: Frans Saris

The parameter $language in extbase's custom statement is not
used anywhere and does not make any sense in use with dbal.

Releases: 6.2
Resolves: #55580
Change-Id: I9c7edda24918b328da66872ef782a6d0e83b0fff
Reviewed-on: https://review.typo3.org/27258
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Reviewed-by: Stefano Kowalke
Tested-by: Stefano Kowalke
Reviewed-by: Stefan Froemken
Tested-by: Stefan Froemken
Reviewed-by: Felix Oertel
Tested-by: Felix Oertel

Currently the property mapper uses the classnames found
in the the class property annotations to find the right
TypeConverter. But for class aliases this breaks as the
alias is used and not the original classname.

There was already a getClassNameForAlias call but this was
to early.

This change moves the getClassNameForAlias() call from
doMapping() to findTypeConverter().

Releases: 6.2, 6.1
Resolves: #54289
Change-Id: Ie4ab3deb3c192290db62ea06826870d2fadba8a7
Reviewed-on: https://review.typo3.org/26578
Reviewed-by: Stefan Froemken
Tested-by: Stefan Froemken
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

Value "maxitems" => 1 must be added to field
`metadata` since it has a one-to-one relation.

Change-Id: Ie8771809b952e3b2aa441fcb222a6a3db301655e
Releases: 6.2
Resolves: #55411
Reviewed-on: https://review.typo3.org/27112
Reviewed-by: Wouter Wolters
Reviewed-by: Xavier Perseguers
Reviewed-by: Frans Saris
Reviewed-by: Stefan Froemken
Reviewed-by: Ingo Schmitt
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny

Separate the create new record label and the foreign table title
with a colon.

Resolves: #17955
Releases: 6.2
Change-Id: I0869f53e1e5ba0b49ded81e1605494fc2b44fdb0
Reviewed-on: https://review.typo3.org/23509
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny

Every time when an extension is registering an extbase
plugin (in ext_localconf.php), the call triggers some
additional TypoScript code, which is basically empty
and does some superfluous code.

The attached patch removes the code inside the
registration process in order to remove the memory
footprint and have a small impact on performance
when bootstrapping TYPO3.

On a frontend script (eID), this makes approx.
2% of the bootstrap process until TSFE kicks in.

Releases: 6.2
Resolves: #55569
Change-Id: I39b810d06be57f436a68afaa717d5ec214b8797b
Reviewed-on: https://review.typo3.org/27248
Reviewed-by: Felix Oertel
Tested-by: Felix Oertel

This changes styles the buttons to add a new irre item like
the button to add images to a content element.

This patch also unifies button styles.

Resolves: #55539, #53218
Releases: 6.2
Change-Id: Ib07e51cfc6b6675671e1c6a2afd7bb0ebe379e1e
Reviewed-on: https://review.typo3.org/27221
Reviewed-by: Stefan Froemken
Tested-by: Stefan Froemken
Reviewed-by: Marcin Sągol
Tested-by: Marcin Sągol
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack

Small CSS fix to overwrite general margin
of paragraph tags in page tree indicator bar.

Resolves: #55536
Releases: 6.2
Change-Id: I9a4766a7fbc22f6ab2506f8a12463f5695813205
Reviewed-on: https://review.typo3.org/27231
Reviewed-by: Stefan Froemken
Tested-by: Stefan Froemken
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind

With TYPO3 6.0, includeLibs for classes with
Namespaces / autoloader is not needed anymore.

The patch cleans up the TypoScript of CSS Styled
Content in order to use the new namings and
the superfluous call to includeLibs.

Releases: 6.2
Resolves: #55558
Change-Id: I94558a24479f220ce0fbebb54bb2f8479085c61c
Reviewed-on: https://review.typo3.org/27234
Reviewed-by: Christian Kuhn
Reviewed-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind

Resolves: #53564
Releases: 6.0, 6.1, 6.2
Change-Id: If7d69e4f87e368c1eef672cb68f1af92d6ae501b
Reviewed-on: https://review.typo3.org/25315
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind

A TypoScript condition like
"[globalString = GP:anEmptyGetPostVarKey = ]" returns a false
value instead of the expected true value.

Fixes: #45183
Releases: 4.5,6.0, 6.1, 6.2
Change-Id: I114b702f4b5ae5f68236874325e82974a8ba6107
Reviewed-on: https://review.typo3.org/21979
Tested-by: Philipp Gampe
Reviewed-by: Philipp Gampe
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind

The module menu and its view are instantiated
on every backend call, BE AJAX call etc although
it is only needed in the backend.php file where
it instantiates itself automatically anyways.

The patch removes the call in init.php and
in the TYPO3 Bootstrap as it is not needed
anymore.

Releases: 6.2
Resolves: #55565
Change-Id: I67b6fb54380485d35c070867abf67e3ed416f004
Reviewed-on: https://review.typo3.org/27242
Reviewed-by: Marcin Sągol
Tested-by: Marcin Sągol
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind

As discussed back in 2010, the value property of the TEXT content object
should have stdWrap functionality as well, if the HTML content object
is deprecated.

Today the 6.0 TSref already mentions stdWrap for value and
the HTML cObject has been removed with 6.0 as well.

This fix now finally adds the stdWrap.

Resolves: #54371
Releases: 6.2, 6.1, 6.0
Change-Id: I1b7068b3715bc9f8aa4608d5f746c16b70562f3b
Reviewed-on: https://review.typo3.org/26445
Reviewed-by: Benjamin Mack
Reviewed-by: Chris topher
Tested-by: Chris topher
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind

There were several issues with the implementation
of class alias handling. Most importantly the
early instance alias cache depended on TYPO3_MODE
which in turn triggered a full class cache
initialization when this cache was missing in one
context.

Additionally eval() calls needed to be used in
certain situations and the building of the cache
files introduced additional complexity.

With this change the cache for early instances
is completely removed and replaced by a simple
setAliasFoClassName() call.

Resolves: #55559
Releases: 6.2
Change-Id: I59958419f28a4ff1d6de4add94ee611b56070068
Reviewed-on: https://review.typo3.org/27236
Reviewed-by: Andreas Wolf
Tested-by: Andreas Wolf
Reviewed-by: Marcin Sągol
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

The Package Manager got pretty big due to the custom
dependency resolving algorithm of CMS. Further the
algorithm relied upon the presence of package objects
which might not be fully present yet during bootstrapping.

This patch extracts the dependency handling from the
Package Manager and adapts it to work only on the
package states configuration.

Resolves: #55404
Releases: 6.2
Change-Id: I00e7a3769378b48bd3f3c285ea2b3c6d824dd061
Reviewed-on: https://review.typo3.org/27101
Tested-by: Thomas Maroschik
Reviewed-by: Markus Klein
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind

This patch replaces most of around 1600 occurrences of
intval() and every (integer) in the whole core.
Additionally it changes GeneralUtility::intExplode to use references
and typecasting as well.
Some occurrences of strstr() together with intval() have been replaced
with strpos() as well.
And some superfluous intval calls have been removed or reduced
to a single one i.e. for protected variables or before loops.
Patch updated after Core CGL decision from 30.01.2014

Resolves: #54265
Releases: 6.2
Change-Id: Iba57ffad1f4233ffa1a9f7d3ca5bfe9d2b53f1e8
Reviewed-on: https://review.typo3.org/26740
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind

The category fields are defined dynamically and added to the
extension table configuration. Since the database definitions
are created before modifying this configuration, the category
fields are not available in Functional Tests.

Resolves: #55560
Releases: 6.2
Change-Id: Ie59e544309184d475428bc298f126c2776b4b5e7
Reviewed-on: https://review.typo3.org/27238
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Christian Kuhn
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader

Replace the existing RequireJS code
with the latest version, which is backwards-
compatible and fixes some requireJS bugs.
See http://requirejs.org/docs/download.html#releasenotes

Releases: 6.2
Resolves: #55543
Change-Id: I8ef64858b762a93db0c032509f100235424c2d9a
Reviewed-on: https://review.typo3.org/27224
Reviewed-by: Andreas Wolf
Tested-by: Andreas Wolf
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

LocalConfiguration setting EXT/requiredExt was obsoleted with the
new package manger, the setting is removed by the PackageStates
migration code in install tool already.

* Remove further mentions of this setting
* Adapt method in ExtensionManagementUtility
* Streamline and remove some related units tests
* Move deletion of requiredExt setting to silent update
* Adapt an em view helper to new API

Change-Id: Ie9593c9791893bb4fb0714032efbfc06808b0a35
Resolves: #55555
Releases: 6.2
Reviewed-on: https://review.typo3.org/27232
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Daniel Siepmann
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

The options of cacheConfigurations were not reset when setting the
cacheConfigurations to NullBackend in the Install tool.

Resolves: #55527
Releases: 6.2
Change-Id: I25586f16f001fdddbd2d43b2df9110f65c4ad1b4
Reviewed-on: https://review.typo3.org/27214
Reviewed-by: Ernesto Baschny
Reviewed-by: Peter Kuehn
Tested-by: Peter Kuehn
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

When storing a cache in page the array variable "cache_data" gets
serialized and when being retrieved from cache unserialized.

This is not necessary as de-/serialization is already performed by
the variable caching backend.

Change-Id: I9cf817123947af3f4076dabdce3c569bf41b477c
Resolves: #55493
Releases: 6.2
Reviewed-on: https://review.typo3.org/27179
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Andreas Wolf
Tested-by: Andreas Wolf

Methods in this class are called a lot and are in need of some cleanup.
* return early
* reduce method and function calls
* update doc comments
* added tests with data provider for Method getCN

Change-Id: I5dcab647fc3da078b5f29beb57fecbf7c98bcaa5
Resolves: #55122
Releases: 6.2
Reviewed-on: https://review.typo3.org/27019
Reviewed-by: Andreas Wolf
Tested-by: Andreas Wolf

If there is no valid configuration or there are no sys_note on
the page at all, the Bootstrap doesn't trigger the extbase
rendering. The patch reduces the load time of the page-, info-
and list-module.

Resolves: #55375
Releases: 6.2
Change-Id: Id099c26c272abf5606ccec169bd8eb7487b51349
Reviewed-on: https://review.typo3.org/27081
Reviewed-by: Helmut Hummel
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Remove a duplicate mocking in test fileIndexStatusIsTrueIfUidIsSet()
and setUp() triggered as side effect after patch 71eb69ed.

Resolves: #53691
Releases: 6.2
Change-Id: I8ac96d9157bf946bba3c9561369f3553d459f275
Reviewed-on: https://review.typo3.org/27223
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

Since the backend restructuring for TYPO3 4.2
the alt_shortcut.php file is not used any more.

We can now safely remove it.

Resolves: #55546
Releases: 6.2
Change-Id: I0ee0108c6238a28ad7b2ad0597f421a30eaf118c
Reviewed-on: https://review.typo3.org/27225
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

This also fixes “IRRE - drag and drop sorting of items
not possible in Internet Explorer”.

* Added jQuery-ui and jQuery to requirejs.
* Reworked the IRRE-Header HTML and CSS.
* Sortable is done by jQuery-Ui.

Resolves: #51768
Releases: 6.2
Change-Id: Idd121617f2cd5215604747cd0f18285a73dfed49
Reviewed-on: https://review.typo3.org/27164
Reviewed-by: Frans Saris
Tested-by: Frans Saris
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack

Due to all the refactorings all file-objects are created centralized.
In addition it is not possible anymore to create a file object without
an existing index record. Therefore all the fallback-logic for lazy
loading the index record can be removed from the file object.

In addition the unit tests for these parts of the file object have been
removed, too.

Releases: 6.2
Resolves: #53691
Change-Id: I0a01c12e2caaf8554a5b606b7a85d50b44e0e97c
Reviewed-on: https://review.typo3.org/27193
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack

This patch adds some tests for a simple import and export
scenario for pages and a tt_content element.

Resolves: #55100
Releases: 6.2
Change-Id: Ia4b9a8990c7b757d25f18500def6ddd060426c2f
Reviewed-on: https://review.typo3.org/26907
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

Locker has wrong LockState in semaphore mode, if the lock
could not be acquired.

Resolves: #52048
Releases: 6.2, 6.1, 6.0
Change-Id: Ifdc2f5d9b2a3c35a0ebef54817a56344f27ab15d
Reviewed-on: https://review.typo3.org/23854
Reviewed-by: Stefan Neufeind
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

If a import file has extension dependencies the user was
redirected to the old em with CMD requestInstallExtensions.
Since the new extensionmanager hasn't this functionality,
remove this magic and show the message only.

Resolves: #43709
Releases: 6.2, 6.1, 6.0
Change-Id: I161d4a24135f0d011177f2d4006e4713c71a8fcb
Reviewed-on: https://review.typo3.org/27100
Reviewed-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

The file input fields in the ElementBrowser have the attribute
multiple so you can select multiple files. But as the name
is no array it only uploads 1 file.

This patch changes the name attribute of the file input fields
to an array and shows the flashmessages when an error occurred
during upload.

Resolves: #55497
Releases: 6.2
Change-Id: I1315e35e2ef4cfa8175f962c42f32a5a33ffc16e
Reviewed-on: https://review.typo3.org/27182
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

If you run the test from the BE module of PHPUnit together with
all/other tests it fails. This is due to the fact that the
tests checks more than it actually should.

In particular the static $enumConstants array may already contain
information from other classes, therefore the test only has to
check for existane of information for the tested class.

The patch also corrects the missing \ in the namespace part
between Type and Fixture.

Releases: 6.2
Resolves: #55270
Change-Id: I1ea6546af8013f6c9075525c5bc6f3df579ccfcc
Reviewed-on: https://review.typo3.org/27020
Reviewed-by: Stefano Kowalke
Tested-by: Stefano Kowalke
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn