- Jun 26, 2024
-
-
Stefan Bürk authored
With PHP 8.4 marking method parameter implicitly nullable is deprecated and will emit a `E_DEPRECATED` warning. One recommended way to resolve this, is making it explicitly nullable using the `?` nullable operator or adding a null tyype to an union type definition. [1] This prepares the way towards PHP 8.4 compatibility. [1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated Resolves: #104209 Releases: main Change-Id: Iea94673b0d04d80f7b71f1cc9e936ccdbd7784e9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84914 Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
core-ci <typo3@b13.com> Reviewed-by:
-
Stefan Bürk authored
With PHP 8.4 marking method parameter implicitly nullable is deprecated and will emit a `E_DEPRECATED` warning. One recommended way to resolve this, is making it explicitly nullable using the `?` nullable operator or adding a null tyype to an union type definition. [1] This prepares the way towards PHP 8.4 compatibility. [1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated Resolves: #104211 Releases: main, 12.4, 11.5 Change-Id: Ic086fc77872c54f763d774f4118517658d8d52e3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84918 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
Stefan Bürk authored
Since recently upgraded PHP-version the 10mb big xml unit test failes. The `\LIBXML_PARSEHUGE` xml option could be used to mitigate this case but would not explain the change from PHP yet. Thus the decision has been made to disable the failing data set as a temporary solution to avoid disturbance for core contribution until this issue has been investigated and reported to PHP itself. Resolves: #104218 Releases: main, 12.4, 11.5 Change-Id: Ifef4f18818e661312b9e56e013bb8f479146b806 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84926 Tested-by:
Markus Hofmann <typo3@calien.de> Reviewed-by:
-
Oliver Bartsch authored
For additional context does the PolicyMutatedEvent now provide the current PSR-7 Request. Resolves: #104141 Releases: main, 12.4 Change-Id: I1817366e77f20f6c43eef0ee209fbb419e7237e2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84913 Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
-
Christian Kuhn authored
typo3/testing-framework v8 has been branched, dev-main modernizes the codebase and removes some deprecated details. > composer u typo3/testing-framework Resolves: #104213 Releases: main Change-Id: Iaf5770905c8c9cad1d3d15dbc3c6ad1559334f3e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84882 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
-
- Jun 25, 2024
-
-
Stefan Bürk authored
With PHP 8.4 marking method parameter implicitly nullable is deprecated and will emit a `E_DEPRECATED` warning. One recommended way to resolve this, is making it explicitly nullable using the `?` nullable operator. [1] This prepares the way towards PHP 8.4 compatibility. [1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated Resolves: #104206 Releases: main, 12.4, 11.5 Change-Id: I0d82e0474143f63870f772002de52d26c6c960fd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84906 Reviewed-by:
Garvin Hicking <gh@faktor-e.de> Reviewed-by:
-
Stefan Bürk authored
With PHP 8.4 marking method parameter implicitly nullable is deprecated and will emit a `E_DEPRECATED` warning. One recommended way to resolve this, is making it explicitly nullable using the `?` nullable operator. [1] This prepares the way towards PHP 8.4 compatibility. [1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated Resolves: #104205 Releases: main, 12.4, 11.5 Change-Id: Iaca12350ce8b28943fd5ce8181d42b91feb471e3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84903 Reviewed-by:
-
Andreas Kienast authored
All FormEngine field types shipped in TYPO3 core use a CSS class `hasDefaultValue` that was never defined or referenced since its introduction in TYPO3 4.7 with #33235. This commit removes the remaining traces of said CSS class. Resolves: #104207 Related: #33235 Releases: main, 12.4 Change-Id: I10d70fb61f79a0c0974a6d101efb3b4cb5463060 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84911 Tested-by:
Andreas Nedbal <andy@pixelde.su> Tested-by:
Andreas Kienast <a.fernandez@scripting-base.de> Reviewed-by:
-
Christian Reifenscheid authored
The AbstractModule class is located within the 'ModuleApi' folder, so the namespace must be \TYPO3\CMS\Adminpanel\ModuleApi\AbstractModule. This patch fixes the issue. Releases: main, 12.4 Resolves: #104204 Change-Id: I28dc1777fe8900665e8a3d43a8655674dbb82185 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84901 Reviewed-by:
-
Stefan Bürk authored
With PHP 8.4 marking method parameter implicitly nullable is deprecated and will emit a `E_DEPRECATED` warning. One recommended way to resolve this, is making it explicitly nullable using the `?` nullable operator. [1] In case of union type the null is added as additional type. This prepares the way towards PHP 8.4 compatibility. [1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated Resolves: #104203 Releases: main, 12.4, 11.5 Change-Id: I1e264d242e53e4d258abe82831e612ee43234d0d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84898 Reviewed-by:
-
Tim Weisenberger authored
This patch adds missing translation string for the validation error which is returned when a string is not recognized as date in a specific format. Resolves: #94192 Releases: main Change-Id: Ia205d323b6ce65279823c8a7ea6880a068ee98b1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81933 Tested-by:
Torben Hansen <derhansen@gmail.com> Reviewed-by:
-
Stefan Bürk authored
This change modifies the `Build/Scripts/runTests.sh` dispatcher script to add new database version. Added versions: * MySQL 8.4 * MariaDB 11.2 * MariaDB 11.3 * MariaDB 11.4 Note that for TYPO3 v12 and v11 also missing versions up to these are added now. This is not a official supported version statement. [1] https://endoflife.date/mariadb [2] https://endoflife.date/mysql [3] https://endoflife.date/postgresql Resolves: #104200 Releases: main, 12.4, 11.5 Change-Id: I338a7f0973a46fb8bc6a582a5c478c4715a8000e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84893 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
Stefan Bürk authored
This change modifies the `Build/Script/runTests.sh` command dispatcher to allow passing composer options to the `composer install` subcommand, for example Build/Scripts/runTests.sh -s composerInstall \ -- --prefer-source Note that this is already possible using the generic `-s composer` dispatcher but would resolve some user confusion. This is useful to install dependencies as git checkouts, for example when working on packages like `typo3/testing-framework` changes. Albeit the need to remove the vendor folder first is needed in case of the example. Resolves: #104186 Releases: main, 12.4, 11.5 Change-Id: Id07c90f3b6902ad8866249563eceeb2dafbc919b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84870 Tested-by: -
Oliver Bartsch authored
The ext:form EmailFinisher allows to retreive recipients via different ways. Next to the default yaml configuration is it also possible to set recipients via flexform or via TypoScript. In such cases there might be additional whitespaces added, which would lead to the function not returning the recipients address since GU:validEmail() would fail. Since recipients are mandatory, this leads to an exception in the finisher. To prevent such "false positives", the address is now trimmed before being checked. Resolves: #104198 Releases: main, 12.4 Change-Id: Ia66cc73d477507aee6c954995d6afd6a771e6354 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84889 Reviewed-by:
-
Stefan Bürk authored
This change adds a `@` silence operator to the usage of `preg_match()` in the `RedirectService`. This prevents errors in case of manually-entered malformed regexp patterns and follows existing similar usages of the service. Additionally, a todo comment is added to evaluate future early pattern evaluation in record creation/editing so that a proper response to invalid patterns can be emitted. Resolves: #102176 Releases: main, 12.4, 11.5 Change-Id: I88687c128986ae6fa1e2b7a3a4bf414ee8f952f0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84872 Reviewed-by:
-
Stefan Bürk authored
With PHP 8.4 marking method parameter implicitly nullable is deprecated and will emit a `E_DEPRECATED` warning. One recommended way to resolve this, is making it explicitly nullable using the `?` nullable operator. [1] This prepares the way towards PHP 8.4 compatibility. [1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated Resolves: #104196 Releases: main, 12.4, 11.5 Change-Id: Iec724407eed8edefed48c2e032b2105b42cabc94 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84883 Tested-by:
Fabien Udriot <fudriot@omic.ch> Tested-by:
-
Stefan Bürk authored
With PHP 8.4 marking method parameter implicitly nullable is deprecated and will emit a `E_DEPRECATED` warning. One recommended way to resolve this, is making it explicitly nullable using the `?` nullable operator. [1] This prepares the way towards PHP 8.4 compatibility. [1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated Resolves: #104197 Releases: main, 12.4, 11.5 Change-Id: Ie2fbd6369e6c59c275939c42daa8c45c22334e48 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84886 Tested-by:
-
- Jun 24, 2024
-
-
Marcin Sągol authored
The `typo3-backend-icon` component code contains a duplicated code fragment. This patch removes one occurrence. Resolves: #104199 Releases: main, 12.4 Change-Id: I0530f89f646c5c2fda8a170f3792a28a2c04243d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84890 Tested-by:
-
Oliver Bartsch authored
Since #104172, the `columnsOnly` configuration has to be provided in a new format, using the table name as key and an array of fields as parameter value. To prevent deprecation log entries are the recordlist and filelist JS components adjusted to use the new format. Resolves: #104172 Related: #104108 Releases: main Change-Id: I87a03179bac3eeba40f6a1c1d6e9ad5d88f055b4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84816 Reviewed-by:
-
Stefan Bürk authored
With PHP 8.4 marking method parameter implicitly nullable is deprecated and will emit a `E_DEPRECATED` warning. One recommended way to resolve this, is making it explicitly nullable using the `?` nullable operator. [1] This prepares the way towards PHP 8.4 compatibility and unifies towards using `?` nullable operator over union null type when possible. [1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated Resolves: #104185 Releases: main, 12.4, 11.5 Change-Id: I12462595d622efa1bbe2a479f159d68a984bda23 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84867 Reviewed-by:
-
Andreas Kienast authored
Resolves: #104161 Resolves: #104193 Related: #103767 Releases: main Change-Id: I8223ae8aef6bb7b035d184e454bf2f781374788b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84881 Tested-by:
-
Stefan Bürk authored
With PHP 8.4 marking method parameter implicitly nullable is deprecated and will emit a `E_DEPRECATED` warning. One recommended way to resolve this, is making it explicitly nullable using the `?` nullable operator. [1] This prepares the way towards PHP 8.4 compatibility. [1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated Resolves: #104187 Releases: main, 12.4 Change-Id: I80b1494413016658e6c5ed88485cce887178fdbf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84873 Reviewed-by:
-
Stefan Bürk authored
With PHP 8.4 marking method parameter implicitly nullable is deprecated and will emit a `E_DEPRECATED` warning. One recommended way to resolve this, is making it explicitly nullable using the `?` nullable operator. [1] This prepares the way towards PHP 8.4 compatibility. [1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated Resolves: #104188 Releases: main, 12.4 Change-Id: I3a3273b9176fce9b0e64a084654acf17c8738da4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84875 Reviewed-by:
-
Jasmina Ließmann authored
Language keys used in toolbar context are now in their corresponding extensions. The following language keys were unused and have been removed: - toolbarItems.shortcut - toolbarItems.shortcuts - toolbarItems.shortcutsGroup - toolbarItems.shortcutsEdit - toolbarItems.shortcutsDelete - toolbarItems.bookmark - toolbarItems.bookmarksGroup - toolbarItems.collapsePageTree - systemInformation.header Resolves: #104128 Releases: main Change-Id: Ia8aed4da14c625df324c4741bdcaa5e5cd124e9e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84734 Reviewed-by:
-
Andreas Kienast authored
This commit updates TypeScript to 5.5, along with its related friends. Executed commands: npm install --save-dev \ @typescript-eslint/eslint-plugin@^7.13.1 \ @typescript-eslint/parser@^7.13.1 \ @typescript-eslint/typescript-estree@^7.13.1 \ typescript@^5.5.2 npm run build Resolves: #104189 Releases: main, 12.4 Change-Id: Ic2b66c65485845ae62371228f6f8b62c8a320172 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84877 Reviewed-by: -
Oliver Bartsch authored
Since #96515, is's possible to configure aliases for backend modules. Those are handled by the UriBuilder to allow using those aliases for building links to the corresponding module. Using the ActionDispatcher JS component for building module links via the "TYPO3.ModuleMenu.showModule" action, it's now also possible to use corresponding aliases. Therefore, the BackendController now adds the module aliases to the module information JS array and the module JS component properly checks for those aliases when resolving a given module name / identifier. Resolves: #104165 Related: #96515 Releases: main, 12.4 Change-Id: Ia8372a503f4973d81deb285a9945fa13ade24dd3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84804 Reviewed-by:
-
Benjamin Kott authored
Move lib.parseFunc to EXT:frontend in order to allow fluid_styled_content to become optional at some point. Resolves: #103485 Releases: main Change-Id: I8c60c15cea86d5fe784b213a5a2f4ae87ba6a06a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83321 Tested-by:
Benjamin Kott <benjamin.kott@outlook.com> Reviewed-by:
-
Stefan Bürk authored
With PHP 8.4 marking method parameter implicitly nullable is depreacted and will emit a `E_DEPRECATED` warning. One recommended way to resolve this, is making it explicitly nullable using the `?` nullable operator. [1] This prepares the way towards PHP 8.4 compatibility. [1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated Resolves: #104184 Releases: main, 12.4, 11.5 Change-Id: I1e1a60a36ae2b5244bbd8c3cf963f2165077dbad Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84864 Tested-by:
-
- Jun 23, 2024
-
-
Stefan Bürk authored
With PHP 8.4 marking method parameter implicitly nullable is depreacted and will emit a `E_DEPRECATED` warning. One recommended way to resolve this, is making it explicitly nullable using the `?` nullable operator. [1] In cases, where are implicitly nullable parameter exists before not-nullable parameters in a method or constructor, making it explicitly nullable will emit a Optional parameter <paramname> declared before required parameter <paramname> is implicitly treated as a required parameter since PHP 8.0 [2]. This change adds the `?` nullable operator [1] and removes the null default value when one or more non-optional argument follows [2] to mitigate both issues. Note that the second case is a edge case in this change. This prepares the way towards PHP 8.4 compatibility and unifies towards using `?` nullable operator over union null type when possible. [1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated [2] https://php.watch/versions/8.0/deprecate-required-param-after-optional Resolves: #104182 Releases: main, 12.4, 11.5 Change-Id: I68362a89458117eca4f0488c67a0b9ed17e7b929 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84857 Reviewed-by:
-
Oliver Bartsch authored
Next to renaming the module identifier of the EXT:indexed_search backend module is the path changed analogous to the forms and workspaces modules. Resolves: #104173 Releases: main Change-Id: Iea86aa73db93c9ef40ed5068ffff6b2c0c46d0f9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84817 Tested-by:
-
- Jun 22, 2024
-
-
Lina Wolf authored
Renames the title and headline on startpage to "TYPO3 Core Changelog" for improved SEO results and less confusion with readers. Resolves: #104181 Releases: main Change-Id: I8d9079d2f97774044bb988d37bd4275703a19be2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84856 Tested-by:
Stefan Froemken <froemken@gmail.com> Reviewed-by:
Lina Wolf <112@linawolf.de> Tested-by:
-
- Jun 21, 2024
-
-
Stefan Bürk authored
This change streamlines the `SchemaMigrator`, mainly moving code from the `parseCreateTableStatements()` method into dedicated methods. Divide and conquer. Acts as preparation for better schema migration and side effecet free test refactoring. Resolves: #104180 Releases: main Change-Id: I150ee9d83836c8e079c94682c0179f87972f2c7d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84827 Reviewed-by:
-
Sybille Peters authored
In some cases, it is helpful to have more context when editing records from the list of broken links. Previously, only the field which contains the broken link was opened in the edit form. A new button is introduced, opening the edit form with the full record. Resolves: #103493 Releases: main Change-Id: Ia8800c875812ebe780834b10eeacad4e08bc4acd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83614 Tested-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Reviewed-by:
-
Benjamin Kott authored
Using the forced primary link colors in dark mode on dark backgrounds generates insufficient contrast. In addition, we let the general module link handler handle the switch to the module. Resolves: #104175 Related: #104129 Releases: main Change-Id: I4ead28801d66ffee2ffcb13766be115c25601b36 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84821 Tested-by:
-
Garvin Hicking authored
Internally, all allowedAspectRatios will replace a "." character with "_" to prevent problems with Fluid variable key access. The lead to a situation that the backend was unable to reference the current selectedRatio, because the comparison was not performed on the "fixed" key name. This patch now uses a central "fix" method Ratio::prepareAspectRatioId in both the value object preparation as well as the configuration instantiation. The EXT:styleguide imageManipulation element 'crop_3' has been enhanced to utilize such an allowedAspectRatio for easier re- production. This workaround should be addressed as a breaking change in TYPO3v14, a note has been added. Resolves: #103047 Releases: main, 12.4 Change-Id: I8999b5d54627cda7044662ca5da17f4886a700e8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84718 Reviewed-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Tested-by:
-
Christian Kuhn authored
Not globally setting backupGlobals=true speeds up unit tests quite significantly. We can do this with deprecated unit tests without further issues already. Resolves: #104177 Releases: main Change-Id: I4566b5113400563254041a35819ab34efa642313 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84831 Tested-by:
-
Georg Ringer authored
The view "List of indexed pages" lists all indexed pages with the page arguments used during indexing. To avoid errors in rendering those, the viewhelper `f:format.json` is used. Resolves: #99125 Releases: main, 12.4 Change-Id: I91038cef9c76d884c2c484925ecef4a70070e153 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84812 Tested-by:
-
Anja Leichsenring authored
The functional test setup allows for easy access to registered services via `$this->get` and will not consider any other possible treatments to classes like e.g. xclassing when running tests. Thus, the usage of `$this->get` for services and otherwise just `new` is preferred over GeneralUtility::makeInstance(). Resolves: #104174 Related: #103902 Releases: main Change-Id: I8dc439b73dbc83ea7c242d44009199b16a96d356 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84818 Tested-by:
-
Peter Kraume authored
Using constants in the LinkHandler TSConfig does not work in the redirects module. Resolves: #103205 Releases: main, 12.4, 11.5 Change-Id: I29dda248c5e80e077d53c8ecead9fb29fd041f76 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83140 Reviewed-by:
Jörg Bösche <typo3@joergboesche.de> Tested-by:
-
Sybille Peters authored
The class EditableRestriction is used in EXT:linkvalidator to apply permission restrictions to database queries for current (non-admin) BE user. In case of table sys_file_reference, the value for $GLOBALS['TCA'][$table]['ctrl']['type'] might be "uid_local:type". In that case, the class EditableRestriction tried to access the TCA configuration for this field via $GLOBALS['TCA']['sys_file_reference'] ['columns']['uid_local:type']['config'] when in fact this will be empty (and the type refers to the table sys_file). We now check if the resulting array is empty and skip the check if that is the case. Resolves: #103559 Related: #83835 Releases: main, 12.4, 11.5 Change-Id: Idbe653ef9f1c21c077fcb79c03212e606cc71830 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83698 Tested-by:
-
