- Jul 12, 2022
-
-
Shehfinaz Kadavil authored
The existing condition checks if opcache_invalidate and opcache_reset are disabled, the new condition also checks if the function opcache_invalidate exists. Resolves: #97826 Releases: main, 11.5 Change-Id: Ibb201946b358a592f3c5b264646d100867e5e385 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75135 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
-
Daniel authored
Like the surrounding $conf['max'], this array index access should also be secured. Releases: main, 11.5 Resolves: #97908 Change-Id: I36ad5cf3d9eac5655e8721c8913bed43ab26377f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75134 Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
-
Andreas Fernandez authored
flatpickr always defaults to 12:00 if no other value is given, being quite inconvenient. The options `defaultHour` and `defaultMinute` are now provided to set the current time when opening flatpickr on an empty input field. Resolves: #97798 Releases: main, 11.5 Change-Id: Ic222c2ff0e3bf111c498c16dd27ecdc703909342 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75125 Tested-by:
-
Oliver Hader authored
Change-Id: I4b0d5e16384fdc6313848f6ab18bd98ce83cee91 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75121 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
Oliver Hader authored
Change-Id: I09299dd3a23c9492b4e8be5b57bdab7ac09bb773 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75120 Tested-by:
-
Nikita Hovratov authored
This patch reverts #91148 and #97897. This change had some side effects in FlexForm value displaying outside the intended diff-view. Resolves: #97904 Related: #91148 Related: #97897 Releases: main, 11.5 Change-Id: I6d5af76dea80b457de5a690e3065ccb700b2a507 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75113 Tested-by:
Nikita Hovratov <nikita.h@live.de> Reviewed-by:
-
Ralf Zimmermann authored
A new `FormRequestHandler` has been introduced as entry point which takes care of creating and rendering the actual `FormRuntime`. Independent of the current application dispatcher (either the default `FormFrontendController`, any custom Extbase controller or a TypoScript `FLUIDTEMPLATE` cObject) any processing will end up here. To ensure proper caching, it is important to separate the two main actions `render` and `perform`, which unfortunately cannot be resolved easily, especially when using custom Extbase controller actions. The term uncached refers to using cObject `USER_INT` instead of `USER`. More details about the process flow are described in `\TYPO3\CMS\Form\Core\FormRequestHandler`, introduced by this change. Resolves: #93887 Resolves: #92406 Releases: main, 11.5, 10.4 Change-Id: I0b98d39f04b6c70ea370200c53316b381019dd2a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75013 Tested-by:
waldhacker <hello@waldhacker.dev> Tested-by:
Björn Jacob <bjoern.jacob@tritum.de> Tested-by:
timobert <tobert@w-commerce.de> Tested-by:
-
Benni Mack authored
This is a precursor for several language-related Extbase bugfixes, allowing to hand over a custom LanguageAspect into PageRepository->getRecordOverlay() instead of the legacy naming conventions. Resolves: #97903 Releases: main, 11.5 Change-Id: I06f6e889bc0e9f052a79fc8f719b090bface0f77 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75114 Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
Frank Naegler authored
Since TYPO3 version 10.4, the custom page type is not restricted to any range of numbers. This limitation no longer exists, and any number is allowed. The ElementBrowserPageTreeView just now also respect this and allows to link to other any doktype beside: - PageRepository::DOKTYPE_RECYCLER - PageRepository::DOKTYPE_SYSFOLDER Resolves: #97626 Releases: main, 11.5, 10.4 Change-Id: Iffc3f705f74cc7516464fdb00adb456141657948 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75132 Tested-by:
-
Sybille Peters authored
Add the following information to impexp documentation: - export functionality is restricted to admin users and users for which the new User TSconfig option options.impexp.enableExportForNonAdminUser has been set - export functionality poses security risk as explained in patch https://review.typo3.org/c/Packages/TYPO3.CMS/+/74902 - the same restrictions apply to the import functionality (which is not new but has not been documented) Resolves: #97899 Releases: main, 11.5, 10.4 Change-Id: Icb16dc97505a3bbe671357555bb786705121cb67 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75070 Tested-by:
-
Oliver Bartsch authored
The rollback link for a single field change is now displayed again in the rollback view of the history module by using the correct variable in the template. Additionally, an unintended change in #91148 is resolved, which would also display the rollback link in the normal history list view. Resolves: #97901 Releases: main, 11.5 Change-Id: I2606d0585a5f1d196adab5f83340ff3033dced1c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75071 Tested-by:
-
- Jul 11, 2022
-
-
Oliver Bartsch authored
A couple of debug information, e.g. the field- and tablenames in FormEngine, are displayed depending on the user status and the debug settings. To simplify the codebase, this condition is now centralized in BackendUserAuthentication. Resolves: #97894 Releases: main, 11.5 Change-Id: I5173c48180fbf96f7408c008eeb3c71c25686d0d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75069 Tested-by:
-
Oliver Bartsch authored
Since #91148, EXT:backend and EXT:workspaces depend on the "lolli42/finediff" package, which is a fork of the archived "cogpowered/finediff" package. This dependency is now declared in the corresponding composer manifests. Resolves: #97897 Related: #91148 Releases: main, 11.5 Change-Id: Ia6c53bcee4173a1f7598581c30825ee162126c9d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75107 Tested-by:
-
Francois Suter authored
The LogManager tries to access $GLOBALS['TYPO3_CONF_VARS']['LOG'] without considering that it could be undefined Releases: main, 11.5 Resolves: #97888 Change-Id: I7ac2435e548e2d241fe223686595a42927ae1a60 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75068 Tested-by:
-
- Jul 10, 2022
-
-
linawolf authored
The outdated links in EXT:install are improved in https://forge.typo3.org/issues/97885 Releases: main, 11.5 Resolves: #97886 Change-Id: I25979df8f9f322461ffc6d03ab9030240c2e0e8a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75067 Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
-
linawolf authored
Releases: main, 11.5, 10.4 Resolves: #97885 Change-Id: Ib274d3d85f1311f100afe8e12167ebc6eaab21db Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75065 Tested-by:
-
- Jul 09, 2022
-
-
Andreas Fernandez authored
The confirmation dialog when FormEngine requests an update never came up in FlexForms as the array key used in `TYPO3\CMS\Backend\Form\Behavior\ReloadOnFieldChange->toArray()` didn't match the key in the `typo3-backend-form-reload` handler in FormEngine JavaScript, which is solved in this commit. Resolves: #97804 Related: #91787 Releases: main, 11.5 Change-Id: I1b95e836408a579d1b3e075f7614d7907bf94a37 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75088 Tested-by:
-
Ralf Zimmermann authored
In preparation for patchset https://review.typo3.org/c/Packages/TYPO3.CMS/+/70460/, functional tests are introduced to test the caching behavior of EXT:form. Resolves: #97049 Related: #93887 Releases: main, 11.5 Change-Id: Ief1c8d90371d6003512f88a064c2d82e51502590 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75082 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
Stefan Bürk authored
This patch raises egulias/email-validator to min version of 3.2.1, which incorporates latest changes. This also contains a fix to avoid the usage of PHP8.2 deprecated methods, namely `utf8_encode()` and `utf8_decode()`. Used commands: > composer req egulias/email-validator:"^3.2.1" > composer req egulias/email-validator:"^3.2.1" \ -d typo3/sysext/core --no-update Resolves: #97879 Releases: main, 11.5 Change-Id: Ia985dd3171ec988201022052d036b00e765c2654 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75078 Tested-by: -
Larry Garfield authored
This patch addresses most "undefined property" PHPStan messages. Used command: > Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #97596 Releases: main, 11.5 Change-Id: I8c599166fa1747cc34573a035598eaaadbf680cc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75076 Tested-by:
-
- Jul 08, 2022
-
-
dsteinborn authored
"msclkid" is the Click ID parameter of Microsoft / Bing which should be excluded from cHash generation. Resolves: #97870 Releases: main, 11.5, 10.4 Change-Id: I9c625e559cb2c7cf031466730ea4eab2e376f9ff Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75063 Tested-by:
-
Uwe Trotzek authored
This change transforms the processed record of FlexForms into a human-readable format. This is especially useful when comparing changes in the history module or the workspaces diff view. The diff needs to be formatted with line breaks and tabs as the output is passed through "htmlspecialchars" before it will be displayed. The white-space css setting needs to be changed to "pre-wrap", because this is the only setting where line breaks and tabs are kept and the text will still be word-wrapped. The old view is used as a fallback, if no record is available (import preview). Resolves: #91148 Releases: main, 11.5 Change-Id: Iab1dfb59f98dc712b8984a8087525634b5ec4ebd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75075 Tested-by:
-
Mathias Brodala authored
The Guzzle handler stack allows for pushing handlers/middlewares with a name which simplifies debugging. A possibly defined handler name is now pushed onto the stack as well. Resolves: #97873 Releases: main, 11.5 Change-Id: I94ecbe7bc26f550111407f19f71add3ca7c3a6b2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75062 Tested-by:
-
Oliver Hader authored
Escaping SQL `LIKE` wildcards is only provided via `QueryBuilder::escapeLikeWildcards()`, but would be useful as `Connection::escapeLikeWildcards()` as well (without having the demand to create another `QueryBuilder` instance). With this patch, both methods are available: * `QueryBuilder::escapeLikeWildcards()`, and * `Connection::escapeLikeWildcards()` Resolves: #97878 Releases: main, 11.5, 10.4 Change-Id: Ia8968dee944300949c6bb2be5b15e2d02a589d25 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75060 Tested-by:
-
- Jul 07, 2022
-
-
Oliver Klee authored
Storage folder identifiers can also be int-like strings, which causes them to automatically get cast to int when used as array keys. Our types annotations need to reflect this in order to keep developers and static analysis for taking those array keys to be always strings (which can lead to type errors and has recently done so). Resolves: #97858 Relates: #97851 Relates: #97711 Releases: main, 11.5 Change-Id: If0fbfab5792446cfe10564803d8d540dd3cc6bb5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75059 Tested-by:
-
Oliver Hader authored
Several places in the TYPO3 core fall back to using 'http' as protocol for links in case none was given. In order to adjust this behavior new $GLOBALS['TYPO3_CONF_VARS']['SYS']['defaultScheme'] setting has been introduced, which uses 'http' as default. In order to adjust the default protocol, one has to add the following assignment to their LocalConfiguration.php settings: $GLOBALS['TYPO3_CONF_VARS']['SYS']['defaultScheme'] = 'https' Resolves: #97111 Releases: main, 11.5 Change-Id: I8c86a3b98dfdfef96c6e433de28e24c1af7f27ab Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75045 Tested-by:
-
Oliver Klee authored
Methods from InaccessibleFolder should not be called and always throw an exception when called. Annotate this to help static code analysis understand this. Resolves: #97859 Releases: main, 11.5 Change-Id: Id3f563e5cd2780715a860de7faf567f9cb960d30 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75055 Tested-by:
-
Lina Wolf authored
Releases: main, 11.5, 10.4 Resolves: #97867 Change-Id: I5948ff1ab539d6f90da9034fdd05c104ea344c25 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75056 Tested-by:
-
Georg Ringer authored
Fix a notice if a browse menu is being generated but no parent page is available. Resolves: #97608 Releases: main, 11.5 Change-Id: Id0674fddccf62e02febdfa7b609521d0db3114b1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75058 Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
- Jul 06, 2022
-
-
Oliver Klee authored
This helps reduce warnings when extensions are type-checked with PHPStan. Resolves: #97820 Releases: main, 11.5 Change-Id: Iee5cd28402d9e33af0bfaa34815552ba331718ee Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75042 Tested-by:
-
- Jul 05, 2022
-
-
Andreas Fernandez authored
The method FileStorageTreeProvider->getSubfoldersRecursively() iterates an array of subfolders and prepares folder information based on the iterated data. This functionality has a minor flaw, thanks to PHP, in case a folder is named with numbers only, PHP treats array indices as integer if they can be parsed as such, leading to TypeErrors as the method prepareFolderInformation() expects a nullable string. The passed subfolder name is now cast to string to solve this issue. Resolves: #97851 Releases: main, 11.5 Change-Id: I3357121c4892d6063b6714e4e7b436b3ebdd1802 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75053 Tested-by:
-
Andreas Fernandez authored
With the upgrade of TypeScript to version 4.7, typescript-eslint reported itself as incompatible. To solve this, all eslint related packages are updated to their respective latest version. Executed commands: cd Build nvm use yarn add --dev \ @typescript-eslint/eslint-plugin@^5.30.5 \ @typescript-eslint/parser@^5.30.5 \ @typescript-eslint/typescript-estree@^5.30.5 \ eslint@^8.19.0 grunt build Resolves: #97854 Related: #97698 Releases: main, 11.5 Change-Id: Id59b1658b1d83bfa537629b8d1df32c3624351b4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75037 Tested-by: -
Andreas Fernandez authored
TypeScript has been updated to 4.7. Unfortunately, the package `@types/filesystem` (hoisted by `@types/chrome`) is incompatible with this version. As it seems to be unused, `@types/chrome` has been removed with this patch. Executed commands: cd Build yarn add --dev typescript@~4.7.0 yarn remove @types/chrome grunt build Resolves: #97698 Releases: main, 11.5 Change-Id: I1b8d2134b6403f1f9672325beabe62436d8b8901 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74824 Tested-by: -
Florian Rival authored
Use new Symfony TypoScript condition syntax instead of outdated syntax. Releases: main,11.5,10.4 Resolves: #97847 Change-Id: Ib0711c2ed871762415b022159a3c6c4b5e688a10 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74948 Tested-by:
-
Nikita Hovratov authored
Resolves: #97855 Releases: main, 11.5 Change-Id: I2cff602b6b77f451061024797adec94713f8b82e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75052 Tested-by:
-
- Jul 04, 2022
-
-
Francois Suter authored
In two places \TYPO3\CMS\Extbase\Persistence\Generic\Mapper\DataMapFactory accesses the TCA for some table without checking if it exists. Resolves: #97853 Releases: main, 11.5 Change-Id: I02c46153013c920cc771f085f872004e9a22ab3c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74950 Tested-by:
-
Francois Suter authored
Make sure that item key for custom permission options are cast to string before being parsed for invalid characters. Resolves: #97852 Releases: main, 11.5 Change-Id: Id8ff1997b875171316784d00bdc7bf72702d7645 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74949 Reviewed-by:
-
- Jul 03, 2022
-
-
Simon Schaufelberger authored
Resolves: #97845 Releases: main, 11.5 Change-Id: Iac347c7e2b5c46302a5a323222130437e4f772b6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74947 Tested-by:
-
Andreas Fernandez authored
The used flatpickr library version is quite dated and was not updated since its introduction in mid 2020. This commit updates the library to version 4.6.13, fixing several bugs. Additionally, the flatpickr can now be hidden by pressing the ESC key. Changelogs: https://github.com/flatpickr/flatpickr/releases Executed commands: cd Build nvm use yarn add flatpickr@^4.6.13 grunt build Resolves: #97837 Releases: main, 11.5 Change-Id: I4720f30447514374d638cf3d3a318e6a8e789f6d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75022 Tested-by:
-
- Jul 02, 2022
-
-
Ralf Zimmermann authored
When changing values in the form editor inspector, their header content is updated and overridden - as a result the corresponding type icon in the header suddenly disappears. Resolves: #97841 Releases: main, 11.5, 10.4 Change-Id: I18bbd668a16a5b350a14cfa565fb5b96ab205fe8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75012 Tested-by:
-
