- Nov 21, 2023
-
-
Oliver Bartsch authored
In case a user does not have content edit permissions, the content preview does no longer link to FormEngine, which previously lead to a couple of error messages on open. Resolves: #102421 Releases: main, 12.4 Change-Id: I0435ed67c629fdf163fabdfb1c61d5b8aacfe28e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81786 Tested-by:
Annett Jähnichen <mcmietz@web.de> Reviewed-by:
core-ci <typo3@b13.com>
-
Andreas Kienast authored
The Page module loads a different partial to render its columns if `defLangBinding` is enabled, that misses some DOM attributes required for drag&drop handling. This patch now adds the necessary attributes (data attributes, CSS classes). Also, to workaround a rendering issue, the page module now reloads itself after dropping an element into a column. Resolves: #102379 Releases: main, 12.4 Change-Id: I5cb6c927e09411091586e1228fe2aa71c6057376 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81784 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
-
- Nov 20, 2023
-
-
Rico Sonntag authored
This change fixes the error `array_key_exists(): Argument #1 ($key) must be a valid array offset type` This error occurs, for example, when a SaveToDatabase finisher is configured to map a form field named "type": finishers: - identifier: SaveToDatabase options: - table: tx_mytable elements: type: mapOnDatabaseColumn: foo The FormEditor invokes transformMultiValuePropertiesForFormEditor($definition, 'type', $types) with the intent to transform all structures that contain a `type: {someDefinedType}` child-entry to a slightly different format. It does this recursively for the entire form configuration, and failed for the finisher cases mentioned above. As `type` has an array value in this case: ['mapOnDatabaseColumn' => 'foo'] it can not be used as `$key` argument for `array_key_exists`. Releases: main, 12.4 Resolves: #102340 Change-Id: If79a96b7c22a4a39d211d3e09d11381db3de1134 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81776 Reviewed-by:Benjamin Franzke <ben@bnf.dev> Tested-by:
-
Oliver Bartsch authored
A non-admin is now able to delete file references when having content edit permissions are set again. Resolves: #102257 Releases: main, 12.4 Change-Id: I48ebc4d603b98dcf222ed488cc28c292e5d27a08 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81783 Tested-by:
-
Sascha Nowak authored
When using the first-class TypoScript cache or stdWrap cache functions the given cache tags of the content object are not correctly propagated to pages on consecutive requests. The cache tags were not stored in the cache entry, which is why they were never applied to the rendered page cache once they were reused. This patch adds support to store and restore the cache tag like #90775 did. Thus cache tags of subparts are now added as page cache tags. [1] https://docs.typo3.org/m/typo3/reference-typoscript/main/en-us/Functions/Cache.html#cache-as-first-class-function Resolves: #101663 Related: #90775 Releases: main, 12.4 Change-Id: Icb53c7708a4e1d4dca0e7eca754471756f4e2d63 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81806 Tested-by:
-
Garvin Hicking authored
Resolves: #102084 Releases: main, 12.4 Change-Id: Ib4086a4067008d1279dccbd9299978967faac375 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81781 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
-
Andreas Kienast authored
The backport of #101860 accidentally uses a label that is available in TYPO3 v13+ only. This patch reverts to the previously used label. Resolves: #102342 Related: #101860 Relases: 12.4 Change-Id: I0fc4bfc80c4139317e93cd97a026e7bf4b19b1dd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81805 Tested-by:
Nikita Hovratov <nikita.h@live.de> Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
-
Garvin Hicking authored
When `composer install|dumpautoload` is performed, the PackageArtifactBuilder inspects the list of all extensions, and then creates symlinks to `Resources/Public` of each extension into the `_assets` subdirectory. This step could fail, when a vendor name ended on "ext". A package in `vendor/superagency-next/myextension/Resources/Public` would not have gotten symlinked, because "ext/myextension" matches in this combination. The fix is to check the directory for the actual pattern of non-composer legacy installations (which is available as a constant). Resolves: #101590 Releases: main, 12.4 Change-Id: Ie19dae86dc69ce9c78681e8011575f12a46c5f8f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81782 Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
-
Garvin Hicking authored
Note: This patch doesn't make the command be on feature-parity with the web-based installer. CLI bails out when the DB doesn't exist; web is able to create non-existant DB at this stage. This would need implementation as a follow-up feature. This patch only addresses not raising an exception on CLI installation. Resolves: #102322 Releases: main, 12.4 Change-Id: Ic71c71669b010d4fc8e9cb9f229cbdb191dbbee8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81779 Tested-by:
-
Garvin Hicking authored
This is a follow-up to patch 81704 and adds one more guard to a usage of possibly empty $GLOBALS['TYPO3_CONF_VARS']['SYS'] ['systemLocale'] Resolves: #102405 Related: #102343 Releases: main, 12.4 Change-Id: I8efad0cfef4ad15d98c44a26270ee3f2b53cb3c0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81778 Reviewed-by:
-
Oliver Bartsch authored
The auto configuration of the symfony AsCommand attribute, introduced with #101567, now properly handles the `aliases` parameter. Resolves: #102406 Related: #101567 Releases: main, 12.4 Change-Id: I4a872e28d041dcfd4bf65517e5d01c625da82af9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81777 Tested-by:
-
Christian Kuhn authored
This patch is paired with the setup of a new CI [1]. The patch adapts runTests.sh to allow podman as container environment next to docker. New CI relies on podman. Locally, podman can be selected as container environment using the `-b podman` flag to runTests.sh. A "recent" podman version - at least around 4.x - should be used. docker is kept as default for now. The new CI setup comes with a series of improvements to speed up things. This makes the acceptance tests a bit more brittle again. The patch comes with some further stabilizations, and we may add even more with dedicated patches later. [1] https://git.typo3.org/typo3/CI/testing-infrastructure/ Change-Id: I206c1577335bfbefb801eaababa4b713e1edda12 Resolves: #102385 Releases: main, 12.4, 11.5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81744 Reviewed-by:
-
- Nov 19, 2023
-
-
Peter Kraume authored
In frontend context the field scope in table sys_csp_resolution is filled with a concatenation of "frontend." and the site configuration identifier. When the site identifier is too long, new entries in sys_csp_resolution fail for frontend requests. Resolves: #102404 Releases: main, 12.4 Change-Id: Ibe274ffb91f35949ff312026b2a904e7cb36a3b3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81775 Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
Anja Leichsenring authored
The test showcased an outdated concept of custom eval implementation. The showcase has been removed to promote more modern approaches, now the test fails and is removed, too. This reveals a cross dependency between acceptance tests, which is fixed along the way by combining two test files. Resolves: #102238 Releases: main, 12.4 Change-Id: I91c437f31399a26f9ce052024a004f55dc6348dd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81770 Reviewed-by:
-
Willi Wehmeier authored
Add autocomplete attribute to the realName and email input field in the user settings backend module Resolves: #102395 Releases: main, 12.4 Change-Id: If0dda91fa4c2bc8afd78879cf9358c940cb32026 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81774 Reviewed-by:
-
Marcin Sągol authored
This commit renames the `Access Lists` tab to `Access Rights` in the backend group configuration form. This ensures consistency with the `Access Rights` tab in the backend user configuration form. The id for this label was already set to `be_groups.tabs.base_rights` in the XLF file; thus, only the value was updated. Additionally, an unused id `be_groups.inc_access_lists` has been removed from the corresponding XLF file. Resolves: #101533 Releases: main, 12.4 Change-Id: I78394a4c6b35c4cf19dadf169bbf21efea720916 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81772 Tested-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Reviewed-by:
-
Benni Mack authored
This change allows the usage of "options.pageTree.altElementBrowserMountPoints" in the ElementBrowser again. It was available in the LinkHandlers, but not in the ElementBrowser. Resolves: #98105 Releases: main, 12.4 Change-Id: Iddf8001c3f28a3addb9cb13c076bce7edeeeb4d1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81773 Reviewed-by:
-
Guido Schmechel authored
Resolves: #102399 Releases: main, 12.4 Change-Id: I2d9e7beea1a9b5a548357e9715d13890712c51a7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81671 Reviewed-by:
-
- Nov 18, 2023
-
-
Oliver Bartsch authored
FieldControl is required to set a title. To ensure this, the field control options can now be used to set a custom title. Additionally, a fallback is added to ensure a title is always set, even if a custom TCA type is used and no title is defined, using the FieldControl option. Resolves: #102366 Releases: main, 12.4 Change-Id: Id4b2bbb15d5e1d12fae6dbd287dbdeda7ba5b987 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81767 Tested-by:
-
Oliver Bartsch authored
The raw search in the DB check module now works reliable and consistent with other search functionality in the backend. Therefore the search now uses proper JS to: * Submit the form on browser clear * Monitor search term inputs * Toggling the submit button Additionally, the template got adjusted: * Display of proper info for search with no results * Display of proper info for an empty search * Usage of aria-labeldby * Usage of search icon in combination with the <button> tag for consistency * Resolving duplicated if clauses Resolves: #102394 Releases: main, 12.4 Change-Id: I6a4dd9f23920eb25f4c3cc2817f48a02182a6545 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81766 Reviewed-by:
-
- Nov 17, 2023
-
-
Simon Schaufelberger authored
Remove outdated "max" property. Resolves: #102351 Releases: main, 12.4 Change-Id: Ib64460a53d2dc6c00e45cfa66bf9891df7e08cf4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81761 Reviewed-by:
-
- Nov 16, 2023
-
-
Benjamin Franzke authored
Backend responses must never be cached. The previously used Cache-Control instruction "must-revalidate" implicitly enabled caching in order to possibly reuse a response. While that could only happen when two requests to the same URL are invoked within one second (because the browsers `If-Modified-Since` header and our `Last-Modified` header match, causing the webserver to issue a 304 response), that is certainly possible in CI setups or fast user clicks. Use `no-store` in order to instruct browsers to not cache and try revalidation at all. Also remove hard-coded acceptance test waiters that were introduced to circumvent this (but only did sometimes because with 0.5s wait time there was still room for two requests within one second). Resolves: #102377 Releases: main, 12.4, 11.5 Change-Id: Ic05cad748f824e7a45a1740aca15cd2fc3595a79 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81670 Tested-by:
-
- Nov 15, 2023
-
-
Sascha Egerer authored
A "valuePicker" TCA configuration allows to either prepend, append or replace a preset for an input field. While "prepend" and "append" allow to continuously pick and choose elements to be inserted, the "replace" mode is single-use and always resets to a single chosen value. For the "replace" mode it could be helpful to keep the input field in sync with the ValuePicker especially if the value picker as a human-readable representation of the value that is added in the input field. Resolves: #102330 Releases: main, 12.4 Change-Id: I07a8c8ca29877f2a1f580f44ed572280e87dded4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81669 Tested-by:
-
Mathias Brodala authored
Resolves: #102374 Relates: #102140 Releases: main, 12.4 Change-Id: Ib3e1f60080c9e1c7a7839aa2fcb90f9d91d6a4ed Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81668 Tested-by:
-
- Nov 14, 2023
-
-
Oliver Bartsch authored
The enable fields of webhook records are now properly respected. Also the listing in the backend module is fixed, allowing to toggle the disabled state and also displaying the correct record icon (including a possible overlay icon). Resolves: #102341 Releases: main, 12.4 Change-Id: Ib866ce6dbb4524cf85cf6191fb2771e980be028a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81667 Tested-by:
-
Oliver Hader authored
Change-Id: Ifbe44c4a86a2b9395aa48b03d06ec40c648892b9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81741 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
Oliver Hader authored
Change-Id: I4526cec76bd4e8d8df9a94684e250e8d5bcf9c5e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81740 Tested-by:
-
Benjamin Franzke authored
See https://github.com/TYPO3/html-sanitizer/releases/tag/v2.1.4 composer req typo3/html-sanitizer:^2.1.4 composer req typo3/html-sanitizer:^2.1.4 \ -d typo3/sysext/core --no-update Resolves: #102169 Releases: main, 12.4, 11.5 Change-Id: I76edb7ff0dc66d3308d5c0875c2db56ca02addd7 Security-Bulletin: TYPO3-CORE-SA-2023-007 Security-References: CVE-2023-47125 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81735 Tested-by:
-
Benjamin Franzke authored
Given that there are two sites `site-a.com` and `site-b.com` in the same TYPO3 installation, it was possible to reuse a session cookie that was generated for `site-a.com` in `site-b.com`. Since there are scenarios, where this is the expected behavior – when sharing sessions across sub domains, so that an explicit cookieDomain needs to be configured – user sessions signatures are now salted with the desired cookie domain, so that a cookie can only be used on the domain that the cookie was created for. Testing framework will need to be adapted in a subsequent patch, but for the time being – and for compatiblity with possible 3rd party authenticators – legacy tokens will be accepted, but not created by TYPO3 core. Resolves: #100885 Releases: main, 12.4, 11.5 Change-Id: I0d1c314c6e206ac12604ba6f859af78b958651dd Security-Bulletin: TYPO3-CORE-SA-2023-006 Security-References: CVE-2023-47127 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81734 Tested-by:
-
Markus Klein authored
Using the Install Tool in composer mode, the login displays a hint, where the ENABLE_INSTALL_TOOL file must be placed to unlock the Install Tool. This hint does not show the full path anymore. Only the path relative to the project root is shown. Resolves: #102242 Releases: main, 12.4 Change-Id: I1e9cbfe3ef7d4cc6af9635da71d0c7450fe44aa6 Security-Bulletin: TYPO3-CORE-SA-2023-005 Security-References: CVE-2023-47126 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81733 Reviewed-by:
-
- Nov 13, 2023
-
-
Christian Kuhn authored
We're in the process of establishing a new core CI. This has more power and is better optimized. The resulting runtime changes reveal various flaky acceptance tests. Most have been problematic before already, but not as bad. The patch adds various guards to acceptance tests to reduce flakiness. Resolves: #102363 Releases: main, 12.4, 11.5 Change-Id: Iff2c79411b39fffe659c78a8e889f8a804939bc4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81721 Tested-by:
-
Sybille Peters authored
TCA fields of type 'slug' can be configured with the property generatorOptions. Particularly, the short form of using a simple array for the fields instead of a nested array is a common source of confusion and the initially introduced changelog had incorrect examples. The changelog is improved as follows - Fix the examples. The examples 2 and 3 showed incorrect results - Use the multidimensional array in the source snippet - Clarify that ['nav_title', 'title'] is the same as [['nav_title'], ['title']], but not the same as [['nav_title', 'title']] Resolves: #89390 Releases: main, 12.4, 11.5 Change-Id: Ib1944c2a1eb9e2a69a0f169f316208cf46f9be84 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81726 Tested-by:
-
Christian Kuhn authored
In AC tests it appears that popover instances are not available, either because the DOM isn't ready yet, or the element got removed meanwhile, leading to AC test failures. As a safety net, popover instances are now checked for not being `null`, and a warning is logged in the console. Also, the `@typo3/backend/context-help` module now waits for a ready DOM and only takes elements into consideration that existed on initialization time. Resolves: #102368 Releases: main, 12.4 Change-Id: Icffc6f7e144881ded56910d7cb6f75b80f9752e1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81725 Tested-by:
-
Patrick Schriner authored
Resolves: #102358 Releases: main, 12.4 Change-Id: I6bab163fea7b186d1da713a764678d9a885122bf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81666 Tested-by:
-
- Nov 10, 2023
-
-
Thomas Hohn authored
If a HMAC cannot be `json_decode`d (possibly due to old saved pages or other outdated content), now a proper exception is thrown instead of issuing a PHP warning. Resolves: #97337 Releases: main, 12.4, 11.5 Change-Id: I12f5633a85508bf4099d72e474c24b5a0100498c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81718 Tested-by:
-
- Nov 09, 2023
-
-
Achim Fritz authored
The page types section of the Compare User View now displays the correct record type icon, which is already resolved from the record type items definition. Additionally, a fallback is added to prevent a possible undefined array key warning. Resolves: #102338 Releases: main, 12.4 Change-Id: I405b1933d01c1691fdcc10c15b323f92757365ed Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81664 Reviewed-by:
-
Patrick Schriner authored
Resolves: #102350 Releases: main, 12.4 Change-Id: Ieb5f0b952bb647b02fc3dff183f744b8f8cfd1f4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81665 Reviewed-by:
-
- Nov 08, 2023
-
-
Andreas Kienast authored
Exected commands: npm install --save cropperjs@^1.6.1 npm run build Resolves: #102333 Releases: main, 12.4 Change-Id: I9be75686cb974a8c4288153e414bbbf2cc696859 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81710 Tested-by:Andreas Kienast <a.fernandez@scripting-base.de> Tested-by:
-
Xavier Perseguers authored
When $GLOBALS['TYPO3_CONF_VARS']['SYS']['systemLocale'] is empty, a call to setlocale() may lead to a PHP crash. Resolves: #102343 Releases: main, 12.4 Change-Id: Icbb9d0118327c0303ae6d3fc98e1cbecfb704877 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81663 Tested-by:
Xavier Perseguers <xavier@typo3.org> Reviewed-by:
-
- Nov 07, 2023
-
-
Benjamin Franzke authored
With #99503 `cObjGet()` was implemented as a wrapper around the strictly typed cObjGetSeparated method, effectively enforcing the first argument to be an array, while previously non array values were returned as an empty string. Resolves: #102328 Related: #99503 Releases: main, 12.4, 11.5 Change-Id: I7c04307f14da5a93e12672b36de163071dad7359 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81661 Tested-by:
-
