- Aug 21, 2024
-
-
Karsten Nowak authored
Fix not cklickable `+` sign for the nested properties in debugger tree in frontend. The css selector for input fields of type checkbox are not strong enough if the website css defines own css rules and select checkboxes with input[type="checkbox"] the selector in DebuggerUtility loses and properties are overriden. Height, width, z-index and other properties were used to hide the default appearance of checkboxes and make those form elements looking nice. Therefore, DebuggerUtilitys selector should be a bit more stronger. Resolves: #104681 Releases: main, 12.4 Change-Id: Id6964e0dbf19b83318f1e5de5f3763c6be6652a0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85710 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
Garvin Hicking <gh@faktor-e.de>
-
Oliver Bartsch authored
Renaming resources via the ResourceController, called via AJAX, does now also properly log the performed action to be consistent with the use of the ExtendedFileUtiltiy. Resolves: #104569 Releases: main, 12.4 Change-Id: Icc2a5effcfa06269c2ad2f96cfa844206232ac60 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85696 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Christian Kuhn authored
ext:fluid RenderingContext is in the bad habit of extending fluid standalone RenderingContext with the two methods setRequest() and getRequest() that are not part of fluid standalone RenderingContextInterface. This is ugly with type hinting and can't be changed in a good way due to liskov collisions on method signatures in view helpers. Fluid standalone also does not want to add these methods itself since it - as a view - wants to avoid dependencies to PSR-7. Fluid standalone instead added setAttribute(), hasAttribute() and getAttribute() to RenderingContextInterface. This allows adding "arbitrary" objects. The patch makes use of this: On the setter side, the RenderingContextFactory->create() is extended to accept the request and set it as attribute, on the has/getter side all consumers are adapted. This deprecates setRequest() and getRequest(), which are changed to transparently work with the attribute instead. Resolves: #104684 Releases: main Change-Id: Id096073765c00e06e0437539f963f59a69e3fba0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85708 Tested-by:
Garvin Hicking <gh@faktor-e.de> Reviewed-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de>
-
Christian Kuhn authored
Various ext:extbase functional tests set $GLOBALS['TYPO3_REQUEST']. The extbase codebase still has various places that access the global. We can still reduce some usages in tests which are obsolete meanwhile, or can be improved by setting the request on ConfigurationManager instead, which is one of the main callers to the $GLOBALS['TYPO3_REQUEST'] fallback in tests. Resolves: #104677 Related: #104675 Releases: main Change-Id: I8672cad869e64545c482664e5d995bc1ef02bd64 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85706 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Simon Praetorius <simon@praetorius.me> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Simon Praetorius <simon@praetorius.me> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
Benjamin Kott authored
We are dropping the Bootstrap CSS definitions for all form stylings to have more control about the styling of the form elements. From now on we are shipping custom css adapted to our needs. The new form element styling is context aware and adapts to light and dark color schemes. Resolves: #104676 Releases: main Change-Id: I0da5017c961e9712c027f09a34f4cf91a7b11a45 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83047 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Andreas Kienast <a.fernandez@scripting-base.de> Reviewed-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
Benjamin Franzke <ben@bnf.dev> Reviewed-by:
Andreas Kienast <a.fernandez@scripting-base.de>
-
- Aug 20, 2024
-
-
Oliver Bartsch authored
There might be the case that the same flag icon is used for different languages. Due to iconFactory using a cache for generated icons, record list needs to set the title explicitly to prevent using a wrong title on reusing the flag icons. Resolves: #104663 Releases: main, 12.4 Change-Id: I1eea6a608f1ce243cc0437de39c5b5ca323f2be1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85693 Reviewed-by:
Andreas Kienast <a.fernandez@scripting-base.de> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Andreas Kienast <a.fernandez@scripting-base.de> Reviewed-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Garvin Hicking <gh@faktor-e.de>
-
Christian Kuhn authored
Various ext:fluid functional tests set $GLOBALS['TYPO3_REQUEST']. There are three scenarious fixed with this change: * A VH uses ContentObjectRenderer that is fetched from request attribute 'currentContentObject'. If the request has not been set up correctly, it falls back to globals. Set those properly. * Setting $GLOBALS['TYPO3_REQUEST'] is not needed at all. * The VH triggers extbase request dependent ConfigurationManager, which is not set up properly. Set up those. Resolves: #104675 Releases: main Change-Id: I9155de89aa2799710f3453977473c58e8382fa7b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85701 Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Simon Praetorius <simon@praetorius.me> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Simon Praetorius <simon@praetorius.me> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Christian Kuhn authored
View helpers link.typolink and uri.typolink fail to set the given request on ContentObjectRenderer, so it falls back to $GLOBALS['TYPO3_REQUEST']. The patch sets the request (if given), and adapts the tests to rely on it, which avoid setting the global. Resolves: #104674 Releases: main Change-Id: Iac5d28eac3adce5632e70794f38956c244545509 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85702 Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Simon Praetorius <simon@praetorius.me> Tested-by:
Simon Praetorius <simon@praetorius.me> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
core-ci <typo3@b13.com>
-
Christian Kuhn authored
Next change in the "Tame extbase ConfigurationManager" series. ext:form comes with an add-on class of extbase ConfigurationManager: It extends the class with an own feature to load the relevant YAML configuration from the extensions TypoScript. This is accompanied by an own interface. This is not a great idea from a structural point of view: The ext:form ConfigurationManager should be decoupled from extbase ConfigurationManager. It may decorate it, but should not extend it. Or - even better - not have a dependency to extbase ConfigurationManager at all, but get the required extbase ConfigurationManager state hand over. The latter option is preferred since extbase ConfigurationManager is this evil injectable stateful singleton, that hides required state away. Turning this around in ext:form forces consumers to hand over state directly, making the dependency to extbase ConfigurationManager state explicit in callers of ext:form ConfigurationManager. The patch does this: ext:form ConfigurationManager no longer extends extbase ConfigurationManager, but is turned into a standalone and stateless service with an own signature that actively receives needed state from consumers. Resolves: #104670 Related: #104514 Releases: main Change-Id: If6073eb50df788d45a7f4d73e95cbd2d54a8c5fe Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85638 Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Simon Praetorius <simon@praetorius.me> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Simon Praetorius <simon@praetorius.me> Tested-by:
core-ci <typo3@b13.com>
-
Oliver Bartsch authored
Resolves: #104639 Releases: main, 12.4, 11.5 Change-Id: I74a0cd9e856283d26a382582cc5d6b8e99887cd4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85694 Tested-by:
Andreas Kienast <a.fernandez@scripting-base.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Andreas Kienast <a.fernandez@scripting-base.de> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de>
-
Christian Kuhn authored
The FormPersistenceManager is a central class of ext:form that takes care of .form.yaml writing and loading. This includes overloading with form specific TypoScript settings and sanitation of storage locations based on module.tx_form TypoScript. Since ext:form is designed as an extbase extension, FormPersistenceManager relies on extbase ConfigurationManager to retrieve TypoScript. The ext:form internal own variant of extbase ConfigurationManager has this dependency as well. This wouldn't be a huge problem if FormPersistenceManager is only used from within the extbase bootstrapped extension context only. FormPersistenceManager however is used 'out-of-context' in three places: It is used within the BE FormEngine related flex form data structure handling hook, within the BE page module related content element preview rendering, and by the formvh:render view helper. These three places do not have an extbase context, so extbase, and especially the extbase related stateful injectable singleton ConfigurationManager, has not been configured at these points. Extbase ConfigurationManager, and in turn the ext:form extended variant as well, have a dependency to the request to work properly and thus rely on the request being set up correctly. To deal with this, FormPersistenceManager configures extbase ConfigurationManager within __construct() by handing over the request from $GLOBALS['TYPO3_REQUEST']. This is bad for a series of reasons, one being obviously the access to $GLOBALS['TYPO3_REQUEST'] within __construct() in the first place. Also, FormPersistenceManager is quite often used *within* properly configured extbase context as well, for instance from within the extbase based ext:form controllers, so FormPersistenceManager then reconfigures extbase ConfigurationManager with the (non-extbase) global request and thus messes up its state. The problem is here that FormPersistenceManager does not and can not know wether its used 'out-of-context'. To deal with this, the patch removes use of ConfigurationManager to retrieve TypoScript within FormPersistenceManager, and forces consumers to hand it over to those methods that need it. The idea is that only the callers know their context and can take care of setting up ConfigurationManager as needed on their own. This approach makes the dependency to the request object explicit: Two of the three 'out-of-context' places are "ok" with that: The BE page module preview rendering has the request available, the formvh:render view helper as well. The third one will be harder to resolve: The flex form related data structure handling has not been designed to have the request, there may or may not be CLI situations in this low level handling where no request is available. This needs further analysis, the patch outlines various options for now. The patch forces FormPersistenceManagerInterface to be adapted, which should not be a huge issue since the overall functionality is ext:form internal, and there shouldn't be extensions that use it directly. The patch is thus *not* considered breaking and FormPersistenceManagerInterface is now declared @internal along the way to reflect this. Also, as usual when working in this area, the related tests receive an overhaul to deal with the new signatures and internal handling, and to be more easy to maintain. Also, class ext:form ConfigurationService suffers from similar issues as outlined above and will probably need a revamp as well. This one however is only used in combination with FormPersistenceManager when used 'out-of-context', so the changes for FormPersistenceManager relax this situation as well. Still, and @todo is left in it. Resolves: #104667 Related: #92408 Related: #102558 Releases: main Change-Id: I555aa6445f1fad577253cf90065df540a5830bd7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85669 Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Daniel Siepmann authored
TCEforms were removed with #97126 in v12. Still there was a usage within EditPopup leading to an Exception when editing a record with FlexForm via edit form control. Resolves: #104658 Releases: main, 12.4 Change-Id: Ie7110367922a99ca088b416da4c11a025efcde00 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85676 Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Garvin Hicking <gh@faktor-e.de> Reviewed-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Andreas Kienast <a.fernandez@scripting-base.de>
-
Oliver Bartsch authored
Resolves: #104665 Related: #103783 Releases: main Change-Id: I60bb7561f25a0c25068064890ee5deb474c183e4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85681 Reviewed-by:
Jochen Roth <rothjochen@gmail.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Garvin Hicking <gh@faktor-e.de> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Jochen Roth <rothjochen@gmail.com>
-
Andreas Kienast authored
The date picker used in EXT:styleguide -> Components -> Form needs another format to be functional again. Resolves: #104660 Releases: main Change-Id: Iec506bbdbb68d3f41c6e9c0fb5701fc5ba0522d3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85678 Tested-by:
Garvin Hicking <gh@faktor-e.de> Reviewed-by:
Garvin Hicking <gh@faktor-e.de> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de>
-
- Aug 19, 2024
-
-
Lina Wolf authored
Documents https://review.typo3.org/c/Packages/TYPO3.CMS/+/85472 Resolves: #104647 Releases: main Change-Id: Ifb41959a20001664e39eadbd13d85cfbc153a783 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85663 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Chris Müller <typo3@brotkrueml.dev> Reviewed-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
Chris Müller <typo3@brotkrueml.dev> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Garvin Hicking <gh@faktor-e.de>
-
Oliver Hader authored
This change introduces the following enhancements: * `Map::keys(): array` resolves all keys of a map * `Map::values(): array` resolves all values of a map * `Map::assign(?Map): void` incorporates entries of other map Resolves: #104656 Releases: main, 12.4 Change-Id: Ifc358c83275128c52f8f195b06c1b36f54227f86 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85673 Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Andreas Kienast <a.fernandez@scripting-base.de> Tested-by:
Andreas Kienast <a.fernandez@scripting-base.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
core-ci <typo3@b13.com>
-
- Aug 18, 2024
-
-
Jasmina Ließmann authored
The backend module "Backend Users" lists all backend users and backend user groups in the system. A detailed view can be called up for each backend user, which shows all compiled rights and settings for the backend user. This view has been revised to increase the UX and user-friendliness. The backend module also offers the option of comparing individual backend users or backend user groups with each other. These comparison views have also been slightly adjusted to improve clarity. Resolves: #104635 Releases: main Change-Id: I2f118ea49783e99c2b174dd33a7d58847338e183 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85543 Reviewed-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Tested-by:
Guido Schmechel <guido.schmechel@brandung.de> Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Guido Schmechel <guido.schmechel@brandung.de>
-
- Aug 17, 2024
-
-
Lina Wolf authored
As prepatch for https://forge.typo3.org/issues/104597 Only syntax changes and a changed headline. Layout will be addressed via https://github.com/TYPO3-Documentation/render-guides/issues/707. Resolves: #104644 Related: #104597 Releases: main, 12.4 Change-Id: Ibe9ee56d522c6eb1b337d38ed61bd004124fee6e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85661 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Garvin Hicking <gh@faktor-e.de>
-
Lina Wolf authored
References: https://github.com/TYPO3-Documentation/Changelog-To-Doc/issues/982 Releases: main Resolves: #104649 Related: #101391 Change-Id: I525d6fe5172b5bab110882140137601e7d508a83 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85665 Tested-by:
Garvin Hicking <gh@faktor-e.de> Reviewed-by:
Garvin Hicking <gh@faktor-e.de>
-
Lina Wolf authored
references: https://github.com/TYPO3-Documentation/Changelog-To-Doc/issues/982 Releases: main Resolves: #104648 Related: #101391 Change-Id: I6182144b7f18486813fc8236d58e0c53921cd6b9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85664 Reviewed-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
Garvin Hicking <gh@faktor-e.de>
-
Lina Wolf authored
Documentation of https://review.typo3.org/c/Packages/TYPO3.CMS/+/83702 https://github.com/TYPO3-Documentation/Changelog-To-Doc/issues/895 Resolves: #104650 Related: #103563 Releases: main Change-Id: Iaf7603c0873bef2889b7380c3cf6c3aeedcf2c05 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85666 Tested-by:
Garvin Hicking <gh@faktor-e.de> Reviewed-by:
Garvin Hicking <gh@faktor-e.de>
-
Christian Kuhn authored
To prepare further works on the implementing class, FormPersistenceManagerInterface is synchronized with some methods FormPersistenceManager implements and are needed, but are not within the interface, yet. Method checkForDuplicateIdentifier() is used internally only, and removed from the interface. Move public methods to top in FormPersistenceManager, remove an obsolete attribute of the "fake request" (which will see more handling with another patch), and mark the implementing class @internal since everything can be programmed to the interface. Resolves: #104652 Releases: main Change-Id: I69bf2a4118811c1407e329893559867a75457630 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85668 Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech>
-
Christian Kuhn authored
The method was used by an upgrade wizard that has been removed in v11 already. Remove that method and streamline the class a bit. Resolves: #104651 Related: #94299 Releases: main Change-Id: I90b613913fe09d1f5f42bf7a6bb3efba2f88c4c4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85667 Tested-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
- Aug 16, 2024
-
-
Stefan Bürk authored
Replace `sprintf()` union building for the recursive Common Table Expression part with `UNION clause` QueryBuilder API to resolve `@todo` in the TYPO3 implementation. Resolves: #104638 Related: #104631 Related: #104628 Releases: main Change-Id: Iede147e930125f821dd9ea7ba57a78b0bfb84434 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85502 Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de>
-
Christian Kuhn authored
The patch is rather straight in class `FormDefinitionValidationService`. The tests receive a major overhaul towards less mocking. Note the entire ext:form 'validation' topic is rather over-abstracted and complex. It should see some simplifications in the future. Resolves: #104645 Releases: main Change-Id: I12e5b0f4d8242dfc0a8cfe58f004b26631689e80 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85660 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Stefan Bürk authored
The `UNION Clause` is used to combine the result-set of two or more `SELECT` SQL queries suported by all database vendors - at least on a shared basic level with the usual special vendor enhancements. There is a common shared subset working for all of them: SELECT column_name(s) FROM table1 WHERE ... UNION <ALL | DISTINCT> SELECT column_name(s) FROM table2 WHERE ... ORDER BY ... LIMIT x OFFSET y Instead of introducing the `UNION Clause` support into the TYPO3 QueryBuilder, the challenge was taken to add this directly into Doctrine DBAL [1]. The effort was rewarded and with the release of `Doctrine DBAL 4.1.0` `UNION Clause` [2] the support is included. This change adopts the new feature into the extended `ConcreteQueryBuilder` and `QueryBuilder` to support extension authors with a simple and usable interface to build `UNION (DISTINCT)` and `UNION ALL` queries. [1] https://github.com/doctrine/dbal/pull/6369 [2] https://github.com/doctrine/dbal/releases/tag/4.1.0 Resolves: #104631 Related: #104628 Releases: main Change-Id: I443b762fdc6a9f1ed77b3d655d0ab2f371a56d50 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83943 Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Jasmina Ließmann authored
The functionality of the web component `<typo3-formengine-element- select-check-box></typo3-formengine-element-select-check-box>` should not be exclusively for use in FormEngine. Therefore, the component is renamed and moved. Resolves: #104636 Related: #98683 Related: #104142 Releases: main Change-Id: Id6a639a8a6b262edc19fc0d96831406950e45783 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85652 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Tested-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Tested-by:
core-ci <typo3@b13.com>
-
Christian Kuhn authored
Refactor ext:form ConfigurationService towards DI. The main FormFrontendController is refactored along the way. Both their test cases are turned into functional tests, to other tests are adapted slightly. Resolves: #104641 Releases: main Change-Id: I555ac4c4489eaf4b29e07240262bca362ac97dd6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85654 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
core-ci <typo3@b13.com>
-
Lina Wolf authored
This patch adds a description on how to utilize site sets from `EXT:seo` to the Configuration section. Resolves: #104600 Releases: main Change-Id: I79f206d08692ad905d29f2fe30d1b09993b99b82 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85608 Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Sandra Erbel <erbel@analog.de> Tested-by:
Garvin Hicking <gh@faktor-e.de> Reviewed-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Sandra Erbel <erbel@analog.de>
-
Sandra Erbel authored
Releases: main Resolves: #104642 Change-Id: I514ebf96642e3ad0401443fb01dacfcb5f38bea5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85656 Tested-by:
Lina Wolf <112@linawolf.de> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Lina Wolf <112@linawolf.de> Tested-by:
Stefan Bürk <stefan@buerk.tech>
-
Lina Wolf authored
Resolves: #104599 Releases: main Change-Id: Ic4059c5d7f1266c57a2a7c053bdb09afa836f075 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85603 Reviewed-by:
Stefan Froemken <froemken@gmail.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Stefan Froemken <froemken@gmail.com> Tested-by:
core-ci <typo3@b13.com>
-
Frank Naegler authored
playwright/axe iterates over a list of web pages and highlights accessibility issues. This tool is now applied as a CI job to the TYPO3 Backend where the main backend layout and modules are being tested. Usage: # CI mode Build/Scripts/runTests.sh -s accessibility # Run against local instance ACCESSIBILITY_BASE_URL=https://t3main.devbox.local/typo3 \ npm --prefix=Build run accessibility # Prepare CI mode, run locally (repeatable command will be printed) Build/Scripts/runTests.sh -s accessibility-prepare Commands executed: npm --prefix=Build install --save-dev \ @axe-core/playwright@4.9.1 \ @playwright/test@1.45.3 Resolves: #103283 Releases: main, 12.4 Change-Id: Ib1c74027eaacd2a225decd59406d79528f14635e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80557 Tested-by:
Benjamin Franzke <ben@bnf.dev> Reviewed-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
Andreas Kienast <a.fernandez@scripting-base.de> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Andreas Kienast <a.fernandez@scripting-base.de>
-
Chris Müller authored
First, breaking the <f:uri.resource> example into multiple lines makes it easier for users on small screens/browser width (or with larger font size) to get the relevant attribute without horizontal scrolling. Second, the relevant parts are now highlighted to spot the significant part faster. Resolves: #104640 Related: #99203 Releases: main Change-Id: Ia7719b9a59a7920bf88e7add37a433ec41c856c5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85655 Tested-by:
Garvin Hicking <gh@faktor-e.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
core-ci <typo3@b13.com>
-
- Aug 15, 2024
-
-
Christian Kuhn authored
Move FormPersistenceManager::FORM_DEFINITION_FILE_EXTENSION to FormPersistenceManagerInterface::FORM_DEFINITION_FILE_EXTENSION and use it. Resolves: #104637 Releases: main Change-Id: I96dc9aeeee396bc50a1fd70a2fbd002bffd05408 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85653 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Reviewed-by:
Andreas Kienast <a.fernandez@scripting-base.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Andreas Kienast <a.fernandez@scripting-base.de>
-
Andreas Kienast authored
The package `devbridge-autocomplete` was removed in TYPO3 v12 (#98455), but it is still referenced in "External Libraries" in the "About" module. The reference is now removed. Resolves: #104632 Related: #98455 Releases: main, 12.4 Change-Id: I8032933f59f1fcf0acccc6baf30ac0515b441faa Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85645 Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
core-ci <typo3@b13.com>
-
Christian Kuhn authored
AbstractBackendController of ext:form does not do much, except it gets DI wrong and relies on the global initializeObject method, which is kinda ugly for stuff like this. The patch merges AbstractBackendController into the two ext:form backend controllers, which now extend extbase ActionController directly. The patch finishes DI of the two controllers and cleans up minor things like the usual "use less properties by handing over stuff directly" stuff. The existing tests receive a rewrite and are changed from unit to functional tests: This reduces mocking significantly and makes much more clear what is actually tested. The should be much more easy to maintain now. Resolves: #104634 Releases: main Change-Id: I2610a25023a3a1762d3ba6cabd116e1adfcca96b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85641 Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de>
-
Stefan Bürk authored
The Doctrine Team recently released minor version release `4.1.0` including a couple of bugfixes, internal changes and also new features [1]. The aforementioned internal changes introduces breaking stuff within internal implementation, for example the TYPO3 Database Analyzer stack enforcing adoption [2][3][4]. Sadly, it's not possible to provide backwards compatible code and thus minimum version raise is "absolutly" required. Doctrine DBAL 4.1.0 also includes new platform implementation for some database platforms and this change adds them as extend replacements to ensure working state with TYPO3 DB Analyzer. Note that previous TYPO3 v13.x composer instances needs to limit doctrine/dbal to 4.0.x on their own to avoid breaking behaviour. Used command(s): \ composer require --no-update --no-install \ -d typo3/sysext/redirects \ "doctrine/dbal":"^4.1" \ && composer require --no-update --no-install \ -d typo3/sysext/core \ "doctrine/dbal":"^4.1" \ &...
-
Oliver Hader authored
Aims to combine disabling site-specific CSP with report-only mode later. This reverts commit acf70306. Reverts: #104549 Resolves: #104633 Releases: main, 12.4 Change-Id: I651f60d7b5cc24133801412c8f09b1efba98d3f4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85646 Reviewed-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
Garvin Hicking <gh@faktor-e.de>
-
Oliver Hader authored
The previous patch introduced ambiguities for allowed attributes for multiple HTML elements that were reliable and hard-coded in previous versions. This reverts commit cb5f8bb4. Resolves: #104622 Reverts: #104520 Releases: main, 12.4 Change-Id: Ib63cc4733944ad98830ee269baf13f1b15076ef5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85642 Tested-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Benjamin Franzke <ben@bnf.dev>
-
- Aug 14, 2024
-
-
Christian Kuhn authored
Inject ext:form ConfigurationManagerInterface, not the implementation ConfigurationManager in the ext:form "Show Configuration" ProviderInterface feature for ext:lowlevel. Resolves: #104626 Releases: main Change-Id: I777e24e5aeb6a9738c207b0c0462f0ff71374703 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85637 Reviewed-by:
Andreas Nedbal <andy@pixelde.su> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Andreas Nedbal <andy@pixelde.su> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
core-ci <typo3@b13.com>
-