- May 10, 2022
-
-
Oliver Hader authored
Change-Id: If249fa2af484ba4582d3f850062c25c0433b7858 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74597 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
Oliver Hader authored
Change-Id: I8bd3e7ec4fce5774412920a93f297fb94178d090 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74596 Tested-by:
-
Christian Kuhn authored
A series of minor TF fixes, nothing fancy. composer req --dev typo3/testing-framework:^6.16.4 Change-Id: I3b8fcec5d16398ba0b1b88379c3dc54b129252d3 Resolves: #97600 Releases: 11.5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74592 Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
-
- May 09, 2022
-
-
Christian Kuhn authored
We restricted the default retry of single jobs a while ago to do that only for acceptance test related jobs. This does not work out well: There are simply to many things that occassionally false-negative due to network, timing or other issues. The patch adds general retry:1 for all jobs for mental sanity. Resolves: #97597 Related: #96999 Releases: main, 11.5 Change-Id: I408b7ef1b6c6145dc1b5b12bc4550c00dfdaa930 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74585 Tested-by:
-
Nikita Hovratov authored
Not all tables have tstamp defined in their ctrl section. Resolves: #97588 Releases: main, 11.5 Change-Id: Ibddaab2e313bc2511b1f9aa903ed312d3cf7f9bd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74556 Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
Oliver Klee authored
This helps avoid breakage when GeneralUtility will switch to strict mode. Resolves: #97579 Relates: #97578 Releases: main, 11.5 Change-Id: I813075a74805b72781a493278e45aa1e9a1e2cc2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74555 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
-
- May 08, 2022
-
-
Oliver Klee authored
In tests for `GeneralUtility` that explicitly violate the contract (and test the correct error handling in those cases), PHPStan errors about the contract violation are not helpful and rather clutter the PHPStan baseline. So these errors are now silenced with an annotation in the corresponding tests, allowing us to focus on PHPStan errors about actual issues. Note: We only use this annotation in tests, not in production code, to avoid silencing errors about actual problems. Resolves: #97574 Releases: main, 11.5 Change-Id: I2586dd77a4e3f9d801e24af68ab29984ad8d02c5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74551 Tested-by:
-
Lina Wolf authored
Releases: main, 11.5 Resolves: #97577 Change-Id: I68f6433a4ae38eb05e24b997cdfcba8b2eb60115 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74554 Tested-by:
-
- May 07, 2022
-
-
Larry Garfield authored
The PHPStan baseline file has several entries for this error. This patch resolves them by adjusting the code so the issue is not relevant. Resolves: #97458 Releases: main, 11.5 Change-Id: Ida192b1168dbf9c9cc3ba7f2ca9e635187137a05 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74553 Tested-by:
Nikita Hovratov <nikita.h@live.de> Reviewed-by:
-
Stephan Großberndt authored
Avoid a postgresql error when previewing a page from the backend which has an access protection by a fe_group due to PreviewSimulator faking a fe_user with uid PHP_INT_MAX and sql failure to update the is_online status of this fake user in PostgreSQL as column fe_users.uid is of type integer and thus has max value of 2147483647 instead of PHP_INT_MAX. Releases: main, 11.5, 10.4 Resolves: #97564 Change-Id: I16c866c368a9b3f5ac6bdfacf2c6660a7046df5a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74471 Reviewed-by:
-
Andreas Fernandez authored
The argument `$funcName` is now annotated as `non-empty-string|\Closure` to reflect the actual allowed input types. Additionally corresponding test in `GeneralUtilityTest.php` is also annotated properly. Used command: > Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #97568 Releases: main, 11.5 Change-Id: I7ce640d3565f099e6dc5ba62c59e5616dc4dc6e4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74546 Reviewed-by:
-
Stefan Bürk authored
phpstan parallel execution is limited to a maximum of 5 processes to be a nice neighbor when executed during core CI runs. This however leads to longer execution times when executed on local developer machines with many available CPU's. This patch introduces two separated phpstan config file entrypoints, one for local and one for CI. They are automatically selected in runTests.sh based on existence of a CI env variable. Resolves: #97571 Releases: main, 11.5 Change-Id: I14bf13412de7a2471703e7982dad4030ae6ba735 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74536 Tested-by:
-
Christian Kuhn authored
Latest docker:20.10-dind (currently 20.10.15) triggers an error on CI: Error response from daemon: failed to create shim task: OCI runtime create failed: runc create failed: unable to start container process: unable to apply cgroup configuration: mkdir /sys/fs/cgroup/rdma/docker: permission denied: unknown The image is the 'sub-container' in CI on runner hosts, that runs all the test images like the php and database images. This error *may* have to do with sysbox, which is a security layer on runner hosts to separate CI jobs from each other. We however currently don't know exactly what is going on. For the time being, we pin the dind image to its previous verion docker:20.10.14-dind Change-Id: Ie59be69680e1f444c115f2249ca8709bbfdd1e3e Releases: main, 11.5, 10.4 Resolves: #97570 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74542 Tested-by:
-
- May 06, 2022
-
-
Nikita Hovratov authored
In order to fix select fields overflowing into each other when they have very long option titles, the CSS rule "overflow: hidden" has been added. As it seems, this wasn't even necessary as the rule "min-width: 120px" already does the trick. The CSS rule "overflow: hidden" is now removed, which enables the accessibility box-shadows from bootstrap 5 again. Resolves: #97565 Related: #94688 Releases: main, 11.5 Change-Id: Ifd8495430ecdc404fa1dbebe9633ef5f401a6af6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74470 Tested-by:
-
- May 05, 2022
-
-
Patrick Lenk authored
Currently, a user can reset their password, but never gets the information what their username is. Many users forget their login username and reset their password using their email address. This patch adds the username in brackets after the first and last name to the salutation in the recovery email. Resolves: #96705 Releases: main, 11.5 Change-Id: Idb18e13e453edbab8645b079b7573e91191e479b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74469 Tested-by:
-
Oliver Klee authored
a || (b && !a) can be simplified to a || b (because the second sub-condition is only evaluated if a is false). Resolves: #97421 Releases: main, 11.5 Change-Id: I04d62fd46736bb4a0b9dfce54851aaa8f99d20e1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74468 Tested-by:
-
Stefan Bürk authored
Raise phpstan to newest release, which find more things in a proper way. This includes some opcache and autoloading fixes which may hopefully help with lately occurrence of long-running phpstan ci runs. Used commands: > composer req --dev phpstan/phpstan:^1.6.7 > Build/Scripts/runTests.sh -s clean > Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #97551 Releases: main, 11.5 Change-Id: If7493bc4138e99ff173047cba358d3be43cf2357 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74525 Reviewed-by:
-
- May 04, 2022
-
-
Florian Rival authored
"AbstractOEmbedHelper::getOEmbedData()" requests data and decode it as json. json_decode() may fail and thus having a invalid type decoded. In the complete chain this lead to a "access array offset on value type bool" warning. This patch checks the decoded value before returning, thus ensure valid return type is "array" or "null". Furthermore this avoids a signature change of the corresponding method "AbstractOEmbedHelper::getOEmbedData()". Additionally this paves the way for adding proper return type in a dedicated patch. Streamline usage in VimeoHelper along the way. Resolves: #97428 Releases: main, 11.5 Change-Id: Icda6b2baa88ddcbf070ceae75eafcb2e9ccb41f1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74467 Tested-by:
-
J. Peter M. Schuler authored
An exception will be raised, if an upgrade wizard identifier returned by "UpgradeWizardInterface::getIdentifier()" is not valid due to e.g. misspelling. The invalid identifier is now mentioned in the exception message for easier debugging. In addition, the exception is now split up into two separate exceptions in order to define the reason more precisely. Resolves: #97437 Releases: main, 11.5 Change-Id: Ie34ad4e4bb698109e224488ff1b43e2b3d66e7fd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74392 Tested-by:
-
Elias Häußler authored
This patches replaces several wrong or incomplete type annotations in FormDefinition. Additionally, the `$renderables` property is now explicitly declared and annotated as `array<int, Page>` since it only contains pages. Resolves: #97545 Releases: main, 11.5 Change-Id: I182a861276c65142be7266ec7b10420f8532372c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74508 Tested-by:
Björn Jacob <bjoern.jacob@tritum.de> Tested-by:
Elias Häußler <e.haeussler@familie-redlich.de> Reviewed-by:
-
Kevin Appelt authored
Resolves: #97268 Releases: 11.5 Change-Id: I389cb4d076f1595347c1b4c28df8ec84c373c552 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74124 Tested-by:
-
Jochen Roth authored
Currently acceptance tests do not work on arm64 (Apple M1) due to the lack of support in the selenium docker image. This has been fixed by detecting arm64 and switch to arm64 compatible image (seleniarm/standalone-chromium). Resolves: #97541 Releases: main, 11.5, 10.4 Change-Id: I531e7e1d7f0f11a1c6d850699eee3b4a9aa3e5d0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74465 Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
-
Simon Schaufelberger authored
Increase code coverage with some more tests. Resolves: #97444 Related: #97303 Releases: main, 11.5 Change-Id: Icaa20aea45bc34b5618bfc55710014d928444510 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74466 Tested-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Tested-by:
-
Chris Müller authored
Switchable controller actions are removed with TYPO3 12.0. The deprecation note is adjusted to reflect it. Resolves: #97523 Related: #89463 Related: #96282 Releases: main, 11.5, 10.4 Change-Id: Iad04bbb573f2b87ce87a8faabe25c97a8812f937 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74463 Tested-by:
-
Oliver Bartsch authored
Namespaces in the extension scanner files must not contain a leading backslash. Resolves: #97547 Releases: main, 11.5 Change-Id: Idb608b3e02c8901972a068c531ee681e8b2dd49e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74512 Tested-by:
-
- May 03, 2022
-
-
Oliver Hader authored
Calling a site using http://example.org/index.php/invalid/ leads to ~/index.php/whatever/ being used as internal script path, which causes errors or internal side-effects. This behavior seems to occur only on web-servers using Apache with PHP-CGI or PHP-FPM, using PHP setting `cgi.fix_pathinfo = 1`. In case `cgi.fix_pathinfo` is enabled, the current script name is retrieved from `$_SERVER['SCRIPT_FILENAME']` instead. Resolves: #97543 Releases: main, 11.5, 10.4 Change-Id: Ia5f6b705253d42d4fc409b90b21d0363c4b97974 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74506 Tested-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
-
Oliver Hader authored
FileRepository::findByRelation does not apply any workspace context when invoked in backend context. Resolves: #59334 Releases: main, 11.5 Change-Id: I98f3f0640773c7d87879adb2b75cdb92a410bbc3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74503 Tested-by:
-
- May 02, 2022
-
-
Simon Schaufelberger authored
The method parseDataStructureByIdentifier defines that files can also be loaded with the "EXT:" prefix. This is currently not supported and not documented, thus should be removed. The only valid syntax is with "FILE:EXT:" Resolves: #92483 Releases: main, 11.5 Change-Id: I5156c40215753566251c56ca0cbd9b94b66ce4a0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74462 Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
Stefan Bürk authored
rowCount() on result sets for SELECT queries are not reliable across all DBMS, which doctrine/dbal comments in the docblock. See: https://github.com/doctrine/dbal/blob/110ab13/src/Driver/Result.php#L77 Because of "rowCount()"'s unreliable behaviour for some dbms like sqlite, this should be avoided to ensure cross dbms support. '\TYPO3\CMS\IndexedSearch\Domain\Repository\IndexSearchRepository' uses 'rowCount()' in 'doSearch()' which fails on sqlite, making it impossible to get any result in the frontend search. Doing a count() query as replacement is not possible and needs a bigger architectural change, which is not feasable as bugfix. Thus fallback to retrieve the result into an array and counting the array is used as a intermediate solution to ensure index_search is working across all supported database systems. The architectural change will be done in a dedicated patch. Resolves: #97460 Releases: main, 11.5 Change-Id: Id7afa9f95fefbba07acb7c0dda1267dd2fce92db Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74461 Tested-by:
-
- Apr 29, 2022
-
-
Elias Häußler authored
Form elements in the tree component are labelled with the label of the corresponding form element definition, whereas the stage component uses the form element's type. This has now been streamlined to always use the label of the form element definition, since editors might not be interested in (internal) types anyway. Resolves: #97507 Releases: main, 11.5 Change-Id: Ife4c52207957db3cfd1cfa1818ccc9628e36b91c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74488 Tested-by:
waldhacker <hello@waldhacker.dev> Reviewed-by:
-
Torben Hansen authored
symfony/rate-limiter:5.4.8 has been released, so the failing tests commented out with #97298 can be included again. Raised symfony/rate-limiter:^5.4.8 to ensure that broken version is not used. Used commands: > composer req "symfony/rate-limiter":"^5.4.8" > composer req "symfony/rate-limiter":"^5.4.8" \ -d typo3/sysext/core --no-update Resolves: #97494 Related: #97298 Releases: main, 11.5 Change-Id: Idaa17f130a56f3e23c56243f24ecdccc14ac4b46 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74486 Tested-by: -
Oliver Klee authored
Resolves: #97424 Releases: main, 11.5 Change-Id: I9ccac96427c71f65e1922fe7e6ffb376d06d7e02 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74460 Tested-by:
-
- Apr 28, 2022
-
-
Tymoteusz Motylewski authored
The new version finds some new possible bugs. Used commands: > composer require --dev phpstan/phpstan:^1.6.3 > Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #97508 Releases: main, 11.5 Change-Id: I7a813c4f12258aad96b99cec3feb93ee10d55bcf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74482 Tested-by:
-
Björn Jacob authored
The API Reference of the form framework resided inside the docs for integrators. This patch creates a new main chapter "For Developers/ API Reference" and moves all the related content there. In addition, the content has been splitted in three documents. Resolves: #97039 Releases: main, 11.5 Change-Id: Ie626f3ebdd137dfb7aef308b1bf7568dc17de985 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73719 Tested-by:
-
Stephan Großberndt authored
Releases: master, 11.5 Resolves: #97504 Change-Id: I26ff53cc81eefa550e86928a6db6fd6a982a6008 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74477 Tested-by:
-
Larry Garfield authored
The "page" and "pages" translation keys are backwards. This patch makes them forwards. Resolves: #96795 Releases: main, 11.5 Change-Id: I3dde22d5a6f9ae7c62fe8c60156d6131f676a11c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74459 Tested-by:
-
Ralf Zimmermann authored
Adding a new validator to a form element in form editor led to an error if the validator defines additionalElementPropertyPaths. This happened because the initial value of those property paths was not applied to the form element when the validator was added. Therefore, it was not possible to unset those values as they did not exist unless their initial value has changed. With this patch applied, the initial value of validator options is now passed to all properties of additionalElementPropertyPaths as well. Resolves: #97040 Releases: main, 11.5 Change-Id: Ife242a48276789fcad6a47679478b68d79e78e6b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74445 Tested-by:
-
Stefan Bürk authored
sqlite basicly knows about two kind of autoincrement column definition. One which is an alias on the provided "row_id" field for an integer field which is also the single field of the primary key index. And the second one with a real autoincrement notation, which is not an alias like the first one. Basicly this differes in some behaviours, mainly that the second one will never reassign ids which has been deleted. The first one will eventually reassign deleted ids to fill up spaces in between. This counts for inserts where the column data has a null value. If a real value is provided, this will be used. "ext:indexed_search" defines some tables with integer columns which are the primary key, which are not flagged as autoincrement fields. This is not needed as the inserted data always uses pre calculated hash values. This works pretty fine on most dbms. sqlite automatically assumes the autoincrement field (row_id) alias type for creation, which works so far pretty well. doctrine/dbal uses 'PRAGMA table_info(<table-name>)' to read the table structure, which do not containts the information if the field is created with the AUTOINCREMENT keyword or not. Reading the table struncture from a sqlite database sets the "autoincrement: true" value for colums of type integer, if they are the only included column of an primary key. On the other side, reading/building the meta schema based on the TYPO3 "ext_tables.sql" files of extensions and using the default table definition building based on TCA, the column will get "autoincrement: false" if the auto_increment keyword is not used. This will popup these tables again and again, as it always will detect the column as changed, because of the not matching column autoincrement value. This patch adopts this assumptions from doctrine/dbal and set the autoincrement to true, if a table has one primary key colum of type integer without a autoincremet flag. This will create the real autoincrement column instead, which is a safer variant for it. doctrine/dbal added this detection based on these assumptions with: https://github.com/doctrine/dbal/commit/33555d36e7e7d07a5880e01 Resolves: #97447 Releases: main, 11.5 Change-Id: I410da0db7a8f0748e5a8ee099cd36ee121cafa60 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74458 Tested-by:
-
- Apr 27, 2022
-
-
Stefan Bürk authored
Recently from time to time phpstan ci runs are failing with following error message: > Reached internal errors count limit of 50, exiting... > Internal error: Child process timed out after 600.0 seconds. > Try making it longer with parallel.processTimeout setting. As a intermediate solution this timeout should be increased. Deeper investigation and maybe finding a solution to avoid such long subprocess run times is the more reasonable way - but to avoid a lot of test failes, better trade a longer runtime in ci than a linger time to find a proper fix for it as a first solution. Resolves: #97490 Releases: main, 11.5 Change-Id: I8f5a23f233024090de32ce4b3272d3800fc0c2ab Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74457 Tested-by:
-
Stefan Bürk authored
composer v2 is no longer an experimental feature of Docker Desktop for MacOS/Windows. Broken composer v2 error message should be updated to give proper actual information how to disable it correctly. Resolves: #97489 Releases: main, 11.5, 10.4 Change-Id: I7c4199e5d3d3c47bbadba8210cc96b0385ab6fcc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74455 Reviewed-by:
-
