- Jul 25, 2023
-
-
Torben Hansen authored
When a domain model object has a lazy loading property (e.g. relation to another domain model object), the `AbstractGenericObjectValidator` may fail validation the domain model, if the database record for the related object has been deleted. This change fixes the problem by adding a null safe operator to the `$realInstance` variable in the magic `__get` call in LazyLoadingProxy. The return type for `_loadRealInstance` has been adapted, since the function actually can return `null`. This allows the removal of an entry in the phpstan baseline file. Additionally a todo in `AbstractGenericObjectValidator` has been removed, since the function actually supports lazy loading proxies as the initial error shows. Resolves: #101400 Releases: main, 12.4 Signed-off-by:
Torben Hansen <derhansen@gmail.com> Change-Id: Ib39da09fdc94ef529f672af7f948d6a7fd82e531 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80104 Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Alexander Schnitzler <git@alexanderschnitzler.de> Reviewed-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
-
Alexander Schnitzler authored
Releases: main Resolves: #101419 Change-Id: I283746f6dd48da89899e987c80f32ca01f492570 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80119 Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
-
- Jul 24, 2023
-
-
Thomas Hohn authored
This change converts class Action to a native backed enum. In addition it's moved to namespace \TYPO3\CMS\Scheduler\ and renamed to SchedulerManagementAction. Resolves: #101129 Releases: main Change-Id: I3752754b021a75cb9873806cb670d1adbc20fce4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79476 Tested-by:
Stefan B�rk <stefan@buerk.tech> Reviewed-by:
-
Sybille Peters authored
Ckeditor 5 is used since TYPO3 12 which has significantly changed how elements in the DOM are handled. The `a` element is handled in the plugin typo3-link, but it did not handle some attributes correctly, specifically: - class - rel - target This resulted in only `href` and `title` being persisted when saving or switching between source and normal mode. This is now fixed, so that all 5 attributes will be handled correctly. Resolves: #101360 Related: #96874 Releases: main, 12.4 Change-Id: I403ec880a24ae582a8c73b2ac2ccae49ffcbc21f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80034 Tested-by:
Benjamin Franzke <ben@bnf.dev> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Mathias Brodala <mbrodala@pagemachine.de> Reviewed-by:
Kevin Appelt <kevin.appelt@icloud.com>
-
Ayke Halder authored
The `redirectMode=refererDomains` configuration allows to process a redirect after a successful login to an evaluated referer value. This patch fixes the evaluation of https urls as referer value. Without this patch only http urls are evaluated correctly. Also do not match hostnames that contain an invalid underscore in name. Additionally the regex matching for the domain was not quoting the configured domain names and thereby matching dots as 'any single character' instead of a dot. Resolves: #100215 Releases: main, 12.4, 11.5 Change-Id: I589638d82627283b5acdeec5da0243e082cc5ebf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78883 Reviewed-by:
-
Torben Hansen authored
This change removes 3 functions in `BackendUser` domain model which were never used in ext:beuser. The functions were copied to the domain model, when \TYPO3\CMS\Extbase\Domain\Model\BackendUser was deprecated in extbase. Resolves: #101422 Related: #101420 Releases: main Signed-off-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
Stefan Bürk authored
PHP8.3 emits a warning for content handed over to unserialize() which contains superflous content at the end. The silence operator `@` is now used to suppress the test setup unserialize() to avoid this exact warning as preparation for PHP8.3 introduction. Can be verified before and after by executing: > Build/Scripts/runTests.sh -p 8.3 -s unitDeprecated Resolves: #101409 Releases: main, 12.4, 11.5 Change-Id: I5741cd86e8e0a8afedb49ad01676d0766d5fbfaa Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80109 Tested-by:
-
- Jul 23, 2023
-
-
Torben Hansen authored
The return type of `getConfigurationOption()` is defined as boolean, so the typecast can safely be removed. Resolves: #101412 Releases: main Signed-off-by:
Sybille Peters <sypets@gmx.de> Tested-by:
-
Nikita Hovratov authored
The groups and the sorting are already defined in "itemGroups", which is available since TYPO3 v10. Defining the "--div--" items with the same group label again is redundant and was only kept to not disturb other people's TCA after a non dot-zero release. Resolves: #101358 Releases: main Change-Id: Ida1f99e7a19b460dea1d8968cc547a5b9276a6bb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80030 Reviewed-by:
-
Alexander Schnitzler authored
Releases: main Resolves: #101402 Change-Id: Ic9a6d1dc433de7644d08c2c7ee8c7364c6583f4f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80105 Tested-by:
-
Alexander Schnitzler authored
Type declarations have been introduced for properties and methods. In addition, PHPStan-specific PHPDoc annotations have been introduced to give PHPStan more insights. Releases: main Resolves: #101383 Change-Id: I63e173d4c9d5570c4cc27545b20e6e3ece9fa940 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80084 Tested-by:
-
Torben Hansen authored
The typecasts for `$demand->getBackendUserGroup()` can safely be removed, since the return type is always an integer. Additionally, the todo about refactoring to n:m relations has been removed, since there currently is no plan to refactor the `be_users.usergroup` field to use n:m relations. Resolves: #101416 Releases: main Signed-off-by:
-
Torben Hansen authored
The type of the function argument `$number` is already defined as int, so the following typecast can safely be removed. Resolves: #101413 Releases: main Signed-off-by:
-
- Jul 21, 2023
-
-
Susanne Moog authored
The SilentUpgrade handles changes "under the hood" by migrating old to new settings. If the settings.php is not writable, these changes fail with an exception. As we cannot predict which side- effects non-execution may have, we cannot allow further usage of the install tool before those changes are done. We are now giving the user a better error message and the option to run silent upgrade with the normal CLI upgrade command. Resolves: #101193 Releases: main Change-Id: Id1f201440a9feb0c5e33374cc781893a352a523d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79593 Reviewed-by:
-
Alexander Schnitzler authored
Use early returns to remove if..else cascades which are hard to read. Releases: main Resolves: #101406 Change-Id: I4e4e559ca469d941dbe7a5c4facad265ab00c3f7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80108 Tested-by:
-
Tizian Schmidlin authored
When updating entries, the `updateFields` will provide `uid`, which works fine in MySQL but might lead to problems when working with stricter DBMS. Such an example of a DBMS not liking the update of an identity field, is SQL Server. Now, I know that SQL Server will not be supported in TYPO3 v12 going onward, but on the off-chance that somebody has another DBMS than MySQL or has DBMS that will break when trying to update an identify field, this bugfix might still be valuable. The bug exists back to TYPO3 10 at least. Releases: main, 12.4, 11.5 Resolves: #100175 Change-Id: Id4dd90579191da0cb770490256087209e749deb4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78130 Reviewed-by:
-
Thomas Hohn authored
Enforce that all methods and class variables are strictly typed in: `\TYPO3\CMS\Frontend\Exception\UnableToLinkException` Resolves: #101186 Related: #100119 Related: #100106 Releases: main Change-Id: Ib39cef55f95d9f1071cb8f0d2977324448c649d2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79531 Reviewed-by:
-
Alexander Schnitzler authored
The process of thawing properties didn't properly distinguish between thawing types (int|float|object etc.) and thawing objects. This has been mitigated by first using a match statement on the built in type and handling different types of classes in a separate method. It's easier to read, maintain and extend. Releases: main Resolves: #101405 Change-Id: If85abd7fad12dc97b80b406d26aa528da4bc1588 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80107 Tested-by:
-
Nikita Hovratov authored
With the introduced group and sorting feature for TCA items it was ever since possible to easily define the way items were displayed in select drop-downs. This feature, however, was not considered in the "New Pages" view. This is the view, which allows to create multiple pages at once. For each page it is possible to select the type. This select drop-down now correctly groups and sorts custom page types. For Core types the order was already correct like it is in the TCA definition. To achieve this, the "group and sort" functionality needed to be extracted into an own service. The NewPages template also needed some adjustments, as group labels are already translated by the service. Resolves: #101355 Releases: main Change-Id: I9203085cc816186887048383d96b85cd3c6d3925 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80029 Reviewed-by:
-
Andreas Fernandez authored
Due to color changes in the notifications, the spinner used in deferred actions was barely visible since then. This patch changes the icon identifier to `spinner-circle`, showing a darker spinner again. Resolves: #101399 Releases: main, 12.4 Change-Id: I1f3f8fa83b4c68103376ae154693c4381ce75c25 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80103 Reviewed-by:
-
Nikita Hovratov authored
RelationHandler had an unused property `$fetchAllFields` since TYPO3 11.5.0. The related method `setFetchAllFields` has been removed with it. Resolves: #101398 Related: #94651 Releases: main Change-Id: I6b615cabdb6a7d2ade29162a5732902bd3722a97 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80102 Tested-by:
J�rg B�sche <typo3@joergboesche.de>
-
Oliver Klee authored
Convert an improperly used array shape into a list. Resolves: #101390 Releases: main, 12.4 Change-Id: Ic02efafbb90caa010307716465b3a0adb447544c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80096 Reviewed-by:
-
- Jul 20, 2023
-
-
Stefan Bürk authored
Handling the pages slug changed event has been implemented with a dedicated hook handling class, consuming two DataHandler hooks to prepare and handle the redirect creation and slug update for subpages. Auto redirect creation and subpage slug updating are controlled by site setting configuration options. The chosen second hook `processDatamap_postProcessFieldArray()` is executed before the record is persisted into the database. This change switches to `processDatamap_afterDatabaseOperations()` as the second hook, so handling code can expect to have the changes persisted to the database already. For example, this would allow to use the slug generator in the `updateSlug()` method in a dedicated change as possible solution for #96928. Resolves: #101335 Related: #96928 Releases: main, 12.4 Change-Id: I5a83b6ecb9bebd7d1ebf1f3c704ca2ec2c10aa96 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80010 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
-
Gerrit Mohrmann authored
Site settings have been extracted from `config.yaml` with #99047 by providing a dedicated `UpgradeWizard`. Site settings are now read from the `settings.yaml` in the site configuration folder, if it exists. During editing site configuration within the GUI, the deprecated settings in the `config.yaml` has been updated. That missbehaviour was corrected with #100162. Before these changes, symfony yaml placeholder have been replaced except if the SiteConfiguration have been loaded in edit context or context needing the raw configuraiton (couple of form engine elements). Loaded from `settings.yaml` the placeholder are not replaced anymore. This change now ensures that site settings loaded from the `settings.yaml` are loaded with replacing placeholder again. Additionally, a todo-comment is added to raise some precaution for an eventually coming settings GUI for the `settings.yaml`. Resolves: #101386 Related: #100162 Related: #99047 Releases: main, 12.4 Change-Id: I6c601226b404c1d1180d6702950af2cbd3e41529 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80087 Tested-by:
-
- Jul 19, 2023
-
-
Christian Kuhn authored
Some rather minor script modifications in runTests.sh to prepare #97566 Resolves: #101389 Related: #97566 Releases: main, 12.4, 11.5 Change-Id: I35e2acd7848f5b49c2a1359d2e976cb553d72ac0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80093 Tested-by:
-
Alexander Schnitzler authored
Return and param type declarations have been introduced for all methods stubs of \TYPO3\CMS\Core\Resource\Driver\DriverInterface. Also, method sanitizeFileName() of abstract class \TYPO3\CMS\Core\Resource\Driver\AbstractDriver has been removed. Releases: main Resolves: #101309 Change-Id: I00c2e046fab9dbb840891bae5891a79ece5d4e5f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79884 Reviewed-by:
-
Benni Mack authored
Resolves: #100853 Releases: main, 12.4, 11.5 Change-Id: I8a1284c2c859cde9d114fecbbe9c5a1e38a35c94 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79590 Tested-by:
Frank N�gler <frank.naegler@typo3.com> Reviewed-by:
-
Oliver Klee authored
The variable `$port` in the changed code is an array element from the return value of `GeneralUtility::trimExplode()` with the `$removeEmptyValues` argument set to `true`. Hence it is ensured to not be an empty string. This change should be backported as it otherwise would block improvements for the type annotations of `GeneralUtility::trimExplode()`. Resolves: #101384 Releases: main, 12.4, 11.5 Change-Id: I74ce433495fc3975c11991d21831db0244eacba0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80085 Tested-by:
-
Georg Ringer authored
Just clear potential the page being edited from indexed_search's index. The previous implementation did also take potential child pages, into account, but not the page itself. Resolves: #100877 Releases: main, 12.4, 11.5 Change-Id: I4c8e0c70e68744f629cb1b1c9f62b5f3028502fd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79066 Tested-by:
-
Alexander Schnitzler authored
Return and param type declarations have been introduced for all methods stubs of \TYPO3\CMS\Core\Resource\FileInterface. All implementations of \TYPO3\CMS\Core\Resource\FileInterface need to reflect those changes and add the same return and param type declarations. In case, any of the core implementations are extended, overridden methods might need to be adjusted. The core classes, implementing \TYPO3\CMS\Core\Resource\FileInterface are: - \TYPO3\CMS\Core\Resource\AbstractFile - \TYPO3\CMS\Core\Resource\File - \TYPO3\CMS\Core\Resource\FileReference - \TYPO3\CMS\Core\Resource\ProcessedFile Releases: main Resolves: #101294 Change-Id: I058be67b75619f8f92ee0225424ad2e62c3d7bb7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79883 Tested-by:
-
Christian Kuhn authored
Runtime static `FilePathSanitizer` and stateless `TypoScriptService` can be injected in ext:frontend `RequestHandler`. Also, the `ServiceProvider` entry is useless since the class implements `RequestHandlerInterface`, which sets those classes public. Change-Id: Ia7469d8e4d4f940871c4856d4782d53b70e4cee4 Resolves: #101375 Releases: main Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80076 Reviewed-by:
-
- Jul 18, 2023
-
-
Oliver Klee authored
A route option that is missing should either not be set at all, or it should be `null`, but it will never be `false`. Simplify the test by removing the missing option altogether to make the test more minimal. Resolves: #101382 Releases: main, 12.4 Change-Id: I76359e128b3d9715cf1a3741597ce7830374b613 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80082 Tested-by:
-
Nikita Hovratov authored
These tests verify the regression fix for #101379 Resolves: #101385 Related: #101379 Releases: main, 12.4 Change-Id: Ic98e87038de1c74d25190dc7b659c347e01d900a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80086 Reviewed-by:
-
Nikita Hovratov authored
Since the introduction of customizable page type icons, the fallback icons did no longer work. Only the icon and variations for "contentFromPid" worked. The reason is, that these icons are prefixed with "page" while the other ones are prefixed with the doktype ("1"). This is fixed now by providing an optional argument for the getRecordTypeForPageType method, which takes the type name as parameter. The default is "1". Resolves: #101379 Related: #90042 Releases: main, 12.4, 11.5 Change-Id: Ia4379899642ad477026dd73b1ac0c22b918a1629 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80078 Reviewed-by: -
Stefan Bürk authored
With #86859 array lists which can become quite large have been replaced using `$queryBuilder->quoteArrayBasedValueListToIntegerList($idList)` to reduce the consumed placeholders. However, one replacement removed accidently the wrapping `->in(...)` expression. This has been detected during the backport process, which means that we need to restore this only for `main`. Backports have been fixed directly. Resolves: #101381 Related: #86859 Releases: main Change-Id: I1f23179408e660c40346aaff1259a8a755d9378f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80081 Tested-by:
-
Stefan Bürk authored
The main query execution builds a QueryBuilder instance out of different sub information. Additionally, several hooks can be used to influence the created query. On top of this, different type of search queries are possible. This change avoid consuming a lot of placeholder for list based `in()` expressions by using a corresponding QueryBuilder method suitable for the value type. This means that no placeholder are used any longer for list expressions. Note: Max query size may still be exceeded if the lists would getting bigger. This can be adjusted by database server administrators, but will lead to another exception for really large value lists. Resolves: #86859 Releases: main, 12.4, 11.5 Change-Id: Ic0ac51c13cb74a058d71152ad626c484f696b176 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79913 Reviewed-by: -
Oliver Klee authored
Resolves: #101378 Releases: main Change-Id: I9b8006f65b0805185dc189dce8e19024497326d2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80009 Tested-by:
-
Stefan Bürk authored
RegEx redirects have been processed in the order how they have been inserted into the database ignoring the flag `respect_query_parameters` completely. Due to this fact, a non-query argument based regex redirect would match before a concrete query-argument aware regexp redirect have been matched - additionally favored by the changes introduced with #96480 to provide a fallback. To combine all use-cases and additionally fix the detected issues, this change now splits the cached regex redirects into two flavors: * `regexp_respect_query_parameters` * `regexp_flat` That follows the pre-selection for the non-regex redirects. Redirects respecting query paramaters have higher precedence above the non-respecting once. Therefore, the matching flow in the `RedirectService` has been aligned correspondingly to respect this separated workflow. The #96480 is now only applied for regex redirects which do not respect query-arguments at all. It should be considered if we should remove that safety fallback and enforce correct regex redirects in a dedicated future change. Furthermore, a deterministic sorting criteria chain has been added to the `RedirectCacheService` to ensure a deterministic loading and caching order of redirects. The changes play together, which is the reason why they are included in one change and to avoid a inbetween incorrect test chain. Regression tests have been added to cover the cases. Resolves: #101191 Related: #96480 Releases: main, 12.4, 11.5 Change-Id: I9638835c33809e92ba883efb65d86bb1e9f5031b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79967 Tested-by:
-
Oliver Klee authored
Add native type declarations and first-class callables for improved type safety and readability. Resolves: #101328 Releases: main Change-Id: I2a67f807a39826b756685a75be654ccd05d261bb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80003 Tested-by:
-
Oliver Klee authored
Resolves: #101376 Releases: main Change-Id: I8d091d11cb1eb1cc633364ced2af8f14538df527 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80077 Tested-by:
-
