Change-Id: Id732c8b5d1207f6febe11513535560261146f9d5
Reviewed-on: https://review.typo3.org/24231
Reviewed-by: TYPO3 Release Team
Tested-by: TYPO3 Release Team

Sometimes a file has incorrect content and incorrect permissions.
Now both warnings are shown at the same time.

Resolves: #52405
Releases: 6.2
Change-Id: I8c36db5f42456ef9491dc1329dc7e0b22b815395
Reviewed-on: https://review.typo3.org/24179
Reviewed-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring

Make removeObsoleteLocalConfigurationSettings only rewrite the
file if something has changed.

Resolves: #52437
Releases: 6.2
Change-Id: I014fa04659d1ca8435d576c85ab039a9ee0bf92b
Reviewed-on: https://review.typo3.org/24221
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring

* Restyle toggle-groups with a more t3skin-like visual.
* Restyle "All configuration":
  * no more "green success boxes" per item, but instead
    alternating background.
  * no more horizontal rulers in between.
  * Clicking in the explanatory text in some item will focus the
    corresponding input-field.
* Submit buttons in "All Configuration" and "Configuration
  Presets" are now always visible due to them sticking to the
  bottom of the scrollable area.
* Use CSS3 gradients in buttons instead of background images.

Related: #52087
Resolves: #38701
Releases: 6.2
Change-Id: I1abfb42273bcb9f60c3feef9fcfbb411585c63bf
Reviewed-on: https://review.typo3.org/24187
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring

This reverts commit 5fbbb8b6

If no signal is registered, the original markers are lost. Needs rework.

Change-Id: Ib043b731af526de685c8d06927459ff069be14a9
Reviewed-on: https://review.typo3.org/24227
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring

During silent updates the only file that can be influenced is
LocalConfiguration.php. If values are available in
AdditionalConfiguration.php, those take precedence, but can not be
overridden by the updater. This can lead to endless loops, because
preconditions are never met.

So silent update relies now only on values in LocalConfiguration.
For values in AdditionalConfiguration.php the user must take full
responsibility.

Change-Id: I5b450f0cf09f09bd3bb35a519b5b8d6b33e650ac
Resolves: #52338
Releases: 6.2
Reviewed-on: https://review.typo3.org/24140
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Markus Klein
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny

Currently its not possible to have signales handle parameter of slots
as a reference. Because of this its not possible to add marker in the
emit. With this patch the parameter containing the markers is taken
after process and then the markers get handed over to the reference
again.

Resolves: #51892
Releases: 6.2
Change-Id: Id6f92195608ca8684fdbfe911b193789055d6775
Reviewed-on: https://review.typo3.org/23728
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring

Change-Id: Iaa92566c53301e49396fc9fb26b0b339c48d567b
Resolves: #52360
Releases: 6.2
Reviewed-on: https://review.typo3.org/24212
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring

IE9 and later understand CSS3 features which we use in the Install
Tool. Make sure IE don't fall back into IE7 mode.

Resolves: #52413
Releases: 6.2
Change-Id: I48933d44e63a59deac131a7cbfeda38fc77aafff
Reviewed-on: https://review.typo3.org/24186
Reviewed-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny

The Install Tool checks for permissions in it's folder structure.  A
folder (typo3temp, uploads, fileadmin) not being writeable now is an
Error and not only a Warning thus displaying a red badge in the Install
Tool main menu.

Resolves: #52407
Releases: 6.2
Change-Id: I6de5f2eace4ecdf089848efbf063a82302aea093
Reviewed-on: https://review.typo3.org/24180
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

If $TYPO3_CONF_VARS['FE']['defaultTypoScript_constants'] or
$TYPO3_CONF_VARS['FE']['defaultTypoScript_setup'] are set through
the PHP code, cached TS will not be found in cache. This would
result in TS parsing every time when there are USER_INT objects
on the page. It may slow down the page with USER_INT objects
by about 300% comparing to the cached version.

This change is re-added after it got reverted due to lack of reviews in
Ia0fd65a35897c71d60c48c0b03098ce67ad16c70.

Change-Id: Ief3a065451644423b236489729716b906f3d4500
Resolves: #43540
Releases: 4.5, 4.7, 6.0, 6.1, 6.2
Reviewed-on: https://review.typo3.org/18072
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert

Similar to the environment status the number of folder structure
errors are now shown in the left menu.

Change-Id: I665c32e8a3c4389941437a2bb6caeb32b862b673
Resolves: #52368
Releases: 6.2
Reviewed-on: https://review.typo3.org/24136
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Markus Klein
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

During installation it may happen that the folder structure reports
errors during creation, but still creates the main folder structure.
This is the case for example if the document root or fileadmin
is a link and not a directory. In those cases the installer does not
create a LocalConfiguration and shows the first step again. It will
stop with a "ENABLE_INSTALL_TOOL" file missing message afterwards.

This is better sanitized with the patch: If the folder structure
reports errors but still successfully created a typo3conf folder, the
LocalConfiguration is also created and the next step is called after
redirect.

Furthermore, two possible warnings are caught in the folder structure
and adapted status messages are created.

Change-Id: I54d99f826336c513641028f29d389da845d7d26a
Resolves: #52367
Releases: 6.2
Reviewed-on: https://review.typo3.org/24135
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

The document root folder may not have correct permissions and
they can not be fixed if the owner is not the executing webserver
user.

This is a common issue during installation, currently the first
step breaks if permission on document root are not 2770 and the
folder is not owned by the executing webserver user.

The patch adds a new option "targetPermissionRelaxed" to
DirectoryNodes and uses it on the RootNode to lower the severity
if permissions are not correct. The installation will proceed
then as long as sub folders can be created.

Change-Id: Ibde9f7ff0dde14502ac24fdb73c0a2ed384119a6
Resolves: #52356
Releases: 6.2
Reviewed-on: https://review.typo3.org/24130
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog

Add missing files that got lost during conflict resolving

Change-Id: If9fc0e23aba97659222bee0c5b2205c5030411fc
Resolves: #51835
Releases: 6.2
Reviewed-on: https://review.typo3.org/24129
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Sometimes extensions depend on customized versions of other
extensions or on extensions that aren't released to the TER.

This feature allows an extension to deliver it's own dependencies
by having the unpacked extensions inside the folder
Initialisation/Extensions. The extensions are then copied to
typo3conf/ext when resolving the dependencies.

Resolves: #51835
Releases: 6.2
Change-Id: I66f6e5d5d40e11471f9766ac2ed9d0eb5386eb49
Reviewed-on: https://review.typo3.org/23672
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind

Due to a superfluos try-catch block dependencies for TYPO3 and
PHP version were not checked correctly.

Additionally the TER version comparison was wrong as it did not
include the given version (only less or greater was checked, not
...OrEqual).

Resolves: #48809
Resolves: #51730
Resolves: #51182
Releases: 6.2, 6.1, 6.0
Change-Id: I773e1af014cd3e8525794c2fcdc615ea8a5f36a1
Reviewed-on: https://review.typo3.org/23673
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

Some methods within FolderStructure class hierachy are public
but should be used internally only. The patch protects them.

Change-Id: I273f829f29ca4f5a6da1d03f028be7a8500e222b
Resolves: #52354
Releases: 6.2
Reviewed-on: https://review.typo3.org/24123
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog

The folder structure definition can be simplified a bit if target
content of files is not stored in the structure definition array
but moved to template files. This also enables handling of binary
files.
The patch implements an option 'targetContentFile' to FileNode and
adapts the current FolderStructure definition to use it.

Change-Id: I097e87a1f7a16e325b398468286fe661abec3553
Resolves: #52351
Releases: 6.2
Reviewed-on: https://review.typo3.org/24122
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog

This patch initializes the extension name in the configuration manager
as soon as it is available during an Extbase command line request.

Resolves: #51329
Releases: 6.2, 6.1, 6.0
Change-Id: I73b0f0e7a0b20e1773c9eb92f0d2175416ce2bb1
Reviewed-on: https://review.typo3.org/23883
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring

This adds an extra column to the record table in
the recycler module so users can sort by that
value and come quicker to the decision whether
to recover that record or not.

Resolves: #52324
Releases: 6.2
Change-Id: Ife1d985f517f7ae5e9be419783e1132b532cabef
Reviewed-on: https://review.typo3.org/24115
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers

Properly check for array-type before accessing
or counting the variable.

Resolves: #52045
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Change-Id: Id161fddadbbcadd462de36e8227278107f2e7a3a
Reviewed-on: https://review.typo3.org/23857
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
Reviewed-by: Markus Klein
Tested-by: Markus Klein

This change adds a table cf_cache_hash for clear cache by tag
for example for cached menu.

Resolves: #51588
Releases: 6.2, 6.1, 6.0
Change-Id: I18b8aad3ac82737bbc52d4aae49be9028b6df944
Reviewed-on: https://review.typo3.org/23624
Reviewed-by: Tymoteusz Motylewski
Tested-by: Tymoteusz Motylewski
Reviewed-by: Piotr Molewski
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

The Javascript functions jumpToUrl(URL,anchor) and jumpToUrl(URL,formEl)
cannot be used interchangeably. This leads to a javascript error,
because the formElement is rendered as string
("[object HTMLInputElement]").

Resolves: #50437
Releases: 6.0, 6.1, 6.2
Change-Id: I53e1be3c157a2ef6c646f02af15e8c746b6e6375
Reviewed-on: https://review.typo3.org/23889
Reviewed-by: Eric Chavaillaz
Tested-by: Eric Chavaillaz
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Henrik Ziegenhain
Tested-by: Henrik Ziegenhain
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

* To show the item, SYS/lang/cache/clear_menu has to be manually
enabled, and a (not documented) userTSconfig option must be set.
* The item *never* worked since the underlying LanguageCacheClearer
class expects an array with cacheCmd set to either "all" or
"temp_cached", that is not set in the according AJAX call of the
menu action.
* Class LanguageCacheClearer hooks into DataHandler and is only
triggered on clear "all" cache.
* Clearing "all" cache flushes all caches anyway, so the hook
currently triggers flushing the language cache a second time.
* SYS/lang/cache/lifetime is unused and can be removed.

Since the functionality is broken, not documented, obsolete and
"internal" code of ext:lang, the whole thing is removed without
further deprecation.

Change-Id: Ic0d19bf31109832c9ed88d81d883516c109cf47e
Resolves: #52312
Releases: 6.2
Reviewed-on: https://review.typo3.org/24077
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

Some methods in boostrap silently change TYPO3_CONF_VARS to adapt
some settings. Those methods are moved to the install tool as
"silent upgrade" to write out configuration options.
The silent upgrade code within StepController is extracted to
an own class for better encapsulation.

Change-Id: Id68bfdce7ffb661fb341e21eb8a26a03fe76ac07
Resolves: #52287
Releases: 6.2
Reviewed-on: https://review.typo3.org/24060
Reviewed-by: Thomas Maroschik
Reviewed-by: Wouter Wolters
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

If pi_flexform is converted to an array already, checking via strlen
produces a warning. An additional check via is_string suppresses the
warning.

Resolves: #52091
Resolves: #51684
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Change-Id: I97c41cdedb1afb28e2a9ca39e1d9cfb3921d9f47
Reviewed-on: https://review.typo3.org/24018
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Markus Klein
Tested-by: Markus Klein

If you group an property with annotated @lazy option
f:groupedFor-ViewHelper can't group by this property.

Resolves: #52266
Releases: 6.2, 6.1, 6.0
Change-Id: Ie208b67eec8500fee87ee1c62b1bd348c0ed5598
Reviewed-on: https://review.typo3.org/24050
Reviewed-by: Xavier Perseguers
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

Some systems allow to connect with empty username / password
configuration to the database. Although this is not wrong the install
tool should always ask for database credentials for new installations.
This patch prevents the install tool from setting an empty username and
password as default values without manually submitting the form.

Resolves: #51540
Resolves: #51956
Releases: 6.2
Change-Id: Ic245635bf649f4ad477d793eda658096ed659aa0
Reviewed-on: https://review.typo3.org/23866
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Markus Klein
Tested-by: Markus Klein

Change-Id: I6f6c8a2ddc26a6c7584e6a067c887768cf3ae5b1
Resolves: #52316
Related: #52305
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/24084
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

The extbase reflection and object caches are "stable" cache entries
and only need to be deleted if extensions change or are updates. The
extension manager takes care of flushing in this case.
Currently, the default lifetime of those cache entries is only one
hour, so they are recalculated pretty often. This is especially a
problem if the site was not accessed for more than an hour, since
tons of cache entries exceeded their lifetime and require
recalculation.
The patch moves the cache configuration of the required extbase
extension to DefaultConfiguration and sets unlimited default
lifetime for object and reflection cache.

Change-Id: I671692645aeb104f7fa73595cc79b25ed5984b85
Resolves: #52305
Related: #51116
Related: #52304
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/24069
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

The language cache by default uses the FileBackend to store its data.
Language cache entries need to be deleted only if new extensions are
loaded and if new language overlays are fetched. They do not need
tagging and can have an unlimited lifetime.
Switching to SimpleFileBackend removes the tagging and sets unlimited
lifetime by to reduce read and write load on this cache.

Change-Id: I5c4778f4c38ae369b6873574e961fa65208d77a1
Resolves: #52295
Related: #52125
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/24064
Reviewed-by: Wouter Wolters
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Thomas Maroschik
Tested-by: Thomas Maroschik
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

On first installation only existing empty databases can be selected.
The hint for "Existing tables will be removed" is obsolete.

Change-Id: I05c0fb460672b8b4bbffe321945c46d2c7be2b2f
Resolves: #52314
Releases: 6.2
Reviewed-on: https://review.typo3.org/24078
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

The MessageDisplay class that is used to display a hint in the extension
settings of the dbal extension was removed with commit
2e3c9d5e.

This commit re-adds the class to prevent a PHP error.

Resolves: #52167
Releases: 6.2
Change-Id: I1fa8749ffb93eab45646948ff336bf3d331aa92c
Reviewed-on: https://review.typo3.org/23949
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Change-Id: I856db58b5843615ddae80e5f978de79981027711
Resolves: #52270
Releases: 6.2
Reviewed-on: https://review.typo3.org/24056
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

docs.typo3.org is new official documentation platform supporting both
OpenOffice and Sphinx manuals.

Fixes: #52226
Releases: 6.2, 6.1, 6.0
Change-Id: Ie5f27bf15f5174a6e1bb53bedd575ceeb362add8
Reviewed-on: https://review.typo3.org/24017
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers

Exporting arrays for caches is now done with var_export().

Resolves: #51116
Releases: 6.2, 6.1, 6.0
Change-Id: I7519fd9c2ab21cc22a3f4e092b611c6bca58c30f
Reviewed-on: https://review.typo3.org/23969
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Helmut Hummel
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Exception code "1314354065" is used twice: once in the abstract
Resource repository and the other one in the File Collection repository.
Since exception code must be unique, the patch simply renames one
occurrence.

Change-Id: I41474db5de7e8f575275d57e9585252857334ee2
Releases: 6.0, 6.1, 6.2
Resolves: #52243
Reviewed-on: https://review.typo3.org/24038
Reviewed-by: Kilian Hann
Tested-by: Kilian Hann
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers

There are two very weird settings is GFX array that previously
decided on how "masks" are applied to images if combining
multiple images. GFX/im_negate_mask and GFX/im_imvMaskState are
also manipulated during boostrap and depend on each other.

Fiddling with those settings in ImageMagick 6 and GraphicsMagick
with its supported versions, it turns out that they are obsolete
and can be removed completly. The patch does this.

Change-Id: Ic24c877287382f9e718974a0df3577dad2eeaac9
Resolves: #52088
Releases: 6.2
Reviewed-on: https://review.typo3.org/23880
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

The new property mapper is enabled by default now.
Due to this the hint inside the exception is misleading.
It hints now to the new @ignorevalidation annotation.

The old one annotation will stay.

Change-Id: I6a7f213f38a72a3b7676af5b1bf07f879fb99253
Resolves: #52198
Releases: 6.2
Reviewed-on: https://review.typo3.org/23999
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer