Skip to content
Snippets Groups Projects
  1. Jan 22, 2024
  2. Jan 21, 2024
  3. Jan 20, 2024
  4. Jan 19, 2024
    • Marcin Sągol's avatar
      [TASK] Sort table and field list in DB Check module by labels · 566c6d60
      Marcin Sągol authored
      When we use DB Check module and our project has large number of
      tables configured in the TCA it is often hard to quickly find on the
      select list the one we are interested with.
      
      This commit adds small changes to `DatabaseIntegrityController` to:
      - sort (ASC) available tables list by table label
      - if table label is not defined, use raw table name wrapped with [...]
      - sort (ASC) fields defined for table by their labels
      - if field label is not defined, [FIELD: xxx] is used as before
      
      Examples for table label
      
      $GLOBALS['TCA']['sys_file']['title'] = 'Label';
      - result without debug mode enabled in the BE: 'Label'
      - result with debug mode disabled in BE: 'Label [sys_file]'
      
      $GLOBALS['TCA']['sys_file']['title'] = '';
      - result without debug mode enabled in the BE: '[sys_file]'
      - result with debug mode disabled in BE: '[sys_file]'
      
      Examples for field label
      
      $GLOBALS['TCA']['sys_file']['title']['columns']['field']['label'] = 'Label';
      - result without debug mode enabled in the BE: 'Label'
      - result with debug mode disabled in BE: 'Label [field]'
      
      $GLOBALS['TCA']['sys_file']['title']['columns']['field']['label'] = '';
      - result without debug mode enabled in the BE: '[FIELD: field]'
      - result with debug mode disabled in BE: '[FIELD: field] [field]'
      
      Resolves: #98110
      Releases: main, 12.4
      Change-Id: I6511ee44f2503b9908a9bdc9f06b508c2f049483
      Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82480
      
      
      Tested-by: default avatarAndreas Kienast <a.fernandez@scripting-base.de>
      Reviewed-by: default avatarAndreas Kienast <a.fernandez@scripting-base.de>
      Tested-by: default avatarcore-ci <typo3@b13.com>
      566c6d60
  5. Jan 18, 2024
  6. Jan 16, 2024
  7. Jan 14, 2024
  8. Jan 12, 2024
    • Stefan Bürk's avatar
      [BUGFIX] Update doctrine/dbal to ensure performance bugfix · c17e7978
      Stefan Bürk authored
      Doctrine DBAL 3.7.0 introduced a performance issue [1]
      which has been already fixed by the Doctrine Team [2].
      
      This change updates the `doctrine/dbal` composer constraint
      to ensure that this performance issue is gone.
      
      Note:   The monorepo composer.lock already containted the
              3.7.2 bugfis release, therefore this has not been
              detected in casual core development. This update
              is to mitigate the performance issue at all costs
              for TYPO3 users.
      
      As a sideeffect, this should put `composerInstallMin`
      nightly function tests on speed again.
      
      Used command(s):
      
      > composer require --no-update --no-install \
          -d typo3/sysext/redirects \
          "doctrine/dbal":"^3.7.2" ; \
        composer require --no-update --no-install \
          -d typo3/sysext/core \
          "doctrine/dbal":"^3.7.2" ; \
        composer require --no-update --no-install \
          -d typo3/sysext/install \
          "doctrine/dbal":"^3.7.2" ; \
        composer require --no-update \
          "doctrine/...
      c17e7978
    • Benni Mack's avatar
      [BUGFIX] Use DataHandler->log consistently · 8889d55b
      Benni Mack authored
      When using DataHandler->log, the format changed
      to using an associative array as $data, whereas
      the message then contains PSR-3 compatible log
      strings.
      
      This was handled in TYPO3 v12 but a few
      places around Workspaces were missed.
      
      This patch adapts these places.
      
      Resolves: #102827
      Related: #97556
      Releases: main, 12.4
      Change-Id: Id871d65a52243489d7434025850438e0f7aeb670
      Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82391
      
      
      Reviewed-by: default avatarBenni Mack <benni@typo3.org>
      Tested-by: default avatarBenni Mack <benni@typo3.org>
      Tested-by: default avatarcore-ci <typo3@b13.com>
      8889d55b
    • Benni Mack's avatar
      [BUGFIX] Allow SelectItem to be used in registerPlugin syntax · 994d152d
      Benni Mack authored
      With TYPO3 v12, the SelectItem API was introduced to
      allow an associative array for registering items in TCA
      select. However, it was forgotten to be added in
      registerPlugin and addPlugin, which is now
      supported as well to be consistent around TYPO3 Core,
      and the new API.
      
      As an addition, Extbase plugins can now also add a description
      in order to have feature parity with Core API.
      
      Core plugins such as indexed search now utilize description
      and group, moving "EXT:indexed_search" plugin into the
      forms group for consistency reasons.
      
      Resolves: #102826
      Related: #99739
      Releases: main, 12.4
      Change-Id: Ifcfc5f8ce482fab3203fe6a9591cc152d0a4261a
      Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82390
      
      
      Tested-by: default avatarBenni Mack <benni@typo3.org>
      Tested-by: default avatarcore-ci <typo3@b13.com>
      Reviewed-by: default avatarBenni Mack <benni@typo3.org>
      994d152d
  9. Jan 11, 2024
  10. Jan 10, 2024
    • Stefan Bürk's avatar
      [TASK] Avoid invalid datetime database default in a test · 036c2e36
      Stefan Bürk authored
      With #102479 support for persisting datetime_immutable
      object has been ensured and covered with a functional
      test. However, using a empty string as default for a
      not nullable datetime field is invalid for MariaDB and
      MySQL which seemed to work until now in test executions.
      
      Something has changed, but had no luck to find any traces
      in the mariadb, mysql or corresponding docker hub changelogs
      and commits explaining this.
      
      The TYPO3 default TCA schema creates nullable fields with a
      null default for `date, datetime and timestamp` anyway, and
      therefore we now use that for the test case table structure.
      
      It make sense to test a valid structure if working state is
      expected.
      
      Note:   It seems that core ci is not blocked by this yet,
              however local execution are broken. To verify with
              and without the change use following command(s):
      
          > Build/Scripts/runTests.sh -u
          > Build/Scripts/runTests.sh -s functional -d mysql \
              typo3/sysext/core/Tests/Functional/Database/
      
      Resolves: #102807
      Releated: #102479
      Releases: main, 12.4
      Change-Id: Ide32b3f9dc4b049ff5c3982997c85a0bb01e2fce
      Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82388
      
      
      Tested-by: default avatarcore-ci <typo3@b13.com>
      Reviewed-by: default avatarStefan Bürk <stefan@buerk.tech>
      Tested-by: default avatarStefan Bürk <stefan@buerk.tech>
      036c2e36
    • Oliver Bartsch's avatar
      [BUGFIX] Properly handle unknown link type · 931fc9a7
      Oliver Bartsch authored
      In case an invalid link type is used in
      a link field, the link browser does no
      longer throw an exception but instead
      displays a flash message with the
      corresponding information.
      
      Additionally, an undefined array key access
      is resolved, which might happen e.g. in
      case such invalid link is being analyzed
      by link validator.
      
      Resolves: #102804
      Releases: main, 12.4
      Change-Id: I5ad35ff46360cc4b27556b8e2c75da69ecbe76d9
      Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82387
      
      
      Tested-by: default avatarcore-ci <typo3@b13.com>
      Reviewed-by: default avatarNikita Hovratov <nikita.h@live.de>
      Tested-by: default avatarNikita Hovratov <nikita.h@live.de>
      931fc9a7
  11. Jan 09, 2024
  12. Jan 08, 2024