- Mar 24, 2014
-
-
Marc Bastian Heinrichs authored
Before version 4.7 you could build up a section index with links to content elements with hidden headers. Since version 4.7 elements with a hidden header type are sorted out for the section index, overriding the extra flag "sectionIndex", which is especially integrated for this. This patch adds a extra flag for menu configuration sectionIndex named "includeHiddenHeaders" to make it possible to re-enable the behaviour of versions before 4.7. Resolves: #52928 Related: #31767 Documentation: #53699 Releases: 6.2 Change-Id: Iee7f20cfc317c2b624dfc440811c5edc0a367a1e Reviewed-on: https://review.typo3.org/24876 Reviewed-by: Markus Klein Tested-by: Markus Klein Reviewed-by: Wouter Wolters Reviewed-by: Sebastian Fischer Reviewed-by: Jigal van Hemert Tested-by: Jigal van Hemert
-
Helmut Hummel authored
Unit tests have been forgotten to be adapted, so fix them now to make travis happy again. Also remove the superfluous constructor in InstallUtility, as both dependencies are injected anyway. Resolves: #57247 Related: #57199 Releases: 6.2 Change-Id: I40c39705c2db546b38d94936feac2c8757eed8da Reviewed-on: https://review.typo3.org/28722 Reviewed-by: Helmut Hummel Tested-by: Helmut Hummel
-
Benjamin Mack authored
In order to know what is going to be installed, the distribution manager should display more information about a single extension, also with a link to configure the distribution, if possible. Releases: 6.2 Resolves: #57212 Change-Id: Ia092ec7b2c5162b33f4fce614415de07ffa2ca47 Reviewed-on: https://review.typo3.org/28677 Reviewed-by: Xavier Perseguers Tested-by: Xavier Perseguers Reviewed-by: Helmut Hummel Tested-by: Helmut Hummel
-
Alexander Opitz authored
Add a link to http://wiki.typo3.org/Opcode_Cache in installers system environment check messages. Resolves: #56526 Releases: 6.2 Change-Id: If7314d52426729ce092e281697fbbd67bd6ae9d7 Reviewed-on: https://review.typo3.org/28712 Reviewed-by: Markus Klein Tested-by: Markus Klein Reviewed-by: Jigal van Hemert Tested-by: Jigal van Hemert
-
Helmut Hummel authored
The download queue is build recursively, but if an extension is marked for download, it is added to the queue before its dependencies have been resolved, which leads to a wrong download and installation order of extensions. We also need to add dependency resolving when marking an extension for installation to fix the exact same problem when extensions already reside in the system. Lastly we must take care of flushed class loader caches and trigger a rebuild to avoid fatals. This is done by introducing a signal and registering a method in package manager as slot that set the packages for the class loader to trigger a rebuild of the caches. The parts of this patch that fix dependency handling should be backported to older 6.x branches. Resolves: #57199 Releases: 6.2 Change-Id: Iab343c544bfe2e3e19cbf4c05090eb4994df57b1 Reviewed-on: https://review.typo3.org/28660 Reviewed-by: Sebastian Fischer Reviewed-by: Philipp Gampe Tested-by: Philipp Gampe Reviewed-by: Christian Kuhn Reviewed-by: Xavier Perseguers Tested-by: Xavier Perseguers Reviewed-by: Markus Klein Tested-by: Markus Klein
-
Klaas Johan Kooistra authored
See change: I517c0500cad75cae96fd739f2ff7222db80b42a5 At the end of the Typo3DbQueryParser::parseComparison() method the updated operator for NULL values was no longer passed to the parseDynamicOperand, generating = NULL instead of IS NULL. Solved the issue by adding the operator parameter again. Change-Id: I13c3cecf0bf4c95789032f31ead192b945794484 Resolves: #57130 Related: #55167 Releases: 6.2 Reviewed-on: https://review.typo3.org/28592 Reviewed-by: Markus Klein Reviewed-by: Felix Oertel Tested-by: Felix Oertel
-
Helmut Hummel authored
Trying to access a property if the subject is a string, causes the class loader to be triggered as is_callable is invoked. We can avoid that by checking if the subject is an object or array. We can neglect that is_scalar also returns false for resource types as this will not really happen in practice. Resolves: #56993 Releases: 6.2 Change-Id: I94754cd919acc857cd9a8b8e486080c0bf567112 Reviewed-on: https://review.typo3.org/28586 Reviewed-by: Alexander Opitz Tested-by: Alexander Opitz Reviewed-by: Christian Weiske Tested-by: Christian Weiske Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
Nicole Cordes authored
The patch adds a new module for the record history view. All calls to the show_rechis.php script are rewritten to use BackendUtility::getModuleUrl() to ensure CSRF protection. Resolves: #56632 Releases: 6.2 Change-Id: I2466c1b08afdd7d987ef38a29500f02641156c07 Reviewed-on: https://review.typo3.org/28205 Reviewed-by: Markus Klein Tested-by: Markus Klein
-
Xavier Perseguers authored
Fixes: #57238 Releases: 6.2, 6.1, 6.0 Change-Id: Icca7e1637387e2ad31a1368abcd59b1bd443255f Reviewed-on: https://review.typo3.org/28705 Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters Reviewed-by: Xavier Perseguers Tested-by: Xavier Perseguers
-
Alexander Opitz authored
This adds the possibility to reset the complete opcode cache in the install tool. This functionality may be needed if you update extensions not via EM and the cache does not stat the files. Resolves: #56987 Releases: 6.2 Change-Id: I540a31a939fdc6305ad0aff9d39f7e424404925d Reviewed-on: https://review.typo3.org/28520 Reviewed-by: Stefan Neufeind Reviewed-by: Ernesto Baschny Tested-by: Ernesto Baschny Reviewed-by: Xavier Perseguers Tested-by: Xavier Perseguers Reviewed-by: Markus Klein Tested-by: Markus Klein
-
Oliver Hader authored
The workspace module in the backend has a check and dependency to the page module in the top frame. To ease debugging of this backend module in a separate browser process, this dependency is encapsulated since JavaScript errors are thrown. Resolves: #57176 Releases: 6.2 Change-Id: I79b4d79ad23d89a70014602d4a04360f709fcab5 Reviewed-on: https://review.typo3.org/28632 Reviewed-by: Oliver Hader Tested-by: Oliver Hader
-
Benjamin Kott authored
Currently the user is not able to recognize that he is working on record relations. These records may be used in several places in the system and the user should be aware of that specific behaviour. In previous versions of TYPO3 there has been a wrapper which highlighted input fields, but had no explanation. This was removed later. To restore the functionality and make it understandable to the user why he should edit the fields wisely, the wrapper has been replaced by a flash message. This explains to the user what happens when the record gets changed. Resolves: #55553 Releases: 6.2 Change-Id: Ic8a41cdb251cfc8d0134e2b53927ff71ddd5e594 Reviewed-on: https://review.typo3.org/27235 Reviewed-by: Stefan Froemken Tested-by: Stefan Froemken Reviewed-by: Markus Klein Tested-by: Markus Klein
-
Helmut Hummel authored
Instead of doing calculations if an invalid class name could still be found and implementing safeguards that our caching layer does not fail with invalid identifiers, we exit early if we find an invalid class name. Maybe PHP will be smart enough at some point not calling an autoloader at all if the class name is invalid anyway so we could the remove this check. By doing a comprehensive check upfront, we can remove the safeguard code for the caching layer. The performance impact of this change breaks down to be lower than 1ms for a regular TYPO3 request. Resolves: #57183 Releases: 6.2 Change-Id: Id38bea6b85fbfd280417adca325411410cd9fb63 Reviewed-on: https://review.typo3.org/28553 Reviewed-by: Thomas Maroschik Reviewed-by: Sebastian Fischer Reviewed-by: Alexander Stehlik Reviewed-by: Markus Klein Tested-by: Markus Klein Reviewed-by: Alexander Opitz Tested-by: Alexander Opitz Reviewed-by: Ernesto Baschny Tested-by: Ernesto Baschny
-
Philipp Gampe authored
Dependecies might be given as empty string, e.g. array ( 'depends' => array ( 'typo3' => '4.5.0-6.2.99', ), 'conflicts' => '', 'suggests' => array ( ), ), This is how the kickstarter used to generate it. Resolves: #57207 Releases: 6.2 Change-Id: I314249f8883ee82fdfa9ee81aca7a526716ccade Reviewed-on: https://review.typo3.org/28671 Reviewed-by: Alexander Opitz Tested-by: Alexander Opitz Reviewed-by: Ernesto Baschny Reviewed-by: Markus Klein Tested-by: Markus Klein
-
Claus Due authored
This change fixes a problem which occurs under these circumstances: * Extension A depends on Extension B * Extension B is currently installed * Extension A is not currently installed * Extension B has composer.json file * Extension B composer.json file contains no "version" attribute or this attribute is empty. When installing Extension A in this case, EM will fail with an error saying "could not resolve dependency for xyz" which is a bit too vague to be helpful. This change fixes this murky error by throwing a much more specific error saying exactly that the error stems from the composer.json file missing a "version" no. Releases: 6.2 Resolves: #57216 Change-Id: I39ab18d6cf35b69600663524827422c732b813cf Reviewed-on: https://review.typo3.org/28683 Reviewed-by: Alexander Opitz Tested-by: Alexander Opitz Reviewed-by: Markus Klein Tested-by: Markus Klein
-
Markus Klein authored
Fixing a wrong phpdoc comment in EnableFileService Resolves: #57226 Releases: 6.2 Change-Id: I3531960084bd950f5803bc2212ac36037558cbe3 Reviewed-on: https://review.typo3.org/28693 Reviewed-by: Markus Klein Tested-by: Markus Klein
-
Christian Weiske authored
Instead of using a file's identifier, the file's name is used to check if it has a valid file extension. This allows FAL drivers to use non-file name related identifiers. Change-Id: I5b870e06f60c9259951a5f20fd69660ab19c49c2 Resolves: #57141 Releases: 6.2 Reviewed-on: https://review.typo3.org/28597 Reviewed-by: Frans Saris Tested-by: Frans Saris Reviewed-by: Markus Klein Tested-by: Markus Klein
-
Frans Saris authored
#51326 introduced a setEvaluatePermissions() method to enable/disable permission checking in the ResourceStorage. But a getter is missing so there is no way to get the current setting. This is needed if you only want to disable the checks temporary and you do not know what the current state is. This changes adds a getter for the evaluatePermissions value so you can fetch the current value. Resolves: #57220 Releases: 6.2 Change-Id: I3fd22c112fb1f251b85d23fd8fa553091e3e3fc4 Reviewed-on: https://review.typo3.org/28690 Reviewed-by: Xavier Perseguers Tested-by: Xavier Perseguers Reviewed-by: Alexander Opitz Tested-by: Alexander Opitz Reviewed-by: Frans Saris Tested-by: Frans Saris
-
- Mar 23, 2014
-
-
Tymoteusz Motylewski authored
Makes clipboard names more meaningful for editors. It also makes "Normal" clipboard name translatable and adds titles with additional description to the clipboard links. Resolves: #57154 Releases: 6.2 Change-Id: I218a70648616eb1d2efca0006411af57c3cff96e Reviewed-on: https://review.typo3.org/28610 Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters Reviewed-by: Stefan Neufeind Tested-by: Stefan Neufeind
-
Pascal Dürsteler authored
As annotated in SwitchBackUserHook.php, the update method is moved into the BackendUserSessionRepository file. Resolves: #57012 Releases: 6.2 Change-Id: I5e127b8e71585e64bd99ae3175655b058162da83 Reviewed-on: https://review.typo3.org/28487 Reviewed-by: Wouter Wolters Reviewed-by: Philipp Gampe Tested-by: Philipp Gampe Reviewed-by: Pascal Dürsteler Tested-by: Pascal Dürsteler Reviewed-by: Stefan Neufeind Tested-by: Stefan Neufeind
-
Xavier Perseguers authored
preparseQuery only takes query's parameters to compute its hash but not the operators used. As such, those two queries result into the same cache hash: SELECT * FROM fe_groups WHERE uid = :uid SELECT * FROM fe_groups WHERE uid IN (:uid) Fixes: #57173 Releases: 6.2 Change-Id: I6a65ba0be81da73f55c2e6a73f508728567064c3 Reviewed-on: https://review.typo3.org/28656 Reviewed-by: Felix Oertel Tested-by: Felix Oertel Reviewed-by: Markus Klein Reviewed-by: Philipp Gampe Tested-by: Philipp Gampe
-
Markus Klein authored
Rename the GeneralUtility class in the Documentation sysext to avoid confusion with GeneralUtility used in the Core sysext. Resolves: #57197 Releases: 6.2 Change-Id: Iff44c713307c86840d60bc9ef5aee67ae9741fa9 Reviewed-on: https://review.typo3.org/28655 Reviewed-by: Xavier Perseguers Tested-by: Xavier Perseguers Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn Reviewed-by: Philipp Gampe Tested-by: Philipp Gampe
-
Francois Suter authored
Check if a given configuration option in the EM really has both a headline and a text, before writing out an empty label. Resolves: #57205 Releases: 6.2 Change-Id: I66c405f255b9bd6ba9b130088732984157cf4152 Reviewed-on: https://review.typo3.org/28665 Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters Reviewed-by: Stefan Neufeind Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
Ernesto Baschny authored
The distribution management looks ugly. Make it usable and not just a raw list. Resolves: #57139 Releases: 6.2 Change-Id: I95eb8dca3cd6b3915839736d18ff3d78e746a30a Reviewed-on: https://review.typo3.org/28615 Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
Stefan Neufeind authored
Parsetime is output either if config.debug is set or if FE-debug is activated in LocalConfiguration. Allow to explicitly override (set to 0) the debugging in TS for cases where you want to output page-objects like a JSON-page or so where Parsetime leads to problems. Change-Id: Ie5588218694219c13f136b5ac928e697ca472cfb Resolves: #57202 Releases: 6.2, 6.1 Reviewed-on: https://review.typo3.org/28663 Reviewed-by: Markus Klein Tested-by: Markus Klein Reviewed-by: Stefan Neufeind Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
Helmut Hummel authored
IndexerServiceTest and ExtensionManagementServiceTest both execute emit signal methods which in turn try to instantiate the SignalSlotDispatcher, which can fail. Resolve this by mocking these methods. Resolves: #57206 Releases: 6.2 Change-Id: I0a239abeb7c94839a413870c58f22ae59fed8470 Reviewed-on: https://review.typo3.org/28666 Reviewed-by: Markus Klein Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
Jost Baron authored
The jquery plugin is not a real external contribution, but was written specifically for TYPO3, so modifying it in the contrib-folder should be ok. Change-Id: I263d827b8e08a83c345b3525c53124483eba5620 Resolves: #57051 Releases: 6.2 Reviewed-on: https://review.typo3.org/28659 Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
Helmut Hummel authored
All core extensions need to benefit from the new Ajax API and will be CSRF protected by that. Resolves: #57196 Releases: 6.2 Change-Id: I8f6f45fc9426a0e9ae15e61670f52b7cf9f461af Reviewed-on: https://review.typo3.org/28654 Reviewed-by: Markus Klein Tested-by: Markus Klein
-
Francois Suter authored
Make all system extensions use localized labels for their configuration options, to make the TYPO3 BE better translatable. Resolves: #57203 Releases: 6.2 Change-Id: I6dcbfc6477ba32037595dbef20d630f6294dde0b Reviewed-on: https://review.typo3.org/28664 Reviewed-by: Xavier Perseguers Tested-by: Xavier Perseguers Reviewed-by: Francois Suter Tested-by: Francois Suter
-
Helmut Hummel authored
Hooks that used the element browser used the JavaScript function jumpToUrl with relative URLs. After refactoring the element browser, it was necessary to compute the absolute URL. To stay backwards compatible we catch this case in JavaScript and rewrite the URL according to the new requirements. By doing so, we can simplify our code again. The method getThisScript might still be needed in Hooks for other purposes, so we make it public. Resolves: #56721 Releases: 6.2 Change-Id: Ieed6d037b428c5c15d18905341ff46dece1d67a7 Reviewed-on: https://review.typo3.org/28618 Reviewed-by: Ernesto Baschny Reviewed-by: Markus Klein Tested-by: Markus Klein Reviewed-by: Stefan Neufeind Reviewed-by: Wouter Wolters Reviewed-by: Helmut Hummel Tested-by: Helmut Hummel
-
Francois Suter authored
The configuration options labels are not translated anymore in the Extension Manger. This is due to a recent refactoring, which encapsulated the translation process in a separate method, but forgot to return the translated value. Resolves: #57198 Releases: 6.2 Change-Id: Ib0051225860c408b00827bf7212835beafbbd2fa Reviewed-on: https://review.typo3.org/28657 Reviewed-by: Georg Ringer Tested-by: Georg Ringer
-
Stefan Neufeind authored
commit 7ccbb22f added ajaxUrls to TYPO3.settings. The functional test needs to be adapted accordingly Change-Id: I24267feaab39f0260db934e2151f33c948036080 Resolves: #57096 Releases: 6.2 Reviewed-on: https://review.typo3.org/28658 Reviewed-by: Helmut Hummel Tested-by: Helmut Hummel
-
Benjamin Mack authored
When rendering the module menu icons, the menu items on the top level (Web, File, User, Admin) don't have an icon, however the getModuleIcon functionality processes them, and checks for getimagesize() even though no image is added. To overcome this, the function needs to be modified slightly to only call getimagesize if there is actually an icon. Releases: 6.2, 6.1 Resolves: #57179 Change-Id: Icb45d53a3a61d308b5ff56612f1b9b9b54245a53 Reviewed-on: https://review.typo3.org/28639 Reviewed-by: Markus Klein Tested-by: Markus Klein Reviewed-by: Stefan Neufeind Reviewed-by: Xavier Perseguers Tested-by: Xavier Perseguers
-
Helmut Hummel authored
This change streamlines the use of Ajax URLs by auto-publishing all Ajax URLs to JavaScript inline settings. All Ajax URLs can now also be looked up in JavaScript by providing the AjaxID like that: var ajaxUrl = TYPO3.settings.ajaxUrls['TxMyExt::process']; All code has been adapted to reflect this change. Resolves: #57096 Documentation: #56347 Releases: 6.2 Change-Id: I4a441f51dcb3551874082077c52918b3fc6a9b0f Reviewed-on: https://review.typo3.org/28602 Reviewed-by: Markus Klein Tested-by: Markus Klein Reviewed-by: Stefan Neufeind Tested-by: Stefan Neufeind
-
- Mar 22, 2014
-
-
Christian Kuhn authored
The patch removes loadConfigurationAndInitialize() from unit test bootstrap and substitutes it with some more fine grained bootstrap calls. In effect, the instance specific LocalConfiguration.php is no longer loaded and removes another depencency from unit tests to the instance. Change-Id: Ia6591fe8d40d530558a514832c8d649c46b4ccc9 Resolves: #57035 Related: #51436 Releases: 6.2 Reviewed-on: https://review.typo3.org/28491 Reviewed-by: Helmut Hummel Tested-by: Helmut Hummel Reviewed-by: Markus Klein Tested-by: Markus Klein
-
Christian Kuhn authored
Some tests of GeneralUtility depend on LocalConfiguration settings and can not easily be mocked in a sane way. They are also not very helpfull and the functionality tested is unlikly to break. They are removed for now. Change-Id: Ic162e950d4df75e1b8aea63a6c547139efabdf15 Resolves: #57185 Related: #51436 Related: #57035 Releases: 6.2 Reviewed-on: https://review.typo3.org/28644 Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn Reviewed-by: Helmut Hummel Tested-by: Helmut Hummel
-
Christian Kuhn authored
With proper mocking in place we no longer need an initialized database to run unit tests. Change-Id: I3913186540bbd1b1419c37132cddaaa34ea9ca34 Related: #51436 Releases: 6.2 Reviewed-on: https://review.typo3.org/28645 Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
Tymoteusz Motylewski authored
In few tests dataproviders have duplicated array keys, which results in some cases not being tested. This patch removes duplicated entries and changes array key names where needed. Resolves: #57180 Releases: 6.2 Change-Id: I68ea38f89ed7f304b57165ca1d225ffdbe2a7a15 Reviewed-on: https://review.typo3.org/28641 Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
Benjamin Mack authored
The output of the distributions should be handled for the introduction package and all other packages. As there is no distinction between official (published by the Core Team) and community-based distributions, the check is done via the username for now, but could be easily modified in one place. Releases: 6.2 Resolves: #57181 Change-Id: I8f2584532dda4738c66bd27e69743bcff91bc422 Reviewed-on: https://review.typo3.org/28640 Reviewed-by: Philipp Gampe Tested-by: Philipp Gampe Reviewed-by: Wouter Wolters Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
Helmut Hummel authored
The autoload registry entry of the form wizard is superfluous now, so remove it. Resolves: #57184 Releases: 6.2 Change-Id: Icc9e7a4791c5a2be95923f2e8bcad980dac611e8 Reviewed-on: https://review.typo3.org/28643 Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters
-