- Nov 23, 2019
-
-
Alexander Schnitzler authored
- Switch the order of constructor arguments $currentPageNumber and $itemsPerPage of both the ArrayPaginator and QueryResultPaginator classes as the $currentPageNumber needs to be set on every object construction whereas the $itemsPerPage argument only needs to be changed for paginators that use a differen amount of items per page other than the default of 10. - Change visibility of properties of both the ArrayPaginator and the QueryResultPaginator from protected to private as both classes are marked final. Releases: master Resolves: #89754 Change-Id: If900c1b786aef7f155bbe0b06cdd167f59e8c9ff Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62418 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Tested-by:
Susanne Moog <look@susi.dev> Reviewed-by:
-
Benni Mack authored
There are various places where TSFE is instantiated, and holding the proper information about a site and the current language. Using the properties from there avoid using $GLOBALS[TYPO3_REQUEST] in "safe" places. Resolves: #89745 Releases: master Change-Id: Id2bb16ce376172bdf563fed0c7ddd0bf84415506 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62379 Tested-by:
-
Sybille Peters authored
The changelog about removing classes from `ext:fluid` is changed to refer to the classes in typo3fluid. This should ease migration. Resolves: #89753 Releases: master, 9.5 Change-Id: Ibf2ce1194427d5b13dca6b7702d3c582813c5b97 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62414 Tested-by:
Sybille Peters <sypets@gmx.de> Tested-by:
Björn Jacob <bjoern.jacob@tritum.de> Reviewed-by:
-
Benni Mack authored
The SystemInformationToolbarItem now has one unified PSR-14 Event instead of the previous signals used by SignalSlotDispatcher. New Event class is called: - TYPO3\CMS\Backend\Backend\Event\SystemInformationToolbarCollectorEvent and provides access to the actual SystemInformationToolbarItem allowing to add messages or new systemInformation blocks by using the API methods there. The existing signals are deprecated, and all existing code is migrated to the PSR-14 event. Resolves: #89750 Related: #89733 Releases: master Change-Id: I249c49f8d24b6e2dc73c2db7b4f7c15c9ccfa3fd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62390 Tested-by:
-
Benni Mack authored
Currently, the Static Route Resolver returns HTTP status code 200 on invalid routes, but a 404 is the correct response. Resolves: #89752 Releases: master, 9.5 Change-Id: Ic7f0cda76777e942ce20fa0577d0c4b0675a69a5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62413 Reviewed-by:
Mathias Brodala <mbrodala@pagemachine.de> Reviewed-by:
-
Alexander Schnitzler authored
This patch introduces native support for pagination of lists such as arrays or QueryResults of Extbase. The main part of this feature is a new PaginatorInterface that defines a basic set of methods a paginator needs to implement. To enable a quick creation of new paginators, an AbstractPaginator class has been created which holds the main pagination logic while the concrete paginator only needs to take care of the concrete data type handling. The PaginatorInterface and the AbstractPaginator allow the creation of futher paginators like one that supports the doctrine/dbal query builder. It's basically possible to create paginators for all sets of items that are countable and which can be transformed into an iterable sub set of given items. The PaginationInterface will also be the foundation for a new type agnostic pagination ViewHelper. Releases: master Resolves: #89603 Change-Id: I46c712d8112ae7dca6caaf0c9476402f6ea5054a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62239 Tested-by:
-
Mathias Brodala authored
Resolves: #88899 Releases: master Change-Id: I775b73eed5b257a65e48f6cc824e0ce855a67f6a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62361 Tested-by:
Ralf Zimmermann <ralf.zimmermann@tritum.de> Reviewed-by:
-
Benni Mack authored
This patch mainly: - Does use statements in all EM code - Removes unused fields "sponsorlink", "sponsorlogo" and "sponsorname" of mirrors XML - Removes unused methods in internal classes It is time to clean up... First one is to get an overview of what is still needed. Resolves: #89751 Releases: master Change-Id: Ie30f05f413afc259fdef6064c363fff47483b331 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62391 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
Björn Jacob authored
Resolves: #84458 Releases: master, 9.5 Change-Id: I0f54f01f2f1adee798c0df7358f61f865039d4e8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60613 Tested-by:
-
Mathias Brodala authored
Resolves: #84203 Releases: master Change-Id: If33c0587881009c378f28112f60a947f0c957cc6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62412 Tested-by:
-
Mathias Brodala authored
Make sure to apply all configured validators if a form is used multiple times on the same page. Resolves: #88730 Releases: master, 9.5 Change-Id: Id2fd63fd83cd2ff657f5bbc3b427147adfd8ab38 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62381 Tested-by:
-
- Nov 22, 2019
-
-
Benni Mack authored
The indexed search plugin is Extbase & Fluid only since TYPO3 v8, and the suffix should be used within the plugin, as this is a technical detail from the past. Resolves: #89749 Releases: master Change-Id: Iaa8d546822da2b444ed81d6c6fc3e497e1e6bb07 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62387 Tested-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Tested-by:
-
Mathias Brodala authored
Resolves: #89747 Releases: master Change-Id: I5cf9038974813dab500934656b49c7a434596c35 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62386 Tested-by:
-
Daniela Pohl authored
The form creation wizard has been improved greatly. This results in a vast enhancement of the user experience. In detail the following changes have been implemented: * The user interface has been visually refurbished and rearranged. * Step 3 - which just stated the successful form creation - has been removed. * Previous steps can now be accessed. * Instead of labeling steps with just a numerical indicator (like "Step x of y") steps now have descriptive labels like "Start" or "Finish!". * Configuration settings did not change in number but are logically structured now. In order to achieve this a new JavaScript module `MultiStepWizard.ts` has been introduced. Check the corresponding .rst files for further information. Resolves: #79445 Releases: master Change-Id: Ia631a411d81b11a21e9b2f682771be536cb01921 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60555 Tested-by:
-
Christian Eßl authored
If multiple storages for form definitions exist and two or more storages have form definitions with the same filename, the latter form definition would not be shown in the list of the form manager. The patch fixes this problem. Resolves: #88539 Releases: master, 9.5 Change-Id: Ifd39a0ba079e7f6bc9a1f800fc63696f4085dbc7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61891 Tested-by:
-
Mathias Brodala authored
Resolves: #89746 Releases: master Change-Id: I641f83199622583e1d52fc1aeb3b2ab78546dd4c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62384 Tested-by:
Daniela Pohl <dpohl@i-d.de> Tested-by:
-
Mathias Brodala authored
Resolves: #89742 Releases: master Change-Id: Iedb8b23b5faf47a23dc2b0147c6cb4c620b3d74f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62375 Tested-by:
-
Benni Mack authored
This change migrates existing Extbase Signal Slots in EXT:core to the new PSR-14 events, which allow to define a proper API for each event fired. The following new Events are in place: - TYPO3\CMS\Core\Imaging\Event\ModifyIconForResourcePropertiesEvent - TYPO3\CMS\Core\DataHandling\Event\IsTableExcludedFromReferenceIndexEvent - TYPO3\CMS\Core\DataHandling\Event\AppendLinkHandlerElementsEvent - TYPO3\CMS\Core\Configuration\Event\AfterTcaCompilationEvent - TYPO3\CMS\Core\Database\Event\AlterTableDefinitionStatementsEvent - TYPO3\CMS\Core\Tree\Event\ModifyTreeDataEvent The following signals are now deprecated: - TYPO3\CMS\Core\Imaging\IconFactory::buildIconForResourceSignal - TYPO3\CMS\Core\Database\SoftReferenceIndex::setTypoLinkPartsElement - TYPO3\CMS\Core\Database\ReferenceIndex::shouldExcludeTableFromReferenceIndex - TYPO3\CMS\Core\Utility\ExtensionManagementUtility::tcaIsBeingBuilt - TYPO3\CMS\Install\Service\SqlExpectedSchemaService::tablesDefinitionIsBeingBuilt - TYPO3\CMS\Core\Tree\TableConfiguration\DatabaseTreeDataProvider::PostProcessTreeData Resolves: #89733 Releases: master Change-Id: I0747c1de3b77a6be2870d87a054522a7df2fdb18 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62331 Tested-by:
-
Benni Mack authored
Calling a URL with type=138 which is not configured should not result in an "page unavailable" but a "page not found" (404) response. Resolves: #86844 Releases: master, 9.5 Change-Id: Iaf739e9bac1b07914aa9e9856bc38a91fe558ed1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62244 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
-
Oliver Hader authored
Introduce additional tests to ensure deflate and inflate handling in VariableProcessor is used in combination. Resolves: #89743 Releases: master, 9.5 Change-Id: I8aef08b5b0c59219ad217f0d8e7dd02e2a5acb7d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62377 Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
-
Christian Eßl authored
Use the form element name for the autocomplete html attribute for honeypot fields to prevent browsers "autofill" feature to fill the honeypot field. Resolves: #89420 Releases: master, 9.5 Change-Id: Ifee039477e1070043fdd0007340a95799dac5b6f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62000 Tested-by:
-
Mathias Brodala authored
The setup of the "form" extension has been restructured. For each validator, form element, and finisher separate files are available. In addition, inheritances have been resolved, which makes existing mixins obsolete. In a subsequent change these mixins will be deprecated as these where actually meant for internal use only but could be used by 3rd party extensions. Due to this change, integrators can easily understand how form objects are defined. Resolves: #84221 Resolves: #84203 Releases: master Change-Id: I1b8d0d67929015ed687335586875fde73b598c13 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62366 Reviewed-by:
Martin Schöne <martin.koske@gmx.de> Reviewed-by:
-
Daniel Goerz authored
A check is added to assure the unserialized content of a be_users uc field is actually an array before passing it to array_walk_recursive(). This is needed because the uc field can also contain null. Resolves: #89638 Related: #89268 Releases: master, 9.5 Change-Id: I9a3d56525b9434522e719d88300240abe9c9c5be Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62368 Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
Christian Eßl authored
The newly introduced BackendUserConfigurationUpdate tries to pass a string value id to the updateBackendUser() function, which requires an integer. This commit solves that problem Resolves: #89683 Releases: master, 9.5 Change-Id: Ieca98c01ec44b7e3a4275d645fa6d25ea09d63a2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62350 Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
-
Oliver Hader authored
Invoking DataHandler in CLI (e.g. when importing data-sets) fails due to flaws in CreateSiteConfiguration which uses $_SERVER as fallback even when it does not contain any web-related information. Thus, hostname and schema prefix is omitted when being called in CLI context. Releases: master Resolves: #89739 Change-Id: Ic8d3e5d4dd81067f2be3fa1d092c180885ba1783 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62370 Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
-
Benni Mack authored
This resolves the most common issues related to PHP 7.4 PHP changes: - implode() argument order - using "{}" instead of "[]" in PHP array keys - PHP notices for invalid array key access Resolves: #89737 Releases: master, 9.5, 8.7 Change-Id: Iff0b8a46279d328f66ae6bab927aef2bca881774 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62367 Tested-by: -
Benni Mack authored
EXT:form consumes migrated Signals in FAL, which should be migrated in order to avoid deprecations. All FAL logic and persistence functionality continues to work as is. Resolves: #89734 Releases: master Change-Id: Ife4785ba73159bf49b7ed76a6705ce5bb2361fac Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62364 Tested-by:
-
Benni Mack authored
When running composer update --prefer-lowest the abandoned package hoa/core could still be installed via codeception/codeception, which in turn results in issues running our test suite. See https://github.com/hoaproject/Protocol/issues/8 This is also needed for PHP 7.4 compatibility. Resolves: #89736 Releases: master Change-Id: I51d2e73875650222bcf9c829cfc684cefd59b612 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62365 Tested-by:
-
- Nov 21, 2019
-
-
Mathias Brodala authored
Resolves: #89730 Releases: master, 9.5 Change-Id: I1754168d86cd9d69d866accee9fc042f8e967490 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62363 Tested-by:
-
Ralf Zimmermann authored
Only use the "allowedMimeTypes" property values from the form definition for the mime type validation of an uploaded file. Resolves: #88238 Releases: master Change-Id: Ic4cfdfc7d6b435e7936e3c312affb775093d856a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60617 Tested-by:
-
Stephan Großberndt authored
This patch adds a safe guard to make sure the `$file` object is not null on trying to update the soft reference. This is necessary as `ResourceFactory->retrieveFileOrFolderObject()` returns null instead of throwing an exception in several cases (e.g. missing form definition located in an extension). Resolves: #89665 Releases: master, 9.5 Change-Id: I09537ddb5a4e9083992ce0fb321f4d81cd279ccf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62314 Tested-by:
-
Benni Mack authored
This change introduces two new API classes relevant for PageTSconfig: - PageTsConfigLoader - PageTsConfigParser The loader class collects all PageTS found in a rootline, which was previously available in two places - BackendUtility and TSFE, although they were similar, they were not the same and error-prone in the past. The previous "TsConfigParser" class had an unusal dependency to the BackendConditionMatcher only, which did not even allow to send in custom arguments. The TSFE part is now also evaluating TSconfig conditions properly, which was not the case in the past. This part is also now cached properly. The TSconfig inclusion ("include from the list of TSconfig inclusions") functionality is now built into the Info module. In addition, the hard-coded "ConditionMatcher" is now seamlessly injected into the parsing process, allowing - Decoupling of Logic and Implementation of parsing in different contexts - Making the ConditionMatcher extensible by having a new ConditionMatcherInterface In the next steps: - the UserTsConfig parsing can be applied separately and split from BE_USER - ConditionMatcher Interface can be used properly - TypoScriptParser can be split up - BackendUtility can be cleaned up further. The following functionality is deprecated: - TYPO3\CMS\Core\Configuration\TsConfigParser - TYPO3\CMS\Backend\Utility\BackendUtility::getRawPagesTSconfig() Resolves: #89718 Releases: master Change-Id: Ibd0a2d086d7e5166f16213fa4aadffd41ecb645c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62349 Tested-by:Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
Benni Mack authored
The next version has PHP 7.4 support and was cleaned up a lot. Used composer command: composer req typo3/testing-framework:~5.0.16 \ --update-with-all-dependencies --dev Resolves: #89725 Releases: master Change-Id: Iba181feb693c9ee61b8792cd0d0197c1e3b1f59a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62359 Tested-by: -
Benni Mack authored
DivSection was used to create GMENU_LAYERS functionality, injecting global inline JavaScript right after the rendered pages' <body> tag. GMENU_LAYERS was removed with TYPO3 v8, however the property was still replaced every single time in the TYPO3 Frontend when a USER_INT was on the page. This is not needed anymore, marking the property as unused. That's why it is deprecated. Resolves: #89722 Releases: master Change-Id: Ia8e3910e20bc28831ba3bdce143812f8acb9d139 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62347 Tested-by:
-
Christian Eßl authored
It is actually possible to unset array property items like select options through the magic "__UNSET" feature of the core ArrayUtility. This should be documented as such. Resolves: #89204 Releases: master, 9.5 Change-Id: I26e5ceea8b526cc4624e0004f3344d7e42b49a71 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61764 Tested-by:
-
Benni Mack authored
TYPO3 Core v10 should rely on Symfony 4.4 (LTS release) and add support for 5.0 automatically. Symfony 4.4 made breaking changes to the Mailer and Mime components which now need adaptions. Used composer command: composer req "symfony/config":"^4.4 || ^5.0" \ "symfony/console":"^4.4 || ^5.0" \ "symfony/dependency-injection":"^4.4 || ^5.0" \ "symfony/expression-language":"^4.4 || ^5.0" \ "symfony/finder":"^4.4 || ^5.0" \ "symfony/mailer":"^4.4 || ^5.0" \ "symfony/mime":"^4.4 || ^5.0" \ "symfony/property-access":"^4.4 || ^5.0" \ "symfony/property-info":"^4.4 || ^5.0" \ "symfony/routing":"^4.4 || ^5.0" \ "symfony/yaml":"^4.4 || ^5.0" --update-with-all-dependencies Loading composer repositories with package information Updating dependencies (including require-dev) Package operations: 0 installs, 27 updates, 0 removals - Updating symfony/polyfill-ctype (v1.11.0 => v1.12.0) - Updating symfony/filesystem (v4.3.1 => v4.4.0) - Updating symfony/config (v4.3.2 => v4.4.0) - Updating symfony/service-contracts (v1.1.2 => v1.1.8) - Updating symfony/polyfill-php73 (v1.11.0 => v1.12.0) - Updating symfony/polyfill-mbstring (v1.11.0 => v1.12.0) - Updating symfony/console (v4.3.1 => v4.4.0) - Updating symfony/dependency-injection (v4.3.2 => v4.4.0) - Updating symfony/var-exporter (v4.3.1 => v4.4.0) - Updating symfony/cache-contracts (v1.1.1 => v1.1.7) - Updating psr/log (1.0.2 => 1.1.2) - Updating symfony/cache (v4.3.1 => v4.4.0) - Updating symfony/expression-language (v4.3.1 => v4.4.0) - Updating symfony/finder (v4.3.3 => v4.4.0) - Updating symfony/polyfill-php72 (v1.11.0 => v1.12.0) - Updating symfony/polyfill-intl-idn (v1.11.0 => v1.12.0) - Updating symfony/mime (v4.3.2 => v4.4.0) - Updating symfony/event-dispatcher-contracts (v1.1.1 => v1.1.7) - Updating symfony/event-dispatcher (v4.3.1 => v4.4.0) - Updating doctrine/lexer (v1.0.1 => 1.2.0) - Updating egulias/email-validator (2.1.9 => 2.1.11) - Updating symfony/mailer (v4.3.2 => v4.4.0) - Updating symfony/inflector (v4.3.1 => v4.4.0) - Updating symfony/property-access (v4.3.1 => v4.4.0) - Updating symfony/property-info (v4.3.1 => v4.4.0) - Updating symfony/routing (v4.3.1 => v4.4.0) - Updating symfony/yaml (v4.3.1 => v4.4.0) Resolves: #89721 Releases: master Change-Id: I834a79e3880b3a7a95429c2fe052657e21599ec7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62354 Tested-by:
-
Benni Mack authored
The serviceChain (services that have been requested before) are currently added as comma-separated list (string), however, every time when GeneralUtility::makeInstanceService() is called, the serviceChain parameter is trimExplode'd to an array, which leads to unnecessary CPU time when multiple services are queried. The compat behaviour of handing in a string is now deprecated, and in TYPO3 v11 only arrays are accepted. Resolves: #89579 Releases: master Change-Id: Id2424907b0d6c62fc1f249bcdd23f13d45de9893 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62043 Reviewed-by:
-
Benni Mack authored
The property "PageRenderer->metaTagsByAPI" has been removed with the introduction of the MetaTag API. The left-over assignment should be removed. Resolves: #89724 Releases: master, 9.5 Change-Id: I9f6ad9c0eea538c83ee2252590c1632719fbd89d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62357 Tested-by:
-
Joerg Kummer authored
Change filename of changelog for issue 88902 fixes ordering in rendered documentation menus. Releases: master Resolves: #89719 Change-Id: I2e9e6045610d601e904f7f5b46ff6a2f2d27774f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62351 Tested-by:
-
Björn Jacob authored
Releases: master, 9.5 Resolves: #89717 Change-Id: I63dd1bcb540c611618d662c01e9d271f013e07e9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62348 Tested-by:
-
