With displaying the count of failed error checks in the navigation menu
(like the count of unread messages in an email inbox) a user will more
likely enter the "System environment" section of the install tool and
take care about the found errors and warnings.

Change-Id: I3d9b628b428da13992c3dc1e7e5ab6beaeda5ce1
Resolves: #51410
Releases: 6.2
Reviewed-on: https://review.typo3.org/23380
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

Remove all calls on SaltedPasswordsUtility::isUsageEnabled('BE')
as backend is enabled by default. Besides remove all
ExtensionManagementUtility::isLoaded('saltedpasswords') as
extension is loaded by default.

Change-Id: Ie2332fc3c6c454888afc8c9956b9869309623584
Resolves: #51356
Releases: 6.2
Reviewed-on: https://review.typo3.org/23375
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

Resolves: #51190
Releases: 6.2, 6.1
Change-Id: I105e23b12659495b4058edbc8091eee4374d58b9
Reviewed-on: https://review.typo3.org/23278
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Oliver Klee
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

The call to substr_count was incorrect.

Change-Id: I9f452d22f03a99fbf0b862021b100dcf6d53d792
Resolves: #51409
Releases: 6.2
Reviewed-on: https://review.typo3.org/23374
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind

Feature wise equal to 4.3.1, but now with MIT license.

Resolves: #51406
Releases: 6.2

Change-Id: Ie0cd306b544c2f56853ca7e16ba6cdd5cdf84a6e
Reviewed-on: https://review.typo3.org/23370
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert

Nearly all buttons in the install tool currently show a green checkmark
icon. This is misleading, as in most cases nothing has been checked.
The button simply leads to the next step or executes the desired action.

With removing the icon, it will be more clearer that clicking a button
will just perform the intended action, without any check being
performed beforehand that this action will actually succeed.

Change-Id: If00d4ccde24a201f552ead6b9d8991c8e58b473f
Resolves: #51407
Releases: 6.2
Reviewed-on: https://review.typo3.org/23368
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

In the extension manager make the extension titles link to the
configuration again. This will provide an additional clickable area and
it allows the integrators to continue using the known behavior.

Resolves: #50234
Releases: 6.2, 6.1, 6.0
Change-Id: I120e8fb47628fe118291cbdd57951a0238ebcd71
Reviewed-on: https://review.typo3.org/22663
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Nicole Cordes
Tested-by: Nicole Cordes
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

To use saltedpasswords in the install tool it is necessary to move the
default salt methods registration from ext_localconf.php to the salt
factory. This patch adds an initialize function to set the default salt
methods.

Resolves: #51404
Releases: 6.2
Change-Id: Iaa4547255c8d6e3b0b0fd75c0aaadfa54109ba27
Reviewed-on: https://review.typo3.org/23369
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

If the Install Tool is locked, the login-screen states whether the
cause to this is if the ENABLE_INSTALL_TOOL file doesn't exist (and
therefore it's locked) or if no password is set.

Currently, the Browser-Title states "No install tool password set"
even if it's set but the ENABLE_INSTALL_TOOL file doesn't exist.
This Patch sets the correct title in the browser-window:
"The Install Tool is locked".

Resolves: #51408
Release: 6.2
Change-Id: Ia9d25a884667404408a2ef6a375d95f7509d8d9d
Reviewed-on: https://review.typo3.org/23373
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

The button icon viewhelper now supports an empty uri parameter. The
link on the next / last button of the backend paginate widget in case
you are on the very last page can be removed.

Change-Id: I238c77efa8a9d4ff4a1864f6df876a695dc690e5
Resolves: #51395
Releases: 6.2
Reviewed-on: https://review.typo3.org/23363
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

This patch rewrites the configuration of ext:saltedpasswords into
a readable array which gets serialized afterwards. The check for
enabling salted passwords in the backend is obsolete and removed.
The values of the "checkConfiguration" user functions superfluous
and removed as well.

Resolves: #51354
Releases: 6.2
Change-Id: I539070d1642660ad0a5641d8971bdabc7cf92223
Reviewed-on: https://review.typo3.org/23366
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

"Check for broken extensions" in important actions of the install
tool checks for broken extenions over an Ajax-Request.

Currently, the user clicks the button to check for broken extensions
and doesn't get any feedback whether there is something going on or not.
This patch implements a loading-message with a Spinner that is displayed
as soon as the button to check for broken extensions is clicked.
Furthermore the button is hidden as long as the request is beign executed
and displayed again if there is anything more to check (e.g. broken
extensions are found).

Resolves: #51379
Release: 6.2
Change-Id: I13e5024a1e2666e54e782ff1bab9418ba8b180f6
Reviewed-on: https://review.typo3.org/23365
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Christoph Buchli
Tested-by: Christoph Buchli
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

Purpose of the initialize() method in the AbstractAction class is the
initialization of a handle. It is not intended to be used for generally
initializing classes derived from AbstractAction.

By refactoring the method name, the method's purpose will be indicated
more clearer.

Change-Id: I1603090e4dfccb5b57da4fa9c3792ec73647c524
Resolves: #51396
Releases: 6.2
Reviewed-on: https://review.typo3.org/23364
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

The patch adds better auto detection of port settings to
install tool step action "database connect". If everything
works out, the database connect step is not rendered anymore
during upgrading which is the case without the patch.

- Split port off from IP only if IPv4 is used
- Get default or configured port for connection test
- Store port, host and socket on success and redirect to self

Change-Id: Ia5b53fc7eff60c5b2613ecee35cd5ee699e141ca
Resolves: #49186
Releases: 6.2
Reviewed-on: https://review.typo3.org/23332
Reviewed-by: Kai Ole Hartwig
Tested-by: Kai Ole Hartwig
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

The functional tests frameworks create a new database per test.
The database name is generated by the original database
name plus a string and a hash.

If the database name length exceeds the maximum length of 64
characters an exception is now thrown.

The generated database name is also been shortened a bit.

Resolves: #51383
Releases: 6.2
Change-Id: I5817e440a3dcba7e53e2a27dca4f7bfc679334f5
Reviewed-on: https://review.typo3.org/23356
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Refactor WorkspaceServiceTest to reflect recent changes
in functional testing.
Enable test so they will be run in Travis.
Still 2 tests are skipped and need further review,
but it can be done in the separate change.

Resolves: #51164
Releases: 6.2
Change-Id: I074629d877b6a4d336bd21aacd20268bf4746811
Reviewed-on: https://review.typo3.org/23185
Reviewed-by: Stefan Neufeind
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

In GeneralUtility::validEmail() there's still a workaround for
a PHP crash (bug 52929).
This was fixed with PHP 5.3.4 and as TYPO3 6.2
requires 5.3.7, this workaround can be removed.

Resolves: #51386
Releases: 6.2
Change-Id: I5b32e90fd1a99c1cb2bdc261965114b06b4d4a58
Reviewed-on: https://review.typo3.org/23357
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind

This patch adds saltedpasswords as a required system extension,
forcing salted hashes to be enabled for backend authentication.
The install tool checks settings and adapts them if needed.
Rsaauth is added to the list of recommended extensions
in the install tool extension installation upgrade wizard.

Resolves: #51352
Releases: 6.2
Change-Id: Ifd3b9f195101bcdb083b3bf9db4a74c812f0a709
Reviewed-on: https://review.typo3.org/23333
Reviewed-by: Kai Ole Hartwig
Tested-by: Kai Ole Hartwig
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

The \TYPO3\CMS\Core\Category\CategoryRegistry::addTcaColumn() method
provides an API for adding a system categories selector to a given
table. However the generated TCA misses a condition in
"foreign_table_where" to hide translated categories.

Resolves: #51304
Releases: 6.0, 6.1, 6.2
Change-Id: I2622371a89c8eabeb29e835c7f6673ffc6349186
Reviewed-on: https://review.typo3.org/23280
Reviewed-by: Philipp Gampe
Reviewed-by: Francois Suter
Tested-by: Francois Suter

"Check for broken extensions" in important actions of the install
tool renders uninstall buttons for every broken extension it found.

Currently only the last extension is uninstalled, no matter which
button is used. The patch fixes this by adding a class to identify
the extension in question to each button and adapts the javascript.

Resolves: #51368
Releases: 6.2
Change-Id: I7b754aca58e262dbd726452f816fe4dfaa6cf54d
Reviewed-on: https://review.typo3.org/23336
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Stefan Neufeind
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

If the system is already translated into French two tests in
Localization\Parser\LocallangXmlParserTest fail. This is because another
localization file is taken where test strings are not included.

As the tested functions can't work system independent, the test has to
make sure no system dependencies are used. Therefore the patch
introduces a new language "md5" to prove the workflow.

Resolves: #50870
Releases: 6.2, 6.1, 6.0
Change-Id: I64e8864a7d746c4f5c278f5e67d8dae068d8f920
Reviewed-on: https://review.typo3.org/22918
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind

This patch adds a missing call to htmlspecialchars() when
the title tag of image links is initialized.

Resolves: #50760
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Change-Id: If41f33d9621f7790c0ff0de4aebcd7cdcb59707f
Reviewed-on: https://review.typo3.org/22803
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind

The page tree doesn't show the result when using the filter
in the page tree in IE7 & IE8. ExtJS somehow breaks silently
when trying to use a non-tag (text) as a drag handle. This fix
works with the original change that introduced this, meaning it
doesn't break the functionality of dragging of locked records.

Change-Id: I3f33fb3e4f6bd7622f502a9265897fee9d3e4ed3
Resolves: #25327
Resolves: #37026
Related: #M17952
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Reviewed-on: https://review.typo3.org/22500
Reviewed-by: Nicole Cordes
Tested-by: Nicole Cordes

- Detect if SYS/isInitialInstallationInProgress is set
- If set: Show form for creating or selecting empty db
- If not set: Show all databases the user has access to

Change-Id: Ifaa1678f8ab1eaacec944e6dddf7d23babb804cf
Resolves: #51357
Releases: 6.2
Reviewed-on: https://review.typo3.org/23329
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-by: Alexander Böhm
Tested-by: Alexander Böhm
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Labels should display as a block so inputs are aligned.
Label-width needs to be adjusted as well then.

Change-Id: I4a0e58fc648efd0767d0d3dc814d5aa7c7c444e2
Resolves: #50951
Releases: 6.2
Reviewed-on: https://review.typo3.org/22983
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

The install tool test section creates test images. If permissions
on the target folder are not set up correctly, the file may not
be created, but a correct file location is returned.
In this case not caught exceptions are thrown. This is
now sanitized with a simple file exists view helper to
show some error message instead.

Change-Id: Ic840b0128e5c69f8ce6f601952b8f17e59713e27
Resolves: #51366
Releases: 6.2
Reviewed-on: https://review.typo3.org/23331
Reviewed-by: Simon Schmidt
Tested-by: Simon Schmidt
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter

Application Context is initialized in Bootstrap. We need a
public API to get the current context without using the bootstrap
itself.

In Flow, the ObjectManager provides this API, but in TYPO3 CMS we
do not have this kind of ObjectManager (except in extbase).

The API call is:
\TYPO3\CMS\Core\Utility\GeneralUtility::getContext();

Resolves: #50983
Releases: 6.2
Change-Id: Ic900a503b3e2bc184d2bfd43345e72180887ef18
Reviewed-on: https://review.typo3.org/23018
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

Follow-up: #51134
Releases: 6.2
Change-Id: I80c2f2bab106cf78a93e371e613c8049510f7bfd
Reviewed-on: https://review.typo3.org/23306
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny

Fluid is currently lacking a view helper to render a skinned icon.
By making the button icon view helper accept an empty URI as an
argument, we let it render an unlinked icon, rather than adding
a new view helper with very similar code.

This patch also cleans up the class phpDoc block, which
contained several errors.

Resolves: #51305
Releases: 6.2
Change-Id: I74b1dc3346e20c9094313a2da451bcb6c1f60f29
Reviewed-on: https://review.typo3.org/23281
Reviewed-by: Frans Saris
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind

The test using this file was not adjusted and thus failing.

The test was adjusted and another one added, looking after the new
position.

Resolves: #51273
Relates: #51251
Releases: 6.2
Change-Id: I12aebadfa12633f62b32365b064e802f608f6197
Reviewed-on: https://review.typo3.org/23262
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

pagegen.php contains rendering code and is called twice
in index_ts.php. The patch merged the content of this
file to index_ts.php to have all global code in one file.

The patch is a straight forward refactoring, only the
time tracking is a bit simplified and an obsolete if
is removed at the former second inclusion of the file.

Change-Id: Id8477423455281bd6df2ce32eb280809045e4541
Resolves: #51254
Releases: 6.2
Reviewed-on: https://review.typo3.org/23246
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

EXT:frontend is the successor of ext:cms. This started with the
namespace change so all class files are already located there.
The patch moves TCA and ext_tables.sql to the extension to make
it very clear that functional tests that depend on this data
should also go to ext:frontend later on.
The patch is trivial since both extensions are "required" and
thus always loaded, with ext:frontend directly before ext:cms,
so nothing can break with this patch.

Change-Id: Ifd9e0c9263f6b9a6aadfbfa1b568c4cd085e40d9
Resolves: #51251
Releases: 6.2
Reviewed-on: https://review.typo3.org/23244
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring

Change-Id: Ice648bc6d9d0668c7f0a42ae57fab556da7dcaaa
Resolves: #51253
Releases: 6.2
Reviewed-on: https://review.typo3.org/23245
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

The sysenv-check is not the proper place for a check that needs a working db-connection. But we'll find a different place for this check shortly and then reintroduce it.

This reverts commit bad3f24c

Change-Id: I1ba4a2ed88ad03df122593ac964d997ec05edacf
Reviewed-on: https://review.typo3.org/23243
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind

ObjectMapper does not work for Backend-Mappings
because of missing "Interface" in Backend-Annotation

Resolves: #51249
Releases: 6.2, 6.1
Change-Id: I45a6f1c57ddcf71282853c44e261bfa877854b85
Reviewed-on: https://review.typo3.org/23238
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind

If the SQL mode "STRICT_ALL_TABLES" is enabled you
will not be able to save most records. (Enable it in
your my.cnf and try to save a tt_content record)

This patch adds a check in the install tool for the
incompatible SQL modes "STRICT_ALL_TABLES" and
"NO_BACKSLASH_ESCAPES".

The automatic fix for "NO_BACKSLASH_ESCAPES" has been
removed because we don't want to change the mysql
environment automatically.

Resolves: #20052
Resolves: #18866
Resolves: #18821
Releases: 6.2, 6.1, 6.0
Change-Id: Ifd2d7901935f06534a273374bf48266916e23698
Reviewed-on: https://review.typo3.org/19671
Reviewed-by: Sascha Egerer
Tested-by: Sascha Egerer
Reviewed-by: Markus Klein
Reviewed-by: Alexander Opitz
Tested-by: Alexander Opitz
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind

Check before generating a publicUrl if storage is online.

Resolves: #49842
Releases: 6.2, 6.1, 6.0
Change-Id: I766e337cf5e7dfcb309bbce0bbd7c4d8df733c84
Reviewed-on: https://review.typo3.org/22915
Reviewed-by: Frans Saris
Tested-by: Frans Saris
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind

It must be possible that processed files are generated
even if the user has read only permissions on a storage.

Additionally add a method to Storage, to specifically
update a processed file with a local file.

Resolves: #51209
Releases: 6.0, 6.1, 6.2

Change-Id: I847b02f070c55647e06695c1c70b0b7e8e238177
Reviewed-on: https://review.typo3.org/23196
Reviewed-by: Frans Saris
Tested-by: Frans Saris
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind

The tables sys_language and static_languages do not support
versioning. Therefore, when doing a version preview, no
version overlay should be applied to them.

Change-Id: I37be782601fc37e78a74d2459b6f246c5107b701
Fixes: #37892
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/11928
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Stefan Neufeind
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

When adding a file or requesting a file by an identifier
cleanup any . and .. in the path before handing off
to the driver so files are not indexed multiple times.

Fixes: #46989
Releases: 6.2, 6.1, 6.0
Change-Id: I4198a8885a6a148e68e1e0f717775f9af976a9ef
Reviewed-on: https://review.typo3.org/22923
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind