Change-Id: Ibd990830d7ad9d43707be802c6a24a1388589d18
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83716


Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>

This change adds additional tests to cover additional
variants for `EXT:redirects` handling. Placing guards
helps to avoid mitigating regressions for these cases.

Resolves: #103564
Related: #103395
Related: #103555
Releases: main, 12.4
Change-Id: I4b6deb258610d1a3d416c16eec610aa2bfd9ef72
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83665


Tested-by: Stefan Bürk <stefan@buerk.tech>
Tested-by: core-ci <typo3@b13.com>
Reviewed-by: Stefan Bürk <stefan@buerk.tech>

Redirects can match even if no SiteConfiguration could
be determined for the current request and a `NullSite`
has been added as request attribute. In this case, the
`RedirectService` already resolves a SiteConfiguration
for the matched redirect.

Bootstrapping a  `TypoScriptFrontendController` is done
using the resolved SiteConfiguration, still using the
NullSite in the request for id determination and loading
TypoScript.

In cases where no real `sys_template` records exists,
for example when `b13/bolt` is used to provide fake
rows, it is important to avoid NullSite.

This change uses the redirect target based resolved
site in case the request does not contain a valid
site object. Prepared test from #103555 is enabled
now to guard this case for the future.

Note: TYPO3 v13 recieved quite some refactoring in
the Middleware, TSFE and TypoScript loading order
a long with a factory and fixed this already. This
is a simple solution for TYPO3 v12.

Resolves: #103395
Related: #103555
Releases: 12.4
Change-Id: If3d3003c8af1799e19937328c00fedb7b32562c7
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83701


Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Andreas Kienast <a.fernandez@scripting-base.de>
Reviewed-by: Andreas Kienast <a.fernandez@scripting-base.de>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Stefan Bürk <stefan@buerk.tech>
Reviewed-by: Stefan Bürk <stefan@buerk.tech>

`Build/Scripts/runTests.sh` is the monorepo main dispatcher of
script and tools to ensure same working state across developer
host system and installation by using well defined containers.
This mitigates issues with missing dependencies or wrong version
of tools on develper machines.

Until now local installation of `node` and `npm` in the matching
version was mandatory to work with the node ecosystem like manage
dependencies, executing node based tools or the build chain for
CSS and TypeScript/JavaScript.

This change adds now a `npm` dispatcher to `runTests.sh` similar
to the `composer` command dispatcher introduced with #103045 to
allow executing npm commands and defined scripts in `package.json`
in a well-defined environment and removes the hard-requirement of
installing it locally for new contributors.

Added `runTests.sh` suite:

* ./Build/Scripts/runTests.sh -s npm --  <npm-command-arguments>

which allows now to using npm commands always with the correct
npm and node version defined for the mono-repository state.

Some examples:

  ./Build/Scripts/runTests.sh -s npm -- audit
  ./Build/Scripts/runTests.sh -s npm -- ci
  ./Build/Scripts/runTests.sh -s npm -- run build
  ./Build/Scripts/runTests.sh -s npm -- run watch:build
  ./Build/Scripts/runTests.sh -s npm -- install \
    --save bootstrap@^5.3.2

Resolves: #103552
Related: #103045
Releases: main, 12.4, 11.5
Change-Id: Ie9de71f24dfd4805a98be7dc1b1604e5d0146eec
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83663


Tested-by: core-ci <typo3@b13.com>
Tested-by: Stefan Bürk <stefan@buerk.tech>
Reviewed-by: Stefan Bürk <stefan@buerk.tech>

`\TYPO3\CMS\Backend\RecordList\DatabaseRecordList` provides the ability
to modify the QueryBuilder used for the record list representation with
the PSR-14 `ModifyDatabaseQueryForRecordListingEvent`, after generic
query information like default orderings and similar have been added.

That is covered within the `getQueryBuilder()` method, which is used in
other class methods, for example in `getTables()` where it is changed
to a `COUNT()` query.

MariaDB for example is picky about count queries using `order by`,
`group by` or aggregation methods which are not reflected or added
in the counter parts leading to a not so useful error like

  Mixing of GROUP columns (MIN(),MAX(),COUNT(),...) with no GROUP
  columns is illegal if there is no GROUP BY clause

or similar variants. This error message can be missleading for the
case a order by has been used along with a COUNT() query.

Listener of the event do not get the information if order-by can
be added or should be left out, therefore maybe adding sorting
conditions for a count query.

This change now resets any order statements for the count-query
like other places in the TYPO3 core.

Resolves: #103427
Releases: main, 12.4, 11.5
Change-Id: Ie421993a1890dd6682d02f54203d538e6ae1b76c
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83532


Reviewed-by: Garvin Hicking <gh@faktor-e.de>
Reviewed-by: Stefan Bürk <stefan@buerk.tech>
Tested-by: Garvin Hicking <gh@faktor-e.de>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Stefan Bürk <stefan@buerk.tech>

The check for content_from_pid is wrong as it is not the raw database record and therefore the relation is an array.

Resolves: #103405
Releases: main, 12.4
Change-Id: I31cfc584d9d1164ef96e1c3bec5ec75cc1619bd7
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83662


Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: core-ci <typo3@b13.com>

The indexed_search BE module links to word details.
This link is broken in main and v12:

* In main, the wordHash argument is a string, but the extbase
  target action expects an int.
* In v12, the wordHash is an int, but is misinterpreted as
  pages-uid.

The patch fixes this by switching from the argument name
'id' to 'wordHash' to suppress the pages-uid "convention"
to kick in. In main, the target action argument is declared
as string and both arguments are set non-optional.

Resolves: #103547
Related: #102975
Related: #96797
Related: #103540
Releases: main, 12.4
Change-Id: Ibd4732d086f1af264ee317c7e7d4fe0f15a15aa4
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83680


Tested-by: Stefan Bürk <stefan@buerk.tech>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: core-ci <typo3@b13.com>
Reviewed-by: Stefan Bürk <stefan@buerk.tech>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>

Issue with the `RedirectService` has been reported
wiht #103395 related to non-matching SiteConfig in
cases no TypoScript template records exists, like
when `b13/bolt` is used in instances.

Changes #103437, #103439 and #103554 fixed the
mentioned issue #103395 for TYPO3 v13, leaving
the issue open for TYPO3 v12.

Note: For v12 the regression test dataset needs
to be disabled for now, and will be enabled with
the upcoming fix.

This change adds now some tests for non matching
SiteConfiguration for `source_hosts`.

Resolves: #103555
Related: #103395
Related: #103554
Related: #103439
Related: #103437
Releases: main, 12.4
Change-Id: I2c72de3fa5f8d8aae5e6d2ca702ea4685cd367b3
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83695


Tested-by: core-ci <typo3@b13.com>
Reviewed-by: Stefan Bürk <stefan@buerk.tech>
Tested-by: Stefan Bürk <stefan@buerk.tech>

This change introduces the use of the DataHandler instead of the
QueryBuilder when creating backend users via CLI command
`backend:user:create`.

This ensures that the user is initialized with TCA default options and
the creation and history of the new user is logged to the TYPO3 log.

Resolves: #102062
Releases: main, 12.4
Change-Id: I78f7093108d1df3c6d37ab7545911365d3c846bb
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83688


Tested-by: core-ci <typo3@b13.com>
Tested-by: Stefan Bürk <stefan@buerk.tech>
Reviewed-by: Stefan Bürk <stefan@buerk.tech>

When t3editor got streamlined in the past, configuration for flex was
defined that conflicts with CodeMirror's internal style definition,
leading to UI glitches like "cut out" content, see screenshot attached
to the ticket..

This commit removes the conflicting CSS.

Resolves: #101442
Releases: main, 12.4
Change-Id: Ie5b9f8d498cdaef0b3455e05e247cb5fd64b0617
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83685


Tested-by: Andreas Kienast <a.fernandez@scripting-base.de>
Reviewed-by: Andreas Kienast <a.fernandez@scripting-base.de>
Tested-by: core-ci <typo3@b13.com>

As documented by PHP, `\DateTime` or `\DateTimeImmutable`
objects created with a timestamp only ('@12345678') as the
first constructor argument will use UTC as TimeZone.

Creating an object instance without any constructor arguments
will use the `date_default_timezone_get()` timezone for the
object - and setting the timestamp using `setTimestamp()` will
not change the object's timezone.

That means, that formatting the value will be done using
the object Timezone and **NOT** the default PHP Timezone
(`date_default_timezone_get()`).

Consequently, this may lead to wrong interpretation of
the displayed formatted value in the context of another
timezone - if no timezone information (+0000/-0100) is
included.

This change streamlines this for a couple of places were
it is expected to format date, datetime or time values
for the current context timezone by ensuring objects get
the current timezone set instead of `UTC`.

Note: Changing the date default timezone on the fly after
an object has been created will show a similar effect like
using constructor values, even if the object has been
created by using the `setTimestamp()` method.

[1] https://3v4l.org/sGEe2

Resolves: #98045
Resolves: #99627
Releases: main, 12.4, 11.5
Change-Id: I095a0b0b376361e25396647d02727ac08f35cae0
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83682


Tested-by: Stefan Bürk <stefan@buerk.tech>
Reviewed-by: Stefan Bürk <stefan@buerk.tech>
Tested-by: core-ci <typo3@b13.com>

The backend uses request GET/POST parameter 'id' as convention for
"pages uid" at various places: Especially the BackendModuleValidator
checks for this parameter early, to deny access to pages a BE user
has no access to.

This convention is a broken misuse: There is no such convention,
and for instance the filelist module uses 'id' to transfer a
selected "storage-uid:path".

The BackendModuleValidator mitigates this by calling
MU::canBeInterpretedAsInteger() before interpreting that
parameter as a pages-uid.

The extbase BackendConfigurationManager also uses 'id' to retrieve
the FE TypoScript configuration for this "pages-uid", it however
does not check with MU::canBeInterpretedAsInteger(), first.

The patch adds a MU::canBeInterpretedAsInteger() check to extbase
BackendConfigurationManager to be in-line with BackendModuleValidator,
and adds `@todo` comments outlining the general misuse of the argument.

Change-Id: I9b53a521bde4d3c145bfda2994d81dc4abf9c103
Resolves: #103540
Related: #96797
Releases: main, 12.4
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83678


Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>

New core-testing-* images has been build and published in
the TYPO3 testing-infrastructure repository and pulled to
the core ci gitlab runner instances. [1][2]

This change modifies `Build/Scripts/runTests.sh` to set
new image version to ensure the usage for all changes
based on this change.

For information what changed in the image see the patches
in the testing-infrastrucure repository linked below.

* core-testing-nodejs18 => 1.4
* core-testing-nodejs18-chrome => 1.4

[1] https://nodejs.org/en/blog/vulnerability/april-2024-security-releases/
[2] https://git.typo3.org/typo3/CI/testing-infrastructure/-/commit/712e35c72cd7788d1d6311714b5a0dfe46e743a7

Resolves: #103518
Releases: main, 12.4
Change-Id: Ibaafbd465a21d631f6726064255241aa4b42e726
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83652


Tested-by: core-ci <typo3@b13.com>
Tested-by: Andreas Kienast <a.fernandez@scripting-base.de>
Reviewed-by: Stefan Bürk <stefan@buerk.tech>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Andreas Kienast <a.fernandez@scripting-base.de>
Tested-by: Oliver Klee <typo3-coding@oliverklee.de>
Tested-by: Stefan Bürk <stefan@buerk.tech>

Doctrine dbal function fetchAssociative() was used in combination
with accessing an array element without null colesce.

Resolves: #103423
Releases: main, 12.4, 11.5
Change-Id: I6f5842f28722dc8b2716533e818fc40ed2fc25ef
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83660


Reviewed-by: Stefan Bürk <stefan@buerk.tech>
Tested-by: Stefan Bürk <stefan@buerk.tech>
Tested-by: core-ci <typo3@b13.com>

TCA for usage of `sys_file` may configure their allowed extensions by an
array (e.g. EXT:bootstrap_package, "Media" content element) which failed
as the Element Browser took only strings into account.

The class `TcaPreparation` now takes `columnsOverrides` and their
respective `overrideChildTca` configuration into account.

Resolves: #103316
Releases: main, 12.4
Change-Id: Ie173a0e007ab44bcb9f090a5b7ae8b7eedd9d45a
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83649


Tested-by: core-ci <typo3@b13.com>
Reviewed-by: Andreas Kienast <a.fernandez@scripting-base.de>
Tested-by: Andreas Kienast <a.fernandez@scripting-base.de>

In the image editor, the "Cropped area" was configured with a `ceil`ed
width and height. Since all other dimensions are `floor`ed, this might
cause an overlap.
Due to the configured cropping mode, defining that the cropping area
must never exceed the image dimensions, the cropper library places the
cropper to a position that's mathematically correct but not desired.

To solve this issue, the `width` and `height` properties fed to the
cropper are now `floor`ed as well, basically aligning with the rest of
the coordinates.

Resolves: #101520
Releases: main, 12.4, 11.5
Change-Id: I981bd185eaf0db60662a5a6b7b423d84112c2150
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83659


Tested-by: core-ci <typo3@b13.com>
Reviewed-by: Andreas Kienast <a.fernandez@scripting-base.de>
Tested-by: Andreas Kienast <a.fernandez@scripting-base.de>

To harden the Extbase LazyLoadingProxy implementation
a new test has been added with #101400, which creates
a proxy directly and using ObjectAccess::getProperty()
to access a property of the not loadable child proxy
class instance.

Due to the use of magic methods`__get()` and `__isset()`
methods in the `LazyLoadingProxy` class and some wrong
assumptions of the Symfony PropertyAccessor simply null
has been retrieved even if the concrete class could not
been retrieved (property on a null value instead of an
object). The property accessor is used under the hood
within the Extbase internal ObjectAccess implementation.

The Symfony Team recently declared that behaviour a bug
and fixed it with releases `7.0.6` and `6.4.6` and now
correctly throwing the `PropertyNotAccessibleException`.

Failing nightlies with Symfony releases containing the
bugfix revealed a incorrect test implementation, using
a constructed and unrealistic construct.

This change modifies the test to use a correct access
on the LazyLoadingProxy without changing the scenario
of the test.

[1] https://github.com/symfony/symfony/releases/tag/v7.0.6
[2] https://github.com/symfony/symfony/releases/tag/v6.4.6
[3] https://github.com/symfony/symfony/pull/54194

Resolves: #103531
Related: #101400
Releases: main, 12.4
Change-Id: I5bdd52955af138c1e99b4492c9b5a43839c743cf
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83658


Reviewed-by: Stefan Bürk <stefan@buerk.tech>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Stefan Bürk <stefan@buerk.tech>

To regenerate a slug, the fields defined in
the TCA "generatorOptions" configuration have
to be present in the form.

There are cases where those fields are added as
hidden fields (e.g. using the "overrideValues"
feature). Those fields are now also properly
respected for the regeneration.

Resolves: #103500
Releases: main, 12.4
Change-Id: I0ca7de4b7d7d09e62ece511aeb16615af3d3a1fa
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83657


Tested-by: core-ci <typo3@b13.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Oliver Bartsch <bo@cedev.de>

If a page uses a specific page layout, it must be used in the page
module. To be in sync with v12 the change is also merged into v12.

Resolves: #103501
Releases: main, 12.4
Change-Id: I91341249fd3f6142a9830bb594a8fe1d2d6ded7a
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83656


Tested-by: core-ci <typo3@b13.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Oliver Bartsch <bo@cedev.de>

Updated and renamed files and adapted paths and extension names.

Resolves: #103497
Releases: main, 12.4
Change-Id: Ib79540d47a9112711d53373de2952203c41ded9a
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83655


Tested-by: core-ci <typo3@b13.com>
Reviewed-by: Lina Wolf <112@linawolf.de>
Tested-by: Lina Wolf <112@linawolf.de>

The menu generation must not reuse the page record from the current page
but must use the data from the linked page.

Resolves: #101883
Releases: main, 12.4
Change-Id: I491ed6d2f0d33f9bbe2ef934c4304adfae656808
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83654


Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: core-ci <typo3@b13.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>

Resolves: #103496
Releases: main, 12.4
Change-Id: I688540c91e85d28eec1951305d63028efa27eb82
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83653


Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>

Executed commands:

    composer require --dev sokil/php-isocodes-db-i18n:^4.0.21
    Build/Scripts/updateIsoDatabase.php

Resolves: #103524
Releases: main, 12.4
Change-Id: I052c959bfa85de02f28dfa190b939adcda2207f7
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83641


Tested-by: Andreas Kienast <a.fernandez@scripting-base.de>
Tested-by: core-ci <typo3@b13.com>
Reviewed-by: Andreas Kienast <a.fernandez@scripting-base.de>

While extracting dedicated TCA types from the god type `input`, the
`valuePicker` option was forgotten for type `email`. Other types like
`number` do have this option.

An acceptance test is added to ensure this option will not be dropped
by accident in the future.

Resolves: #103510
Related: #97013
Releases: main, 12.4
Change-Id: I95c51d858ca9cb3caefa174cd8ce5946c8352aa2
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83639


Tested-by: Nikita Hovratov <nikita.h@live.de>
Reviewed-by: Nikita Hovratov <nikita.h@live.de>
Tested-by: core-ci <typo3@b13.com>

When opening the "tile view" in the backend, third party FAL adapters
may not correctly return 'mtime' and 'ctime' as integers.
This already is fixed in the main branch but can occur in TYPO3 12 LTS
as well, therefore relevant changes are picked from #101469.

Resolves: #103495
Related: #101469
Releases: 12.4
Change-Id: Ibdcf878da63ff0c79dd1dba8ac28f6f7f68e7a0e
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83616


Tested-by: core-ci <typo3@b13.com>
Reviewed-by: Sybille Peters <sypets@gmx.de>
Reviewed-by: Simon Schaufelberger <simonschaufi+typo3@gmail.com>
Tested-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Tested-by: Simon Schaufelberger <simonschaufi+typo3@gmail.com>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>

At various places, it's possible to edit the metadata
of a file in the default language. However, users might
not have access to the default language. To prevent
moving to FormEngine and facing access permission
errors, those places now use proper language access
checks and do not display corresponding action if
the user does not have access.

Resolves: #103432
Releases: main, 12.4
Change-Id: I22c3755a17888cfc623ce05b25fd655b323cc553
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83583


Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Tested-by: core-ci <typo3@b13.com>

A backport to 11.5 is not possible due to too many issues in the Docs that cannot be backported automatically.

Change-Id: I32e957ec8b41059e8eb8ddfd17f80f08c3ea454d
Resolves: #103479
Releases: main, 12.4
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83543


Tested-by: core-ci <typo3@b13.com>
Reviewed-by: Lina Wolf <112@linawolf.de>
Tested-by: Lina Wolf <112@linawolf.de>

The page tree in TYPO3 v11 and v12 has a default timeout of 300ms for
click events to be processed (in order to wait for double-click
detection). This caused race conditions in tests since code that
waited for #nprogress to hide after clicking on the pagetree
did not have anything to wait for (yet), because the progress
loaded was only triggered 300ms later, when the click was detected
to not be a double click event and the content frame was started
to be updated.

Also remove wait timeout that were implicitly added for the same
issue, but were spread throughout the test cases.

Resolves: #103473
Releases: 12.4, 11.5
Change-Id: Ie9c9aff8c8a36581555a9ad352fb98b3d446ba42
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83576


Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Oliver Klee <typo3-coding@oliverklee.de>
Tested-by: Stefan Bürk <stefan@buerk.tech>
Reviewed-by: Benjamin Franzke <ben@bnf.dev>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Benjamin Franzke <ben@bnf.dev>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Stefan Bürk <stefan@buerk.tech>

Fixes the Doctrine error:
Incorrect integer value: '' for column 'editlock' at row 1

Releases: main, 12.4, 11.5
Resolves: #103461
Resolves: #103462
Change-Id: I0e3f0344157f66c07681bd29a47f4f51e32e4225
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83541


Reviewed-by: Stefan Bürk <stefan@buerk.tech>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Stefan Bürk <stefan@buerk.tech>

`SiteBasedTestTrait` created a instance of the `SiteConfiguration`
using the PHP `new` keyword for writing functional test instance
site configurations.

It is possible, that the `SiteConfiguration` is retrieved from
the `Dependency Injection container` by code executed before
the test releated site configuration is written, which does not
reset the instance based `SiteConfiguration->$firstLevelCache`
property and later retrieving site configurations using the
`SiteFinder`, for example in rootline and other operations,
cannot find the test instance configurations.

This change now uses the `SiteConfiguration` from the test
instance `Dependency Injection container` which ensures that
the internal first level cache is properly reset on `write()`
actions.

Resolves: #103470
Releases: main, 12.4
Change-Id: I70368e56abd10e55f06d3813371c4538ad704136
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83540


Tested-by: Stefan Bürk <stefan@buerk.tech>
Reviewed-by: Stefan Bürk <stefan@buerk.tech>
Tested-by: core-ci <typo3@b13.com>

New core-testing-* images have been build and published in
the TYPO3 testing-infrastructure repository and pulled to
the core ci gitlab runner instances. [1][2]

This change modifies `Build/Scripts/runTests.sh` to set
new image version to ensure the usage for all changes
based on this change.

For information what changed in the image see the
patches in the testing-infrastrucure repository
linked below.

* core-testing-php81 => 2.12
* core-testing-php82 => 1.12
* core-testing-php83 => 1.13

[1] https://git.typo3.org/typo3/CI/testing-infrastructure/-/commit/ebdaefdb54a4fe970abf0cb1d32567bbd6339de5
[2] https://git.typo3.org/typo3/CI/testing-infrastructure/-/commit/21f88537fab0a6c5be866c602f206acdb289a20a

Resolves: #103469
Releases: main, 12.4, 11.5
Change-Id: I35ffd10e7979d4fd59aab5a7fa5d52330e71e0e1
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83537


Reviewed-by: Oliver Bartsch <bo@cedev.de>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Tested-by: Oliver Klee <typo3-coding@oliverklee.de>
Tested-by: Stefan Bürk <stefan@buerk.tech>
Reviewed-by: Stefan Bürk <stefan@buerk.tech>

When removeByType is used to remove restrictions
from the container, it is now ensured that also
cross classes are properly respected.

Resolves: #103456
Releases: main, 12.4
Change-Id: I4841fe1cba7388358771cf01ee220afa4482349a
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83539


Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: core-ci <typo3@b13.com>
Reviewed-by: Oliver Bartsch <bo@cedev.de>

Unset non matching key arrays and additionally
secure the array access with a corresponding
check.

Resolves: #102241
Releases: main, 12.4
Change-Id: If034faf04f52f6e8882dd0b610fa5dfdf9ec2298
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83570


Reviewed-by: Oliver Bartsch <bo@cedev.de>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Oliver Bartsch <bo@cedev.de>

Resolves: #103424
Releases: main, 12.4
Change-Id: I3c2da18a3d09e78fe9b72113e1a7332942bde715
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83536


Tested-by: Lina Wolf <112@linawolf.de>
Reviewed-by: Lina Wolf <112@linawolf.de>
Tested-by: core-ci <typo3@b13.com>

This commit checks whether `eval` and `is_in` are not empty before they
are used as "input params" for the JavaScript part of the FormEngine.

Also, a plausibility check is added to ensure `eval=is_in` and a
non-falsy `is_in` configuration are given.

Resolves: #103184
Releases: main, 12.4
Change-Id: I23da4483f1b35b0720ce59d07847fe01ead9a461
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83561


Tested-by: core-ci <typo3@b13.com>
Tested-by: Andreas Kienast <a.fernandez@scripting-base.de>
Reviewed-by: Andreas Kienast <a.fernandez@scripting-base.de>

Resolves: #103429
Releases: main, 12.4
Change-Id: Id8ab8e745a316f8af0abcfe495b7174f0afe1b96
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83535


Tested-by: core-ci <typo3@b13.com>
Tested-by: Jasmina Ließmann <minapokhalo+typo3@gmail.com>
Reviewed-by: Jasmina Ließmann <minapokhalo+typo3@gmail.com>

This commit adds `_ga` to the `excludedParameters` configuration used
for the cHash calculation.

Resolves: #103435
Releases: main, 12.4, 11.5
Change-Id: I5c79c9264d1d8f09f45db947d714d27b3da4fb00
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83533


Tested-by: core-ci <typo3@b13.com>
Reviewed-by: Andreas Kienast <a.fernandez@scripting-base.de>
Tested-by: Andreas Kienast <a.fernandez@scripting-base.de>

 * Always clean-up containers when Control-C is pressed
 * Enforce removing networks even if some containers have not been
   fully stopped (does not work with older docker versions, therefore
   only enabled for podman)
 * Bail out if `waitFor` failed instead of resuming with subsequent
   commands
 * Avoid waiting unnecessarily for VNC-web port 7900 in headless mode
 * Do not derive `--pull=never` from the `$CI` environment variable, as
   `$CI` is set both in gitlab [1] and github [2] actions.
   runTests.sh might be used in github actions, therefore this flag is
   moved into our gitlab-ci specific configuration.
 * Fix typos

[1] https://docs.gitlab.com/ee/ci/variables/predefined_variables.html
[2] https://docs.github.com/en/actions/learn-github-actions/variables#default-environment-variables

Resolves: #103420
Releases: main, 12.4, 11.5
Change-Id: Ie8fcdc5ebc5ba651242bb54faffdfd8de0dc6026
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83518


Tested-by: core-ci <typo3@b13.com>
Reviewed-by: Benjamin Franzke <ben@bnf.dev>
Tested-by: Benjamin Franzke <ben@bnf.dev>

Doctrine DBAL 3.x has been introduced into TYPO3 v12
with #96287 and raised over the time, adding the one
or other deprecation and dual code branches and some
compat layers.

The `\Doctrine\DBAL\Schema\Comparator::compareSchemas()`
for example is still static and instantiaces itself,
and therefore not properly handing over the platform.
The missing platform does not execute the new way of
using `AbstractPlatform::columnsEqual()`, but renders
the platform specific handlings useless - specially
added for MySQL based platforms, for example the
datbase type `TEXT` length check and comparision.

This change passes the platform down to the inner
`Comparator` instance to ensure that the platform
specific handling can work. To avoid the new way
using the `AbstractPlatform::columnsEqual()` which
introduces incompatible checks for now, that method
is overriden and the `diffColumn()` check used.

That allows the proper TEXT sub-type handling with
MySQL and MariaDB while supressing noise for now.

Note: This is also done currently in TYPO3 v13.

Resolves: #103348
Related: #96287 (Doctrine DBAL 3.2)
Releases: 12.4
Change-Id: If130c73ff122d09a50158bc3ac53f28f9a4eb749
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83457


Reviewed-by: Garvin Hicking <gh@faktor-e.de>
Reviewed-by: Stefan Bürk <stefan@buerk.tech>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christophe Monard <contact@cmonard.fr>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: core-ci <typo3@b13.com>
Reviewed-by: Christophe Monard <contact@cmonard.fr>
Reviewed-by: Developer Archriss <typo3@archriss.com>
Tested-by: Stefan Bürk <stefan@buerk.tech>
Tested-by: Garvin Hicking <gh@faktor-e.de>
Tested-by: Developer Archriss <typo3@archriss.com>

Change-Id: I03729854c268a32ba072d891d4701d42ba5d365d
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83517


Tested-by: core-ci <typo3@b13.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>